René's URL Explorer Experiment


Title: gh-148510: restore `func_version` check in `_LOAD_ATTR_PROPERTY_FRAME` by NekoAsakura · Pull Request #148528 · python/cpython · GitHub

Open Graph Title: gh-148510: restore `func_version` check in `_LOAD_ATTR_PROPERTY_FRAME` by NekoAsakura · Pull Request #148528 · python/cpython

X Title: gh-148510: restore `func_version` check in `_LOAD_ATTR_PROPERTY_FRAME` by NekoAsakura · Pull Request #148528 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Do not merge. Prerequisite: #148524 (Merged) Mean +- std: [main] 12.8 ms +- 0.2 ms -> [branch] 12.3 ms +- 0.1 ms Issue: _LOAD_ATTR_PROPERTY_FRAME has too weak checks that are also slow #148510

X Description: Do not merge. Prerequisite: #148524 (Merged) Mean +- std: [main] 12.8 ms +- 0.2 ms -> [branch] 12.3 ms +- 0.1 ms Issue: _LOAD_ATTR_PROPERTY_FRAME has too weak checks that are also slow #148510

Opengraph URL: https://github.com/python/cpython/pull/148528

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:dcef5c68-fdf4-aa9f-f4ae-1bccb6e34dde
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC294:FC5BE:39447EA:4C08AF2:6B0218EF
html-safe-noncef32aaf621f01d8b038295eaf1993e18bd3940312f2a22a6bd1b2151b9ec7d5a3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjk0OkZDNUJFOjM5NDQ3RUE6NEMwOEFGMjo2QjAyMThFRiIsInZpc2l0b3JfaWQiOiIzNzA2NjI3NTI0OTQ0NTk5Mjc5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac55532c6210596795dc8451ccd6b5144b26f53f4a68612fc7a8265e218795d1da
hovercard-subject-tagpull_request:3525235214
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/148528/commits
twitter:imagehttps://opengraph.githubassets.com/a1dd7030e6451e3fe26e3f761cefc5fef04dbf37b64afa9eace57ec6faedcc0c/python/cpython/pull/148528
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a1dd7030e6451e3fe26e3f761cefc5fef04dbf37b64afa9eace57ec6faedcc0c/python/cpython/pull/148528
og:image:altDo not merge. Prerequisite: #148524 (Merged) Mean +- std: [main] 12.8 ms +- 0.2 ms -> [branch] 12.3 ms +- 0.1 ms Issue: _LOAD_ATTR_PROPERTY_FRAME has too weak checks that are also slow #148510
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameNekoAsakura
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/148528/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148528%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148528%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/148528/commits
Reloadhttps://github.com/python/cpython/pull/148528/commits
Reloadhttps://github.com/python/cpython/pull/148528/commits
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
Fidget-Spinnerhttps://github.com/Fidget-Spinner
python:mainhttps://github.com/python/cpython/tree/main
NekoAsakura:gh-148510/load-attr-property-framehttps://github.com/NekoAsakura/cpython/tree/gh-148510/load-attr-property-frame
Conversationhttps://github.com/python/cpython/pull/148528
Commits9 (9)https://github.com/python/cpython/pull/148528/commits
Checkshttps://github.com/python/cpython/pull/148528/checks
Files changedhttps://github.com/python/cpython/pull/148528/files
gh-148510: restore func_version check in _LOAD_ATTR_PROPERTY_FRAMEhttps://github.com/python/cpython/pull/148528/commits#top
Fidget-Spinnerhttps://github.com/Fidget-Spinner
python:mainhttps://github.com/python/cpython/tree/main
NekoAsakura:gh-148510/load-attr-property-framehttps://github.com/NekoAsakura/cpython/tree/gh-148510/load-attr-property-frame
gh-148510: restore `func_version` check in `_LOAD_ATTR_PROPERTY_FRAME`https://github.com/python/cpython/pull/148528/commits/9235de6b9651a42fc55c084e3705e5a019cd5a8d
https://github.com/NekoAsakura
NekoAsakurahttps://github.com/python/cpython/commits?author=NekoAsakura
9235de6https://github.com/python/cpython/pull/148528/commits/9235de6b9651a42fc55c084e3705e5a019cd5a8d
https://github.com/python/cpython/tree/9235de6b9651a42fc55c084e3705e5a019cd5a8d
gh-148510: restore `func_version` check in `_LOAD_ATTR_PROPERTY_FRAME`https://github.com/python/cpython/pull/148528/commits/815b6ba9d8188f8dc252cbfa0016cd367c158e66
https://github.com/NekoAsakura
NekoAsakurahttps://github.com/python/cpython/commits?author=NekoAsakura
815b6bahttps://github.com/python/cpython/pull/148528/commits/815b6ba9d8188f8dc252cbfa0016cd367c158e66
https://github.com/python/cpython/tree/815b6ba9d8188f8dc252cbfa0016cd367c158e66
gh-148510: revert 148524https://github.com/python/cpython/pull/148528/commits/8968aa51979c47fbbb8539f0b2a298cb3ffcbaeb
https://github.com/NekoAsakura
NekoAsakurahttps://github.com/python/cpython/commits?author=NekoAsakura
8968aa5https://github.com/python/cpython/pull/148528/commits/8968aa51979c47fbbb8539f0b2a298cb3ffcbaeb
https://github.com/python/cpython/tree/8968aa51979c47fbbb8539f0b2a298cb3ffcbaeb
Merge branch 'main' into gh-148510/load-attr-property-framehttps://github.com/python/cpython/pull/148528/commits/4bc0a97da9038fbd7449404ef6f8379956ccb2d1
https://github.com/NekoAsakura
NekoAsakurahttps://github.com/python/cpython/commits?author=NekoAsakura
4bc0a97https://github.com/python/cpython/pull/148528/commits/4bc0a97da9038fbd7449404ef6f8379956ccb2d1
https://github.com/python/cpython/tree/4bc0a97da9038fbd7449404ef6f8379956ccb2d1
gh-148510: restore `func_version` check in `_LOAD_ATTR_PROPERTY_FRAME`https://github.com/python/cpython/pull/148528/commits/cc16f6fc887811dc298d4bc8d0c3fae8040a55e9
https://github.com/NekoAsakura
NekoAsakurahttps://github.com/python/cpython/commits?author=NekoAsakura
cc16f6fhttps://github.com/python/cpython/pull/148528/commits/cc16f6fc887811dc298d4bc8d0c3fae8040a55e9
https://github.com/python/cpython/tree/cc16f6fc887811dc298d4bc8d0c3fae8040a55e9
gh-148510: call builtin in property testhttps://github.com/python/cpython/pull/148528/commits/9c7940c8181add241beb9a71f6633601e243771f
https://github.com/NekoAsakura
NekoAsakurahttps://github.com/python/cpython/commits?author=NekoAsakura
9c7940chttps://github.com/python/cpython/pull/148528/commits/9c7940c8181add241beb9a71f6633601e243771f
https://github.com/python/cpython/tree/9c7940c8181add241beb9a71f6633601e243771f
gh-148510: restore `func_version` check in `_LOAD_ATTR_PROPERTY_FRAME`https://github.com/python/cpython/pull/148528/commits/6a430c892632e1605aa67617683d3c908ba7a5e6
https://github.com/NekoAsakura
NekoAsakurahttps://github.com/python/cpython/commits?author=NekoAsakura
6a430c8https://github.com/python/cpython/pull/148528/commits/6a430c892632e1605aa67617683d3c908ba7a5e6
https://github.com/python/cpython/tree/6a430c892632e1605aa67617683d3c908ba7a5e6
gh-148510: restore `func_version` check in `_LOAD_ATTR_PROPERTY_FRAME`https://github.com/python/cpython/pull/148528/commits/7a0aced22a56bf5a542187a6bc5b3df04ae92332
https://github.com/NekoAsakura
NekoAsakurahttps://github.com/python/cpython/commits?author=NekoAsakura
7a0acedhttps://github.com/python/cpython/pull/148528/commits/7a0aced22a56bf5a542187a6bc5b3df04ae92332
https://github.com/python/cpython/tree/7a0aced22a56bf5a542187a6bc5b3df04ae92332
gh-148510: remove duplicationhttps://github.com/python/cpython/pull/148528/commits/c8ea319203d5556b4223028323427eb04a7a7818
https://github.com/NekoAsakura
NekoAsakurahttps://github.com/python/cpython/commits?author=NekoAsakura
c8ea319https://github.com/python/cpython/pull/148528/commits/c8ea319203d5556b4223028323427eb04a7a7818
https://github.com/python/cpython/tree/c8ea319203d5556b4223028323427eb04a7a7818
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.