René's URL Explorer Experiment


Title: [3.13] gh-105936: Properly update closure cells for __setattr__ and __delattr__ in frozen dataclasses with slots (GH-144021) by gpshead · Pull Request #148476 · python/cpython · GitHub

Open Graph Title: [3.13] gh-105936: Properly update closure cells for __setattr__ and __delattr__ in frozen dataclasses with slots (GH-144021) by gpshead · Pull Request #148476 · python/cpython

X Title: [3.13] gh-105936: Properly update closure cells for __setattr__ and __delattr__ in frozen dataclasses with slots (GH-144021) by gpshead · Pull Request #148476 · python/cpython

Description: gh-105936: Properly update closure cells for __setattr__ and __delattr__ in frozen dataclasses with slots (GH-144021) (cherry picked from commit 8a398bf) The cherry-pick required additional changes beyond the original commit because 3.13 lacks the __class__ closure cell fixup machinery that was added in 3.14 by GH-124455 (gh-90562). Specifically: Co-authored-by: Sviataslau 35541026+Prometheus3375@users.noreply.github.com Backported _update_func_cell_for__class__() helper function and the closure fixup loop in _add_slots() from GH-124455. Without these, renaming the closure variable from cls to __class__ has no effect because nothing updates the cell when the class is recreated with slots. Changed _add_slots() to use newcls instead of reusing cls for the recreated class, so both old and new class references are available for the fixup loop. Replaced assertNotHasAttr with assertFalse(hasattr(...)) in tests (assertNotHasAttr was added in 3.14). Dropped test_original_class_is_gced additions (that test does not exist on 3.13; it was added by GH-137047 for gh-135228 which was not backported to 3.13).

Open Graph Description: gh-105936: Properly update closure cells for __setattr__ and __delattr__ in frozen dataclasses with slots (GH-144021) (cherry picked from commit 8a398bf) The cherry-pick required additional changes...

X Description: gh-105936: Properly update closure cells for __setattr__ and __delattr__ in frozen dataclasses with slots (GH-144021) (cherry picked from commit 8a398bf) The cherry-pick required additional changes...

Opengraph URL: https://github.com/python/cpython/pull/148476

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7afeb7e4-f271-1892-0365-5b252e289a7b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAAB0:2A7C1C:1836A55:1FFEFB3:6B020BB2
html-safe-nonce1d614ff2bb6cbb97e9087acc903e68ab4cd07f23d8efa61e8272a0e354c85cad
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQUIwOjJBN0MxQzoxODM2QTU1OjFGRkVGQjM6NkIwMjBCQjIiLCJ2aXNpdG9yX2lkIjoiNjAxMjMxOTg3MTAwMDUxMzQ1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac56d4bb0be5b19d4ff85271787ec7403e139334877b9fb853ab29863b27a56797
hovercard-subject-tagpull_request:3520348798
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/148476/files
twitter:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
og:image:altgh-105936: Properly update closure cells for __setattr__ and __delattr__ in frozen dataclasses with slots (GH-144021) (cherry picked from commit 8a398bf) The cherry-pick required additional changes...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/148476/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148476%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148476%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/148476/files
Reloadhttps://github.com/python/cpython/pull/148476/files
Reloadhttps://github.com/python/cpython/pull/148476/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gpsheadhttps://github.com/gpshead
python:3.13https://github.com/python/cpython/tree/3.13
gpshead:backport-8a398bf-3.13https://github.com/gpshead/cpython/tree/backport-8a398bf-3.13
Conversation 5 https://github.com/python/cpython/pull/148476
Commits 2 https://github.com/python/cpython/pull/148476/commits
Checks 41 https://github.com/python/cpython/pull/148476/checks
Files changed https://github.com/python/cpython/pull/148476/files
Please reload this pagehttps://github.com/python/cpython/pull/148476/files
[3.13] gh-105936: Properly update closure cells for __setattr__ and __delattr__ in frozen dataclasses with slots (GH-144021) https://github.com/python/cpython/pull/148476/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/148476/files
aa1e00f [3.13] gh-105936: Properly update closure cells for `__setattr__` and… gpshead Apr 12, 2026 https://github.com/python/cpython/pull/148476/commits/aa1e00f711dbdd032dc8d2967893410ba3e2e9e9
678cc46 [3.13] gh-148947: dataclasses: fix error on empty __class__ cell (GH… gpshead Apr 25, 2026 https://github.com/python/cpython/pull/148476/commits/678cc46cb7c82f5f9b641b9870286aed0a6f6730
Clear filters https://github.com/python/cpython/pull/148476/files
Please reload this pagehttps://github.com/python/cpython/pull/148476/files
Please reload this pagehttps://github.com/python/cpython/pull/148476/files
dataclasses.py https://github.com/python/cpython/pull/148476/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
__init__.py https://github.com/python/cpython/pull/148476/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676
2026-01-19-21-23-18.gh-issue-105936.dGrzjM.rst https://github.com/python/cpython/pull/148476/files#diff-df82254e279f56e4c5c0247e83bda81565a296e95bf928fe80dc8434f95a1d5c
https://github.com/python/cpython/blob/3.13/.github/CODEOWNERS#L207
Lib/dataclasses.pyhttps://github.com/python/cpython/pull/148476/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
View file https://github.com/gpshead/cpython/blob/678cc46cb7c82f5f9b641b9870286aed0a6f6730/Lib/dataclasses.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/148476/{{ revealButtonHref }}
https://github.com/python/cpython/pull/148476/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/148476/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/148476/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/148476/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/148476/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/148476/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/148476/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/148476/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/blob/3.13/.github/CODEOWNERS#L207
Lib/test/test_dataclasses/__init__.pyhttps://github.com/python/cpython/pull/148476/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676
View file https://github.com/gpshead/cpython/blob/678cc46cb7c82f5f9b641b9870286aed0a6f6730/Lib/test/test_dataclasses/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/148476/{{ revealButtonHref }}
https://github.com/python/cpython/pull/148476/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676
https://github.com/python/cpython/pull/148476/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676
https://github.com/python/cpython/pull/148476/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676
https://github.com/python/cpython/pull/148476/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676
https://github.com/python/cpython/pull/148476/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676
https://github.com/python/cpython/pull/148476/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676
Misc/NEWS.d/next/Library/2026-01-19-21-23-18.gh-issue-105936.dGrzjM.rsthttps://github.com/python/cpython/pull/148476/files#diff-df82254e279f56e4c5c0247e83bda81565a296e95bf928fe80dc8434f95a1d5c
View file https://github.com/gpshead/cpython/blob/678cc46cb7c82f5f9b641b9870286aed0a6f6730/Misc/NEWS.d/next/Library/2026-01-19-21-23-18.gh-issue-105936.dGrzjM.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/148476/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/148476/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.