René's URL Explorer Experiment


Title: [3.14] gh-145105: Fix crash in csv.reader with re-entrant iterator (GH-145106) by miss-islington · Pull Request #148404 · python/cpython · GitHub

Open Graph Title: [3.14] gh-145105: Fix crash in csv.reader with re-entrant iterator (GH-145106) by miss-islington · Pull Request #148404 · python/cpython

X Title: [3.14] gh-145105: Fix crash in csv.reader with re-entrant iterator (GH-145106) by miss-islington · Pull Request #148404 · python/cpython

Description: When a custom iterator calls next() on the same csv.reader from within next, the inner iteration sets self->fields to NULL. The outer iteration then crashes in parse_save_field() by passing NULL to PyList_Append. Add a guard after PyIter_Next() to detect that fields was set to NULL by a re-entrant call, and raise csv.Error instead of crashing. (cherry picked from commit 20994b1) Co-authored-by: Ramin Farajpour Cami ramin.blackhat@gmail.com Issue: gh-145105 Fixes #145105

Open Graph Description: When a custom iterator calls next() on the same csv.reader from within next, the inner iteration sets self->fields to NULL. The outer iteration then crashes in parse_save_field() by passing NULL...

X Description: When a custom iterator calls next() on the same csv.reader from within next, the inner iteration sets self->fields to NULL. The outer iteration then crashes in parse_save_field() by passing ...

Opengraph URL: https://github.com/python/cpython/pull/148404

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:772eec78-7a30-5ee5-447b-1dbc169b5d77
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE6C4:B9D02:B9C53F:F75934:6A604CB7
html-safe-nonceacd79856aafd97abeabbd21a0bc5840f3cbe281d9fc1c9929b11e2b6f100a1ad
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkM0OkI5RDAyOkI5QzUzRjpGNzU5MzQ6NkE2MDRDQjciLCJ2aXNpdG9yX2lkIjoiNTk0Mjc1NDI1MTMzNjg2MjkwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9cf51bae758321daeee9536e8265c97e900a411d2ba408a0d1f866cd05a6c9b7
hovercard-subject-tagpull_request:3518329702
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/148404/files
twitter:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
og:image:altWhen a custom iterator calls next() on the same csv.reader from within next, the inner iteration sets self->fields to NULL. The outer iteration then crashes in parse_save_field() by passing NULL...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None60da8c2a42fa2bbf5f7567474990ec467836a84444262a58e200fa91b7f3d2d0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9824515e740d83d5eb82168a089b806ab0fe04a1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/148404/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148404%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148404%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/148404/files
Reloadhttps://github.com/python/cpython/pull/148404/files
Reloadhttps://github.com/python/cpython/pull/148404/files
Please reload this pagehttps://github.com/python/cpython/pull/148404/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/148404/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.4k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gpsheadhttps://github.com/gpshead
python:3.14https://github.com/python/cpython/tree/3.14
miss-islington:backport-20994b1-3.14https://github.com/miss-islington/cpython/tree/backport-20994b1-3.14
Conversation 0 https://github.com/python/cpython/pull/148404
Commits 1 https://github.com/python/cpython/pull/148404/commits
Checks 50 https://github.com/python/cpython/pull/148404/checks
Files changed https://github.com/python/cpython/pull/148404/files
Please reload this pagehttps://github.com/python/cpython/pull/148404/files
[3.14] gh-145105: Fix crash in csv.reader with re-entrant iterator (GH-145106) https://github.com/python/cpython/pull/148404/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/148404/files
0d71152 gh-145105: Fix crash in csv.reader with re-entrant iterator (GH-145106) raminfp Apr 11, 2026 https://github.com/python/cpython/pull/148404/commits/0d71152d278763d623bb8e10e5d0340011fb401c
Clear filters https://github.com/python/cpython/pull/148404/files
Please reload this pagehttps://github.com/python/cpython/pull/148404/files
Please reload this pagehttps://github.com/python/cpython/pull/148404/files
test_csv.py https://github.com/python/cpython/pull/148404/files#diff-dd5e5efc1566b1c1dc988769a04cc403d2416c8af5bf4785bec235d02a780813
2026-02-22-00-00-00.gh-issue-145105.csv-reader-reentrant.rst https://github.com/python/cpython/pull/148404/files#diff-50d989643e2ca13d15235dea7eb4213586acdffeff5500d85e0bf252ccbf3855
_csv.c https://github.com/python/cpython/pull/148404/files#diff-38fcce6bb475616052f5c9a0973eefd49489a4dff719f30e407534258e2a3ec3
Lib/test/test_csv.pyhttps://github.com/python/cpython/pull/148404/files#diff-dd5e5efc1566b1c1dc988769a04cc403d2416c8af5bf4785bec235d02a780813
View file https://github.com/miss-islington/cpython/blob/0d71152d278763d623bb8e10e5d0340011fb401c/Lib/test/test_csv.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/148404/{{ revealButtonHref }}
https://github.com/python/cpython/pull/148404/files#diff-dd5e5efc1566b1c1dc988769a04cc403d2416c8af5bf4785bec235d02a780813
https://github.com/python/cpython/pull/148404/files#diff-dd5e5efc1566b1c1dc988769a04cc403d2416c8af5bf4785bec235d02a780813
...EWS.d/next/Library/2026-02-22-00-00-00.gh-issue-145105.csv-reader-reentrant.rsthttps://github.com/python/cpython/pull/148404/files#diff-50d989643e2ca13d15235dea7eb4213586acdffeff5500d85e0bf252ccbf3855
View file https://github.com/miss-islington/cpython/blob/0d71152d278763d623bb8e10e5d0340011fb401c/Misc/NEWS.d/next/Library/2026-02-22-00-00-00.gh-issue-145105.csv-reader-reentrant.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/148404/{{ revealButtonHref }}
Modules/_csv.chttps://github.com/python/cpython/pull/148404/files#diff-38fcce6bb475616052f5c9a0973eefd49489a4dff719f30e407534258e2a3ec3
View file https://github.com/miss-islington/cpython/blob/0d71152d278763d623bb8e10e5d0340011fb401c/Modules/_csv.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/148404/{{ revealButtonHref }}
https://github.com/python/cpython/pull/148404/files#diff-38fcce6bb475616052f5c9a0973eefd49489a4dff719f30e407534258e2a3ec3
https://github.com/python/cpython/pull/148404/files#diff-38fcce6bb475616052f5c9a0973eefd49489a4dff719f30e407534258e2a3ec3
Please reload this pagehttps://github.com/python/cpython/pull/148404/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.