René's URL Explorer Experiment


Title: gh-148380: remove all uses of `_PyType_LookupByVersion` in `optimizer_bytecodes.c` by NekoAsakura · Pull Request #148394 · python/cpython · GitHub

Open Graph Title: gh-148380: remove all uses of `_PyType_LookupByVersion` in `optimizer_bytecodes.c` by NekoAsakura · Pull Request #148394 · python/cpython

X Title: gh-148380: remove all uses of `_PyType_LookupByVersion` in `optimizer_bytecodes.c` by NekoAsakura · Pull Request #148394 · python/cpython

Description: I couldn't add _RECORD_TOS to LOAD_ATTR_CLASS_WITH_METACLASS_CHECK since the recording slot's already taken by _RECORD_TOS_TYPE. cpython/Tools/cases_generator/analyzer.py Lines 1135 to 1150 in e36f8db first = True for part in macro.uops: match part: case parser.OpName(): if part.name == "flush": parts.append(Flush()) else: if part.name not in uops: raise analysis_error( f"No Uop named {part.name}", macro.tokens[0] ) uop = uops[part.name] if uop.properties.records_value and not first: raise analysis_error( f"Recording uop {part.name} must be first in macro", macro.tokens[0]) So there's a minor optimisation regression on the metaclass path, but not much we can do about it. As for naming, it's a right mix in the file, so I just went with what felt consistent. Issue: gh-148380

Open Graph Description: I couldn't add _RECORD_TOS to LOAD_ATTR_CLASS_WITH_METACLASS_CHECK since the recording slot's already taken by _RECORD_TOS_TYPE. cpython/Tools/cases_generator/analyzer.py ...

X Description: I couldn't add _RECORD_TOS to LOAD_ATTR_CLASS_WITH_METACLASS_CHECK since the recording slot's already taken by _RECORD_TOS_TYPE. cpython/Tools/cases_generator/analyze...

Opengraph URL: https://github.com/python/cpython/pull/148394

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3a92689b-401a-1ebe-93fb-b52e0b1985d8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idABE0:2AAD2E:353B752:4707AB8:6B0207E1
html-safe-nonceb69c4fcc011c811a8778483b16b9a63bc7751eaed21e93103bf3e81734077b28
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkUwOjJBQUQyRTozNTNCNzUyOjQ3MDdBQjg6NkIwMjA3RTEiLCJ2aXNpdG9yX2lkIjoiODA3MDk4NzgyMTU2NzA1MTc0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca28b3aeb18cdf02a06c6528d4a6770e2f627fa27add53f7da4c769daecc559ec
hovercard-subject-tagpull_request:3517950973
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/148394/files
twitter:imagehttps://avatars.githubusercontent.com/u/72689291?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/72689291?s=400&v=4
og:image:altI couldn't add _RECORD_TOS to LOAD_ATTR_CLASS_WITH_METACLASS_CHECK since the recording slot's already taken by _RECORD_TOS_TYPE. cpython/Tools/cases_generator/analyzer.py ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/148394/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148394%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148394%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/148394/files
Reloadhttps://github.com/python/cpython/pull/148394/files
Reloadhttps://github.com/python/cpython/pull/148394/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Fidget-Spinnerhttps://github.com/Fidget-Spinner
python:mainhttps://github.com/python/cpython/tree/main
NekoAsakura:gh-148380/remove-LookupByVersionhttps://github.com/NekoAsakura/cpython/tree/gh-148380/remove-LookupByVersion
Conversation 13 https://github.com/python/cpython/pull/148394
Commits 10 https://github.com/python/cpython/pull/148394/commits
Checks 72 https://github.com/python/cpython/pull/148394/checks
Files changed https://github.com/python/cpython/pull/148394/files
Please reload this pagehttps://github.com/python/cpython/pull/148394/files
gh-148380: remove all uses of _PyType_LookupByVersion in optimizer_bytecodes.c https://github.com/python/cpython/pull/148394/files#top
Show all changes 10 commits https://github.com/python/cpython/pull/148394/files
4660757 gh-148380: remove all uses of `_PyType_LookupByVersion` in `optimizer… NekoAsakura Apr 11, 2026 https://github.com/python/cpython/pull/148394/commits/4660757c2f6ad23c2d0691c5189d8896848b57de
a65ab7c Merge branch 'main' into gh-148380/remove-LookupByVersion NekoAsakura Apr 11, 2026 https://github.com/python/cpython/pull/148394/commits/a65ab7c0e3fba9c51f1b8808303b6a1c463cf75c
565507e gh-148380: revert `_GUARD_TYPE_VERSION` NekoAsakura Apr 14, 2026 https://github.com/python/cpython/pull/148394/commits/565507e60471f50bc909e04115b5bc0e2e75fd31
bc8a294 Merge branch 'main' into gh-148380/remove-LookupByVersion NekoAsakura Apr 14, 2026 https://github.com/python/cpython/pull/148394/commits/bc8a2940b0c03ac1c61b8c96b574fc39bd895bdf
f05ff38 gh-148380: remove all uses of `_PyType_LookupByVersion` in `optimizer… NekoAsakura Apr 14, 2026 https://github.com/python/cpython/pull/148394/commits/f05ff38bf25fd22005b0d250e5b9d77b72409fb1
b0dd8e4 gh-148380: remove redundant `_RECORD_TOS_TYPE` NekoAsakura Apr 14, 2026 https://github.com/python/cpython/pull/148394/commits/b0dd8e450ab62eba57b734696740eaa4dd325ed8
914ed80 Merge branch 'main' into gh-148380/remove-LookupByVersion NekoAsakura Apr 14, 2026 https://github.com/python/cpython/pull/148394/commits/914ed80762c50af9184fef56286550794cfb434d
c84a36a gh-148380: relax assert NekoAsakura Apr 14, 2026 https://github.com/python/cpython/pull/148394/commits/c84a36a9bc357322186e22f3d0e887571e4b52a2
4eb3e98 Merge branch 'main' into gh-148380/remove-LookupByVersion NekoAsakura Apr 14, 2026 https://github.com/python/cpython/pull/148394/commits/4eb3e981ac12d46fa12b91cf556251e713069897
9145081 Merge branch 'main' into format-type-narrowing NekoAsakura May 2, 2026 https://github.com/python/cpython/pull/148394/commits/9145081f960754caa324cd06613b9832f9872930
Clear filters https://github.com/python/cpython/pull/148394/files
Please reload this pagehttps://github.com/python/cpython/pull/148394/files
Please reload this pagehttps://github.com/python/cpython/pull/148394/files
pycore_opcode_metadata.h https://github.com/python/cpython/pull/148394/files#diff-72bc4c0445516cc3eabd536220b2459617491ffaabbdb8a7c5381f36c991e378
bytecodes.c https://github.com/python/cpython/pull/148394/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
optimizer_bytecodes.c https://github.com/python/cpython/pull/148394/files#diff-e5bd2b14b0b10f0f47786e26306d689ed1361c3dc3b11dcc3ea52b8a2422ff64
optimizer_cases.c.h https://github.com/python/cpython/pull/148394/files#diff-ed4567b3e67709ec57bf4df91ef058cfcbe00d7da11cd2a75e38241fa1ca99d2
record_functions.c.h https://github.com/python/cpython/pull/148394/files#diff-ac2bf70082a97de53db16bbb949b29240f59f89c4b9ad93928b3926738cbb74c
Include/internal/pycore_opcode_metadata.hhttps://github.com/python/cpython/pull/148394/files#diff-72bc4c0445516cc3eabd536220b2459617491ffaabbdb8a7c5381f36c991e378
View file https://github.com/NekoAsakura/cpython/blob/9145081f960754caa324cd06613b9832f9872930/Include/internal/pycore_opcode_metadata.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/148394/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L222
Python/bytecodes.chttps://github.com/python/cpython/pull/148394/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
View file https://github.com/NekoAsakura/cpython/blob/9145081f960754caa324cd06613b9832f9872930/Python/bytecodes.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/148394/{{ revealButtonHref }}
https://github.com/python/cpython/pull/148394/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
https://github.com/python/cpython/pull/148394/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L304
Python/optimizer_bytecodes.chttps://github.com/python/cpython/pull/148394/files#diff-e5bd2b14b0b10f0f47786e26306d689ed1361c3dc3b11dcc3ea52b8a2422ff64
View file https://github.com/NekoAsakura/cpython/blob/9145081f960754caa324cd06613b9832f9872930/Python/optimizer_bytecodes.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/148394/{{ revealButtonHref }}
https://github.com/python/cpython/pull/148394/files#diff-e5bd2b14b0b10f0f47786e26306d689ed1361c3dc3b11dcc3ea52b8a2422ff64
Fidget-Spinnerhttps://github.com/Fidget-Spinner
Apr 11, 2026https://github.com/python/cpython/pull/148394/files#r3068376606
Please reload this pagehttps://github.com/python/cpython/pull/148394/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/148394/files
NekoAsakurahttps://github.com/NekoAsakura
Apr 11, 2026https://github.com/python/cpython/pull/148394/files#r3068397418
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/148394/files
Fidget-Spinnerhttps://github.com/Fidget-Spinner
Apr 11, 2026https://github.com/python/cpython/pull/148394/files#r3068418888
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/148394/files
https://github.com/python/cpython/pull/148394/files#diff-e5bd2b14b0b10f0f47786e26306d689ed1361c3dc3b11dcc3ea52b8a2422ff64
https://github.com/python/cpython/pull/148394/files#diff-e5bd2b14b0b10f0f47786e26306d689ed1361c3dc3b11dcc3ea52b8a2422ff64
Python/optimizer_cases.c.hhttps://github.com/python/cpython/pull/148394/files#diff-ed4567b3e67709ec57bf4df91ef058cfcbe00d7da11cd2a75e38241fa1ca99d2
View file https://github.com/NekoAsakura/cpython/blob/9145081f960754caa324cd06613b9832f9872930/Python/optimizer_cases.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/148394/files
Python/record_functions.c.hhttps://github.com/python/cpython/pull/148394/files#diff-ac2bf70082a97de53db16bbb949b29240f59f89c4b9ad93928b3926738cbb74c
View file https://github.com/NekoAsakura/cpython/blob/9145081f960754caa324cd06613b9832f9872930/Python/record_functions.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/148394/files
Please reload this pagehttps://github.com/python/cpython/pull/148394/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.