René's URL Explorer Experiment


Title: gh-148285: Allow recording uops after specializing uops by adityakrmishra · Pull Request #148373 · python/cpython · GitHub

Open Graph Title: gh-148285: Allow recording uops after specializing uops by adityakrmishra · Pull Request #148373 · python/cpython

X Title: gh-148285: Allow recording uops after specializing uops by adityakrmishra · Pull Request #148373 · python/cpython

Description: Fixes #148285 Replaces closed PR #148367 The Issue: Currently, analyzer.py forces any uop with records_value == True to be at index 0. This prevents Tier 2 recording uops from safely trailing Tier 1 specializing uops. The Fix (V2): Following feedback from @Sacul0457 on the previous PR, simply checking if the preceding uop was tier == 1 was too permissive (it allowed recording uops to follow any Tier 1 uop, not just specializing ones). This updated patch uses a strict positional uop_index tracker in add_macro(). A recording uop is now only permitted if: It is at uop_index == 0 (the very first uop). OR it is at uop_index == 1 AND the preceding uop's name explicitly starts with _SPECIALIZE_. CacheEffect (e.g., unused/1) and flush parts do not increment the uop_index, ensuring they remain completely transparent. This strictly enforces the architecture while allowing structures like: macro(X) = _SPECIALIZE_X + _RECORD_TOS_TYPE + unused/1 + _X; Issue: gh-148285

Open Graph Description: Fixes #148285 Replaces closed PR #148367 The Issue: Currently, analyzer.py forces any uop with records_value == True to be at index 0. This prevents Tier 2 recording uops from safely trailing Tier...

X Description: Fixes #148285 Replaces closed PR #148367 The Issue: Currently, analyzer.py forces any uop with records_value == True to be at index 0. This prevents Tier 2 recording uops from safely trailing Tier...

Opengraph URL: https://github.com/python/cpython/pull/148373

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3bddf26b-e038-7d84-2236-f5c66f6bd17b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8F3A:171DD4:1BB7B43:24D068F:6A52CC0A
html-safe-noncea935f3a2b6e66cbc26e8ac6e524faac090cae382fdadd5a2ef97f3e049b22f61
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjNBOjE3MURENDoxQkI3QjQzOjI0RDA2OEY6NkE1MkNDMEEiLCJ2aXNpdG9yX2lkIjoiMzA5MDY4NTQ4NzYyNDY3MDIxOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac14663d3f46684e0f2782d364bc73b9be14ece7b6cc3daa8613df2a2edc582dc2
hovercard-subject-tagpull_request:3517369500
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/148373/files
twitter:imagehttps://avatars.githubusercontent.com/u/154746713?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/154746713?s=400&v=4
og:image:altFixes #148285 Replaces closed PR #148367 The Issue: Currently, analyzer.py forces any uop with records_value == True to be at index 0. This prevents Tier 2 recording uops from safely trailing Tier...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/148373/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148373%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148373%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/148373/files
Reloadhttps://github.com/python/cpython/pull/148373/files
Reloadhttps://github.com/python/cpython/pull/148373/files
Please reload this pagehttps://github.com/python/cpython/pull/148373/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/148373/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
adityakrmishrahttps://github.com/adityakrmishra
python:mainhttps://github.com/python/cpython/tree/main
adityakrmishra:fix-uop-recording-v2https://github.com/adityakrmishra/cpython/tree/fix-uop-recording-v2
Conversation 20 https://github.com/python/cpython/pull/148373
Commits 6 https://github.com/python/cpython/pull/148373/commits
Checks 74 https://github.com/python/cpython/pull/148373/checks
Files changed https://github.com/python/cpython/pull/148373/files
Please reload this pagehttps://github.com/python/cpython/pull/148373/files
gh-148285: Allow recording uops after specializing uops https://github.com/python/cpython/pull/148373/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/148373/files
ca81806 gh-148285: Allow recording uops after specializing uops adityakrmishra Apr 11, 2026 https://github.com/python/cpython/pull/148373/commits/ca81806af3aaf7ec47e10017aa4bcaa182f3497b
440b823 Apply reviewer suggestions, add tests, and regen cases adityakrmishra Apr 11, 2026 https://github.com/python/cpython/pull/148373/commits/440b8230cb1e823d820811acba63ffb02562454a
1bbac01 Add missing mypy return type annotation in test adityakrmishra Apr 11, 2026 https://github.com/python/cpython/pull/148373/commits/1bbac01df0106f4085160df21f0314e8be6b362e
d9df27e Revert generated C files to upstream state to fix CRLF adityakrmishra Apr 11, 2026 https://github.com/python/cpython/pull/148373/commits/d9df27ecf8b3c1bd301e287f3aee55b83d0584c7
eb3ea3f Move tests to Lib/test and simplify prev_uop tracking per review adityakrmishra Apr 12, 2026 https://github.com/python/cpython/pull/148373/commits/eb3ea3f7203578a2b5cd386ef9c28ab25d51abd8
ae7d3da Convert line endings to LF, revert C files, delete old test adityakrmishra Apr 12, 2026 https://github.com/python/cpython/pull/148373/commits/ae7d3daaef6313f13b027ea9a56f670118dc239e
Clear filters https://github.com/python/cpython/pull/148373/files
Please reload this pagehttps://github.com/python/cpython/pull/148373/files
Please reload this pagehttps://github.com/python/cpython/pull/148373/files
test_generated_cases.py https://github.com/python/cpython/pull/148373/files#diff-9168c63f7de36279d370ea7d6403f554f48e6da75e82b6b70b5a207a11848750
optimizer_bytecodes.c https://github.com/python/cpython/pull/148373/files#diff-e5bd2b14b0b10f0f47786e26306d689ed1361c3dc3b11dcc3ea52b8a2422ff64
analyzer.py https://github.com/python/cpython/pull/148373/files#diff-bf1d5618934b787df486d8077f48217f17bf4321b9a151528f67b6e6f383976b
Lib/test/test_generated_cases.pyhttps://github.com/python/cpython/pull/148373/files#diff-9168c63f7de36279d370ea7d6403f554f48e6da75e82b6b70b5a207a11848750
View file https://github.com/adityakrmishra/cpython/blob/ae7d3daaef6313f13b027ea9a56f670118dc239e/Lib/test/test_generated_cases.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/148373/{{ revealButtonHref }}
https://github.com/python/cpython/pull/148373/files#diff-9168c63f7de36279d370ea7d6403f554f48e6da75e82b6b70b5a207a11848750
https://github.com/python/cpython/pull/148373/files#diff-9168c63f7de36279d370ea7d6403f554f48e6da75e82b6b70b5a207a11848750
https://github.com/python/cpython/pull/148373/files#diff-9168c63f7de36279d370ea7d6403f554f48e6da75e82b6b70b5a207a11848750
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L307
Python/optimizer_bytecodes.chttps://github.com/python/cpython/pull/148373/files#diff-e5bd2b14b0b10f0f47786e26306d689ed1361c3dc3b11dcc3ea52b8a2422ff64
View file https://github.com/adityakrmishra/cpython/blob/ae7d3daaef6313f13b027ea9a56f670118dc239e/Python/optimizer_bytecodes.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/148373/{{ revealButtonHref }}
https://github.com/python/cpython/pull/148373/files#diff-e5bd2b14b0b10f0f47786e26306d689ed1361c3dc3b11dcc3ea52b8a2422ff64
https://github.com/python/cpython/pull/148373/files#diff-e5bd2b14b0b10f0f47786e26306d689ed1361c3dc3b11dcc3ea52b8a2422ff64
https://github.com/python/cpython/pull/148373/files#diff-e5bd2b14b0b10f0f47786e26306d689ed1361c3dc3b11dcc3ea52b8a2422ff64
https://github.com/python/cpython/pull/148373/files#diff-e5bd2b14b0b10f0f47786e26306d689ed1361c3dc3b11dcc3ea52b8a2422ff64
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L227
Tools/cases_generator/analyzer.pyhttps://github.com/python/cpython/pull/148373/files#diff-bf1d5618934b787df486d8077f48217f17bf4321b9a151528f67b6e6f383976b
View file https://github.com/adityakrmishra/cpython/blob/ae7d3daaef6313f13b027ea9a56f670118dc239e/Tools/cases_generator/analyzer.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/148373/{{ revealButtonHref }}
https://github.com/python/cpython/pull/148373/files#diff-bf1d5618934b787df486d8077f48217f17bf4321b9a151528f67b6e6f383976b
https://github.com/python/cpython/pull/148373/files#diff-bf1d5618934b787df486d8077f48217f17bf4321b9a151528f67b6e6f383976b
https://github.com/python/cpython/pull/148373/files#diff-bf1d5618934b787df486d8077f48217f17bf4321b9a151528f67b6e6f383976b
https://github.com/python/cpython/pull/148373/files#diff-bf1d5618934b787df486d8077f48217f17bf4321b9a151528f67b6e6f383976b
Please reload this pagehttps://github.com/python/cpython/pull/148373/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.