René's URL Explorer Experiment


Title: gh-123471: Make concurrent iteration over itertools.islice thread-safe using a critical section by eendebakpt · Pull Request #148348 · python/cpython · GitHub

Open Graph Title: gh-123471: Make concurrent iteration over itertools.islice thread-safe using a critical section by eendebakpt · Pull Request #148348 · python/cpython

X Title: gh-123471: Make concurrent iteration over itertools.islice thread-safe using a critical section by eendebakpt · Pull Request #148348 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: In this PR we use a critical section. An alternative approach is to use atomics (#144528), but that is more complex. Issue: Make concurrent iteration over pairwise, combinations, permutations, c...

X Description: In this PR we use a critical section. An alternative approach is to use atomics (#144528), but that is more complex. Issue: Make concurrent iteration over pairwise, combinations, permutations, c...

Opengraph URL: https://github.com/python/cpython/pull/148348

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ab9b95f8-47da-91a7-468d-5eefd1fa3abf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBDDC:19C884:7B2F6E:A9363E:6A57DBD4
html-safe-nonce1e62d195e7a432add10aef4502e82bb290f42fa141316d7bbbaf1788cf1029a5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRERDOjE5Qzg4NDo3QjJGNkU6QTkzNjNFOjZBNTdEQkQ0IiwidmlzaXRvcl9pZCI6IjM0NDI1Mzk5NTAyMjY1MjkyMzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2afef6b1420301036f736419d4084cda5b4c56e3e39d4f5a2141d94e3a084579
hovercard-subject-tagpull_request:3515071972
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/148348/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/43d77911b9025761dc35736089f0a399591c74c36c3f170cbcce83759fce0c95/python/cpython/pull/148348
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/43d77911b9025761dc35736089f0a399591c74c36c3f170cbcce83759fce0c95/python/cpython/pull/148348
og:image:altIn this PR we use a critical section. An alternative approach is to use atomics (#144528), but that is more complex. Issue: Make concurrent iteration over pairwise, combinations, permutations, c...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameeendebakpt
hostnamegithub.com
expected-hostnamegithub.com
None837767abbd14b05f219fd812ef2842c659968b63619e1b966dded83972ab5bca
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release36b9c371e4e031091f1b89adf913d9e6993943df
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/148348#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148348
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148348
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/148348
Reloadhttps://github.com/python/cpython/pull/148348
Reloadhttps://github.com/python/cpython/pull/148348
Please reload this pagehttps://github.com/python/cpython/pull/148348
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/148348
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
eendebakpthttps://github.com/eendebakpt
python:mainhttps://github.com/python/cpython/tree/main
eendebakpt:islice_ft_cshttps://github.com/eendebakpt/cpython/tree/islice_ft_cs
Conversationhttps://github.com/python/cpython/pull/148348
Commits3 (3)https://github.com/python/cpython/pull/148348/commits
Checkshttps://github.com/python/cpython/pull/148348/checks
Files changedhttps://github.com/python/cpython/pull/148348/files
gh-123471: Make concurrent iteration over itertools.islice thread-safe using a critical sectionhttps://github.com/python/cpython/pull/148348#top
eendebakpthttps://github.com/eendebakpt
python:mainhttps://github.com/python/cpython/tree/main
eendebakpt:islice_ft_cshttps://github.com/eendebakpt/cpython/tree/islice_ft_cs
https://github.com/eendebakpt
eendebakpthttps://github.com/eendebakpt
Apr 10, 2026https://github.com/python/cpython/pull/148348#issue-4240565454
Please reload this pagehttps://github.com/python/cpython/pull/148348
#144528https://github.com/python/cpython/pull/144528
Make concurrent iteration over pairwise, combinations, permutations, cwr, product, etc. from itertools safe under free-threading #123471https://github.com/python/cpython/issues/123471
Please reload this pagehttps://github.com/python/cpython/pull/148348
https://github.com/eendebakpt
Make itertools.islice safe in the FT buildhttps://github.com/python/cpython/pull/148348/commits/0a581a1e0b788bff5ef8ba8e4d2085183353d28d
0a581a1https://github.com/python/cpython/pull/148348/commits/0a581a1e0b788bff5ef8ba8e4d2085183353d28d
https://github.com/eendebakpt
eendebakpthttps://github.com/eendebakpt
rhettingerhttps://github.com/rhettinger
code ownerhttps://github.com/python/cpython/blob/70b86e7829c42d36c80853ba9bf1da0d8464065b/.github/CODEOWNERS#L523
April 10, 2026 16:52https://github.com/python/cpython/pull/148348#event-24388502522
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 10, 2026https://github.com/python/cpython/pull/148348#event-24388504202
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 10, 2026 https://github.com/python/cpython/pull/148348#ref-issue-2494501268
Make concurrent iteration over pairwise, combinations, permutations, cwr, product, etc. from itertools safe under free-threading #123471 https://github.com/python/cpython/issues/123471
https://github.com/eendebakpt
eendebakpthttps://github.com/eendebakpt
Apr 10, 2026 https://github.com/python/cpython/pull/148348#ref-pullrequest-3903493580
gh-123471: Make concurrent iteration over itertools.islice thread-safe #144528 https://github.com/python/cpython/pull/144528
https://github.com/eendebakpt
news entryhttps://github.com/python/cpython/pull/148348/commits/5ee09e19bd7bdcfd3b37719f9467f441f09e06ac
5ee09e1https://github.com/python/cpython/pull/148348/commits/5ee09e19bd7bdcfd3b37719f9467f441f09e06ac
https://github.com/eendebakpt
eendebakpthttps://github.com/eendebakpt
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Apr 10, 2026https://github.com/python/cpython/pull/148348#event-24390085425
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
May 18, 2026https://github.com/python/cpython/pull/148348#issuecomment-4477994895
Please reload this pagehttps://github.com/python/cpython/pull/148348
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
May 18, 2026https://github.com/python/cpython/pull/148348#event-25658483991
https://github.com/eendebakpt
Merge branch 'main' into islice_ft_cshttps://github.com/python/cpython/pull/148348/commits/1024151d2641501519075964a10ddb4aedecb0ad
1024151https://github.com/python/cpython/pull/148348/commits/1024151d2641501519075964a10ddb4aedecb0ad
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
May 26, 2026https://github.com/python/cpython/pull/148348#event-25967358327
https://github.com/eendebakpt
eendebakpthttps://github.com/eendebakpt
Jun 12, 2026 https://github.com/python/cpython/pull/148348#ref-pullrequest-4650578115
gh-151409: add critical section for islice_next #151410 https://github.com/python/cpython/pull/151410
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148348
https://github.com/rhettinger
rhettinger https://github.com/rhettinger
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Please reload this pagehttps://github.com/python/cpython/pull/148348
https://github.com/eendebakpt
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.