René's URL Explorer Experiment


Title: [3.14] gh-70039: smtplib: store the server name in ._host in .connect() (GH-115259) by miss-islington · Pull Request #148273 · python/cpython · GitHub

Open Graph Title: [3.14] gh-70039: smtplib: store the server name in ._host in .connect() (GH-115259) by miss-islington · Pull Request #148273 · python/cpython

X Title: [3.14] gh-70039: smtplib: store the server name in ._host in .connect() (GH-115259) by miss-islington · Pull Request #148273 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Original patch by gigaplastik, extended with a few more tests. Addresses gh-70039 and bpo-25852: failure of starttls if connect is called explicitly. (cherry picked from commit 442f83a) Co-authored...

X Description: Original patch by gigaplastik, extended with a few more tests. Addresses gh-70039 and bpo-25852: failure of starttls if connect is called explicitly. (cherry picked from commit 442f83a) Co-authored...

Opengraph URL: https://github.com/python/cpython/pull/148273

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/checks(.:format)
route-controllerpull_requests
route-actionchecks
fetch-noncev2:e32d00e4-22f3-f751-cbac-e46dd1124c38
current-catalog-service-hash87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a
request-idB722:390ECE:2BA86C1:3F0B8CC:6A56680A
html-safe-nonce7e532e481a4c1acd22d659267dcf8971d2771c407341992d31c388525c9499b4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzIyOjM5MEVDRToyQkE4NkMxOjNGMEI4Q0M6NkE1NjY4MEEiLCJ2aXNpdG9yX2lkIjoiMjk3MDU0OTI4NjY0NjIxMjYxOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac59ec2cd5b1bcfa4cd9a3e01746121c49ce7acf3815ab3b376f5264f98164f0ee
hovercard-subject-tagpull_request:3505544721
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/checks
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/148273/checks
twitter:imagehttps://opengraph.githubassets.com/dbc14de2f5c01c5a0c21c5ec35f272b8b9ca7801c1fbe1dffb801effc7d2b8e7/python/cpython/pull/148273
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dbc14de2f5c01c5a0c21c5ec35f272b8b9ca7801c1fbe1dffb801effc7d2b8e7/python/cpython/pull/148273
og:image:altOriginal patch by gigaplastik, extended with a few more tests. Addresses gh-70039 and bpo-25852: failure of starttls if connect is called explicitly. (cherry picked from commit 442f83a) Co-authored...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemiss-islington
hostnamegithub.com
expected-hostnamegithub.com
None1bfcd903bf3318822b10b18a6332fac40d3a21f7d94456dca766ab8fa7328068
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release37f446b78ad53e6f593aa1a4243b87c76a3428ab
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/148273/checks#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148273%2Fchecks
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148273%2Fchecks
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/148273/checks
Reloadhttps://github.com/python/cpython/pull/148273/checks
Reloadhttps://github.com/python/cpython/pull/148273/checks
Please reload this pagehttps://github.com/python/cpython/pull/148273/checks
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/148273/checks
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
bitdancerhttps://github.com/bitdancer
python:3.14https://github.com/python/cpython/tree/3.14
miss-islington:backport-442f83a-3.14https://github.com/miss-islington/cpython/tree/backport-442f83a-3.14
Conversationhttps://github.com/python/cpython/pull/148273
Commits1 (1)https://github.com/python/cpython/pull/148273/commits
Checkshttps://github.com/python/cpython/pull/148273/checks
Files changedhttps://github.com/python/cpython/pull/148273/files
[3.14] gh-70039: smtplib: store the server name in ._host in .connect() (GH-115259)https://github.com/python/cpython/pull/148273/checks#top
bitdancerhttps://github.com/bitdancer
python:3.14https://github.com/python/cpython/tree/3.14
miss-islington:backport-442f83a-3.14https://github.com/miss-islington/cpython/tree/backport-442f83a-3.14
Please reload this pagehttps://github.com/python/cpython/pull/148273/checks
Sign in for the full log viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148273%2Fchecks
Check labels on: pull_request https://github.com/python/cpython/actions/runs/24160415242
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/24160415242/job/70510069437?pr=148273
Unresolved review https://github.com/python/cpython/actions/runs/24160415242/job/70510069510?pr=148273
Tests on: pull_request https://github.com/python/cpython/actions/runs/24160415333
Change detection / Create context from changed files https://github.com/python/cpython/actions/runs/24160415333/job/70510069901?pr=148273
Docs / Docs https://github.com/python/cpython/actions/runs/24160415333/job/70510107224?pr=148273
Docs / Doctest https://github.com/python/cpython/actions/runs/24160415333/job/70510107235?pr=148273
Docs / Check EPUB https://github.com/python/cpython/actions/runs/24160415333/job/70510107194?pr=148273
Check if the ABI has changed https://github.com/python/cpython/actions/runs/24160415333/job/70510106643?pr=148273
Check if Autoconf files are up to date https://github.com/python/cpython/actions/runs/24160415333/job/70510106633?pr=148273
Check if generated files are up to date https://github.com/python/cpython/actions/runs/24160415333/job/70510106639?pr=148273
Windows / Build and test (x64) https://github.com/python/cpython/actions/runs/24160415333/job/70510107064?pr=148273
Windows (free-threading) / Build and test (x64) https://github.com/python/cpython/actions/runs/24160415333/job/70510107070?pr=148273
Windows / Build and test (Win32) https://github.com/python/cpython/actions/runs/24160415333/job/70510107046?pr=148273
Windows / Build and test (arm64) https://github.com/python/cpython/actions/runs/24160415333/job/70510107034?pr=148273
Windows (free-threading) / Build and test (arm64) https://github.com/python/cpython/actions/runs/24160415333/job/70510107049?pr=148273
Windows MSI${{ '' }} https://github.com/python/cpython/actions/runs/24160415333/job/70510107204?pr=148273
macOS / build and test (macos-26) https://github.com/python/cpython/actions/runs/24160415333/job/70510107013?pr=148273
macOS (free-threading) / build and test (macos-26) https://github.com/python/cpython/actions/runs/24160415333/job/70510107041?pr=148273
macOS / build and test (macos-15-intel) https://github.com/python/cpython/actions/runs/24160415333/job/70510107036?pr=148273
Ubuntu / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/24160415333/job/70510107133?pr=148273
Ubuntu / build and test (ubuntu-24.04-arm) https://github.com/python/cpython/actions/runs/24160415333/job/70510107123?pr=148273
Ubuntu (free-threading) / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/24160415333/job/70510107149?pr=148273
Ubuntu (free-threading) / build and test (ubuntu-24.04-arm) https://github.com/python/cpython/actions/runs/24160415333/job/70510107220?pr=148273
Ubuntu (bolt) / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/24160415333/job/70510107185?pr=148273
Ubuntu SSL tests (ubuntu-24.04, openssl, 1.1.1w) https://github.com/python/cpython/actions/runs/24160415333/job/70510106792?pr=148273
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.0.19) https://github.com/python/cpython/actions/runs/24160415333/job/70510106810?pr=148273
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.3.6) https://github.com/python/cpython/actions/runs/24160415333/job/70510106818?pr=148273
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.4.4) https://github.com/python/cpython/actions/runs/24160415333/job/70510106824?pr=148273
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.5.5) https://github.com/python/cpython/actions/runs/24160415333/job/70510106786?pr=148273
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.6.1) https://github.com/python/cpython/actions/runs/24160415333/job/70510106828?pr=148273
Android (aarch64) https://github.com/python/cpython/actions/runs/24160415333/job/70510106746?pr=148273
Android (x86_64) https://github.com/python/cpython/actions/runs/24160415333/job/70510106688?pr=148273
iOS https://github.com/python/cpython/actions/runs/24160415333/job/70510106722?pr=148273
Emscripten / build and test https://github.com/python/cpython/actions/runs/24160415333/job/70510107023?pr=148273
WASI / build and test https://github.com/python/cpython/actions/runs/24160415333/job/70510106913?pr=148273
Hypothesis tests on Ubuntu https://github.com/python/cpython/actions/runs/24160415333/job/70510106732?pr=148273
Address sanitizer (ubuntu-24.04) https://github.com/python/cpython/actions/runs/24160415333/job/70510106730?pr=148273
Sanitizers / TSan https://github.com/python/cpython/actions/runs/24160415333/job/70510107181?pr=148273
Sanitizers / TSan (free-threading) https://github.com/python/cpython/actions/runs/24160415333/job/70510107271?pr=148273
Sanitizers / UBSan https://github.com/python/cpython/actions/runs/24160415333/job/70510107211?pr=148273
Cross build Linux https://github.com/python/cpython/actions/runs/24160415333/job/70510106805?pr=148273
CIFuzz${{ '' }} https://github.com/python/cpython/actions/runs/24160415333/job/70510106893?pr=148273
All required checks pass https://github.com/python/cpython/actions/runs/24160415333/job/70513372127?pr=148273
Lint on: pull_request https://github.com/python/cpython/actions/runs/24160415373
lint https://github.com/python/cpython/actions/runs/24160415373/job/70510069830?pr=148273
Check labels on: pull_request https://github.com/python/cpython/actions/runs/24160418448
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/24160418448/job/70510079779?pr=148273
Unresolved review https://github.com/python/cpython/actions/runs/24160418448/job/70510079822?pr=148273
Check labels on: pull_request https://github.com/python/cpython/actions/runs/24161465960
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/24161465960/job/70513560677?pr=148273
Unresolved review https://github.com/python/cpython/actions/runs/24161465960/job/70513560672?pr=148273
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.