René's URL Explorer Experiment


Title: [3.14] gh-70039: smtplib: store the server name in ._host in .connect() (GH-115259) by miss-islington · Pull Request #148273 · python/cpython · GitHub

Open Graph Title: [3.14] gh-70039: smtplib: store the server name in ._host in .connect() (GH-115259) by miss-islington · Pull Request #148273 · python/cpython

X Title: [3.14] gh-70039: smtplib: store the server name in ._host in .connect() (GH-115259) by miss-islington · Pull Request #148273 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Original patch by gigaplastik, extended with a few more tests. Addresses gh-70039 and bpo-25852: failure of starttls if connect is called explicitly. (cherry picked from commit 442f83a) Co-authored...

X Description: Original patch by gigaplastik, extended with a few more tests. Addresses gh-70039 and bpo-25852: failure of starttls if connect is called explicitly. (cherry picked from commit 442f83a) Co-authored...

Mail addresses
nis.martensen@web.de

Opengraph URL: https://github.com/python/cpython/pull/148273

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:20db1b80-d8de-3683-dc8e-e8ed5e16bfef
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBED2:2B7730:1B839D3:27F4B17:6A563551
html-safe-noncef44c62b473d03917934212b56104dbd4f7c6411fc89dba9de7a85c03cb16dca6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRUQyOjJCNzczMDoxQjgzOUQzOjI3RjRCMTc6NkE1NjM1NTEiLCJ2aXNpdG9yX2lkIjoiNTExMDUyMzM2MzU5NDIxMjY1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac47f523b6313eef3c24fd070b7d1d98075d78f0f09e6b6294bde42e2a48335549
hovercard-subject-tagpull_request:3505544721
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/148273/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/dbc14de2f5c01c5a0c21c5ec35f272b8b9ca7801c1fbe1dffb801effc7d2b8e7/python/cpython/pull/148273
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dbc14de2f5c01c5a0c21c5ec35f272b8b9ca7801c1fbe1dffb801effc7d2b8e7/python/cpython/pull/148273
og:image:altOriginal patch by gigaplastik, extended with a few more tests. Addresses gh-70039 and bpo-25852: failure of starttls if connect is called explicitly. (cherry picked from commit 442f83a) Co-authored...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemiss-islington
hostnamegithub.com
expected-hostnamegithub.com
None9d78ea552aac0685ca5f006d44f88166cbbf3bb96843f8da0c5a2c0b9908430b
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423b2fb76ac2b90de5ab599b7a76a0d2b2c83f24
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/148273#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148273
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148273
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/148273
Reloadhttps://github.com/python/cpython/pull/148273
Reloadhttps://github.com/python/cpython/pull/148273
Please reload this pagehttps://github.com/python/cpython/pull/148273
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/148273
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
bitdancerhttps://github.com/bitdancer
python:3.14https://github.com/python/cpython/tree/3.14
miss-islington:backport-442f83a-3.14https://github.com/miss-islington/cpython/tree/backport-442f83a-3.14
Conversationhttps://github.com/python/cpython/pull/148273
Commits1 (1)https://github.com/python/cpython/pull/148273/commits
Checkshttps://github.com/python/cpython/pull/148273/checks
Files changedhttps://github.com/python/cpython/pull/148273/files
[3.14] gh-70039: smtplib: store the server name in ._host in .connect() (GH-115259)https://github.com/python/cpython/pull/148273#top
bitdancerhttps://github.com/bitdancer
python:3.14https://github.com/python/cpython/tree/3.14
miss-islington:backport-442f83a-3.14https://github.com/miss-islington/cpython/tree/backport-442f83a-3.14
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Apr 8, 2026https://github.com/python/cpython/pull/148273#issue-4227860928
gh-70039https://github.com/python/cpython/issues/70039
bpo-25852https://bugs.python.org/issue?@action=redirect&bpo=25852
442f83ahttps://github.com/python/cpython/commit/442f83a5ea1b4d334befd231a79c40d6ff41a0bd
Please reload this pagehttps://github.com/python/cpython/pull/148273
https://github.com/nmartensen
https://github.com/miss-islington
pythongh-70039https://github.com/python/cpython/issues/70039
: smtplib: store the server name in ._host in .connect() (https://github.com/python/cpython/pull/148273/commits/6a8ba62e3c460bf2a7e57f77ff16b3a6b467619c
6a8ba62https://github.com/python/cpython/pull/148273/commits/6a8ba62e3c460bf2a7e57f77ff16b3a6b467619c
pythonGH-115259https://github.com/python/cpython/pull/115259
pythongh-70039https://github.com/python/cpython/issues/70039
442f83ahttps://github.com/miss-islington/cpython/commit/442f83a5ea1b4d334befd231a79c40d6ff41a0bd
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
code ownerhttps://github.com/python/cpython/blob/a84e2dba24286d9cf13c29807d6994a13dc102a1/.github/CODEOWNERS#L176
April 8, 2026 21:47https://github.com/python/cpython/pull/148273#event-24313038309
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 8, 2026 https://github.com/python/cpython/pull/148273#ref-pullrequest-2128714567
gh-70039: smtplib: store the server name in ._host in .connect() #115259 https://github.com/python/cpython/pull/115259
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 8, 2026https://github.com/python/cpython/pull/148273#event-24313040892
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 8, 2026 https://github.com/python/cpython/pull/148273#ref-issue-1198945171
smtplib's SMTP.connect() should store the server name in ._host for .starttls() #70039 https://github.com/python/cpython/issues/70039
https://github.com/bitdancer
bitdancerhttps://github.com/bitdancer
f46a17bhttps://github.com/python/cpython/commit/f46a17b19ff535591b75f5f3df5b48f7b4f939b4
Apr 8, 2026https://github.com/python/cpython/pull/148273#event-24314009209
Please reload this pagehttps://github.com/python/cpython/pull/148273
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 8, 2026https://github.com/python/cpython/pull/148273#event-24314010832
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
April 8, 2026 22:14https://github.com/python/cpython/pull/148273#event-24314010957
https://github.com/carloshdelreal
carloshdelrealhttps://github.com/carloshdelreal
May 21, 2026 https://github.com/python/cpython/pull/148273#ref-pullrequest-4496686149
ODP-619 Data api download failing - AWS SES started enforcing strict SNI wri/wri-odp#880 https://github.com/wri/wri-odp/pull/880
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148273
Please reload this pagehttps://github.com/python/cpython/pull/148273
https://github.com/miss-islington
https://github.com/bitdancer
https://github.com/nmartensen
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.