René's URL Explorer Experiment

Title: gh-143732: Add tier2 specialization for TO_BOOL by eendebakpt · Pull Request #148271 · python/cpython · GitHub

Open Graph Title: gh-143732: Add tier2 specialization for TO_BOOL by eendebakpt · Pull Request #148271 · python/cpython

X Title: gh-143732: Add tier2 specialization for TO_BOOL by eendebakpt · Pull Request #148271 · python/cpython

Description: See discussion at #148113. (description updated after refactoring) This PR adds two tier2 opcodes for specialization of TO_BOOL. The *args and **kwargs arguments are marked in tier2 as tuple and dict, respectively. A recording uop is added to TO_BOOL. Benchmark main branch Speedup to_bool_dict_recorded 1.21 sec 852 ms 1.41× to_bool_tuple_recorded 1.21 sec 850 ms 1.42× to_bool_bytes_true 1.20 sec 852 ms 1.41× to_bool_bytes_false 922 ms 566 ms 1.63× to_bool_bytearray 1.20 sec 851 ms 1.41× to_bool_set_recorded 1.23 sec 849 ms 1.45× to_bool_frozenset 1.23 sec 850 ms 1.45× to_bool_kwargs_nonempty 1.26 sec 912 ms 1.38× to_bool_kwargs_empty 952 ms 576 ms 1.65× to_bool_varargs_nonempty 1.23 sec 892 ms 1.38× to_bool_varargs_empty 933 ms 574 ms 1.62× to_bool_set_literal 26.3 ms 24.6 ms 1.07× Geometric mean (ref) 1.43× Details """TO_BOOL specialization benchmark. Covers both the static (sym_get_type) and recorded (sym_get_probable_type) paths through the JIT optimizer's _TO_BOOL rule. Static path: - kwargs dict (via **kwargs slot priming) - varargs tuple (via *args slot priming) - set literal (via _BUILD_SET) Recorded path (only reached via _RECORD_TOS_TYPE; bytes/bytearray/frozenset have no static-type construction at all): - dict / tuple / bytes / bytearray / set / frozenset passed as parameter """ import pyperf INNER_ITERS = 200 # ---- recorded-type path: value comes in as a parameter, no static type ---- def _recorded_inner(v): cnt = 0 for _ in range(INNER_ITERS): if v: cnt += 1 return cnt def to_bool_dict_recorded(n): d = {"a": 1} for _ in range(n): _recorded_inner(d) def to_bool_tuple_recorded(n): t = (1, 2, 3) for _ in range(n): _recorded_inner(t) def to_bool_bytes_true(n): b = b"hello" for _ in range(n): _recorded_inner(b) def to_bool_bytes_false(n): b = b"" for _ in range(n): _recorded_inner(b) def to_bool_bytearray(n): b = bytearray(b"hello") for _ in range(n): _recorded_inner(b) def to_bool_set_recorded(n): s = {1, 2, 3} for _ in range(n): _recorded_inner(s) def to_bool_frozenset(n): s = frozenset({1, 2, 3}) for _ in range(n): _recorded_inner(s) # ---- static-type path: kwargs / varargs slot priming ---- def _kwargs_inner(**kwargs): cnt = 0 for _ in range(INNER_ITERS): if kwargs: cnt += 1 return cnt def _varargs_inner(*args): cnt = 0 for _ in range(INNER_ITERS): if args: cnt += 1 return cnt def to_bool_kwargs_nonempty(n): for _ in range(n): _kwargs_inner(x=1, y=2) def to_bool_kwargs_empty(n): for _ in range(n): _kwargs_inner() def to_bool_varargs_nonempty(n): for _ in range(n): _varargs_inner(1, 2, 3) def to_bool_varargs_empty(n): for _ in range(n): _varargs_inner() # ---- static-type path: set literal via _BUILD_SET ---- def to_bool_set_literal(n): cnt = 0 for _ in range(n): s = {1} if s: cnt += 1 return cnt N = 500_000 runner = pyperf.Runner() runner.bench_func("to_bool_dict_recorded", to_bool_dict_recorded, N) runner.bench_func("to_bool_tuple_recorded", to_bool_tuple_recorded, N) runner.bench_func("to_bool_bytes_true", to_bool_bytes_true, N) runner.bench_func("to_bool_bytes_false", to_bool_bytes_false, N) runner.bench_func("to_bool_bytearray", to_bool_bytearray, N) runner.bench_func("to_bool_set_recorded", to_bool_set_recorded, N) runner.bench_func("to_bool_frozenset", to_bool_frozenset, N) runner.bench_func("to_bool_kwargs_nonempty", to_bool_kwargs_nonempty, N) runner.bench_func("to_bool_kwargs_empty", to_bool_kwargs_empty, N) runner.bench_func("to_bool_varargs_nonempty", to_bool_varargs_nonempty, N) runner.bench_func("to_bool_varargs_empty", to_bool_varargs_empty, N) runner.bench_func("to_bool_set_literal", to_bool_set_literal, N) Issue: gh-143732

Open Graph Description: See discussion at #148113. (description updated after refactoring) This PR adds two tier2 opcodes for specialization of TO_BOOL. The *args and **kwargs arguments are marked in tier2 as tuple and di...

X Description: See discussion at #148113. (description updated after refactoring) This PR adds two tier2 opcodes for specialization of TO_BOOL. The *args and **kwargs arguments are marked in tier2 as tuple and di...

Opengraph URL: https://github.com/python/cpython/pull/148271

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width