René's URL Explorer Experiment


Title: gh-148241: Fix json serialization for str subclasses by vstinner · Pull Request #148249 · python/cpython · GitHub

Open Graph Title: gh-148241: Fix json serialization for str subclasses by vstinner · Pull Request #148249 · python/cpython

X Title: gh-148241: Fix json serialization for str subclasses by vstinner · Pull Request #148249 · python/cpython

Description: Fix json serialization: no longer call str(obj) on str subclasses. Replace PyUnicodeWriter_WriteStr() with PyUnicodeWriter_WriteASCII() and private _PyUnicodeWriter_WriteStr(). Issue: gh-148241

Open Graph Description: Fix json serialization: no longer call str(obj) on str subclasses. Replace PyUnicodeWriter_WriteStr() with PyUnicodeWriter_WriteASCII() and private _PyUnicodeWriter_WriteStr(). Issue: gh-148241

X Description: Fix json serialization: no longer call str(obj) on str subclasses. Replace PyUnicodeWriter_WriteStr() with PyUnicodeWriter_WriteASCII() and private _PyUnicodeWriter_WriteStr(). Issue: gh-148241

Opengraph URL: https://github.com/python/cpython/pull/148249

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:cb8b4128-9c34-3202-b617-f2fd5e35612a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8958:317608:3DF46A5:4E69131:6B0208AB
html-safe-nonce2f83936d880ed2abaa62f3eda3247ad1bfcba67f128975523c0affd6bdcddda9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTU4OjMxNzYwODozREY0NkE1OjRFNjkxMzE6NkIwMjA4QUIiLCJ2aXNpdG9yX2lkIjoiODI5NjU3NTgwNzY0ODgyNzU2MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac15f3397763b5631b72308d5693b7cf2aa851c9ba014e3576e4bd6f0827c31466
hovercard-subject-tagpull_request:3503189377
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/148249/files
twitter:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
og:image:altFix json serialization: no longer call str(obj) on str subclasses. Replace PyUnicodeWriter_WriteStr() with PyUnicodeWriter_WriteASCII() and private _PyUnicodeWriter_WriteStr(). Issue: gh-148241
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/148249/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148249%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148249%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/148249/files
Reloadhttps://github.com/python/cpython/pull/148249/files
Reloadhttps://github.com/python/cpython/pull/148249/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:json_str_subclasshttps://github.com/vstinner/cpython/tree/json_str_subclass
Conversation 14 https://github.com/python/cpython/pull/148249
Commits 3 https://github.com/python/cpython/pull/148249/commits
Checks 57 https://github.com/python/cpython/pull/148249/checks
Files changed https://github.com/python/cpython/pull/148249/files
Please reload this pagehttps://github.com/python/cpython/pull/148249/files
gh-148241: Fix json serialization for str subclasses https://github.com/python/cpython/pull/148249/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/148249/files
1f892cb gh-148241: Fix json serialization for str subclasses vstinner Apr 8, 2026 https://github.com/python/cpython/pull/148249/commits/1f892cb9b51733c335af4d4119a1fbee9d11aa80
c251659 Add a test to test_json.test_enum vstinner Apr 8, 2026 https://github.com/python/cpython/pull/148249/commits/c251659ee05390615289e7dcb77374508b117a0a
fdab889 Reformat tests vstinner Apr 8, 2026 https://github.com/python/cpython/pull/148249/commits/fdab8891a6c7c53c7d36f04bae459c002850fb34
Clear filters https://github.com/python/cpython/pull/148249/files
Please reload this pagehttps://github.com/python/cpython/pull/148249/files
Please reload this pagehttps://github.com/python/cpython/pull/148249/files
test_dump.py https://github.com/python/cpython/pull/148249/files#diff-c48f208a13a0f4cbaced66756fdc25388aedc34dfa4c6da5679d39a241d7a0af
test_encode_basestring_ascii.py https://github.com/python/cpython/pull/148249/files#diff-59c87bea1935f9a553683f08e7fcb5aff52061df8af5a2d40036b239e5829fd2
test_enum.py https://github.com/python/cpython/pull/148249/files#diff-bbd9da17a2a44ba8481172d963d11f3ec49266085cb4312a92a3fd288788f67c
2026-04-08-14-19-17.gh-issue-148241.fO_QT4.rst https://github.com/python/cpython/pull/148249/files#diff-7fc5bd40ccfa5e467fa4a9dd2c3b711c62f92d71ba99611881bed72add40702c
_json.c https://github.com/python/cpython/pull/148249/files#diff-efe183ae0b85e5b8d9bbbc588452dd4de80b39fd5c5174ee499ba554217a39ed
Lib/test/test_json/test_dump.pyhttps://github.com/python/cpython/pull/148249/files#diff-c48f208a13a0f4cbaced66756fdc25388aedc34dfa4c6da5679d39a241d7a0af
View file https://github.com/vstinner/cpython/blob/fdab8891a6c7c53c7d36f04bae459c002850fb34/Lib/test/test_json/test_dump.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/148249/{{ revealButtonHref }}
https://github.com/python/cpython/pull/148249/files#diff-c48f208a13a0f4cbaced66756fdc25388aedc34dfa4c6da5679d39a241d7a0af
https://github.com/python/cpython/pull/148249/files#diff-c48f208a13a0f4cbaced66756fdc25388aedc34dfa4c6da5679d39a241d7a0af
Lib/test/test_json/test_encode_basestring_ascii.pyhttps://github.com/python/cpython/pull/148249/files#diff-59c87bea1935f9a553683f08e7fcb5aff52061df8af5a2d40036b239e5829fd2
View file https://github.com/vstinner/cpython/blob/fdab8891a6c7c53c7d36f04bae459c002850fb34/Lib/test/test_json/test_encode_basestring_ascii.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/148249/{{ revealButtonHref }}
https://github.com/python/cpython/pull/148249/files#diff-59c87bea1935f9a553683f08e7fcb5aff52061df8af5a2d40036b239e5829fd2
https://github.com/python/cpython/pull/148249/files#diff-59c87bea1935f9a553683f08e7fcb5aff52061df8af5a2d40036b239e5829fd2
https://github.com/python/cpython/pull/148249/files#diff-59c87bea1935f9a553683f08e7fcb5aff52061df8af5a2d40036b239e5829fd2
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L464
Lib/test/test_json/test_enum.pyhttps://github.com/python/cpython/pull/148249/files#diff-bbd9da17a2a44ba8481172d963d11f3ec49266085cb4312a92a3fd288788f67c
View file https://github.com/vstinner/cpython/blob/fdab8891a6c7c53c7d36f04bae459c002850fb34/Lib/test/test_json/test_enum.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/148249/{{ revealButtonHref }}
https://github.com/python/cpython/pull/148249/files#diff-bbd9da17a2a44ba8481172d963d11f3ec49266085cb4312a92a3fd288788f67c
https://github.com/python/cpython/pull/148249/files#diff-bbd9da17a2a44ba8481172d963d11f3ec49266085cb4312a92a3fd288788f67c
https://github.com/python/cpython/pull/148249/files#diff-bbd9da17a2a44ba8481172d963d11f3ec49266085cb4312a92a3fd288788f67c
Misc/NEWS.d/next/Library/2026-04-08-14-19-17.gh-issue-148241.fO_QT4.rsthttps://github.com/python/cpython/pull/148249/files#diff-7fc5bd40ccfa5e467fa4a9dd2c3b711c62f92d71ba99611881bed72add40702c
View file https://github.com/vstinner/cpython/blob/fdab8891a6c7c53c7d36f04bae459c002850fb34/Misc/NEWS.d/next/Library/2026-04-08-14-19-17.gh-issue-148241.fO_QT4.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/148249/{{ revealButtonHref }}
Modules/_json.chttps://github.com/python/cpython/pull/148249/files#diff-efe183ae0b85e5b8d9bbbc588452dd4de80b39fd5c5174ee499ba554217a39ed
View file https://github.com/vstinner/cpython/blob/fdab8891a6c7c53c7d36f04bae459c002850fb34/Modules/_json.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/148249/{{ revealButtonHref }}
https://github.com/python/cpython/pull/148249/files#diff-efe183ae0b85e5b8d9bbbc588452dd4de80b39fd5c5174ee499ba554217a39ed
https://github.com/python/cpython/pull/148249/files#diff-efe183ae0b85e5b8d9bbbc588452dd4de80b39fd5c5174ee499ba554217a39ed
https://github.com/python/cpython/pull/148249/files#diff-efe183ae0b85e5b8d9bbbc588452dd4de80b39fd5c5174ee499ba554217a39ed
vstinnerhttps://github.com/vstinner
Apr 8, 2026https://github.com/python/cpython/pull/148249/files#r3051389035
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/148249/files
vstinnerhttps://github.com/vstinner
Apr 8, 2026https://github.com/python/cpython/pull/148249/files#r3051579579
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
gh-148250https://github.com/python/cpython/issues/148250
Please reload this pagehttps://github.com/python/cpython/pull/148249/files
sunmy2019https://github.com/sunmy2019
Apr 8, 2026https://github.com/python/cpython/pull/148249/files#r3052130692
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/148249/files
serhiy-storchakahttps://github.com/serhiy-storchaka
Apr 8, 2026https://github.com/python/cpython/pull/148249/files#r3052438274
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/148249/files
vstinnerhttps://github.com/vstinner
Apr 8, 2026https://github.com/python/cpython/pull/148249/files#r3052477617
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/148249/files
sunmy2019https://github.com/sunmy2019
Apr 8, 2026https://github.com/python/cpython/pull/148249/files#r3052837588
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/148249/files
sunmy2019https://github.com/sunmy2019
Apr 8, 2026https://github.com/python/cpython/pull/148249/files#r3052947871
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/148249/files
serhiy-storchakahttps://github.com/serhiy-storchaka
Apr 8, 2026https://github.com/python/cpython/pull/148249/files#r3052957349
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/148249/files
https://github.com/python/cpython/pull/148249/files#diff-efe183ae0b85e5b8d9bbbc588452dd4de80b39fd5c5174ee499ba554217a39ed
Please reload this pagehttps://github.com/python/cpython/pull/148249/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.