René's URL Explorer Experiment


Title: gh-146613: Fix re-entrant use-after-free in itertools._grouper by TheSkyC · Pull Request #147962 · python/cpython · GitHub

Open Graph Title: gh-146613: Fix re-entrant use-after-free in itertools._grouper by TheSkyC · Pull Request #147962 · python/cpython

X Title: gh-146613: Fix re-entrant use-after-free in itertools._grouper by TheSkyC · Pull Request #147962 · python/cpython

Description: Closes gh-146613 The same pattern was fixed in groupby.__next__ (gh-143543 / a91b5c3), but _grouper_next (the inner group iterator returned by groupby) was missed. A user-defined __eq__ can re-enter the grouper during PyObject_RichCompareBool, causing Py_XSETREF to free currkey while it is still being used. Fixed by taking strong references (Py_INCREF / Py_DECREF) to tgtkey and currkey before the comparison, exactly as done in groupby_next. Added regression test test_grouper_reentrant_eq_does_not_crash.

Open Graph Description: Closes gh-146613 The same pattern was fixed in groupby.__next__ (gh-143543 / a91b5c3), but _grouper_next (the inner group iterator returned by groupby) was missed. A user-defined __eq__ can re-ente...

X Description: Closes gh-146613 The same pattern was fixed in groupby.__next__ (gh-143543 / a91b5c3), but _grouper_next (the inner group iterator returned by groupby) was missed. A user-defined __eq__ can re-ente...

Opengraph URL: https://github.com/python/cpython/pull/147962

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d4711072-c611-b60a-ed64-86f69770e2aa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC19A:0B26:1AA8CD:236203:6A56E3A4
html-safe-nonce23534ec3f8d02a683d93a323ff6fb0784cfaa4163dbc7457d4f221b440759fe2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTlBOjBCMjY6MUFBOENEOjIzNjIwMzo2QTU2RTNBNCIsInZpc2l0b3JfaWQiOiIyMDk4MTY5NTQ4MjU1OTc4NDA0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac27e47cefb534d9fb59664d0bcc89ea58dd15f93a400465661c2c65394f879782
hovercard-subject-tagpull_request:3476606953
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/147962/files
twitter:imagehttps://avatars.githubusercontent.com/u/68433685?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/68433685?s=400&v=4
og:image:altCloses gh-146613 The same pattern was fixed in groupby.__next__ (gh-143543 / a91b5c3), but _grouper_next (the inner group iterator returned by groupby) was missed. A user-defined __eq__ can re-ente...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5220a278731283038daf0ed00b41f06ef7ff9539020ecc806c5c5a0fb6bda25a
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8684ae1a81cd3e4ef219b241179982bbda1a5b1f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/147962/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F147962%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F147962%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/147962/files
Reloadhttps://github.com/python/cpython/pull/147962/files
Reloadhttps://github.com/python/cpython/pull/147962/files
Please reload this pagehttps://github.com/python/cpython/pull/147962/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/147962/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
TheSkyC:gh-146613-itertools-uafhttps://github.com/TheSkyC/cpython/tree/gh-146613-itertools-uaf
Conversation 18 https://github.com/python/cpython/pull/147962
Commits 8 https://github.com/python/cpython/pull/147962/commits
Checks 56 https://github.com/python/cpython/pull/147962/checks
Files changed https://github.com/python/cpython/pull/147962/files
Please reload this pagehttps://github.com/python/cpython/pull/147962/files
gh-146613: Fix re-entrant use-after-free in itertools._grouper https://github.com/python/cpython/pull/147962/files#top
Show all changes 8 commits https://github.com/python/cpython/pull/147962/files
9aa672e gh-146613: Fix re-entrant use-after-free in itertools._grouper TheSkyC Apr 1, 2026 https://github.com/python/cpython/pull/147962/commits/9aa672e163a669faf540c893149459b647457af9
1b647a1 📜🤖 Added by blurb_it. blurb-it[bot] Apr 1, 2026 https://github.com/python/cpython/pull/147962/commits/1b647a1e9d9d760c51b0873e0093de649df0193f
f1d2d2a address review comments from @vstinner TheSkyC Apr 1, 2026 https://github.com/python/cpython/pull/147962/commits/f1d2d2a5005f372769a9654f6a4cbb0ef2af7251
a7aa2ce fix trailing whitespace in test_itertools TheSkyC Apr 1, 2026 https://github.com/python/cpython/pull/147962/commits/a7aa2ce4ce45e8033377476c2bf242fe3780fc52
895b685 Update Misc/NEWS.d/next/Library/2026-04-01-11-05-36.gh-issue-146613.G… TheSkyC Apr 1, 2026 https://github.com/python/cpython/pull/147962/commits/895b685fb16157ef15e8457f933afc86c69a45bd
fef6412 Update Modules/itertoolsmodule.c TheSkyC Apr 1, 2026 https://github.com/python/cpython/pull/147962/commits/fef6412a36f6fccf80fff0245746741b1ed326da
fd9b831 Update Misc/NEWS.d/next/Library/2026-04-01-11-05-36.gh-issue-146613.G… TheSkyC Apr 1, 2026 https://github.com/python/cpython/pull/147962/commits/fd9b831ed91c6aaa3862a3eaa802de42f6da7e78
5c9ff8b Merge branch 'main' into gh-146613-itertools-uaf TheSkyC Apr 1, 2026 https://github.com/python/cpython/pull/147962/commits/5c9ff8b34638a8b19aece1a092ffdf821616594c
Clear filters https://github.com/python/cpython/pull/147962/files
Please reload this pagehttps://github.com/python/cpython/pull/147962/files
Please reload this pagehttps://github.com/python/cpython/pull/147962/files
test_itertools.py https://github.com/python/cpython/pull/147962/files#diff-9abbaeca99112e9e04b554726bff97b76030eb982f39e591be77be8ef14149e5
2026-04-01-11-05-36.gh-issue-146613.GzjUFK.rst https://github.com/python/cpython/pull/147962/files#diff-75df9da59af54261a7ca48b16e2580b83c14856bffe99048c313fcf27fa94d2f
itertoolsmodule.c https://github.com/python/cpython/pull/147962/files#diff-dc27cbdf2b9f6e5236cade13cf301d352a7abd2a8b1988f2517d6f5b7a30c201
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L521
Lib/test/test_itertools.pyhttps://github.com/python/cpython/pull/147962/files#diff-9abbaeca99112e9e04b554726bff97b76030eb982f39e591be77be8ef14149e5
View file https://github.com/TheSkyC/cpython/blob/5c9ff8b34638a8b19aece1a092ffdf821616594c/Lib/test/test_itertools.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/147962/{{ revealButtonHref }}
https://github.com/python/cpython/pull/147962/files#diff-9abbaeca99112e9e04b554726bff97b76030eb982f39e591be77be8ef14149e5
https://github.com/python/cpython/pull/147962/files#diff-9abbaeca99112e9e04b554726bff97b76030eb982f39e591be77be8ef14149e5
Misc/NEWS.d/next/Library/2026-04-01-11-05-36.gh-issue-146613.GzjUFK.rsthttps://github.com/python/cpython/pull/147962/files#diff-75df9da59af54261a7ca48b16e2580b83c14856bffe99048c313fcf27fa94d2f
View file https://github.com/TheSkyC/cpython/blob/5c9ff8b34638a8b19aece1a092ffdf821616594c/Misc/NEWS.d/next/Library/2026-04-01-11-05-36.gh-issue-146613.GzjUFK.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/147962/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L522
Modules/itertoolsmodule.chttps://github.com/python/cpython/pull/147962/files#diff-dc27cbdf2b9f6e5236cade13cf301d352a7abd2a8b1988f2517d6f5b7a30c201
View file https://github.com/TheSkyC/cpython/blob/5c9ff8b34638a8b19aece1a092ffdf821616594c/Modules/itertoolsmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/147962/{{ revealButtonHref }}
https://github.com/python/cpython/pull/147962/files#diff-dc27cbdf2b9f6e5236cade13cf301d352a7abd2a8b1988f2517d6f5b7a30c201
https://github.com/python/cpython/pull/147962/files#diff-dc27cbdf2b9f6e5236cade13cf301d352a7abd2a8b1988f2517d6f5b7a30c201
Please reload this pagehttps://github.com/python/cpython/pull/147962/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.