René's URL Explorer Experiment


Title: gh-146581: Use ZipFile.extractall() in shutil for secure ZIP extraction by Shrey-N · Pull Request #146588 · python/cpython · GitHub

Open Graph Title: gh-146581: Use ZipFile.extractall() in shutil for secure ZIP extraction by Shrey-N · Pull Request #146588 · python/cpython

X Title: gh-146581: Use ZipFile.extractall() in shutil for secure ZIP extraction by Shrey-N · Pull Request #146588 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This PR refactors shutil._unpack_zipfile to use zipfile.ZipFile.extractall() instead of a manual extraction loop. This resolves a directory traversal vulnerability on Windows where archives contain...

X Description: This PR refactors shutil._unpack_zipfile to use zipfile.ZipFile.extractall() instead of a manual extraction loop. This resolves a directory traversal vulnerability on Windows where archives contain...

Opengraph URL: https://github.com/python/cpython/pull/146588

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3957d250-0b0d-0e89-da22-adc896ca0ed1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEDDC:3176E8:F98B12:156D8D0:6A55CB26
html-safe-nonce61f2832d1154cdb04c5cacf2dc1377ea3f5c5550959e52ef92d08f5c44b12d90
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRERDOjMxNzZFODpGOThCMTI6MTU2RDhEMDo2QTU1Q0IyNiIsInZpc2l0b3JfaWQiOiI2NjExMzM5NjY4NDMxOTQ4NTgyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7e1e651f85df33cc02385ce772354d889bb5723782590e9e2a5451e260437a56
hovercard-subject-tagpull_request:3462108772
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/146588/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/580bb628dd43a695889063c4f1c48257b64ed563bc69c4f064309360cf1d252c/python/cpython/pull/146588
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/580bb628dd43a695889063c4f1c48257b64ed563bc69c4f064309360cf1d252c/python/cpython/pull/146588
og:image:altThis PR refactors shutil._unpack_zipfile to use zipfile.ZipFile.extractall() instead of a manual extraction loop. This resolves a directory traversal vulnerability on Windows where archives contain...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameShrey-N
hostnamegithub.com
expected-hostnamegithub.com
Noneb5665c84831ed9ac4fb79519c16c9c5580ba8092fb8bb6e3e72972ec7197348e
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8f8e1726192df8dce16872ceb503336c12e9ae78
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/146588#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146588
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146588
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/146588
Reloadhttps://github.com/python/cpython/pull/146588
Reloadhttps://github.com/python/cpython/pull/146588
Please reload this pagehttps://github.com/python/cpython/pull/146588
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/146588
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Shrey-Nhttps://github.com/Shrey-N
python:mainhttps://github.com/python/cpython/tree/main
Shrey-N:patch-2https://github.com/Shrey-N/cpython-for-fix/tree/patch-2
Conversationhttps://github.com/python/cpython/pull/146588
Commits8 (8)https://github.com/python/cpython/pull/146588/commits
Checkshttps://github.com/python/cpython/pull/146588/checks
Files changedhttps://github.com/python/cpython/pull/146588/files
gh-146581: Use ZipFile.extractall() in shutil for secure ZIP extractionhttps://github.com/python/cpython/pull/146588#top
Shrey-Nhttps://github.com/Shrey-N
python:mainhttps://github.com/python/cpython/tree/main
Shrey-N:patch-2https://github.com/Shrey-N/cpython-for-fix/tree/patch-2
https://github.com/Shrey-N
Shrey-Nhttps://github.com/Shrey-N
Mar 29, 2026https://github.com/python/cpython/pull/146588#issue-4163301856
Please reload this pagehttps://github.com/python/cpython/pull/146588
#146581https://github.com/python/cpython/issues/146581
shutil.unpack_archive() on Windows writes outside extract_dir for ZIP entries with drive-prefixed names #146581https://github.com/python/cpython/issues/146581
Please reload this pagehttps://github.com/python/cpython/pull/146588
Shrey-Nhttps://github.com/Shrey-N
March 29, 2026 13:31https://github.com/python/cpython/pull/146588#commits-pushed-b3d178a
https://github.com/Shrey-N
Update shutil.pyhttps://github.com/python/cpython/pull/146588/commits/b3d178a58e7bebaeab1e55d199a32c56829e40a4
b3d178ahttps://github.com/python/cpython/pull/146588/commits/b3d178a58e7bebaeab1e55d199a32c56829e40a4
https://github.com/Shrey-N
Implement Windows ZIP traversal test in test_shutilhttps://github.com/python/cpython/pull/146588/commits/494d2b19cf22b02c88b95e796719c7bb90220535
494d2b1https://github.com/python/cpython/pull/146588/commits/494d2b19cf22b02c88b95e796719c7bb90220535
https://github.com/Shrey-N
Clarify comments in test_unpack_zipfile_traversal_windows_drivehttps://github.com/python/cpython/pull/146588/commits/d18590531c7f2d7e43333c7b3cb3185d70b4f537
d185905https://github.com/python/cpython/pull/146588/commits/d18590531c7f2d7e43333c7b3cb3185d70b4f537
https://github.com/Shrey-N
Shrey-Nhttps://github.com/Shrey-N
giampaolohttps://github.com/giampaolo
code ownerhttps://github.com/python/cpython/blob/1af025dd2206eecee3ee6242f2a7cdb67173fb97/.github/CODEOWNERS#L573
March 29, 2026 08:12https://github.com/python/cpython/pull/146588#event-24007319868
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Mar 29, 2026https://github.com/python/cpython/pull/146588#event-24007320686
blurb-ithttps://github.com/apps/blurb-it
March 29, 2026 08:14https://github.com/python/cpython/pull/146588#commits-pushed-958ec29
https://github.com/apps/blurb-it
📜🤖 Added by blurb_it.https://github.com/python/cpython/pull/146588/commits/958ec29b135fec8115fec08f708ff0b2a29f1730
958ec29https://github.com/python/cpython/pull/146588/commits/958ec29b135fec8115fec08f708ff0b2a29f1730
https://github.com/Shrey-N
Remove unnecessary blank lines in test_shutil.pyhttps://github.com/python/cpython/pull/146588/commits/b0f0dc8ebcbe2aa72295eb8f36b89177f30c7cba
b0f0dc8https://github.com/python/cpython/pull/146588/commits/b0f0dc8ebcbe2aa72295eb8f36b89177f30c7cba
https://github.com/Shrey-N
Clean up whitespace in _unpack_zipfile functionhttps://github.com/python/cpython/pull/146588/commits/8ce8bc2343b1813ebe0f95b9897f4f19d6c09f75
8ce8bc2https://github.com/python/cpython/pull/146588/commits/8ce8bc2343b1813ebe0f95b9897f4f19d6c09f75
https://github.com/Shrey-N
Update shutil.pyhttps://github.com/python/cpython/pull/146588/commits/cfb3d0fdb0f8367667715978cf4049314e152cc6
cfb3d0fhttps://github.com/python/cpython/pull/146588/commits/cfb3d0fdb0f8367667715978cf4049314e152cc6
https://github.com/hugovk
hugovkhttps://github.com/hugovk
Mar 29, 2026 https://github.com/python/cpython/pull/146588#ref-issue-4161096240
shutil.unpack_archive() on Windows writes outside extract_dir for ZIP entries with drive-prefixed names #146581 https://github.com/python/cpython/issues/146581
https://github.com/Shrey-N
Update shutil.pyhttps://github.com/python/cpython/pull/146588/commits/678fc3d5a269f5e31ca0b10c9487304832fb1a10
678fc3dhttps://github.com/python/cpython/pull/146588/commits/678fc3d5a269f5e31ca0b10c9487304832fb1a10
https://github.com/StanFromIreland
StanFromIrelandhttps://github.com/StanFromIreland
Mar 29, 2026https://github.com/python/cpython/pull/146588#issuecomment-4149841015
#146591https://github.com/python/cpython/pull/146591
Please reload this pagehttps://github.com/python/cpython/pull/146588
https://github.com/StanFromIreland
StanFromIrelandhttps://github.com/StanFromIreland
Mar 29, 2026https://github.com/python/cpython/pull/146588#event-24008161474
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Mar 29, 2026https://github.com/python/cpython/pull/146588#issuecomment-4149842646
@Shrey-Nhttps://github.com/Shrey-N
#146591https://github.com/python/cpython/pull/146591
Please reload this pagehttps://github.com/python/cpython/pull/146588
https://github.com/Shrey-N
Shrey-Nhttps://github.com/Shrey-N
Mar 29, 2026https://github.com/python/cpython/pull/146588#issuecomment-4149867219
@serhiy-storchakahttps://github.com/serhiy-storchaka
#146591https://github.com/python/cpython/pull/146591
Please reload this pagehttps://github.com/python/cpython/pull/146588
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146588
https://github.com/giampaolo
giampaolo https://github.com/giampaolo
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Please reload this pagehttps://github.com/python/cpython/pull/146588
https://github.com/Shrey-N
https://github.com/StanFromIreland
https://github.com/serhiy-storchaka
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.