René's URL Explorer Experiment


Title: gh-146452: Fix pickle segfault on concurrent mutation of dict and list by overlorde · Pull Request #146470 · python/cpython · GitHub

Open Graph Title: gh-146452: Fix pickle segfault on concurrent mutation of dict and list by overlorde · Pull Request #146470 · python/cpython

X Title: gh-146452: Fix pickle segfault on concurrent mutation of dict and list by overlorde · Pull Request #146470 · python/cpython

Description: batch_dict_exact() in _pickle.c iterates dict items using PyDict_Next() which returns borrowed references. Without a critical section, a concurrent dict mutation can invalidate the borrowed reference before Py_INCREF, causing a segfault. The fix wraps PyDict_Next() + Py_INCREF in Py_BEGIN_CRITICAL_SECTION(obj) to prevent the dict from being mutated while converting borrowed refs to owned refs. Same approach as the existing set iteration path in the same file (line 3656). Crashes on both 3.14t (stock install) and main (with ASan). Reproducer in the linked issue. Existing test_pickle passes (1000 tests, no regressions) Added test_free_threading/test_pickle.py that segfaults without the fix and passes with it Issue: gh-146452

Open Graph Description: batch_dict_exact() in _pickle.c iterates dict items using PyDict_Next() which returns borrowed references. Without a critical section, a concurrent dict mutation can invalidate the borrowed referen...

X Description: batch_dict_exact() in _pickle.c iterates dict items using PyDict_Next() which returns borrowed references. Without a critical section, a concurrent dict mutation can invalidate the borrowed referen...

Opengraph URL: https://github.com/python/cpython/pull/146470

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:88d5ae4d-c34c-0691-6d11-8c26c7f39a39
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB534:323204:1590365:1C701DD:6B01FD56
html-safe-nonce9eb89cac675a337b3d4c089a775f664789355ced5e34e57d886e4e19e5e08da3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTM0OjMyMzIwNDoxNTkwMzY1OjFDNzAxREQ6NkIwMUZENTYiLCJ2aXNpdG9yX2lkIjoiMzAyNjcxNDEwNTgzNTgxNDIzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac00a84eb8561ffbc4be40514cd31a0de818ebcd1948c51987937b444350a8bf5e
hovercard-subject-tagpull_request:3452071031
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/146470/files
twitter:imagehttps://avatars.githubusercontent.com/u/21244057?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/21244057?s=400&v=4
og:image:altbatch_dict_exact() in _pickle.c iterates dict items using PyDict_Next() which returns borrowed references. Without a critical section, a concurrent dict mutation can invalidate the borrowed referen...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/146470/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146470%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146470%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/146470/files
Reloadhttps://github.com/python/cpython/pull/146470/files
Reloadhttps://github.com/python/cpython/pull/146470/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
overlorde:fix-issue-146452https://github.com/overlorde/cpython/tree/fix-issue-146452
Conversation 13 https://github.com/python/cpython/pull/146470
Commits 7 https://github.com/python/cpython/pull/146470/commits
Checks 63 https://github.com/python/cpython/pull/146470/checks
Files changed https://github.com/python/cpython/pull/146470/files
Please reload this pagehttps://github.com/python/cpython/pull/146470/files
gh-146452: Fix pickle segfault on concurrent mutation of dict and list https://github.com/python/cpython/pull/146470/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/146470/files
8f55561 gh-146452: Fix pickle segfault when pickling dict with concurrent mut… overlorde Mar 26, 2026 https://github.com/python/cpython/pull/146470/commits/8f55561513fd39b3e129abadfe2c095b921fd155
c4a8ee1 Merge branch 'main' into fix-issue-146452 overlorde Mar 27, 2026 https://github.com/python/cpython/pull/146470/commits/c4a8ee12b15ab3a17bbd5c9e765b1bee1497bbb6
3e57547 Apply suggestion from @kumaraditya303 kumaraditya303 May 17, 2026 https://github.com/python/cpython/pull/146470/commits/3e57547eda6ee4e6a3a5711d9060a68d3658ce40
6276525 change test to use threading_helper.start_threads kumaraditya303 May 17, 2026 https://github.com/python/cpython/pull/146470/commits/6276525b90ca12ce1314469b95522210348db31b
f83fe04 Merge branch 'main' into fix-issue-146452 kumaraditya303 May 17, 2026 https://github.com/python/cpython/pull/146470/commits/f83fe0416b40cb02bbe2ede34b04d6def01fe8e6
62b5811 fix news kumaraditya303 May 17, 2026 https://github.com/python/cpython/pull/146470/commits/62b5811203dae17a8e9197811184d110c1760689
3d305ca Merge branch 'fix-issue-146452' of https://github.com/overlorde/cpyth… kumaraditya303 May 17, 2026 https://github.com/python/cpython/pull/146470/commits/3d305caeb8c63a4d12b7ae7c3bbf86efb7ab8397
Clear filters https://github.com/python/cpython/pull/146470/files
Please reload this pagehttps://github.com/python/cpython/pull/146470/files
Please reload this pagehttps://github.com/python/cpython/pull/146470/files
test_pickle.py https://github.com/python/cpython/pull/146470/files#diff-0ba3c585f5d7cb238340d9412562fff74cfd9d43910adb2d9ce74e0e333ddba5
2026-03-26-09-30-00.gh-issue-146452.Y2N6qZ8J.rst https://github.com/python/cpython/pull/146470/files#diff-8ab7bcc20d5c92fdacfa7901bda43f197fd87738c962f47ad3dc7792590e74e3
_pickle.c https://github.com/python/cpython/pull/146470/files#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
Lib/test/test_free_threading/test_pickle.pyhttps://github.com/python/cpython/pull/146470/files#diff-0ba3c585f5d7cb238340d9412562fff74cfd9d43910adb2d9ce74e0e333ddba5
View file https://github.com/overlorde/cpython/blob/3d305caeb8c63a4d12b7ae7c3bbf86efb7ab8397/Lib/test/test_free_threading/test_pickle.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/146470/{{ revealButtonHref }}
Misc/NEWS.d/next/Library/2026-03-26-09-30-00.gh-issue-146452.Y2N6qZ8J.rsthttps://github.com/python/cpython/pull/146470/files#diff-8ab7bcc20d5c92fdacfa7901bda43f197fd87738c962f47ad3dc7792590e74e3
View file https://github.com/overlorde/cpython/blob/3d305caeb8c63a4d12b7ae7c3bbf86efb7ab8397/Misc/NEWS.d/next/Library/2026-03-26-09-30-00.gh-issue-146452.Y2N6qZ8J.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/146470/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/146470/files
Modules/_pickle.chttps://github.com/python/cpython/pull/146470/files#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
View file https://github.com/overlorde/cpython/blob/3d305caeb8c63a4d12b7ae7c3bbf86efb7ab8397/Modules/_pickle.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/146470/{{ revealButtonHref }}
https://github.com/python/cpython/pull/146470/files#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
https://github.com/python/cpython/pull/146470/files#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
https://github.com/python/cpython/pull/146470/files#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
https://github.com/python/cpython/pull/146470/files#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
Please reload this pagehttps://github.com/python/cpython/pull/146470/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.