René's URL Explorer Experiment


Title: gh-146455: Fix O(N²) in add_const() after constant folding moved to CFG by zSirius · Pull Request #146456 · python/cpython · GitHub

Open Graph Title: gh-146455: Fix O(N²) in add_const() after constant folding moved to CFG by zSirius · Pull Request #146456 · python/cpython

X Title: gh-146455: Fix O(N²) in add_const() after constant folding moved to CFG by zSirius · Pull Request #146456 · python/cpython

Description: Fix O(N²) performance regression in add_const() introduced by moving constant folding from AST to CFG optimizer (gh-126835). Problem After gh-130769 moved tuple folding to CFG, fold_tuple_of_constants() calls add_const() once per inner tuple element. add_const() does a linear scan over the consts list to find the index, so N calls × O(N) scan = O(N²). The same issue affects unary/binary op folding moved in gh-129550 (fold_const_unaryop, fold_const_binop). perf profiling shows add_const taking 83.76% of CPU time when compiling 100K nested constant tuples. Fix Maintain an auxiliary _Py_hashtable_t (pointer → index mapping) alongside the consts list, providing O(1) constant lookup. The hashtable: Uses _Py_hashtable_hash_ptr / _Py_hashtable_compare_direct — pure pointer ops, no Python object overhead Is created at the start of _PyCfg_OptimizeCodeUnit() and destroyed after optimize_cfg(), before remove_unused_consts() reindexes the list Works correctly because _PyCompile_ConstCacheMergeOne() already guarantees identity uniqueness (equal-valued constants share the same pointer) All modified functions are static — no public API changes. Performance (N=100K) Scenario 3.11 3.14 (before) 3.14 (after fix) Nested tuples ((f, f), ...) 1.24s 10.38s 1.48s Unary neg (-1, -2, ..., -N) 0.22s 6.86s 1.12s Binary add (0+1, 0+2, ..., 0+N) 0.27s 2.59s 1.40s All existing tests pass: test_compile, test_peepholer, test_ast, test_dis. Issue: gh-146455

Open Graph Description: Fix O(N²) performance regression in add_const() introduced by moving constant folding from AST to CFG optimizer (gh-126835). Problem After gh-130769 moved tuple folding to CFG, fold_tuple_of_consta...

X Description: Fix O(N²) performance regression in add_const() introduced by moving constant folding from AST to CFG optimizer (gh-126835). Problem After gh-130769 moved tuple folding to CFG, fold_tuple_of_consta...

Opengraph URL: https://github.com/python/cpython/pull/146456

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:88d41d61-173a-5c53-4cf4-4689ac9a4e7d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBC32:386611:41AF88:567690:6B023B39
html-safe-nonce3b950c44452d76af88693e258776216436da424d67167c87f67aa4610763f096
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzMyOjM4NjYxMTo0MUFGODg6NTY3NjkwOjZCMDIzQjM5IiwidmlzaXRvcl9pZCI6IjQxMjk2Nzg0MDYyODE0NzY5MjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac165f04ba8ac1b7ac6d9b7433d6258ee5cfdf84d2137add79382ed39e66056f27
hovercard-subject-tagpull_request:3449899504
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/146456/files
twitter:imagehttps://avatars.githubusercontent.com/u/107359899?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/107359899?s=400&v=4
og:image:altFix O(N²) performance regression in add_const() introduced by moving constant folding from AST to CFG optimizer (gh-126835). Problem After gh-130769 moved tuple folding to CFG, fold_tuple_of_consta...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/146456/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146456%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146456%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/146456/files
Reloadhttps://github.com/python/cpython/pull/146456/files
Reloadhttps://github.com/python/cpython/pull/146456/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Eclips4https://github.com/Eclips4
python:mainhttps://github.com/python/cpython/tree/main
zSirius:fix-add-const-quadratichttps://github.com/zSirius/cpython/tree/fix-add-const-quadratic
Conversation 11 https://github.com/python/cpython/pull/146456
Commits 3 https://github.com/python/cpython/pull/146456/commits
Checks 56 https://github.com/python/cpython/pull/146456/checks
Files changed https://github.com/python/cpython/pull/146456/files
Please reload this pagehttps://github.com/python/cpython/pull/146456/files
gh-146455: Fix O(N²) in add_const() after constant folding moved to CFG https://github.com/python/cpython/pull/146456/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/146456/files
2a67136 gh-146455: Fix O(N²) in add_const() after constant folding moved to CFG Mar 20, 2026 https://github.com/python/cpython/pull/146456/commits/2a6713610f7d15143b3ba2b2497d9c3f8b487deb
cebc9fc 📜🤖 Added by blurb_it. Mar 26, 2026 https://github.com/python/cpython/pull/146456/commits/cebc9fc9a01910c381744bf8b867f60bc60d3cdf
ef2e494 Remove unnecessary comments Apr 22, 2026 https://github.com/python/cpython/pull/146456/commits/ef2e494cc8f29b049134535fcedc590a9b40063a
Clear filters https://github.com/python/cpython/pull/146456/files
Please reload this pagehttps://github.com/python/cpython/pull/146456/files
Please reload this pagehttps://github.com/python/cpython/pull/146456/files
2026-03-26-08-49-35.gh-issue-146455.f54083a9.rst https://github.com/python/cpython/pull/146456/files#diff-596a23ee48b4b325e2854d0aab07bf6051ed5fb570c85f7b3d98fb7833b8fedf
flowgraph.c https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
.../NEWS.d/next/Core_and_Builtins/2026-03-26-08-49-35.gh-issue-146455.f54083a9.rsthttps://github.com/python/cpython/pull/146456/files#diff-596a23ee48b4b325e2854d0aab07bf6051ed5fb570c85f7b3d98fb7833b8fedf
View file https://github.com/zSirius/cpython/blob/ef2e494cc8f29b049134535fcedc590a9b40063a/Misc/NEWS.d/next/Core_and_Builtins/2026-03-26-08-49-35.gh-issue-146455.f54083a9.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/146456/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L230
Python/flowgraph.chttps://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
View file https://github.com/zSirius/cpython/blob/ef2e494cc8f29b049134535fcedc590a9b40063a/Python/flowgraph.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/146456/{{ revealButtonHref }}
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
iritkatrielhttps://github.com/iritkatriel
Apr 26, 2026https://github.com/python/cpython/pull/146456/files#r3143460829
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/146456/files
https://github.com/python/cpython/pull/146456/files#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
Please reload this pagehttps://github.com/python/cpython/pull/146456/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.