René's URL Explorer Experiment


Title: gh-146455: Fix O(N²) in add_const() after constant folding moved to CFG by zSirius · Pull Request #146456 · python/cpython · GitHub

Open Graph Title: gh-146455: Fix O(N²) in add_const() after constant folding moved to CFG by zSirius · Pull Request #146456 · python/cpython

X Title: gh-146455: Fix O(N²) in add_const() after constant folding moved to CFG by zSirius · Pull Request #146456 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Fix O(N²) performance regression in add_const() introduced by moving constant folding from AST to CFG optimizer (gh-126835). Problem After gh-130769 moved tuple folding to CFG, fold_tuple_of_consta...

X Description: Fix O(N²) performance regression in add_const() introduced by moving constant folding from AST to CFG optimizer (gh-126835). Problem After gh-130769 moved tuple folding to CFG, fold_tuple_of_consta...

Opengraph URL: https://github.com/python/cpython/pull/146456

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/checks(.:format)
route-controllerpull_requests
route-actionchecks
fetch-noncev2:f2d1028d-6472-8a31-4f19-ceb0cfbdd534
current-catalog-service-hash87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a
request-idB288:CD79A:439994:59243D:6B023B66
html-safe-noncee49eb9749e4c5889bfba9c42d76df774c83e531004b7efa5f9fd3eb4b84f78ee
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjg4OkNENzlBOjQzOTk5NDo1OTI0M0Q6NkIwMjNCNjYiLCJ2aXNpdG9yX2lkIjoiODk1OTUyNzAzNTEwNjExNDQwNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac213b1661afa4b17e80058b06c8767d36c42f21012a9eef6d61dbdb4ae8bf3d1d
hovercard-subject-tagpull_request:3449899504
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/checks
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/146456/checks
twitter:imagehttps://opengraph.githubassets.com/b0ef7bf76f5cd80845eb3bc393f1c85ad246d15d56f877f3af4c776d9d45b2ed/python/cpython/pull/146456
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b0ef7bf76f5cd80845eb3bc393f1c85ad246d15d56f877f3af4c776d9d45b2ed/python/cpython/pull/146456
og:image:altFix O(N²) performance regression in add_const() introduced by moving constant folding from AST to CFG optimizer (gh-126835). Problem After gh-130769 moved tuple folding to CFG, fold_tuple_of_consta...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamezSirius
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/146456/checks#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146456%2Fchecks
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146456%2Fchecks
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/146456/checks
Reloadhttps://github.com/python/cpython/pull/146456/checks
Reloadhttps://github.com/python/cpython/pull/146456/checks
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
Eclips4https://github.com/Eclips4
python:mainhttps://github.com/python/cpython/tree/main
zSirius:fix-add-const-quadratichttps://github.com/zSirius/cpython/tree/fix-add-const-quadratic
Conversationhttps://github.com/python/cpython/pull/146456
Commits3 (3)https://github.com/python/cpython/pull/146456/commits
Checkshttps://github.com/python/cpython/pull/146456/checks
Files changedhttps://github.com/python/cpython/pull/146456/files
gh-146455: Fix O(N²) in add_const() after constant folding moved to CFGhttps://github.com/python/cpython/pull/146456/checks#top
Eclips4https://github.com/Eclips4
python:mainhttps://github.com/python/cpython/tree/main
zSirius:fix-add-const-quadratichttps://github.com/zSirius/cpython/tree/fix-add-const-quadratic
Please reload this pagehttps://github.com/python/cpython/pull/146456/checks
Sign in for the full log viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146456%2Fchecks
Check labels on: pull_request https://github.com/python/cpython/actions/runs/24763287936
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/24763287936/job/72451607519?pr=146456
Unresolved review https://github.com/python/cpython/actions/runs/24763287936/job/72451607546?pr=146456
Lint on: pull_request https://github.com/python/cpython/actions/runs/24763287930
lint https://github.com/python/cpython/actions/runs/24763287930/job/72451607611?pr=146456
Tests on: pull_request https://github.com/python/cpython/actions/runs/24763287970
Change detection / Create context from changed files https://github.com/python/cpython/actions/runs/24763287970/job/72451607812?pr=146456
Docs / Docs https://github.com/python/cpython/actions/runs/24763287970/job/72451631021?pr=146456
Docs / Doctest https://github.com/python/cpython/actions/runs/24763287970/job/72451631006?pr=146456
Docs / Check EPUB https://github.com/python/cpython/actions/runs/24763287970/job/72451631012?pr=146456
Docs / Check for removed HTML IDs / Check for removed HTML IDs https://github.com/python/cpython/actions/runs/24763287970/job/72451838089?pr=146456
Check if Autoconf files are up to date https://github.com/python/cpython/actions/runs/24763287970/job/72451630544?pr=146456
Check if generated files are up to date https://github.com/python/cpython/actions/runs/24763287970/job/72451630541?pr=146456
C API Docs / Check if all C APIs are documented https://github.com/python/cpython/actions/runs/24763287970/job/72451630638?pr=146456
Windows / Build and test (x64, switch-case) https://github.com/python/cpython/actions/runs/24763287970/job/72451630845?pr=146456
Windows (free-threading) / Build and test (x64, switch-case) https://github.com/python/cpython/actions/runs/24763287970/job/72451630832?pr=146456
Windows / Build and test (Win32, switch-case) https://github.com/python/cpython/actions/runs/24763287970/job/72451630846?pr=146456
Windows / Build and test (arm64, switch-case) https://github.com/python/cpython/actions/runs/24763287970/job/72451630844?pr=146456
Windows (free-threading) / Build and test (arm64, switch-case) https://github.com/python/cpython/actions/runs/24763287970/job/72451630853?pr=146456
Windows / Build and test (x64, tail-call) https://github.com/python/cpython/actions/runs/24763287970/job/72451630857?pr=146456
Windows (free-threading) / Build and test (x64, tail-call) https://github.com/python/cpython/actions/runs/24763287970/job/72451630830?pr=146456
Windows MSI${{ '' }} https://github.com/python/cpython/actions/runs/24763287970/job/72451630701?pr=146456
macOS / build and test (macos-26) https://github.com/python/cpython/actions/runs/24763287970/job/72451630887?pr=146456
macOS (free-threading) / build and test (macos-26) https://github.com/python/cpython/actions/runs/24763287970/job/72451630902?pr=146456
macOS / build and test (macos-15-intel) https://github.com/python/cpython/actions/runs/24763287970/job/72451630898?pr=146456
Ubuntu / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/24763287970/job/72451630999?pr=146456
Ubuntu / build and test (ubuntu-24.04-arm) https://github.com/python/cpython/actions/runs/24763287970/job/72451630998?pr=146456
Ubuntu (free-threading) / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/24763287970/job/72451630987?pr=146456
Ubuntu (free-threading) / build and test (ubuntu-24.04-arm) https://github.com/python/cpython/actions/runs/24763287970/job/72451631000?pr=146456
Ubuntu (bolt) / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/24763287970/job/72451631002?pr=146456
Ubuntu SSL tests (ubuntu-24.04, openssl, 1.1.1w) https://github.com/python/cpython/actions/runs/24763287970/job/72451630688?pr=146456
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.0.19) https://github.com/python/cpython/actions/runs/24763287970/job/72451630703?pr=146456
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.3.6) https://github.com/python/cpython/actions/runs/24763287970/job/72451630674?pr=146456
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.4.4) https://github.com/python/cpython/actions/runs/24763287970/job/72451630696?pr=146456
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.5.5) https://github.com/python/cpython/actions/runs/24763287970/job/72451630697?pr=146456
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.6.1) https://github.com/python/cpython/actions/runs/24763287970/job/72451630677?pr=146456
Ubuntu SSL tests (ubuntu-24.04, aws-lc, 1.68.0) https://github.com/python/cpython/actions/runs/24763287970/job/72451630689?pr=146456
Android (aarch64) https://github.com/python/cpython/actions/runs/24763287970/job/72451630647?pr=146456
Android (x86_64) https://github.com/python/cpython/actions/runs/24763287970/job/72451630645?pr=146456
iOS https://github.com/python/cpython/actions/runs/24763287970/job/72451630633?pr=146456
Emscripten / build and test https://github.com/python/cpython/actions/runs/24763287970/job/72451630818?pr=146456
WASI / build and test https://github.com/python/cpython/actions/runs/24763287970/job/72451630814?pr=146456
Hypothesis tests on Ubuntu https://github.com/python/cpython/actions/runs/24763287970/job/72451630586?pr=146456
Address sanitizer (ubuntu-24.04) https://github.com/python/cpython/actions/runs/24763287970/job/72451630593?pr=146456
Sanitizers / TSan https://github.com/python/cpython/actions/runs/24763287970/job/72451630929?pr=146456
Sanitizers / TSan (free-threading) https://github.com/python/cpython/actions/runs/24763287970/job/72451630931?pr=146456
Sanitizers / UBSan https://github.com/python/cpython/actions/runs/24763287970/job/72451631007?pr=146456
Cross build Linux https://github.com/python/cpython/actions/runs/24763287970/job/72451630639?pr=146456
CIFuzz / cpython3 (address) https://github.com/python/cpython/actions/runs/24763287970/job/72451630932?pr=146456
CIFuzz / cpython3 (undefined) https://github.com/python/cpython/actions/runs/24763287970/job/72451630904?pr=146456
CIFuzz / cpython3 (memory) https://github.com/python/cpython/actions/runs/24763287970/job/72451630914?pr=146456
All required checks pass https://github.com/python/cpython/actions/runs/24763287970/job/72454338704?pr=146456
ClusterFuzzLite/CIFuzz https://github.com/python/cpython/pull/146456/checks?check_run_id=72453640467
Check labels on: pull_request https://github.com/python/cpython/actions/runs/24956380007
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/24956380007/job/73075255352?pr=146456
Unresolved review https://github.com/python/cpython/actions/runs/24956380007/job/73075255322?pr=146456
Check labels on: pull_request https://github.com/python/cpython/actions/runs/24956392295
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/24956392295/job/73075289755?pr=146456
Unresolved review https://github.com/python/cpython/actions/runs/24956392295/job/73075289758?pr=146456
Check labels on: pull_request https://github.com/python/cpython/actions/runs/24956395216
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/24956395216/job/73075298698?pr=146456
Unresolved review https://github.com/python/cpython/actions/runs/24956395216/job/73075298703?pr=146456
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.