René's URL Explorer Experiment


Title: gh-146355: Fix `main_module` ref leak in `_PyRun_SimpleStringFlagsWithName` by A0su · Pull Request #146356 · python/cpython · GitHub

Open Graph Title: gh-146355: Fix `main_module` ref leak in `_PyRun_SimpleStringFlagsWithName` by A0su · Pull Request #146356 · python/cpython

X Title: gh-146355: Fix `main_module` ref leak in `_PyRun_SimpleStringFlagsWithName` by A0su · Pull Request #146356 · python/cpython

Description: gh-146355: Fix main_module ref leak in _PyRun_SimpleStringFlagsWithName This is a sub-issue for #146102 and original gist details can be found here When the_name is NULL we'll fail to call Py_DECREF on main_module. I used the same goto pattern as _PyRun_SimpleFileObject to fix this. I omitted a new test entry as we have indirect coverage of functionality in test_embed.py. Not sure if it makes sense for the scope of fixing the ref leak to include the additional code for a test in test_run.py (which has a TODO for this function).

Open Graph Description: gh-146355: Fix main_module ref leak in _PyRun_SimpleStringFlagsWithName This is a sub-issue for #146102 and original gist details can be found here When the_name is NULL we'll fail to call Py_D...

X Description: gh-146355: Fix main_module ref leak in _PyRun_SimpleStringFlagsWithName This is a sub-issue for #146102 and original gist details can be found here When the_name is NULL we'll fail to call ...

Opengraph URL: https://github.com/python/cpython/pull/146356

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:51f9f56d-18b7-7ae3-4c8c-de16c255c72a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB65C:9C6CC:2069F71:2E108F1:6A50E861
html-safe-nonce4dcf45f09439ad0b80f058ffb3c4c99429e26052250f9e4ebd8b58f75306bbbe
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjVDOjlDNkNDOjIwNjlGNzE6MkUxMDhGMTo2QTUwRTg2MSIsInZpc2l0b3JfaWQiOiIzOTY3Mjk1NTE5NjkzMjY5MDg5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd2ddc4d5ac138bf6eb0dfdf706b5f14c1f478d677d950ce1a133e02c5783e0d5
hovercard-subject-tagpull_request:3437109160
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/146356/files
twitter:imagehttps://avatars.githubusercontent.com/u/43610414?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/43610414?s=400&v=4
og:image:altgh-146355: Fix main_module ref leak in _PyRun_SimpleStringFlagsWithName This is a sub-issue for #146102 and original gist details can be found here When the_name is NULL we'll fail to call Py_D...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None72b13e0e8d0319acdd27a145cfe73f4f06c791713d0ac4690e41fb68ad28cac0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasefb19d617b534959801b4b7453938ecf1dfa22131
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/146356/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146356%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146356%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/146356/files
Reloadhttps://github.com/python/cpython/pull/146356/files
Reloadhttps://github.com/python/cpython/pull/146356/files
Please reload this pagehttps://github.com/python/cpython/pull/146356/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/146356/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
A0su:Fix-SimpleStringFlagsWithName-main-refleakhttps://github.com/A0su/cpython/tree/Fix-SimpleStringFlagsWithName-main-refleak
Conversation 9 https://github.com/python/cpython/pull/146356
Commits 2 https://github.com/python/cpython/pull/146356/commits
Checks 57 https://github.com/python/cpython/pull/146356/checks
Files changed https://github.com/python/cpython/pull/146356/files
Please reload this pagehttps://github.com/python/cpython/pull/146356/files
gh-146355: Fix main_module ref leak in _PyRun_SimpleStringFlagsWithName https://github.com/python/cpython/pull/146356/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/146356/files
cdf1ef3 refactor _PyRun_SimpleStringFlagsWithName to follow goto pattern in _… A0su Mar 24, 2026 https://github.com/python/cpython/pull/146356/commits/cdf1ef3c217e2871c8efefbf7ac74dc00f706a44
4c99feb change to single line fix adding main_module decref A0su Mar 24, 2026 https://github.com/python/cpython/pull/146356/commits/4c99feb15a6f93784f97a8855f5e495a3890b1a0
Clear filters https://github.com/python/cpython/pull/146356/files
Please reload this pagehttps://github.com/python/cpython/pull/146356/files
Please reload this pagehttps://github.com/python/cpython/pull/146356/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L273
Python/pythonrun.chttps://github.com/python/cpython/pull/146356/files#diff-2ecd9b536bc387479d824dc4b53f89679d6978d25c6b8a28ab21ed03e745e46e
View file https://github.com/A0su/cpython/blob/4c99feb15a6f93784f97a8855f5e495a3890b1a0/Python/pythonrun.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/146356/{{ revealButtonHref }}
https://github.com/python/cpython/pull/146356/files#diff-2ecd9b536bc387479d824dc4b53f89679d6978d25c6b8a28ab21ed03e745e46e
https://github.com/python/cpython/pull/146356/files#diff-2ecd9b536bc387479d824dc4b53f89679d6978d25c6b8a28ab21ed03e745e46e
Please reload this pagehttps://github.com/python/cpython/pull/146356/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.