René's URL Explorer Experiment


Title: gh-146261: JIT: protect against function version changes by Fidget-Spinner · Pull Request #146300 · python/cpython · GitHub

Open Graph Title: gh-146261: JIT: protect against function version changes by Fidget-Spinner · Pull Request #146300 · python/cpython

X Title: gh-146261: JIT: protect against function version changes by Fidget-Spinner · Pull Request #146300 · python/cpython

Description: This PR reverts the func_version symbol changes by using the fact that we have recorded values and _CHECK_FUNCTION_VERSION guards --- if we simply keep those around and not eliminate them, our function versions are guaranteed to be correct for all following _PUSH_FRAME if we invalidate dependencies properly in the function version changes. Issue: gh-146261

Open Graph Description: This PR reverts the func_version symbol changes by using the fact that we have recorded values and _CHECK_FUNCTION_VERSION guards --- if we simply keep those around and not eliminate them, our func...

X Description: This PR reverts the func_version symbol changes by using the fact that we have recorded values and _CHECK_FUNCTION_VERSION guards --- if we simply keep those around and not eliminate them, our func...

Opengraph URL: https://github.com/python/cpython/pull/146300

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6a815e57-eada-c9de-0f1b-864747280c51
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB2BC:D445D:14676DD:1B9B828:6A522067
html-safe-nonce4f08c98a94600e9fcade104322cf53ffd0f1676183920c5f12495ccc0fcf5408
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMkJDOkQ0NDVEOjE0Njc2REQ6MUI5QjgyODo2QTUyMjA2NyIsInZpc2l0b3JfaWQiOiIyMzQ3MDYwMjE4NzA0MzA2Mjc5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb7fda842d4eb69aa71240f088f93230b50fa1bff86be98f68efd8606a58b972f
hovercard-subject-tagpull_request:3430980654
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/146300/files
twitter:imagehttps://avatars.githubusercontent.com/u/28750310?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/28750310?s=400&v=4
og:image:altThis PR reverts the func_version symbol changes by using the fact that we have recorded values and _CHECK_FUNCTION_VERSION guards --- if we simply keep those around and not eliminate them, our func...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/146300/changes#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146300%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146300%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/146300/changes
Reloadhttps://github.com/python/cpython/pull/146300/changes
Reloadhttps://github.com/python/cpython/pull/146300/changes
Please reload this pagehttps://github.com/python/cpython/pull/146300/changes
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/146300/changes
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Fidget-Spinnerhttps://github.com/Fidget-Spinner
python:mainhttps://github.com/python/cpython/tree/main
Fidget-Spinner:fix_func_version_changeshttps://github.com/Fidget-Spinner/cpython/tree/fix_func_version_changes
Conversation 2 https://github.com/python/cpython/pull/146300
Commits 7 https://github.com/python/cpython/pull/146300/commits
Checks 67 https://github.com/python/cpython/pull/146300/checks
Files changed https://github.com/python/cpython/pull/146300/files
Please reload this pagehttps://github.com/python/cpython/pull/146300/changes
gh-146261: JIT: protect against function version changes https://github.com/python/cpython/pull/146300/changes#top
Show all changes 7 commits https://github.com/python/cpython/pull/146300/files
a1ef342 JIT: protect against function version changes Fidget-Spinner Mar 22, 2026 https://github.com/python/cpython/pull/146300/commits/a1ef342c2669d2b626ac460091fd0c0fd9368a0b
dc19d93 pass the interp Fidget-Spinner Mar 22, 2026 https://github.com/python/cpython/pull/146300/commits/dc19d93e7201ee067e0ab04cb6a584cf2b5b7e06
463ed28 Update Objects/funcobject.c Fidget-Spinner Apr 6, 2026 https://github.com/python/cpython/pull/146300/commits/463ed287cce7c1070e5ea224d9c324dfabe7796f
ff29164 Merge remote-tracking branch 'upstream/main' into fix_func_version_ch… Fidget-Spinner Apr 12, 2026 https://github.com/python/cpython/pull/146300/commits/ff29164c76eae4163ffa28f5ca3c2798740902aa
9dd70a0 remove func version symbol altogether --- to buggy without watchers Fidget-Spinner Apr 12, 2026 https://github.com/python/cpython/pull/146300/commits/9dd70a02e5792a78508624afe462ea4a03d8ef78
8806c74 Fixups Fidget-Spinner Apr 12, 2026 https://github.com/python/cpython/pull/146300/commits/8806c74b0e172217138fa4e868a392f83945a403
6a42001 Add back test properly Fidget-Spinner Apr 12, 2026 https://github.com/python/cpython/pull/146300/commits/6a42001dc9e97ca62ecb5965ed028b1284e194f4
Clear filters https://github.com/python/cpython/pull/146300/files
Please reload this pagehttps://github.com/python/cpython/pull/146300/changes
Please reload this pagehttps://github.com/python/cpython/pull/146300/changes
pycore_optimizer.h https://github.com/python/cpython/pull/146300/changes#diff-04d62d99f4a2b418ae2fd0eecece5b153dee4ac843c706a8de03c45a2d65efcc
pycore_optimizer_types.h https://github.com/python/cpython/pull/146300/changes#diff-cd178e6d4ba8f18694ab0771162f51bd0ac2415e8d3ce0d43171b2e8c092bcfa
test_opt.py https://github.com/python/cpython/pull/146300/changes#diff-67b5bd915e37f77df79907865982648172c27d3b96fbb072b30a73c6a2735439
funcobject.c https://github.com/python/cpython/pull/146300/changes#diff-57bc77178b3d6f1010dd924722c87522f224d93bc341f0e46c0945094124d8f2
optimizer_analysis.c https://github.com/python/cpython/pull/146300/changes#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
optimizer_bytecodes.c https://github.com/python/cpython/pull/146300/changes#diff-e5bd2b14b0b10f0f47786e26306d689ed1361c3dc3b11dcc3ea52b8a2422ff64
optimizer_cases.c.h https://github.com/python/cpython/pull/146300/changes#diff-ed4567b3e67709ec57bf4df91ef058cfcbe00d7da11cd2a75e38241fa1ca99d2
optimizer_symbols.c https://github.com/python/cpython/pull/146300/changes#diff-b28c00f0aab70992e604ed7c3e9cb4ca39779f33d5ff2c7777de5a044422f095
Include/internal/pycore_optimizer.hhttps://github.com/python/cpython/pull/146300/changes#diff-04d62d99f4a2b418ae2fd0eecece5b153dee4ac843c706a8de03c45a2d65efcc
View file https://github.com/Fidget-Spinner/cpython/blob/6a42001dc9e97ca62ecb5965ed028b1284e194f4/Include/internal/pycore_optimizer.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/146300/{{ revealButtonHref }}
https://github.com/python/cpython/pull/146300/changes#diff-04d62d99f4a2b418ae2fd0eecece5b153dee4ac843c706a8de03c45a2d65efcc
https://github.com/python/cpython/pull/146300/changes#diff-04d62d99f4a2b418ae2fd0eecece5b153dee4ac843c706a8de03c45a2d65efcc
Include/internal/pycore_optimizer_types.hhttps://github.com/python/cpython/pull/146300/changes#diff-cd178e6d4ba8f18694ab0771162f51bd0ac2415e8d3ce0d43171b2e8c092bcfa
View file https://github.com/Fidget-Spinner/cpython/blob/6a42001dc9e97ca62ecb5965ed028b1284e194f4/Include/internal/pycore_optimizer_types.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/146300/{{ revealButtonHref }}
https://github.com/python/cpython/pull/146300/changes#diff-cd178e6d4ba8f18694ab0771162f51bd0ac2415e8d3ce0d43171b2e8c092bcfa
https://github.com/python/cpython/pull/146300/changes#diff-cd178e6d4ba8f18694ab0771162f51bd0ac2415e8d3ce0d43171b2e8c092bcfa
Lib/test/test_capi/test_opt.pyhttps://github.com/python/cpython/pull/146300/changes#diff-67b5bd915e37f77df79907865982648172c27d3b96fbb072b30a73c6a2735439
View file https://github.com/Fidget-Spinner/cpython/blob/6a42001dc9e97ca62ecb5965ed028b1284e194f4/Lib/test/test_capi/test_opt.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/146300/{{ revealButtonHref }}
https://github.com/python/cpython/pull/146300/changes#diff-67b5bd915e37f77df79907865982648172c27d3b96fbb072b30a73c6a2735439
https://github.com/python/cpython/pull/146300/changes#diff-67b5bd915e37f77df79907865982648172c27d3b96fbb072b30a73c6a2735439
https://github.com/python/cpython/pull/146300/changes#diff-67b5bd915e37f77df79907865982648172c27d3b96fbb072b30a73c6a2735439
https://github.com/python/cpython/pull/146300/changes#diff-67b5bd915e37f77df79907865982648172c27d3b96fbb072b30a73c6a2735439
https://github.com/python/cpython/pull/146300/changes#diff-67b5bd915e37f77df79907865982648172c27d3b96fbb072b30a73c6a2735439
https://github.com/python/cpython/pull/146300/changes#diff-67b5bd915e37f77df79907865982648172c27d3b96fbb072b30a73c6a2735439
https://github.com/python/cpython/pull/146300/changes#diff-67b5bd915e37f77df79907865982648172c27d3b96fbb072b30a73c6a2735439
https://github.com/python/cpython/pull/146300/changes#diff-67b5bd915e37f77df79907865982648172c27d3b96fbb072b30a73c6a2735439
Objects/funcobject.chttps://github.com/python/cpython/pull/146300/changes#diff-57bc77178b3d6f1010dd924722c87522f224d93bc341f0e46c0945094124d8f2
View file https://github.com/Fidget-Spinner/cpython/blob/6a42001dc9e97ca62ecb5965ed028b1284e194f4/Objects/funcobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/146300/{{ revealButtonHref }}
https://github.com/python/cpython/pull/146300/changes#diff-57bc77178b3d6f1010dd924722c87522f224d93bc341f0e46c0945094124d8f2
https://github.com/python/cpython/pull/146300/changes#diff-57bc77178b3d6f1010dd924722c87522f224d93bc341f0e46c0945094124d8f2
https://github.com/python/cpython/pull/146300/changes#diff-57bc77178b3d6f1010dd924722c87522f224d93bc341f0e46c0945094124d8f2
https://github.com/python/cpython/pull/146300/changes#diff-57bc77178b3d6f1010dd924722c87522f224d93bc341f0e46c0945094124d8f2
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L306
Python/optimizer_analysis.chttps://github.com/python/cpython/pull/146300/changes#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
View file https://github.com/Fidget-Spinner/cpython/blob/6a42001dc9e97ca62ecb5965ed028b1284e194f4/Python/optimizer_analysis.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/146300/{{ revealButtonHref }}
https://github.com/python/cpython/pull/146300/changes#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
https://github.com/python/cpython/pull/146300/changes#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L307
Python/optimizer_bytecodes.chttps://github.com/python/cpython/pull/146300/changes#diff-e5bd2b14b0b10f0f47786e26306d689ed1361c3dc3b11dcc3ea52b8a2422ff64
View file https://github.com/Fidget-Spinner/cpython/blob/6a42001dc9e97ca62ecb5965ed028b1284e194f4/Python/optimizer_bytecodes.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/146300/{{ revealButtonHref }}
https://github.com/python/cpython/pull/146300/changes#diff-e5bd2b14b0b10f0f47786e26306d689ed1361c3dc3b11dcc3ea52b8a2422ff64
https://github.com/python/cpython/pull/146300/changes#diff-e5bd2b14b0b10f0f47786e26306d689ed1361c3dc3b11dcc3ea52b8a2422ff64
https://github.com/python/cpython/pull/146300/changes#diff-e5bd2b14b0b10f0f47786e26306d689ed1361c3dc3b11dcc3ea52b8a2422ff64
https://github.com/python/cpython/pull/146300/changes#diff-e5bd2b14b0b10f0f47786e26306d689ed1361c3dc3b11dcc3ea52b8a2422ff64
https://github.com/python/cpython/pull/146300/changes#diff-e5bd2b14b0b10f0f47786e26306d689ed1361c3dc3b11dcc3ea52b8a2422ff64
https://github.com/python/cpython/pull/146300/changes#diff-e5bd2b14b0b10f0f47786e26306d689ed1361c3dc3b11dcc3ea52b8a2422ff64
Python/optimizer_cases.c.hhttps://github.com/python/cpython/pull/146300/changes#diff-ed4567b3e67709ec57bf4df91ef058cfcbe00d7da11cd2a75e38241fa1ca99d2
View file https://github.com/Fidget-Spinner/cpython/blob/6a42001dc9e97ca62ecb5965ed028b1284e194f4/Python/optimizer_cases.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/146300/changes
Please reload this pagehttps://github.com/python/cpython/pull/146300/changes
Please reload this pagehttps://github.com/python/cpython/pull/146300/changes
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.