René's URL Explorer Experiment


Title: gh-146205: Check the errno with != 0 in close impls in select module by aisk · Pull Request #146206 · python/cpython · GitHub

Open Graph Title: gh-146205: Check the errno with != 0 in close impls in select module by aisk · Pull Request #146206 · python/cpython

X Title: gh-146205: Check the errno with != 0 in close impls in select module by aisk · Pull Request #146206 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Also changed to set the errno to err only if err != 0. Issue: selectmodule.c: errno < 0 comparison is always false #146205

X Description: Also changed to set the errno to err only if err != 0. Issue: selectmodule.c: errno < 0 comparison is always false #146205

Opengraph URL: https://github.com/python/cpython/pull/146206

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/checks(.:format)
route-controllerpull_requests
route-actionchecks
fetch-noncev2:5df1815d-e0f8-ffc9-b8bc-133ffffb5404
current-catalog-service-hash87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a
request-idB6E4:CB81E:467731E:61E2A03:6A50CBF8
html-safe-nonce45a04a89a07bef12a5e8d1f31417519e4371f849c5d7accf1da480cb52e0317f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNkU0OkNCODFFOjQ2NzczMUU6NjFFMkEwMzo2QTUwQ0JGOCIsInZpc2l0b3JfaWQiOiI3ODEwMDA4Mjc0MTYyNDY5ODgwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8da12d76b45739e5044b707f97ec6f77d2633103575e5c66e54e1366d5049265
hovercard-subject-tagpull_request:3424855456
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/checks
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/146206/checks
twitter:imagehttps://opengraph.githubassets.com/d21ff308052ae2656214e44f10864c876f2c3beb8f985c111e0029dc749698b2/python/cpython/pull/146206
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d21ff308052ae2656214e44f10864c876f2c3beb8f985c111e0029dc749698b2/python/cpython/pull/146206
og:image:altAlso changed to set the errno to err only if err != 0. Issue: selectmodule.c: errno < 0 comparison is always false #146205
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaisk
hostnamegithub.com
expected-hostnamegithub.com
None72b13e0e8d0319acdd27a145cfe73f4f06c791713d0ac4690e41fb68ad28cac0
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release08e79d53fc070870d5b168356afebb1e286a2ffe
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/146206/checks#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146206%2Fchecks
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146206%2Fchecks
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/146206/checks
Reloadhttps://github.com/python/cpython/pull/146206/checks
Reloadhttps://github.com/python/cpython/pull/146206/checks
Please reload this pagehttps://github.com/python/cpython/pull/146206/checks
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/146206/checks
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
aisk:fix-select-closehttps://github.com/aisk/cpython/tree/fix-select-close
Conversationhttps://github.com/python/cpython/pull/146206
Commits2 (2)https://github.com/python/cpython/pull/146206/commits
Checkshttps://github.com/python/cpython/pull/146206/checks
Files changedhttps://github.com/python/cpython/pull/146206/files
gh-146205: Check the errno with != 0 in close impls in select modulehttps://github.com/python/cpython/pull/146206/checks#top
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
aisk:fix-select-closehttps://github.com/aisk/cpython/tree/fix-select-close
Please reload this pagehttps://github.com/python/cpython/pull/146206/checks
Sign in for the full log viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146206%2Fchecks
Lint on: pull_request https://github.com/python/cpython/actions/runs/23343680839
lint https://github.com/python/cpython/actions/runs/23343680839/job/67903364492?pr=146206
Check labels on: pull_request https://github.com/python/cpython/actions/runs/23343680882
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/23343680882/job/67903364423?pr=146206
Unresolved review https://github.com/python/cpython/actions/runs/23343680882/job/67903364407?pr=146206
Tests on: pull_request https://github.com/python/cpython/actions/runs/23343680980
Change detection / Create context from changed files https://github.com/python/cpython/actions/runs/23343680980/job/67903365016?pr=146206
Docs / Docs https://github.com/python/cpython/actions/runs/23343680980/job/67903395276?pr=146206
Docs / Doctest https://github.com/python/cpython/actions/runs/23343680980/job/67903395280?pr=146206
Docs / Check EPUB https://github.com/python/cpython/actions/runs/23343680980/job/67903395299?pr=146206
Check if Autoconf files are up to date https://github.com/python/cpython/actions/runs/23343680980/job/67903394707?pr=146206
Check if generated files are up to date https://github.com/python/cpython/actions/runs/23343680980/job/67903394717?pr=146206
C API Docs / Check if all C APIs are documented https://github.com/python/cpython/actions/runs/23343680980/job/67903394852?pr=146206
Windows / Build and test (x64) https://github.com/python/cpython/actions/runs/23343680980/job/67903395076?pr=146206
Windows (free-threading) / Build and test (x64) https://github.com/python/cpython/actions/runs/23343680980/job/67903395061?pr=146206
Windows / Build and test (Win32) https://github.com/python/cpython/actions/runs/23343680980/job/67903395109?pr=146206
Windows / Build and test (arm64) https://github.com/python/cpython/actions/runs/23343680980/job/67903395141?pr=146206
Windows (free-threading) / Build and test (arm64) https://github.com/python/cpython/actions/runs/23343680980/job/67903395106?pr=146206
Windows MSI${{ '' }} https://github.com/python/cpython/actions/runs/23343680980/job/67903395119?pr=146206
macOS / build and test (macos-14) https://github.com/python/cpython/actions/runs/23343680980/job/67903395167?pr=146206
macOS (free-threading) / build and test (macos-14) https://github.com/python/cpython/actions/runs/23343680980/job/67903395116?pr=146206
macOS / build and test (macos-15-intel) https://github.com/python/cpython/actions/runs/23343680980/job/67903395136?pr=146206
Ubuntu / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/23343680980/job/67903395212?pr=146206
Ubuntu / build and test (ubuntu-24.04-arm) https://github.com/python/cpython/actions/runs/23343680980/job/67903395248?pr=146206
Ubuntu (free-threading) / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/23343680980/job/67903395318?pr=146206
Ubuntu (free-threading) / build and test (ubuntu-24.04-arm) https://github.com/python/cpython/actions/runs/23343680980/job/67903395214?pr=146206
Ubuntu (bolt) / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/23343680980/job/67903395186?pr=146206
Ubuntu SSL tests (ubuntu-24.04, openssl, 1.1.1w) https://github.com/python/cpython/actions/runs/23343680980/job/67903394827?pr=146206
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.0.19) https://github.com/python/cpython/actions/runs/23343680980/job/67903394910?pr=146206
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.3.6) https://github.com/python/cpython/actions/runs/23343680980/job/67903394849?pr=146206
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.4.4) https://github.com/python/cpython/actions/runs/23343680980/job/67903394907?pr=146206
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.5.5) https://github.com/python/cpython/actions/runs/23343680980/job/67903394859?pr=146206
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.6.1) https://github.com/python/cpython/actions/runs/23343680980/job/67903395018?pr=146206
Ubuntu SSL tests (ubuntu-24.04, aws-lc, 1.68.0) https://github.com/python/cpython/actions/runs/23343680980/job/67903394884?pr=146206
Android (aarch64) https://github.com/python/cpython/actions/runs/23343680980/job/67903394787?pr=146206
Android (x86_64) https://github.com/python/cpython/actions/runs/23343680980/job/67903394782?pr=146206
iOS https://github.com/python/cpython/actions/runs/23343680980/job/67903394731?pr=146206
WASI / build and test https://github.com/python/cpython/actions/runs/23343680980/job/67903394944?pr=146206
Hypothesis tests on Ubuntu https://github.com/python/cpython/actions/runs/23343680980/job/67903394743?pr=146206
Address sanitizer (ubuntu-24.04) https://github.com/python/cpython/actions/runs/23343680980/job/67903394746?pr=146206
Sanitizers / TSan https://github.com/python/cpython/actions/runs/23343680980/job/67903395279?pr=146206
Sanitizers / TSan (free-threading) https://github.com/python/cpython/actions/runs/23343680980/job/67903395302?pr=146206
Sanitizers / UBSan https://github.com/python/cpython/actions/runs/23343680980/job/67903395301?pr=146206
Cross build Linux https://github.com/python/cpython/actions/runs/23343680980/job/67903394742?pr=146206
CIFuzz / cpython3 (address) https://github.com/python/cpython/actions/runs/23343680980/job/67903395257?pr=146206
CIFuzz / cpython3 (undefined) https://github.com/python/cpython/actions/runs/23343680980/job/67903395201?pr=146206
CIFuzz / cpython3 (memory) https://github.com/python/cpython/actions/runs/23343680980/job/67903395185?pr=146206
All required checks pass https://github.com/python/cpython/actions/runs/23343680980/job/67906775977?pr=146206
ClusterFuzzLite/CIFuzz https://github.com/python/cpython/pull/146206/checks?check_run_id=67905887264
Check labels on: pull_request https://github.com/python/cpython/actions/runs/23345528851
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/23345528851/job/67909771552?pr=146206
Unresolved review https://github.com/python/cpython/actions/runs/23345528851/job/67909771562?pr=146206
Check labels on: pull_request https://github.com/python/cpython/actions/runs/23345528922
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/23345528922/job/67909771608?pr=146206
Unresolved review https://github.com/python/cpython/actions/runs/23345528922/job/67909771590?pr=146206
Check labels on: pull_request https://github.com/python/cpython/actions/runs/23345578370
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/23345578370/job/67909940161?pr=146206
Unresolved review https://github.com/python/cpython/actions/runs/23345578370/job/67909940119?pr=146206
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.