René's URL Explorer Experiment


Title: gh-146205: Check the errno with != 0 in close impls in select module by aisk · Pull Request #146206 · python/cpython · GitHub

Open Graph Title: gh-146205: Check the errno with != 0 in close impls in select module by aisk · Pull Request #146206 · python/cpython

X Title: gh-146205: Check the errno with != 0 in close impls in select module by aisk · Pull Request #146206 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Also changed to set the errno to err only if err != 0. Issue: selectmodule.c: errno < 0 comparison is always false #146205

X Description: Also changed to set the errno to err only if err != 0. Issue: selectmodule.c: errno < 0 comparison is always false #146205

Opengraph URL: https://github.com/python/cpython/pull/146206

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:75d8b407-a2cc-9f2d-8dbc-ec5921c0ba1b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id99D6:BDE76:2FAA674:4185A0B:6A5074BF
html-safe-nonce9d14834739686f4c69a3ccc658007193f402286e698f0c3fcc9bce92fd369550
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OUQ2OkJERTc2OjJGQUE2NzQ6NDE4NUEwQjo2QTUwNzRCRiIsInZpc2l0b3JfaWQiOiI1MzU1MzY0MjMzMTkzMjIzMzU5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc9d56345bae5c0313f3abd5f2c74c864303ca03c5a19f4811cc200932084fba8
hovercard-subject-tagpull_request:3424855456
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/146206/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d21ff308052ae2656214e44f10864c876f2c3beb8f985c111e0029dc749698b2/python/cpython/pull/146206
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d21ff308052ae2656214e44f10864c876f2c3beb8f985c111e0029dc749698b2/python/cpython/pull/146206
og:image:altAlso changed to set the errno to err only if err != 0. Issue: selectmodule.c: errno < 0 comparison is always false #146205
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaisk
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7ac0ad2f2c7e4b9056617355fd9e33e22b0c8df9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/146206#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146206
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146206
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/146206
Reloadhttps://github.com/python/cpython/pull/146206
Reloadhttps://github.com/python/cpython/pull/146206
Please reload this pagehttps://github.com/python/cpython/pull/146206
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/146206
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
aisk:fix-select-closehttps://github.com/aisk/cpython/tree/fix-select-close
Conversationhttps://github.com/python/cpython/pull/146206
Commits2 (2)https://github.com/python/cpython/pull/146206/commits
Checkshttps://github.com/python/cpython/pull/146206/checks
Files changedhttps://github.com/python/cpython/pull/146206/files
gh-146205: Check the errno with != 0 in close impls in select modulehttps://github.com/python/cpython/pull/146206#top
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
aisk:fix-select-closehttps://github.com/aisk/cpython/tree/fix-select-close
https://github.com/aisk
aiskhttps://github.com/aisk
Mar 20, 2026https://github.com/python/cpython/pull/146206#issue-4107702744
Please reload this pagehttps://github.com/python/cpython/pull/146206
selectmodule.c: errno < 0 comparison is always false #146205https://github.com/python/cpython/issues/146205
Please reload this pagehttps://github.com/python/cpython/pull/146206
https://github.com/aisk
Check the errno with != 0 in close implshttps://github.com/python/cpython/pull/146206/commits/b9817d714c372df86dea9b924c4a712872b0bf4e
b9817d7https://github.com/python/cpython/pull/146206/commits/b9817d714c372df86dea9b924c4a712872b0bf4e
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Mar 20, 2026 https://github.com/python/cpython/pull/146206#ref-issue-4107681414
selectmodule.c: errno < 0 comparison is always false #146205 https://github.com/python/cpython/issues/146205
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Mar 20, 2026https://github.com/python/cpython/pull/146206#event-23751401511
https://github.com/apps/blurb-it
📜🤖 Added by blurb_it.https://github.com/python/cpython/pull/146206/commits/53d6b3a3361091bb5aaf5ce57513b14a00d5a4bf
53d6b3ahttps://github.com/python/cpython/pull/146206/commits/53d6b3a3361091bb5aaf5ce57513b14a00d5a4bf
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Mar 20, 2026 https://github.com/python/cpython/pull/146206#pullrequestreview-3981625964
View reviewed changes https://github.com/python/cpython/pull/146206/files/53d6b3a3361091bb5aaf5ce57513b14a00d5a4bf
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/146206#pullrequestreview-3981625964
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/146206
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Mar 20, 2026https://github.com/python/cpython/pull/146206#event-23752837839
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
9f9faa2https://github.com/python/cpython/commit/9f9faa2d1a31e6d1d6271efa834b955f4acd53ee
Mar 20, 2026https://github.com/python/cpython/pull/146206#event-23752871805
Please reload this pagehttps://github.com/python/cpython/pull/146206
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Mar 20, 2026https://github.com/python/cpython/pull/146206#event-23752873429
https://github.com/aisk
aiskhttps://github.com/aisk
March 20, 2026 13:44https://github.com/python/cpython/pull/146206#event-23752876156
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Mar 20, 2026https://github.com/python/cpython/pull/146206#issuecomment-4098068655
Please reload this pagehttps://github.com/python/cpython/pull/146206
CuriousLearnerhttps://github.com/CuriousLearner
Mar 22, 2026 https://github.com/python/cpython/pull/146206#ref-commit-2691ad9
https://github.com/CuriousLearner
Merge remote-tracking branch 'upstream/main' into fix-https://github.com/CuriousLearner/cpython/commit/2691ad9d6a47b4beee7b5f299d878b4ef36e830c
pythongh-138577https://github.com/python/cpython/issues/138577
2691ad9https://github.com/CuriousLearner/cpython/commit/2691ad9d6a47b4beee7b5f299d878b4ef36e830c
python#145640https://github.com/python/cpython/pull/145640
pythongh-146153https://github.com/python/cpython/issues/146153
python#146154https://github.com/python/cpython/pull/146154
pythongh-138234https://github.com/python/cpython/issues/138234
python#138536https://github.com/python/cpython/pull/138536
pythongh-140947https://github.com/python/cpython/issues/140947
python#141158https://github.com/python/cpython/pull/141158
pythonGH-100108https://github.com/python/cpython/issues/100108
python#141885https://github.com/python/cpython/pull/141885
pythonGH-145667https://github.com/python/cpython/issues/145667
pythonGH-146120https://github.com/python/cpython/pull/146120
pythongh-146228https://github.com/python/cpython/issues/146228
python#146231https://github.com/python/cpython/pull/146231
pythongh-146227https://github.com/python/cpython/issues/146227
pythongh-146229https://github.com/python/cpython/pull/146229
pythongh-145980https://github.com/python/cpython/issues/145980
python#146230https://github.com/python/cpython/pull/146230
pythongh-146092https://github.com/python/cpython/issues/146092
python#146165https://github.com/python/cpython/pull/146165
pythongh-91279https://github.com/python/cpython/issues/91279
python#139396https://github.com/python/cpython/pull/139396
pythongh-146196https://github.com/python/cpython/issues/146196
python#146201https://github.com/python/cpython/pull/146201
pythongh-143930https://github.com/python/cpython/issues/143930
pythongh-145916https://github.com/python/cpython/issues/145916
pythonGH-145919https://github.com/python/cpython/pull/145919
pythongh-146205https://github.com/python/cpython/issues/146205
python#146206https://github.com/python/cpython/pull/146206
pythongh-146171https://github.com/python/cpython/issues/146171
python#146188https://github.com/python/cpython/pull/146188
pythongh-146099https://github.com/python/cpython/issues/146099
pythonGH-146101https://github.com/python/cpython/pull/146101
pythongh-145980https://github.com/python/cpython/issues/145980
pythonGH-145981https://github.com/python/cpython/pull/145981
pythongh-145754https://github.com/python/cpython/issues/145754
python#145756https://github.com/python/cpython/pull/145756
pythongh-145177https://github.com/python/cpython/issues/145177
python#146160https://github.com/python/cpython/pull/146160
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Apr 4, 2026 https://github.com/python/cpython/pull/146206#ref-pullrequest-3716338400
gh-130273: Fix traceback color output with unicode characters #142529 https://github.com/python/cpython/pull/142529
ljfphttps://github.com/ljfp
Apr 25, 2026 https://github.com/python/cpython/pull/146206#ref-commit-fa7d654
https://github.com/aisk
https://github.com/apps/blurb-it
https://github.com/ljfp
pythongh-146205https://github.com/python/cpython/issues/146205
: Check the errno with != 0 in close impls in select m…https://github.com/ljfp/cpython/commit/fa7d654d40b074d49444133fc614b6db60695ebf
fa7d654https://github.com/ljfp/cpython/commit/fa7d654d40b074d49444133fc614b6db60695ebf
python#146206https://github.com/python/cpython/pull/146206
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146206
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/146206/files/53d6b3a3361091bb5aaf5ce57513b14a00d5a4bf
Please reload this pagehttps://github.com/python/cpython/pull/146206
https://github.com/aisk
https://github.com/vstinner
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.