René's URL Explorer Experiment


Title: gh-146169: Prevent re-entrant Parse() calls in pyexpat by okiemute04 · Pull Request #146179 · python/cpython · GitHub

Open Graph Title: gh-146169: Prevent re-entrant Parse() calls in pyexpat by okiemute04 · Pull Request #146179 · python/cpython

X Title: gh-146169: Prevent re-entrant Parse() calls in pyexpat by okiemute04 · Pull Request #146179 · python/cpython

Description: Fixes #146169 Add a check in Parse() to prevent calls when in_callback is true, as this violates expat's requirements and can cause crashes. Now raises RuntimeError with a clear message. Added tests to test_pyexpat.py to verify the fix: test_reentrant_parse_crash: Verifies re-entrant calls raise RuntimeError test_parse_normal: Ensures normal parsing still works Issue: gh-146169

Open Graph Description: Fixes #146169 Add a check in Parse() to prevent calls when in_callback is true, as this violates expat's requirements and can cause crashes. Now raises RuntimeError with a clear message. Added ...

X Description: Fixes #146169 Add a check in Parse() to prevent calls when in_callback is true, as this violates expat's requirements and can cause crashes. Now raises RuntimeError with a clear message. Ad...

Opengraph URL: https://github.com/python/cpython/pull/146179

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b015c310-2562-3f0e-8440-1325e3b212a8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9B62:3CF864:FEFE3C:151558C:6A51A36A
html-safe-nonced18400b29f70e0961cc0814f05b1f8e91ade9c4eda5a751e9d55d01be8a4cde4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjYyOjNDRjg2NDpGRUZFM0M6MTUxNTU4Qzo2QTUxQTM2QSIsInZpc2l0b3JfaWQiOiI4ODM4Nzg5MTczNjIyMTg2ODU5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4501094b5082f19b23947287e63135fcb1ed6a2f878ea374b9e00a67d561e027
hovercard-subject-tagpull_request:3421023260
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/146179/files
twitter:imagehttps://avatars.githubusercontent.com/u/51956662?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/51956662?s=400&v=4
og:image:altFixes #146169 Add a check in Parse() to prevent calls when in_callback is true, as this violates expat's requirements and can cause crashes. Now raises RuntimeError with a clear message. Added ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/146179/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146179%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146179%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/146179/files
Reloadhttps://github.com/python/cpython/pull/146179/files
Reloadhttps://github.com/python/cpython/pull/146179/files
Please reload this pagehttps://github.com/python/cpython/pull/146179/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/146179/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
okiemute04https://github.com/okiemute04
python:mainhttps://github.com/python/cpython/tree/main
okiemute04:fix-pyexpat-reentrant-crash-finalhttps://github.com/okiemute04/cpython/tree/fix-pyexpat-reentrant-crash-final
Conversation 18 https://github.com/python/cpython/pull/146179
Commits 4 https://github.com/python/cpython/pull/146179/commits
Checks 51 https://github.com/python/cpython/pull/146179/checks
Files changed https://github.com/python/cpython/pull/146179/files
Please reload this pagehttps://github.com/python/cpython/pull/146179/files
gh-146169: Prevent re-entrant Parse() calls in pyexpat https://github.com/python/cpython/pull/146179/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/146179/files
c924f57 gh-146174: Prevent re-entrant Parse() calls in pyexpat okiemute04 Mar 19, 2026 https://github.com/python/cpython/pull/146179/commits/c924f5760b7325fd3180b86608911e51e864a612
0e67052 Add NEWS entry for pyexpat re-entrant fix okiemute04 Mar 19, 2026 https://github.com/python/cpython/pull/146179/commits/0e6705285e6b7538a15b8bc0116a27216496293d
029e408 Add NEWS entry for pyexpat re-entrant fix okiemute04 Mar 19, 2026 https://github.com/python/cpython/pull/146179/commits/029e408ece9727fcd29a18983fc6409ed86419b8
57faef4 Merge remote branch to resolve history divergence okiemute04 Mar 19, 2026 https://github.com/python/cpython/pull/146179/commits/57faef447a82c2b09f4d0ee6dae49406aa6c2ea8
Clear filters https://github.com/python/cpython/pull/146179/files
Please reload this pagehttps://github.com/python/cpython/pull/146179/files
Please reload this pagehttps://github.com/python/cpython/pull/146179/files
test_pyexpat.py https://github.com/python/cpython/pull/146179/files#diff-bdb65b60742876d0828ee1d7f2c168d36fa02cc202ace32d27c46a7b4a17605d
2026-03-19-11-15-00.gh-issue-146169.manual.rst https://github.com/python/cpython/pull/146179/files#diff-afe13f59bf6857c7e9789a6bfee1d5e5921cd47eb84203cb2f72aadd8b605801
pyexpat.c https://github.com/python/cpython/pull/146179/files#diff-0534aca0d881f2dd1100e875602f98da60bf20ce127564896dc1e8a92a6fad2c
Lib/test/test_pyexpat.pyhttps://github.com/python/cpython/pull/146179/files#diff-bdb65b60742876d0828ee1d7f2c168d36fa02cc202ace32d27c46a7b4a17605d
View file https://github.com/okiemute04/cpython/blob/57faef447a82c2b09f4d0ee6dae49406aa6c2ea8/Lib/test/test_pyexpat.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/146179/{{ revealButtonHref }}
https://github.com/python/cpython/pull/146179/files#diff-bdb65b60742876d0828ee1d7f2c168d36fa02cc202ace32d27c46a7b4a17605d
picnixzhttps://github.com/picnixz
Mar 20, 2026https://github.com/python/cpython/pull/146179/files#r2968321162
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/146179/files
picnixzhttps://github.com/picnixz
Mar 20, 2026https://github.com/python/cpython/pull/146179/files#r2968370178
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/146179/files
picnixzhttps://github.com/picnixz
Mar 20, 2026https://github.com/python/cpython/pull/146179/files#r2968320534
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/146179/files
picnixzhttps://github.com/picnixz
Mar 20, 2026https://github.com/python/cpython/pull/146179/files#r2968366788
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/146179/files
picnixzhttps://github.com/picnixz
Mar 20, 2026https://github.com/python/cpython/pull/146179/files#r2968319844
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/146179/files
picnixzhttps://github.com/picnixz
Mar 20, 2026https://github.com/python/cpython/pull/146179/files#r2968315548
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/146179/files
picnixzhttps://github.com/picnixz
Mar 20, 2026https://github.com/python/cpython/pull/146179/files#r2968379221
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/146179/files
picnixzhttps://github.com/picnixz
Mar 20, 2026https://github.com/python/cpython/pull/146179/files#r2968311548
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/146179/files
picnixzhttps://github.com/picnixz
Mar 20, 2026https://github.com/python/cpython/pull/146179/files#r2968314193
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/146179/files
https://github.com/python/cpython/pull/146179/files#diff-bdb65b60742876d0828ee1d7f2c168d36fa02cc202ace32d27c46a7b4a17605d
Misc/NEWS.d/next/Library/2026-03-19-11-15-00.gh-issue-146169.manual.rsthttps://github.com/python/cpython/pull/146179/files#diff-afe13f59bf6857c7e9789a6bfee1d5e5921cd47eb84203cb2f72aadd8b605801
View file https://github.com/okiemute04/cpython/blob/57faef447a82c2b09f4d0ee6dae49406aa6c2ea8/Misc/NEWS.d/next/Library/2026-03-19-11-15-00.gh-issue-146169.manual.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/146179/{{ revealButtonHref }}
Modules/pyexpat.chttps://github.com/python/cpython/pull/146179/files#diff-0534aca0d881f2dd1100e875602f98da60bf20ce127564896dc1e8a92a6fad2c
View file https://github.com/okiemute04/cpython/blob/57faef447a82c2b09f4d0ee6dae49406aa6c2ea8/Modules/pyexpat.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/146179/{{ revealButtonHref }}
https://github.com/python/cpython/pull/146179/files#diff-0534aca0d881f2dd1100e875602f98da60bf20ce127564896dc1e8a92a6fad2c
picnixzhttps://github.com/picnixz
Mar 20, 2026https://github.com/python/cpython/pull/146179/files#r2968326374
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/146179/files
picnixzhttps://github.com/picnixz
Mar 20, 2026https://github.com/python/cpython/pull/146179/files#r2968396207
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/146179/files
https://github.com/python/cpython/pull/146179/files#diff-0534aca0d881f2dd1100e875602f98da60bf20ce127564896dc1e8a92a6fad2c
Please reload this pagehttps://github.com/python/cpython/pull/146179/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.