René's URL Explorer Experiment


Title: [3.14] gh-146092: Fix error handling in _BINARY_OP_ADD_FLOAT opcode by vstinner · Pull Request #146119 · python/cpython · GitHub

Open Graph Title: [3.14] gh-146092: Fix error handling in _BINARY_OP_ADD_FLOAT opcode by vstinner · Pull Request #146119 · python/cpython

X Title: [3.14] gh-146092: Fix error handling in _BINARY_OP_ADD_FLOAT opcode by vstinner · Pull Request #146119 · python/cpython

Description: Fix error handling in _PyFloat_FromDouble_ConsumeInputs() used by _BINARY_OP_ADD_FLOAT, _BINARY_OP_SUBTRACT_FLOAT and _BINARY_OP_MULTIPLY_FLOAT opcodes. PyStackRef_FromPyObjectSteal() must not be called with a NULL pointer. Fix also _BINARY_OP_INPLACE_ADD_UNICODE opcode. Issue: gh-146092

Open Graph Description: Fix error handling in _PyFloat_FromDouble_ConsumeInputs() used by _BINARY_OP_ADD_FLOAT, _BINARY_OP_SUBTRACT_FLOAT and _BINARY_OP_MULTIPLY_FLOAT opcodes. PyStackRef_FromPyObjectSteal() must not be c...

X Description: Fix error handling in _PyFloat_FromDouble_ConsumeInputs() used by _BINARY_OP_ADD_FLOAT, _BINARY_OP_SUBTRACT_FLOAT and _BINARY_OP_MULTIPLY_FLOAT opcodes. PyStackRef_FromPyObjectSteal() must not be c...

Opengraph URL: https://github.com/python/cpython/pull/146119

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3be2afe7-4f87-afbf-7c56-453ada5789d4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE398:1EE1:802334B:B42EF0B:6A50D85D
html-safe-nonce2eaea80217db8a6b92f6451238aeaef206d9d9895bf98cdbff87917b7a8bb9c6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzk4OjFFRTE6ODAyMzM0QjpCNDJFRjBCOjZBNTBEODVEIiwidmlzaXRvcl9pZCI6IjQyMDkzNTI4MDI2ODQ2ODg0NzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf8676bebdb75ed3f5b49aa5ac3a8f80c87bcaf920f7a8d40ee799c4552631794
hovercard-subject-tagpull_request:3415698209
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/146119/files
twitter:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
og:image:altFix error handling in _PyFloat_FromDouble_ConsumeInputs() used by _BINARY_OP_ADD_FLOAT, _BINARY_OP_SUBTRACT_FLOAT and _BINARY_OP_MULTIPLY_FLOAT opcodes. PyStackRef_FromPyObjectSteal() must not be c...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None72b13e0e8d0319acdd27a145cfe73f4f06c791713d0ac4690e41fb68ad28cac0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release73ad5c4eaffed7bb3637024653eabdbca84a855e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/146119/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146119%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146119%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/146119/files
Reloadhttps://github.com/python/cpython/pull/146119/files
Reloadhttps://github.com/python/cpython/pull/146119/files
Please reload this pagehttps://github.com/python/cpython/pull/146119/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/146119/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:3.14https://github.com/python/cpython/tree/3.14
vstinner:eval_err14https://github.com/vstinner/cpython/tree/eval_err14
Conversation 8 https://github.com/python/cpython/pull/146119
Commits 4 https://github.com/python/cpython/pull/146119/commits
Checks 67 https://github.com/python/cpython/pull/146119/checks
Files changed https://github.com/python/cpython/pull/146119/files
Please reload this pagehttps://github.com/python/cpython/pull/146119/files
[3.14] gh-146092: Fix error handling in _BINARY_OP_ADD_FLOAT opcode https://github.com/python/cpython/pull/146119/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/146119/files
3bd1e9d gh-146092: Fix error handling in _BINARY_OP_ADD_FLOAT opcode vstinner Mar 18, 2026 https://github.com/python/cpython/pull/146119/commits/3bd1e9db2ae21cfc12e417b461f44d4cfc50cb89
659c4ed Fix also _BINARY_OP_INPLACE_ADD_UNICODE opcode vstinner Mar 18, 2026 https://github.com/python/cpython/pull/146119/commits/659c4ed1e045abc8f8ce2fc81a992d6e71857faf
3517db6 Fix reference counting vstinner Mar 18, 2026 https://github.com/python/cpython/pull/146119/commits/3517db6cab79d820d78f7a53f21fcc8eeafed64f
83d5ef3 Replace ERROR_IF(1) with ERROR_IF(true) vstinner Mar 18, 2026 https://github.com/python/cpython/pull/146119/commits/83d5ef31f3ce4b6073b93006fae7c766a2636939
Clear filters https://github.com/python/cpython/pull/146119/files
Please reload this pagehttps://github.com/python/cpython/pull/146119/files
Please reload this pagehttps://github.com/python/cpython/pull/146119/files
2026-03-18-16-57-56.gh-issue-146092.wCKFYS.rst https://github.com/python/cpython/pull/146119/files#diff-5ed82015f35775440fdb7f955e60b6624aca36a66a856593ec00ed5c252826c2
floatobject.c https://github.com/python/cpython/pull/146119/files#diff-3651445c9f72daa1fdf6577b10902d4ceee89aa99295e01fcab07b58767a935f
bytecodes.c https://github.com/python/cpython/pull/146119/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
executor_cases.c.h https://github.com/python/cpython/pull/146119/files#diff-a1c3430c42a66c16e6d2e154491a6da993b187b27c628545a12a02c7b2a06b81
generated_cases.c.h https://github.com/python/cpython/pull/146119/files#diff-4ef46fa654f95502e49a24f7dc8ee31a4cac9b3433fe9cd2b2d4dd78cfbad448
Misc/NEWS.d/next/Core_and_Builtins/2026-03-18-16-57-56.gh-issue-146092.wCKFYS.rsthttps://github.com/python/cpython/pull/146119/files#diff-5ed82015f35775440fdb7f955e60b6624aca36a66a856593ec00ed5c252826c2
View file https://github.com/vstinner/cpython/blob/83d5ef31f3ce4b6073b93006fae7c766a2636939/Misc/NEWS.d/next/Core_and_Builtins/2026-03-18-16-57-56.gh-issue-146092.wCKFYS.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/146119/{{ revealButtonHref }}
Objects/floatobject.chttps://github.com/python/cpython/pull/146119/files#diff-3651445c9f72daa1fdf6577b10902d4ceee89aa99295e01fcab07b58767a935f
View file https://github.com/vstinner/cpython/blob/83d5ef31f3ce4b6073b93006fae7c766a2636939/Objects/floatobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/146119/{{ revealButtonHref }}
https://github.com/python/cpython/pull/146119/files#diff-3651445c9f72daa1fdf6577b10902d4ceee89aa99295e01fcab07b58767a935f
https://github.com/python/cpython/pull/146119/files#diff-3651445c9f72daa1fdf6577b10902d4ceee89aa99295e01fcab07b58767a935f
https://github.com/python/cpython/blob/3.14/.github/CODEOWNERS#L53
Python/bytecodes.chttps://github.com/python/cpython/pull/146119/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
View file https://github.com/vstinner/cpython/blob/83d5ef31f3ce4b6073b93006fae7c766a2636939/Python/bytecodes.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/146119/{{ revealButtonHref }}
https://github.com/python/cpython/pull/146119/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
Fidget-Spinnerhttps://github.com/Fidget-Spinner
Mar 19, 2026https://github.com/python/cpython/pull/146119/files#r2958056601
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/146119/files
vstinnerhttps://github.com/vstinner
Mar 19, 2026https://github.com/python/cpython/pull/146119/files#r2959264107
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/146119/files
Fidget-Spinnerhttps://github.com/Fidget-Spinner
Mar 19, 2026https://github.com/python/cpython/pull/146119/files#r2959294464
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/146119/files
https://github.com/python/cpython/pull/146119/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
Python/executor_cases.c.hhttps://github.com/python/cpython/pull/146119/files#diff-a1c3430c42a66c16e6d2e154491a6da993b187b27c628545a12a02c7b2a06b81
View file https://github.com/vstinner/cpython/blob/83d5ef31f3ce4b6073b93006fae7c766a2636939/Python/executor_cases.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/146119/files
Python/generated_cases.c.hhttps://github.com/python/cpython/pull/146119/files#diff-4ef46fa654f95502e49a24f7dc8ee31a4cac9b3433fe9cd2b2d4dd78cfbad448
View file https://github.com/vstinner/cpython/blob/83d5ef31f3ce4b6073b93006fae7c766a2636939/Python/generated_cases.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/146119/files
Please reload this pagehttps://github.com/python/cpython/pull/146119/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.