René's URL Explorer Experiment


Title: [3.14] gh-146092: Fix error handling in _BINARY_OP_ADD_FLOAT opcode by vstinner · Pull Request #146119 · python/cpython · GitHub

Open Graph Title: [3.14] gh-146092: Fix error handling in _BINARY_OP_ADD_FLOAT opcode by vstinner · Pull Request #146119 · python/cpython

X Title: [3.14] gh-146092: Fix error handling in _BINARY_OP_ADD_FLOAT opcode by vstinner · Pull Request #146119 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Fix error handling in _PyFloat_FromDouble_ConsumeInputs() used by _BINARY_OP_ADD_FLOAT, _BINARY_OP_SUBTRACT_FLOAT and _BINARY_OP_MULTIPLY_FLOAT opcodes. PyStackRef_FromPyObjectSteal() must not be c...

X Description: Fix error handling in _PyFloat_FromDouble_ConsumeInputs() used by _BINARY_OP_ADD_FLOAT, _BINARY_OP_SUBTRACT_FLOAT and _BINARY_OP_MULTIPLY_FLOAT opcodes. PyStackRef_FromPyObjectSteal() must not be c...

Opengraph URL: https://github.com/python/cpython/pull/146119

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fa7dc356-cee0-d233-8081-e5f597780c20
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB98:B6C89:A29FCA5:E3AAE8E:6A50C86A
html-safe-nonce5d1ba3c19db634616e4993348bdedfc04a806effed311c4ab58a62b7f38f0c2a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjk4OkI2Qzg5OkEyOUZDQTU6RTNBQUU4RTo2QTUwQzg2QSIsInZpc2l0b3JfaWQiOiIzOTEzNjc1NDU1NzUyODgyMjgyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4f767df9fde42a983afeb4f75c4387a3227ecde24667e44c8efcda83b467f11d
hovercard-subject-tagpull_request:3415698209
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/146119/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3fa5b0f73c71b7e2c49afe3a62c2503dcdf08d5c6b38c243afb0cbbddfb8b92d/python/cpython/pull/146119
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3fa5b0f73c71b7e2c49afe3a62c2503dcdf08d5c6b38c243afb0cbbddfb8b92d/python/cpython/pull/146119
og:image:altFix error handling in _PyFloat_FromDouble_ConsumeInputs() used by _BINARY_OP_ADD_FLOAT, _BINARY_OP_SUBTRACT_FLOAT and _BINARY_OP_MULTIPLY_FLOAT opcodes. PyStackRef_FromPyObjectSteal() must not be c...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevstinner
hostnamegithub.com
expected-hostnamegithub.com
None72b13e0e8d0319acdd27a145cfe73f4f06c791713d0ac4690e41fb68ad28cac0
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release08e79d53fc070870d5b168356afebb1e286a2ffe
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/146119#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146119
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146119
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/146119
Reloadhttps://github.com/python/cpython/pull/146119
Reloadhttps://github.com/python/cpython/pull/146119
Please reload this pagehttps://github.com/python/cpython/pull/146119
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/146119
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
vstinnerhttps://github.com/vstinner
python:3.14https://github.com/python/cpython/tree/3.14
vstinner:eval_err14https://github.com/vstinner/cpython/tree/eval_err14
Conversationhttps://github.com/python/cpython/pull/146119
Commits4 (4)https://github.com/python/cpython/pull/146119/commits
Checkshttps://github.com/python/cpython/pull/146119/checks
Files changedhttps://github.com/python/cpython/pull/146119/files
[3.14] gh-146092: Fix error handling in _BINARY_OP_ADD_FLOAT opcodehttps://github.com/python/cpython/pull/146119#top
vstinnerhttps://github.com/vstinner
python:3.14https://github.com/python/cpython/tree/3.14
vstinner:eval_err14https://github.com/vstinner/cpython/tree/eval_err14
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Mar 18, 2026https://github.com/python/cpython/pull/146119#issue-4096155509
Please reload this pagehttps://github.com/python/cpython/pull/146119
Missing PyErr_NoMemory in _zoneinfo load_data and ts_to_local #146092https://github.com/python/cpython/issues/146092
Please reload this pagehttps://github.com/python/cpython/pull/146119
https://github.com/vstinner
pythongh-146092https://github.com/python/cpython/issues/146092
: Fix error handling in _BINARY_OP_ADD_FLOAT opcodehttps://github.com/python/cpython/pull/146119/commits/3bd1e9db2ae21cfc12e417b461f44d4cfc50cb89
3bd1e9dhttps://github.com/python/cpython/pull/146119/commits/3bd1e9db2ae21cfc12e417b461f44d4cfc50cb89
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Mar 18, 2026 https://github.com/python/cpython/pull/146119#ref-issue-4091737007
Missing PyErr_NoMemory in _zoneinfo load_data and ts_to_local #146092 https://github.com/python/cpython/issues/146092
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Mar 18, 2026https://github.com/python/cpython/pull/146119#event-23687754141
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Mar 18, 2026 https://github.com/python/cpython/pull/146119#ref-pullrequest-4095826172
gh-146092: Fix error handling in _BINARY_OP_ADD_UNICODE opcode #146117 https://github.com/python/cpython/pull/146117
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Mar 18, 2026https://github.com/python/cpython/pull/146119#issuecomment-4083718394
@Fidget-Spinnerhttps://github.com/Fidget-Spinner
Please reload this pagehttps://github.com/python/cpython/pull/146119
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
Mar 18, 2026 https://github.com/python/cpython/pull/146119#pullrequestreview-3969037726
View reviewed changes https://github.com/python/cpython/pull/146119/files/3bd1e9db2ae21cfc12e417b461f44d4cfc50cb89
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Mar 18, 2026https://github.com/python/cpython/pull/146119#event-23687915801
https://github.com/vstinner
Fix also _BINARY_OP_INPLACE_ADD_UNICODE opcodehttps://github.com/python/cpython/pull/146119/commits/659c4ed1e045abc8f8ce2fc81a992d6e71857faf
659c4edhttps://github.com/python/cpython/pull/146119/commits/659c4ed1e045abc8f8ce2fc81a992d6e71857faf
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
markshannonhttps://github.com/markshannon
code ownerhttps://github.com/python/cpython/blob/19cbcc0f85f30954293dbd92d718d5b81880b092/.github/CODEOWNERS#L53
March 18, 2026 16:11https://github.com/python/cpython/pull/146119#event-23688102372
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Mar 18, 2026https://github.com/python/cpython/pull/146119#issuecomment-4083837752
@Fidget-Spinnerhttps://github.com/Fidget-Spinner
Please reload this pagehttps://github.com/python/cpython/pull/146119
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
March 18, 2026 16:21https://github.com/python/cpython/pull/146119#event-23688461586
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
Mar 18, 2026https://github.com/python/cpython/pull/146119#issuecomment-4083896275
Please reload this pagehttps://github.com/python/cpython/pull/146119
Please reload this pagehttps://github.com/python/cpython/pull/146119
https://github.com/vstinner
Fix reference countinghttps://github.com/python/cpython/pull/146119/commits/3517db6cab79d820d78f7a53f21fcc8eeafed64f
3517db6https://github.com/python/cpython/pull/146119/commits/3517db6cab79d820d78f7a53f21fcc8eeafed64f
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Mar 18, 2026https://github.com/python/cpython/pull/146119#issuecomment-4085755500
Please reload this pagehttps://github.com/python/cpython/pull/146119
Please reload this pagehttps://github.com/python/cpython/pull/146119
https://github.com/vstinner
Replace ERROR_IF(1) with ERROR_IF(true)https://github.com/python/cpython/pull/146119/commits/83d5ef31f3ce4b6073b93006fae7c766a2636939
83d5ef3https://github.com/python/cpython/pull/146119/commits/83d5ef31f3ce4b6073b93006fae7c766a2636939
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
Mar 19, 2026 https://github.com/python/cpython/pull/146119#pullrequestreview-3973042353
View reviewed changes https://github.com/python/cpython/pull/146119/files/83d5ef31f3ce4b6073b93006fae7c766a2636939
Python/bytecodes.chttps://github.com/python/cpython/pull/146119/files/83d5ef31f3ce4b6073b93006fae7c766a2636939#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
Fidget-Spinnerhttps://github.com/Fidget-Spinner
Mar 19, 2026https://github.com/python/cpython/pull/146119#discussion_r2958056601
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/146119
vstinnerhttps://github.com/vstinner
Mar 19, 2026https://github.com/python/cpython/pull/146119#discussion_r2959264107
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/146119
Fidget-Spinnerhttps://github.com/Fidget-Spinner
Mar 19, 2026https://github.com/python/cpython/pull/146119#discussion_r2959294464
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/146119
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
Mar 19, 2026 https://github.com/python/cpython/pull/146119#pullrequestreview-3974324766
View reviewed changes https://github.com/python/cpython/pull/146119/files/83d5ef31f3ce4b6073b93006fae7c766a2636939
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
7f29c1dhttps://github.com/python/cpython/commit/7f29c1d0dabb84fc91caf874881b501345702793
Mar 19, 2026https://github.com/python/cpython/pull/146119#event-23714008951
Please reload this pagehttps://github.com/python/cpython/pull/146119
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
March 19, 2026 11:14https://github.com/python/cpython/pull/146119#event-23714010010
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Mar 19, 2026https://github.com/python/cpython/pull/146119#event-23714010619
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Mar 19, 2026https://github.com/python/cpython/pull/146119#issuecomment-4089407669
@Fidget-Spinnerhttps://github.com/Fidget-Spinner
Please reload this pagehttps://github.com/python/cpython/pull/146119
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F146119
https://github.com/Fidget-Spinner
Fidget-Spinner https://github.com/Fidget-Spinner
https://github.com/python/cpython/pull/146119/files/83d5ef31f3ce4b6073b93006fae7c766a2636939
https://github.com/markshannon
markshannon https://github.com/markshannon
Please reload this pagehttps://github.com/python/cpython/pull/146119
https://github.com/vstinner
https://github.com/Fidget-Spinner
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.