| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:22f315fe-ed25-0b2e-f690-abf2d541cbe1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A0AC:29FFA9:3B26B59:4AE4BFF:6B01FBDC |
| html-safe-nonce | 16cc43ca6e3e9b1214aaf9994f8cc5a6b92c0b6eaafbfed881e6348f0e3e9a9e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMEFDOjI5RkZBOTozQjI2QjU5OjRBRTRCRkY6NkIwMUZCREMiLCJ2aXNpdG9yX2lkIjoiMTYxODYzODEyMDQxMTA2OTQwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ac8ff9133849180e356c7b2564b5479376da68e22b0e789b0d66fd1e824fa094 |
| hovercard-subject-tag | pull_request:3400336029 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/145957/files |
| twitter:image | https://avatars.githubusercontent.com/u/751088?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/751088?s=400&v=4 |
| og:image:alt | TextIOWrapper keeps its underlying stream in a member called self->buffer. That stream can be detached by user code, such as custom .flush() implementations, resulting in self->buffer being s... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/145957/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F145957%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F145957%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/145957/files |
| Reload | https://github.com/python/cpython/pull/145957/files |
| Reload | https://github.com/python/cpython/pull/145957/files |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| vstinner | https://github.com/vstinner |
| python:main | https://github.com/python/cpython/tree/main |
| cmaloney:textio_nullbuffer | https://github.com/cmaloney/cpython/tree/textio_nullbuffer |
|
Conversation
36
| https://github.com/python/cpython/pull/145957 |
|
Commits
25
| https://github.com/python/cpython/pull/145957/commits |
|
Checks
59
| https://github.com/python/cpython/pull/145957/checks |
|
Files changed
| https://github.com/python/cpython/pull/145957/files |
| Please reload this page | https://github.com/python/cpython/pull/145957/files |
|
gh-143008: Fix Null pointer dereferences in TextIOWrapper underlying stream access
| https://github.com/python/cpython/pull/145957/files#top |
|
Show all changes
25 commits
| https://github.com/python/cpython/pull/145957/files |
|
42caa08
gh-143008: Safer TextIOWrapper underlying stream access
cmaloney Mar 15, 2026
| https://github.com/python/cpython/pull/145957/commits/42caa08ed68701af7e039caea089312fb8b47341 |
|
551c3eb
fixup: Refer to existing helpers
cmaloney Mar 15, 2026
| https://github.com/python/cpython/pull/145957/commits/551c3eb5f5d57d97374c297a558e6802077edb64 |
|
4f455f4
fixup: More precise recursion errorcatching
cmaloney Mar 17, 2026
| https://github.com/python/cpython/pull/145957/commits/4f455f4f6dbab848542fb5255530d017a5b48500 |
|
ec39a61
fixup: Formatting fixes, simplify test
cmaloney Mar 17, 2026
| https://github.com/python/cpython/pull/145957/commits/ec39a6118f238cb8bc2f34088c2e4e5ee18acf00 |
|
98bc865
fixup: correct commment
cmaloney Mar 17, 2026
| https://github.com/python/cpython/pull/145957/commits/98bc8653ea6f23900b7dc0d93fe0b06315094a6a |
|
c52559b
PEP 7 fixes; simplify some comments
cmaloney Mar 30, 2026
| https://github.com/python/cpython/pull/145957/commits/c52559be04be348697cafd24584b93af381d82f5 |
|
210b21b
Merge branch 'main' into textio_nullbuffer
cmaloney Mar 30, 2026
| https://github.com/python/cpython/pull/145957/commits/210b21b0832015254ede1a2d6816f5aef87fe990 |
|
150fcee
Improve PEP-7
cmaloney Apr 20, 2026
| https://github.com/python/cpython/pull/145957/commits/150fceef9c727a99d657dc342b207ec71700853a |
|
d7f14fc
PEP-7: Move to shorter function names, reformat arg lists
cmaloney Apr 21, 2026
| https://github.com/python/cpython/pull/145957/commits/d7f14fc87152d86ba5c6b478550f3dbfacdbc559 |
|
df212a5
Improve NEWS grammer
cmaloney Apr 21, 2026
| https://github.com/python/cpython/pull/145957/commits/df212a5c2cca674355395e2373f62ff45fe1cf97 |
|
d1a1a98
Simplify comment
cmaloney Apr 21, 2026
| https://github.com/python/cpython/pull/145957/commits/d1a1a98036b996ccaefee919236b402b66989c56 |
|
009cf12
Fix comment referring to function name
cmaloney Apr 21, 2026
| https://github.com/python/cpython/pull/145957/commits/009cf121ea6ccd0ea7c0f58666fcc58e00f17f9b |
|
afe79c7
Apply suggestions from code review
cmaloney Jun 5, 2026
| https://github.com/python/cpython/pull/145957/commits/afe79c793e7a4b08c910722ebf569ab98e89bc3b |
|
452168c
Assert self->buffer is locked, fix __init__ race
cmaloney Jun 5, 2026
| https://github.com/python/cpython/pull/145957/commits/452168c4161482bdda8897eb332fb9691c44aefe |
|
d7b146e
Adjust closed_get_impl
cmaloney Jun 5, 2026
| https://github.com/python/cpython/pull/145957/commits/d7b146ed446da879da5acfb2e9e5a8b306e5bbb8 |
|
593b0ea
Add back in locked assterion, match surrounding comment style
cmaloney Jun 5, 2026
| https://github.com/python/cpython/pull/145957/commits/593b0ea6be243570f6eba043bb67c837d564348d |
|
e5c014a
Move null checks up a line
cmaloney Jun 5, 2026
| https://github.com/python/cpython/pull/145957/commits/e5c014af004cc7fe502ef2de87fe3e3461aa989a |
|
eb23eaa
Merge remote-tracking branch 'upstream/main' into textio_nullbuffer
cmaloney Jun 5, 2026
| https://github.com/python/cpython/pull/145957/commits/eb23eaa6d2ea7334bb2208aae5bf6e9207d47f3b |
|
2581e6c
Fix clinic merge
cmaloney Jun 5, 2026
| https://github.com/python/cpython/pull/145957/commits/2581e6c837d0c29fdd2454345e6bce51594ff3bc |
|
feafb90
Fix blurb
cmaloney Jun 5, 2026
| https://github.com/python/cpython/pull/145957/commits/feafb90e079741671ce1b0046d226dec030b7491 |
|
c0bdd84
Apply suggestions from code review
cmaloney Jun 9, 2026
| https://github.com/python/cpython/pull/145957/commits/c0bdd84c64a19ec97ec63c51dcb7a402789bc80f |
|
d7bf513
Remove wrapper_ref, use simpler classes, wrapper local only
cmaloney Jun 9, 2026
| https://github.com/python/cpython/pull/145957/commits/d7bf5131ed3e1185d134e63c4bb29fc088775972 |
|
a24957d
Separate attribute and submodule imports
cmaloney Jun 9, 2026
| https://github.com/python/cpython/pull/145957/commits/a24957de037d51a541e5a55c6fcae59aef3982e6 |
|
c2cb455
Fix NULL with no exception after flush in detach
cmaloney Jun 9, 2026
| https://github.com/python/cpython/pull/145957/commits/c2cb45564828fad958752871666f731dd1ba31e1 |
|
cbcd21a
remove recursion. Add make_text helper and DetachOnce
cmaloney Jun 9, 2026
| https://github.com/python/cpython/pull/145957/commits/cbcd21a8317c7a012f857407214af167a5d534e9 |
|
Clear filters
| https://github.com/python/cpython/pull/145957/files |
| Please reload this page | https://github.com/python/cpython/pull/145957/files |
| Please reload this page | https://github.com/python/cpython/pull/145957/files |
|
test_textio.py
| https://github.com/python/cpython/pull/145957/files#diff-871737268f0629fa5bc32f116d3c5f1a37accc05d5505883c9f0f21bf6ac7ee3 |
|
2025-12-21-17-56-37.gh-issue-143008.aakErJ.rst
| https://github.com/python/cpython/pull/145957/files#diff-64eacb2a655e36ff9e4bfcd2977e304d123c8382e1aa025ef213a67b3162a23c |
|
2026-06-04-18-22-56.gh-issue-143008.z5tw-J.rst
| https://github.com/python/cpython/pull/145957/files#diff-6bbf39fad3c6da5b3d5f1a116a950c59d38b733ccf56f3c27c26869a511f19d9 |
|
textio.c.h
| https://github.com/python/cpython/pull/145957/files#diff-3f9c7f3d55bcd9dd3f3503b1e058b26d56495720f02f4906c9635ca5afcebeb8 |
|
textio.c
| https://github.com/python/cpython/pull/145957/files#diff-f6d1380274f6859688c821fced58fb1c829d8acad44ae252ba988e220e1080b3 |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L526 |
| Lib/test/test_io/test_textio.py | https://github.com/python/cpython/pull/145957/files#diff-871737268f0629fa5bc32f116d3c5f1a37accc05d5505883c9f0f21bf6ac7ee3 |
|
View file
| https://github.com/cmaloney/cpython/blob/cbcd21a8317c7a012f857407214af167a5d534e9/Lib/test/test_io/test_textio.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/145957/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/145957/files#diff-871737268f0629fa5bc32f116d3c5f1a37accc05d5505883c9f0f21bf6ac7ee3 |
| Please reload this page | https://github.com/python/cpython/pull/145957/files |
|
| https://github.com/python/cpython/pull/145957/files#diff-871737268f0629fa5bc32f116d3c5f1a37accc05d5505883c9f0f21bf6ac7ee3 |
| Misc/NEWS.d/next/Library/2025-12-21-17-56-37.gh-issue-143008.aakErJ.rst | https://github.com/python/cpython/pull/145957/files#diff-64eacb2a655e36ff9e4bfcd2977e304d123c8382e1aa025ef213a67b3162a23c |
|
View file
| https://github.com/cmaloney/cpython/blob/cbcd21a8317c7a012f857407214af167a5d534e9/Misc/NEWS.d/next/Library/2025-12-21-17-56-37.gh-issue-143008.aakErJ.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/145957/{{ revealButtonHref }} |
| Misc/NEWS.d/next/Library/2026-06-04-18-22-56.gh-issue-143008.z5tw-J.rst | https://github.com/python/cpython/pull/145957/files#diff-6bbf39fad3c6da5b3d5f1a116a950c59d38b733ccf56f3c27c26869a511f19d9 |
|
View file
| https://github.com/cmaloney/cpython/blob/cbcd21a8317c7a012f857407214af167a5d534e9/Misc/NEWS.d/next/Library/2026-06-04-18-22-56.gh-issue-143008.z5tw-J.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/145957/{{ revealButtonHref }} |
| Modules/_io/clinic/textio.c.h | https://github.com/python/cpython/pull/145957/files#diff-3f9c7f3d55bcd9dd3f3503b1e058b26d56495720f02f4906c9635ca5afcebeb8 |
|
View file
| https://github.com/cmaloney/cpython/blob/cbcd21a8317c7a012f857407214af167a5d534e9/Modules/_io/clinic/textio.c.h |
|
Open in desktop
| https://desktop.github.com |
| how customized files appear on GitHub | https://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github |
| Please reload this page | https://github.com/python/cpython/pull/145957/files |
| Please reload this page | https://github.com/python/cpython/pull/145957/files |
| Please reload this page | https://github.com/python/cpython/pull/145957/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |