René's URL Explorer Experiment


Title: gh-143008: Fix Null pointer dereferences in TextIOWrapper underlying stream access by cmaloney · Pull Request #145957 · python/cpython · GitHub

Open Graph Title: gh-143008: Fix Null pointer dereferences in TextIOWrapper underlying stream access by cmaloney · Pull Request #145957 · python/cpython

X Title: gh-143008: Fix Null pointer dereferences in TextIOWrapper underlying stream access by cmaloney · Pull Request #145957 · python/cpython

Description: TextIOWrapper keeps its underlying stream in a member called self->buffer. That stream can be detached by user code, such as custom .flush() implementations, resulting in self->buffer being set to NULL. The implementation often checked at the start of functions if self->buffer is in a good state but did not always recheck after other Python code which could modify self->buffer. The cases which need to be re-checked are hard to spot so rather than rely on reviewer effort make a better safety net by changing all self->buffer access to go through helper functions. Thank you @yihong0618 for the test, NEWS and an initial implementation in gh-143041. Issue: gh-143008

Open Graph Description: TextIOWrapper keeps its underlying stream in a member called self->buffer. That stream can be detached by user code, such as custom .flush() implementations, resulting in self->buffer being s...

X Description: TextIOWrapper keeps its underlying stream in a member called self->buffer. That stream can be detached by user code, such as custom .flush() implementations, resulting in self->buffer...

Opengraph URL: https://github.com/python/cpython/pull/145957

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:22f315fe-ed25-0b2e-f690-abf2d541cbe1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA0AC:29FFA9:3B26B59:4AE4BFF:6B01FBDC
html-safe-nonce16cc43ca6e3e9b1214aaf9994f8cc5a6b92c0b6eaafbfed881e6348f0e3e9a9e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMEFDOjI5RkZBOTozQjI2QjU5OjRBRTRCRkY6NkIwMUZCREMiLCJ2aXNpdG9yX2lkIjoiMTYxODYzODEyMDQxMTA2OTQwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacac8ff9133849180e356c7b2564b5479376da68e22b0e789b0d66fd1e824fa094
hovercard-subject-tagpull_request:3400336029
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/145957/files
twitter:imagehttps://avatars.githubusercontent.com/u/751088?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/751088?s=400&v=4
og:image:altTextIOWrapper keeps its underlying stream in a member called self->buffer. That stream can be detached by user code, such as custom .flush() implementations, resulting in self->buffer being s...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/145957/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F145957%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F145957%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/145957/files
Reloadhttps://github.com/python/cpython/pull/145957/files
Reloadhttps://github.com/python/cpython/pull/145957/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
cmaloney:textio_nullbufferhttps://github.com/cmaloney/cpython/tree/textio_nullbuffer
Conversation 36 https://github.com/python/cpython/pull/145957
Commits 25 https://github.com/python/cpython/pull/145957/commits
Checks 59 https://github.com/python/cpython/pull/145957/checks
Files changed https://github.com/python/cpython/pull/145957/files
Please reload this pagehttps://github.com/python/cpython/pull/145957/files
gh-143008: Fix Null pointer dereferences in TextIOWrapper underlying stream access https://github.com/python/cpython/pull/145957/files#top
Show all changes 25 commits https://github.com/python/cpython/pull/145957/files
42caa08 gh-143008: Safer TextIOWrapper underlying stream access cmaloney Mar 15, 2026 https://github.com/python/cpython/pull/145957/commits/42caa08ed68701af7e039caea089312fb8b47341
551c3eb fixup: Refer to existing helpers cmaloney Mar 15, 2026 https://github.com/python/cpython/pull/145957/commits/551c3eb5f5d57d97374c297a558e6802077edb64
4f455f4 fixup: More precise recursion errorcatching cmaloney Mar 17, 2026 https://github.com/python/cpython/pull/145957/commits/4f455f4f6dbab848542fb5255530d017a5b48500
ec39a61 fixup: Formatting fixes, simplify test cmaloney Mar 17, 2026 https://github.com/python/cpython/pull/145957/commits/ec39a6118f238cb8bc2f34088c2e4e5ee18acf00
98bc865 fixup: correct commment cmaloney Mar 17, 2026 https://github.com/python/cpython/pull/145957/commits/98bc8653ea6f23900b7dc0d93fe0b06315094a6a
c52559b PEP 7 fixes; simplify some comments cmaloney Mar 30, 2026 https://github.com/python/cpython/pull/145957/commits/c52559be04be348697cafd24584b93af381d82f5
210b21b Merge branch 'main' into textio_nullbuffer cmaloney Mar 30, 2026 https://github.com/python/cpython/pull/145957/commits/210b21b0832015254ede1a2d6816f5aef87fe990
150fcee Improve PEP-7 cmaloney Apr 20, 2026 https://github.com/python/cpython/pull/145957/commits/150fceef9c727a99d657dc342b207ec71700853a
d7f14fc PEP-7: Move to shorter function names, reformat arg lists cmaloney Apr 21, 2026 https://github.com/python/cpython/pull/145957/commits/d7f14fc87152d86ba5c6b478550f3dbfacdbc559
df212a5 Improve NEWS grammer cmaloney Apr 21, 2026 https://github.com/python/cpython/pull/145957/commits/df212a5c2cca674355395e2373f62ff45fe1cf97
d1a1a98 Simplify comment cmaloney Apr 21, 2026 https://github.com/python/cpython/pull/145957/commits/d1a1a98036b996ccaefee919236b402b66989c56
009cf12 Fix comment referring to function name cmaloney Apr 21, 2026 https://github.com/python/cpython/pull/145957/commits/009cf121ea6ccd0ea7c0f58666fcc58e00f17f9b
afe79c7 Apply suggestions from code review cmaloney Jun 5, 2026 https://github.com/python/cpython/pull/145957/commits/afe79c793e7a4b08c910722ebf569ab98e89bc3b
452168c Assert self->buffer is locked, fix __init__ race cmaloney Jun 5, 2026 https://github.com/python/cpython/pull/145957/commits/452168c4161482bdda8897eb332fb9691c44aefe
d7b146e Adjust closed_get_impl cmaloney Jun 5, 2026 https://github.com/python/cpython/pull/145957/commits/d7b146ed446da879da5acfb2e9e5a8b306e5bbb8
593b0ea Add back in locked assterion, match surrounding comment style cmaloney Jun 5, 2026 https://github.com/python/cpython/pull/145957/commits/593b0ea6be243570f6eba043bb67c837d564348d
e5c014a Move null checks up a line cmaloney Jun 5, 2026 https://github.com/python/cpython/pull/145957/commits/e5c014af004cc7fe502ef2de87fe3e3461aa989a
eb23eaa Merge remote-tracking branch 'upstream/main' into textio_nullbuffer cmaloney Jun 5, 2026 https://github.com/python/cpython/pull/145957/commits/eb23eaa6d2ea7334bb2208aae5bf6e9207d47f3b
2581e6c Fix clinic merge cmaloney Jun 5, 2026 https://github.com/python/cpython/pull/145957/commits/2581e6c837d0c29fdd2454345e6bce51594ff3bc
feafb90 Fix blurb cmaloney Jun 5, 2026 https://github.com/python/cpython/pull/145957/commits/feafb90e079741671ce1b0046d226dec030b7491
c0bdd84 Apply suggestions from code review cmaloney Jun 9, 2026 https://github.com/python/cpython/pull/145957/commits/c0bdd84c64a19ec97ec63c51dcb7a402789bc80f
d7bf513 Remove wrapper_ref, use simpler classes, wrapper local only cmaloney Jun 9, 2026 https://github.com/python/cpython/pull/145957/commits/d7bf5131ed3e1185d134e63c4bb29fc088775972
a24957d Separate attribute and submodule imports cmaloney Jun 9, 2026 https://github.com/python/cpython/pull/145957/commits/a24957de037d51a541e5a55c6fcae59aef3982e6
c2cb455 Fix NULL with no exception after flush in detach cmaloney Jun 9, 2026 https://github.com/python/cpython/pull/145957/commits/c2cb45564828fad958752871666f731dd1ba31e1
cbcd21a remove recursion. Add make_text helper and DetachOnce cmaloney Jun 9, 2026 https://github.com/python/cpython/pull/145957/commits/cbcd21a8317c7a012f857407214af167a5d534e9
Clear filters https://github.com/python/cpython/pull/145957/files
Please reload this pagehttps://github.com/python/cpython/pull/145957/files
Please reload this pagehttps://github.com/python/cpython/pull/145957/files
test_textio.py https://github.com/python/cpython/pull/145957/files#diff-871737268f0629fa5bc32f116d3c5f1a37accc05d5505883c9f0f21bf6ac7ee3
2025-12-21-17-56-37.gh-issue-143008.aakErJ.rst https://github.com/python/cpython/pull/145957/files#diff-64eacb2a655e36ff9e4bfcd2977e304d123c8382e1aa025ef213a67b3162a23c
2026-06-04-18-22-56.gh-issue-143008.z5tw-J.rst https://github.com/python/cpython/pull/145957/files#diff-6bbf39fad3c6da5b3d5f1a116a950c59d38b733ccf56f3c27c26869a511f19d9
textio.c.h https://github.com/python/cpython/pull/145957/files#diff-3f9c7f3d55bcd9dd3f3503b1e058b26d56495720f02f4906c9635ca5afcebeb8
textio.c https://github.com/python/cpython/pull/145957/files#diff-f6d1380274f6859688c821fced58fb1c829d8acad44ae252ba988e220e1080b3
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L526
Lib/test/test_io/test_textio.pyhttps://github.com/python/cpython/pull/145957/files#diff-871737268f0629fa5bc32f116d3c5f1a37accc05d5505883c9f0f21bf6ac7ee3
View file https://github.com/cmaloney/cpython/blob/cbcd21a8317c7a012f857407214af167a5d534e9/Lib/test/test_io/test_textio.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/145957/{{ revealButtonHref }}
https://github.com/python/cpython/pull/145957/files#diff-871737268f0629fa5bc32f116d3c5f1a37accc05d5505883c9f0f21bf6ac7ee3
Please reload this pagehttps://github.com/python/cpython/pull/145957/files
https://github.com/python/cpython/pull/145957/files#diff-871737268f0629fa5bc32f116d3c5f1a37accc05d5505883c9f0f21bf6ac7ee3
Misc/NEWS.d/next/Library/2025-12-21-17-56-37.gh-issue-143008.aakErJ.rsthttps://github.com/python/cpython/pull/145957/files#diff-64eacb2a655e36ff9e4bfcd2977e304d123c8382e1aa025ef213a67b3162a23c
View file https://github.com/cmaloney/cpython/blob/cbcd21a8317c7a012f857407214af167a5d534e9/Misc/NEWS.d/next/Library/2025-12-21-17-56-37.gh-issue-143008.aakErJ.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/145957/{{ revealButtonHref }}
Misc/NEWS.d/next/Library/2026-06-04-18-22-56.gh-issue-143008.z5tw-J.rsthttps://github.com/python/cpython/pull/145957/files#diff-6bbf39fad3c6da5b3d5f1a116a950c59d38b733ccf56f3c27c26869a511f19d9
View file https://github.com/cmaloney/cpython/blob/cbcd21a8317c7a012f857407214af167a5d534e9/Misc/NEWS.d/next/Library/2026-06-04-18-22-56.gh-issue-143008.z5tw-J.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/145957/{{ revealButtonHref }}
Modules/_io/clinic/textio.c.hhttps://github.com/python/cpython/pull/145957/files#diff-3f9c7f3d55bcd9dd3f3503b1e058b26d56495720f02f4906c9635ca5afcebeb8
View file https://github.com/cmaloney/cpython/blob/cbcd21a8317c7a012f857407214af167a5d534e9/Modules/_io/clinic/textio.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/145957/files
Please reload this pagehttps://github.com/python/cpython/pull/145957/files
Please reload this pagehttps://github.com/python/cpython/pull/145957/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.