René's URL Explorer Experiment


Title: gh-143008: Fix Null pointer dereferences in TextIOWrapper underlying stream access by cmaloney · Pull Request #145957 · python/cpython · GitHub

Open Graph Title: gh-143008: Fix Null pointer dereferences in TextIOWrapper underlying stream access by cmaloney · Pull Request #145957 · python/cpython

X Title: gh-143008: Fix Null pointer dereferences in TextIOWrapper underlying stream access by cmaloney · Pull Request #145957 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: TextIOWrapper keeps its underlying stream in a member called self->buffer. That stream can be detached by user code, such as custom .flush() implementations, resulting in self->buffer being s...

X Description: TextIOWrapper keeps its underlying stream in a member called self->buffer. That stream can be detached by user code, such as custom .flush() implementations, resulting in self->buffer...

Opengraph URL: https://github.com/python/cpython/pull/145957

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:23c603b7-de5e-726e-6bf1-81b97bbdde99
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idABA6:1C94F:2ACC830:36DA95B:6B01F4E2
html-safe-nonced5550fbf008991ab642605fe5754b322e09ec80c33f41e839406fac276131067
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkE2OjFDOTRGOjJBQ0M4MzA6MzZEQTk1Qjo2QjAxRjRFMiIsInZpc2l0b3JfaWQiOiI2ODUzMzczODUzMTAwNTM3MDU4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac80231784927afab62da13d64fa1ad6dabab0660023b25250c54c4b191cdde69c
hovercard-subject-tagpull_request:3400336029
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/145957/commits
twitter:imagehttps://opengraph.githubassets.com/9f073cb4353c61fd5c7ee34ab18a71ee4344d8435523f35882a2e2213203bbed/python/cpython/pull/145957
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9f073cb4353c61fd5c7ee34ab18a71ee4344d8435523f35882a2e2213203bbed/python/cpython/pull/145957
og:image:altTextIOWrapper keeps its underlying stream in a member called self->buffer. That stream can be detached by user code, such as custom .flush() implementations, resulting in self->buffer being s...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecmaloney
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/145957/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F145957%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F145957%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/145957/commits
Reloadhttps://github.com/python/cpython/pull/145957/commits
Reloadhttps://github.com/python/cpython/pull/145957/commits
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
cmaloney:textio_nullbufferhttps://github.com/cmaloney/cpython/tree/textio_nullbuffer
Conversationhttps://github.com/python/cpython/pull/145957
Commits25 (25)https://github.com/python/cpython/pull/145957/commits
Checkshttps://github.com/python/cpython/pull/145957/checks
Files changedhttps://github.com/python/cpython/pull/145957/files
gh-143008: Fix Null pointer dereferences in TextIOWrapper underlying stream accesshttps://github.com/python/cpython/pull/145957/commits#top
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
cmaloney:textio_nullbufferhttps://github.com/cmaloney/cpython/tree/textio_nullbuffer
gh-143008: Safer TextIOWrapper underlying stream accesshttps://github.com/python/cpython/pull/145957/commits/42caa08ed68701af7e039caea089312fb8b47341
cmaloneyhttps://github.com/python/cpython/commits?author=cmaloney
yihong0618https://github.com/python/cpython/commits?author=yihong0618
42caa08https://github.com/python/cpython/pull/145957/commits/42caa08ed68701af7e039caea089312fb8b47341
https://github.com/python/cpython/tree/42caa08ed68701af7e039caea089312fb8b47341
fixup: Refer to existing helpershttps://github.com/python/cpython/pull/145957/commits/551c3eb5f5d57d97374c297a558e6802077edb64
https://github.com/cmaloney
cmaloneyhttps://github.com/python/cpython/commits?author=cmaloney
551c3ebhttps://github.com/python/cpython/pull/145957/commits/551c3eb5f5d57d97374c297a558e6802077edb64
https://github.com/python/cpython/tree/551c3eb5f5d57d97374c297a558e6802077edb64
fixup: More precise recursion errorcatchinghttps://github.com/python/cpython/pull/145957/commits/4f455f4f6dbab848542fb5255530d017a5b48500
https://github.com/cmaloney
cmaloneyhttps://github.com/python/cpython/commits?author=cmaloney
4f455f4https://github.com/python/cpython/pull/145957/commits/4f455f4f6dbab848542fb5255530d017a5b48500
https://github.com/python/cpython/tree/4f455f4f6dbab848542fb5255530d017a5b48500
fixup: Formatting fixes, simplify testhttps://github.com/python/cpython/pull/145957/commits/ec39a6118f238cb8bc2f34088c2e4e5ee18acf00
https://github.com/cmaloney
cmaloneyhttps://github.com/python/cpython/commits?author=cmaloney
ec39a61https://github.com/python/cpython/pull/145957/commits/ec39a6118f238cb8bc2f34088c2e4e5ee18acf00
https://github.com/python/cpython/tree/ec39a6118f238cb8bc2f34088c2e4e5ee18acf00
fixup: correct commmenthttps://github.com/python/cpython/pull/145957/commits/98bc8653ea6f23900b7dc0d93fe0b06315094a6a
https://github.com/cmaloney
cmaloneyhttps://github.com/python/cpython/commits?author=cmaloney
98bc865https://github.com/python/cpython/pull/145957/commits/98bc8653ea6f23900b7dc0d93fe0b06315094a6a
https://github.com/python/cpython/tree/98bc8653ea6f23900b7dc0d93fe0b06315094a6a
PEP 7 fixes; simplify some commentshttps://github.com/python/cpython/pull/145957/commits/c52559be04be348697cafd24584b93af381d82f5
https://github.com/cmaloney
cmaloneyhttps://github.com/python/cpython/commits?author=cmaloney
c52559bhttps://github.com/python/cpython/pull/145957/commits/c52559be04be348697cafd24584b93af381d82f5
https://github.com/python/cpython/tree/c52559be04be348697cafd24584b93af381d82f5
Merge branch 'main' into textio_nullbufferhttps://github.com/python/cpython/pull/145957/commits/210b21b0832015254ede1a2d6816f5aef87fe990
https://github.com/cmaloney
cmaloneyhttps://github.com/python/cpython/commits?author=cmaloney
210b21bhttps://github.com/python/cpython/pull/145957/commits/210b21b0832015254ede1a2d6816f5aef87fe990
https://github.com/python/cpython/tree/210b21b0832015254ede1a2d6816f5aef87fe990
Improve PEP-7https://github.com/python/cpython/pull/145957/commits/150fceef9c727a99d657dc342b207ec71700853a
https://github.com/cmaloney
cmaloneyhttps://github.com/python/cpython/commits?author=cmaloney
150fceehttps://github.com/python/cpython/pull/145957/commits/150fceef9c727a99d657dc342b207ec71700853a
https://github.com/python/cpython/tree/150fceef9c727a99d657dc342b207ec71700853a
PEP-7: Move to shorter function names, reformat arg listshttps://github.com/python/cpython/pull/145957/commits/d7f14fc87152d86ba5c6b478550f3dbfacdbc559
https://github.com/cmaloney
cmaloneyhttps://github.com/python/cpython/commits?author=cmaloney
d7f14fchttps://github.com/python/cpython/pull/145957/commits/d7f14fc87152d86ba5c6b478550f3dbfacdbc559
https://github.com/python/cpython/tree/d7f14fc87152d86ba5c6b478550f3dbfacdbc559
Improve NEWS grammerhttps://github.com/python/cpython/pull/145957/commits/df212a5c2cca674355395e2373f62ff45fe1cf97
https://github.com/cmaloney
cmaloneyhttps://github.com/python/cpython/commits?author=cmaloney
df212a5https://github.com/python/cpython/pull/145957/commits/df212a5c2cca674355395e2373f62ff45fe1cf97
https://github.com/python/cpython/tree/df212a5c2cca674355395e2373f62ff45fe1cf97
Simplify commenthttps://github.com/python/cpython/pull/145957/commits/d1a1a98036b996ccaefee919236b402b66989c56
https://github.com/cmaloney
cmaloneyhttps://github.com/python/cpython/commits?author=cmaloney
d1a1a98https://github.com/python/cpython/pull/145957/commits/d1a1a98036b996ccaefee919236b402b66989c56
https://github.com/python/cpython/tree/d1a1a98036b996ccaefee919236b402b66989c56
Fix comment referring to function namehttps://github.com/python/cpython/pull/145957/commits/009cf121ea6ccd0ea7c0f58666fcc58e00f17f9b
https://github.com/cmaloney
cmaloneyhttps://github.com/python/cpython/commits?author=cmaloney
009cf12https://github.com/python/cpython/pull/145957/commits/009cf121ea6ccd0ea7c0f58666fcc58e00f17f9b
https://github.com/python/cpython/tree/009cf121ea6ccd0ea7c0f58666fcc58e00f17f9b
Apply suggestions from code reviewhttps://github.com/python/cpython/pull/145957/commits/afe79c793e7a4b08c910722ebf569ab98e89bc3b
cmaloneyhttps://github.com/python/cpython/commits?author=cmaloney
vstinnerhttps://github.com/python/cpython/commits?author=vstinner
afe79c7https://github.com/python/cpython/pull/145957/commits/afe79c793e7a4b08c910722ebf569ab98e89bc3b
https://github.com/python/cpython/tree/afe79c793e7a4b08c910722ebf569ab98e89bc3b
Assert self->buffer is locked, fix __init__ racehttps://github.com/python/cpython/pull/145957/commits/452168c4161482bdda8897eb332fb9691c44aefe
https://github.com/cmaloney
cmaloneyhttps://github.com/python/cpython/commits?author=cmaloney
452168chttps://github.com/python/cpython/pull/145957/commits/452168c4161482bdda8897eb332fb9691c44aefe
https://github.com/python/cpython/tree/452168c4161482bdda8897eb332fb9691c44aefe
Adjust closed_get_implhttps://github.com/python/cpython/pull/145957/commits/d7b146ed446da879da5acfb2e9e5a8b306e5bbb8
https://github.com/cmaloney
cmaloneyhttps://github.com/python/cpython/commits?author=cmaloney
d7b146ehttps://github.com/python/cpython/pull/145957/commits/d7b146ed446da879da5acfb2e9e5a8b306e5bbb8
https://github.com/python/cpython/tree/d7b146ed446da879da5acfb2e9e5a8b306e5bbb8
Add back in locked assterion, match surrounding comment stylehttps://github.com/python/cpython/pull/145957/commits/593b0ea6be243570f6eba043bb67c837d564348d
https://github.com/cmaloney
cmaloneyhttps://github.com/python/cpython/commits?author=cmaloney
593b0eahttps://github.com/python/cpython/pull/145957/commits/593b0ea6be243570f6eba043bb67c837d564348d
https://github.com/python/cpython/tree/593b0ea6be243570f6eba043bb67c837d564348d
Move null checks up a linehttps://github.com/python/cpython/pull/145957/commits/e5c014af004cc7fe502ef2de87fe3e3461aa989a
https://github.com/cmaloney
cmaloneyhttps://github.com/python/cpython/commits?author=cmaloney
e5c014ahttps://github.com/python/cpython/pull/145957/commits/e5c014af004cc7fe502ef2de87fe3e3461aa989a
https://github.com/python/cpython/tree/e5c014af004cc7fe502ef2de87fe3e3461aa989a
Merge remote-tracking branch 'upstream/main' into textio_nullbufferhttps://github.com/python/cpython/pull/145957/commits/eb23eaa6d2ea7334bb2208aae5bf6e9207d47f3b
https://github.com/cmaloney
cmaloneyhttps://github.com/python/cpython/commits?author=cmaloney
eb23eaahttps://github.com/python/cpython/pull/145957/commits/eb23eaa6d2ea7334bb2208aae5bf6e9207d47f3b
https://github.com/python/cpython/tree/eb23eaa6d2ea7334bb2208aae5bf6e9207d47f3b
Fix clinic mergehttps://github.com/python/cpython/pull/145957/commits/2581e6c837d0c29fdd2454345e6bce51594ff3bc
https://github.com/cmaloney
cmaloneyhttps://github.com/python/cpython/commits?author=cmaloney
2581e6chttps://github.com/python/cpython/pull/145957/commits/2581e6c837d0c29fdd2454345e6bce51594ff3bc
https://github.com/python/cpython/tree/2581e6c837d0c29fdd2454345e6bce51594ff3bc
Fix blurbhttps://github.com/python/cpython/pull/145957/commits/feafb90e079741671ce1b0046d226dec030b7491
https://github.com/cmaloney
cmaloneyhttps://github.com/python/cpython/commits?author=cmaloney
feafb90https://github.com/python/cpython/pull/145957/commits/feafb90e079741671ce1b0046d226dec030b7491
https://github.com/python/cpython/tree/feafb90e079741671ce1b0046d226dec030b7491
Apply suggestions from code reviewhttps://github.com/python/cpython/pull/145957/commits/c0bdd84c64a19ec97ec63c51dcb7a402789bc80f
cmaloneyhttps://github.com/python/cpython/commits?author=cmaloney
vstinnerhttps://github.com/python/cpython/commits?author=vstinner
c0bdd84https://github.com/python/cpython/pull/145957/commits/c0bdd84c64a19ec97ec63c51dcb7a402789bc80f
https://github.com/python/cpython/tree/c0bdd84c64a19ec97ec63c51dcb7a402789bc80f
Remove wrapper_ref, use simpler classes, wrapper local onlyhttps://github.com/python/cpython/pull/145957/commits/d7bf5131ed3e1185d134e63c4bb29fc088775972
https://github.com/cmaloney
cmaloneyhttps://github.com/python/cpython/commits?author=cmaloney
d7bf513https://github.com/python/cpython/pull/145957/commits/d7bf5131ed3e1185d134e63c4bb29fc088775972
https://github.com/python/cpython/tree/d7bf5131ed3e1185d134e63c4bb29fc088775972
Separate attribute and submodule importshttps://github.com/python/cpython/pull/145957/commits/a24957de037d51a541e5a55c6fcae59aef3982e6
https://github.com/cmaloney
cmaloneyhttps://github.com/python/cpython/commits?author=cmaloney
a24957dhttps://github.com/python/cpython/pull/145957/commits/a24957de037d51a541e5a55c6fcae59aef3982e6
https://github.com/python/cpython/tree/a24957de037d51a541e5a55c6fcae59aef3982e6
Fix NULL with no exception after flush in detachhttps://github.com/python/cpython/pull/145957/commits/c2cb45564828fad958752871666f731dd1ba31e1
https://github.com/cmaloney
cmaloneyhttps://github.com/python/cpython/commits?author=cmaloney
c2cb455https://github.com/python/cpython/pull/145957/commits/c2cb45564828fad958752871666f731dd1ba31e1
https://github.com/python/cpython/tree/c2cb45564828fad958752871666f731dd1ba31e1
remove recursion. Add make_text helper and DetachOncehttps://github.com/python/cpython/pull/145957/commits/cbcd21a8317c7a012f857407214af167a5d534e9
https://github.com/cmaloney
cmaloneyhttps://github.com/python/cpython/commits?author=cmaloney
cbcd21ahttps://github.com/python/cpython/pull/145957/commits/cbcd21a8317c7a012f857407214af167a5d534e9
https://github.com/python/cpython/tree/cbcd21a8317c7a012f857407214af167a5d534e9
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.