René's URL Explorer Experiment


Title: GH-60729: Add IEEE format wave audio support take two by mbeijen · Pull Request #145931 · python/cpython · GitHub

Open Graph Title: GH-60729: Add IEEE format wave audio support take two by mbeijen · Pull Request #145931 · python/cpython

X Title: GH-60729: Add IEEE format wave audio support take two by mbeijen · Pull Request #145931 · python/cpython

Description: This is an updated version of #102574, the original PR where @lkoenig added support for IEEE Wave Audio. As requested by @encukou I've Renamed the new 'getencoding/setencoding' to 'getformat/setformat' - format is the term used in the specifications Added format to getparams Added FACT chunk to written non-PCM wave files, which is required by the spec (and is what Audacity does) Added documentation! Closes: #102574 This is the new version of #145384 which got merged today AND reverted, because it failed on big-endian. Looking back I changed the test so it has the same structure as all other tests in test_wave.py and I ran it on an s390 docker image and tests are passing now for me. I was surprised there were no big endian tests on PRs only on main!! I'm sorry for the churn this caused. 📚 Documentation preview 📚: https://cpython-previews--145931.org.readthedocs.build/ Issue: gh-60729

Open Graph Description: This is an updated version of #102574, the original PR where @lkoenig added support for IEEE Wave Audio. As requested by @encukou I've Renamed the new 'getencoding/setencoding' to '...

X Description: This is an updated version of #102574, the original PR where @lkoenig added support for IEEE Wave Audio. As requested by @encukou I've Renamed the new 'getencoding/setencoding&...

Opengraph URL: https://github.com/python/cpython/pull/145931

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:be9e17ee-efdd-5e88-8de7-3634d5e51b1d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD4EC:1ED336:4C6D6A:6946C1:6AEDB805
html-safe-noncef22e4b4fddfabac0da2967adcdd9224dd202d50f5c7486e9f60d81a22fa67071
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENEVDOjFFRDMzNjo0QzZENkE6Njk0NkMxOjZBRURCODA1IiwidmlzaXRvcl9pZCI6IjU0MDgzNjYwNzQyMjIxNjE5OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacca38d1540a997c45fed42613207608eca9022c0a8a7870cc24a7e6759c718e42
hovercard-subject-tagpull_request:3397146887
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/145931/commits/7663237b70c7f9215e826603d40268be95dad1d8
twitter:imagehttps://avatars.githubusercontent.com/u/659504?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/659504?s=400&v=4
og:image:altThis is an updated version of #102574, the original PR where @lkoenig added support for IEEE Wave Audio. As requested by @encukou I've Renamed the new 'getencoding/setencoding' to '...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None1eb5f7cedbc707472687eab1a30e6c4619c00791815622ceaba9694eb161930f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef31f9c89203c022acdb651c34ae048cf41764208
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/145931/commits/7663237b70c7f9215e826603d40268be95dad1d8#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F145931%2Fcommits%2F7663237b70c7f9215e826603d40268be95dad1d8
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F145931%2Fcommits%2F7663237b70c7f9215e826603d40268be95dad1d8
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/145931/commits/7663237b70c7f9215e826603d40268be95dad1d8
Reloadhttps://github.com/python/cpython/pull/145931/commits/7663237b70c7f9215e826603d40268be95dad1d8
Reloadhttps://github.com/python/cpython/pull/145931/commits/7663237b70c7f9215e826603d40268be95dad1d8
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.3k (2.3k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
mbeijen:GH-60729-add-ieee-wave-audio-support-take-2https://github.com/mbeijen/cpython/tree/GH-60729-add-ieee-wave-audio-support-take-2
Conversation 3 https://github.com/python/cpython/pull/145931
Commits 14 https://github.com/python/cpython/pull/145931/commits
Checks 45 https://github.com/python/cpython/pull/145931/checks
Files changed https://github.com/python/cpython/pull/145931/files
Please reload this pagehttps://github.com/python/cpython/pull/145931/commits/7663237b70c7f9215e826603d40268be95dad1d8
GH-60729: Add IEEE format wave audio support take two https://github.com/python/cpython/pull/145931/commits/7663237b70c7f9215e826603d40268be95dad1d8#top
Show all changes 14 commits https://github.com/python/cpython/pull/145931/files
bb8e258 Add support for floating point wave files. lkoenig Mar 10, 2023 https://github.com/python/cpython/pull/145931/commits/bb8e258b54456757a688cd051c518cff8bfc502d
164e89e wave: rename encoding API to format mbeijen Feb 28, 2026 https://github.com/python/cpython/pull/145931/commits/164e89efd7a0174a969daf9a175375cf8100366c
33fc496 wave: write FACT chunk for IEEE float mbeijen Feb 28, 2026 https://github.com/python/cpython/pull/145931/commits/33fc49603ee5daeafb5d81d0c193d717a3a69266
58339ae wave: add format to getparams mbeijen Feb 28, 2026 https://github.com/python/cpython/pull/145931/commits/58339aec5293b7068ce281e67db45ac31a1a1318
4ce4379 wave: add documentation on IEEE support, format API mbeijen Mar 1, 2026 https://github.com/python/cpython/pull/145931/commits/4ce437916bd15f72297fc0e60bf7059df5c01541
b5569a9 wave: add documentation for undocumented methods mbeijen Mar 1, 2026 https://github.com/python/cpython/pull/145931/commits/b5569a9e8085ffeddaf9a54dd0d29794ef65fa72
fd1d972 Update Misc/NEWS.d/next/Library/2023-03-10-13-10-06.gh-issue-60729.KC… mbeijen Mar 1, 2026 https://github.com/python/cpython/pull/145931/commits/fd1d972bc63f1de4839c391217f31b7931f11fa3
d65a428 versionchanged mbeijen Mar 3, 2026 https://github.com/python/cpython/pull/145931/commits/d65a42834398f115fdf035ca48bfbd026dee4a6f
3c1275e wave: restore getparams() backward compatibility mbeijen Mar 3, 2026 https://github.com/python/cpython/pull/145931/commits/3c1275eb0071c2542bf40b765516e635467e8b3d
6f86098 wave: export WAVE_FORMAT constants mbeijen Mar 3, 2026 https://github.com/python/cpython/pull/145931/commits/6f86098400ff02960a719b9389709934c9104c8d
7663237 wave docs: add format constants as data mbeijen Mar 3, 2026 https://github.com/python/cpython/pull/145931/commits/7663237b70c7f9215e826603d40268be95dad1d8
5de8957 wave: sampwidth for IEEE Float must be 4 or 8 mbeijen Mar 7, 2026 https://github.com/python/cpython/pull/145931/commits/5de89578f8cac9e3eff9f9a111d3491904af3f1b
6247ace test_wave: fix IEEE float test data for big-endian systems mbeijen Mar 13, 2026 https://github.com/python/cpython/pull/145931/commits/6247ace5a36f019e1c66f3b1147e1a27e3f256a8
27c0ddb Merge branch 'main' into GH-60729-add-ieee-wave-audio-support-take-2 encukou Mar 18, 2026 https://github.com/python/cpython/pull/145931/commits/27c0ddb2a45b45f5409f82ffb2d131e1c5da77e3
Clear filters https://github.com/python/cpython/pull/145931/commits/7663237b70c7f9215e826603d40268be95dad1d8
Please reload this pagehttps://github.com/python/cpython/pull/145931/commits/7663237b70c7f9215e826603d40268be95dad1d8
Please reload this pagehttps://github.com/python/cpython/pull/145931/commits/7663237b70c7f9215e826603d40268be95dad1d8
Prev https://github.com/python/cpython/pull/145931/commits/6f86098400ff02960a719b9389709934c9104c8d
Next https://github.com/python/cpython/pull/145931/commits/5de89578f8cac9e3eff9f9a111d3491904af3f1b
Please reload this pagehttps://github.com/python/cpython/pull/145931/commits/7663237b70c7f9215e826603d40268be95dad1d8
https://github.com/mbeijen
mbeijenhttps://github.com/python/cpython/commits?author=mbeijen
Doc/library/wave.rsthttps://github.com/python/cpython/pull/145931/commits/7663237b70c7f9215e826603d40268be95dad1d8#diff-fc459f8732c78b5086d83c7c9a4d2eaa32b777c865091302f96ccd0a91520cc2
View file https://github.com/mbeijen/cpython/blob/7663237b70c7f9215e826603d40268be95dad1d8/Doc/library/wave.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/145931/commits/{{ revealButtonHref }}
https://github.com/python/cpython/pull/145931/commits/7663237b70c7f9215e826603d40268be95dad1d8#diff-fc459f8732c78b5086d83c7c9a4d2eaa32b777c865091302f96ccd0a91520cc2
https://github.com/python/cpython/pull/145931/commits/7663237b70c7f9215e826603d40268be95dad1d8#diff-fc459f8732c78b5086d83c7c9a4d2eaa32b777c865091302f96ccd0a91520cc2
https://github.com/python/cpython/pull/145931/commits/7663237b70c7f9215e826603d40268be95dad1d8#diff-fc459f8732c78b5086d83c7c9a4d2eaa32b777c865091302f96ccd0a91520cc2
https://github.com/python/cpython/pull/145931/commits/7663237b70c7f9215e826603d40268be95dad1d8#diff-fc459f8732c78b5086d83c7c9a4d2eaa32b777c865091302f96ccd0a91520cc2
https://github.com/python/cpython/pull/145931/commits/7663237b70c7f9215e826603d40268be95dad1d8#diff-fc459f8732c78b5086d83c7c9a4d2eaa32b777c865091302f96ccd0a91520cc2
https://github.com/python/cpython/pull/145931/commits/7663237b70c7f9215e826603d40268be95dad1d8#diff-fc459f8732c78b5086d83c7c9a4d2eaa32b777c865091302f96ccd0a91520cc2
https://github.com/python/cpython/pull/145931/commits/7663237b70c7f9215e826603d40268be95dad1d8#diff-fc459f8732c78b5086d83c7c9a4d2eaa32b777c865091302f96ccd0a91520cc2
https://github.com/python/cpython/pull/145931/commits/7663237b70c7f9215e826603d40268be95dad1d8#diff-fc459f8732c78b5086d83c7c9a4d2eaa32b777c865091302f96ccd0a91520cc2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.