René's URL Explorer Experiment


Title: gh-143050: correct PyLong_FromString() to use _PyLong_Negate() by skirpichev · Pull Request #145901 · python/cpython · GitHub

Open Graph Title: gh-143050: correct PyLong_FromString() to use _PyLong_Negate() by skirpichev · Pull Request #145901 · python/cpython

X Title: gh-143050: correct PyLong_FromString() to use _PyLong_Negate() by skirpichev · Pull Request #145901 · python/cpython

Description: The long_from_string_base() might return a small integer, when the _pylong.py is used to do conversion. Hence, we must be careful here to not smash it "small int" bit by using the _PyLong_FlipSign(). Co-authored-by: Sam Gross colesbury@gmail.com Issue: gh-143050

Open Graph Description: The long_from_string_base() might return a small integer, when the _pylong.py is used to do conversion. Hence, we must be careful here to not smash it "small int" bit by using the _PyLon...

X Description: The long_from_string_base() might return a small integer, when the _pylong.py is used to do conversion. Hence, we must be careful here to not smash it "small int" bit by using th...

Opengraph URL: https://github.com/python/cpython/pull/145901

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d37c4f2f-bb4a-91bb-f6e0-c36e8b7398f8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9E36:13B2CF:6CAE59:924045:6A51D3BC
html-safe-nonce47fd8a666ccdb3c82a1c6060fdb7ed5195ef116c20844ba4a7fe960af8a1e389
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTM2OjEzQjJDRjo2Q0FFNTk6OTI0MDQ1OjZBNTFEM0JDIiwidmlzaXRvcl9pZCI6IjQ5OTE1OTkxNTE5NzAxMTI0NDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb4ee2393f19fe69cd09bc26d7d1d9126f264a5c09e5eb96a2b2dca03d682205d
hovercard-subject-tagpull_request:3393759372
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/145901/files
twitter:imagehttps://avatars.githubusercontent.com/u/2155800?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2155800?s=400&v=4
og:image:altThe long_from_string_base() might return a small integer, when the _pylong.py is used to do conversion. Hence, we must be careful here to not smash it "small int" bit by using the _PyLon...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/145901/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F145901%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F145901%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/145901/files
Reloadhttps://github.com/python/cpython/pull/145901/files
Reloadhttps://github.com/python/cpython/pull/145901/files
Please reload this pagehttps://github.com/python/cpython/pull/145901/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/145901/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
skirpichev:fix-PyLong_FromString/143050https://github.com/skirpichev/cpython/tree/fix-PyLong_FromString/143050
Conversation 50 https://github.com/python/cpython/pull/145901
Commits 13 https://github.com/python/cpython/pull/145901/commits
Checks 53 https://github.com/python/cpython/pull/145901/checks
Files changed https://github.com/python/cpython/pull/145901/files
Please reload this pagehttps://github.com/python/cpython/pull/145901/files
gh-143050: correct PyLong_FromString() to use _PyLong_Negate() https://github.com/python/cpython/pull/145901/files#top
Show all changes 13 commits https://github.com/python/cpython/pull/145901/files
fbcec5a gh-143050: correct PyLong_FromString() to use _PyLong_Negate() skirpichev Mar 13, 2026 https://github.com/python/cpython/pull/145901/commits/fbcec5a7ffe7efdc5fce079e39cf638adc3586b5
b8333ba cleanup, use _testcapi.test_immortal_small_ints() skirpichev Mar 13, 2026 https://github.com/python/cpython/pull/145901/commits/b8333ba67da4773f79e668495b7352ed2650c41b
20e79c6 + add also test with nonzero small int skirpichev Mar 14, 2026 https://github.com/python/cpython/pull/145901/commits/20e79c6c3cc5c8a152d2962e98220e30e68ce2dd
413e56d _long_is_small_int() -> _PyLong_IsImmortal() helper skirpichev Mar 14, 2026 https://github.com/python/cpython/pull/145901/commits/413e56d52f3a0717f4abe2481287700759f1e250
b892216 Merge branch 'master' into fix-PyLong_FromString/143050 skirpichev Mar 17, 2026 https://github.com/python/cpython/pull/145901/commits/b892216f640f307d3c3a16bcbfe51cceafcc5795
78c5b4b address review: rename _PyLong_IsImmortal -> _PyLong_HasImmortalTag skirpichev Mar 17, 2026 https://github.com/python/cpython/pull/145901/commits/78c5b4be4012b0c69070463b3a2609f65bff34bd
69d35bd add assert skirpichev Mar 18, 2026 https://github.com/python/cpython/pull/145901/commits/69d35bda593a5f8aafec607c848d0dbfa81a56c1
2f927e0 address review: simplify assert skirpichev Mar 18, 2026 https://github.com/python/cpython/pull/145901/commits/2f927e0dc13c22bfe628438c3d6e581a5cd9d181
53523de Merge branch 'master' into fix-PyLong_FromString/143050 skirpichev Mar 27, 2026 https://github.com/python/cpython/pull/145901/commits/53523deb383c9b972799496785985284a61dea83
1f363f4 address review: some comments skirpichev Mar 28, 2026 https://github.com/python/cpython/pull/145901/commits/1f363f41256562347be497789450d74af071a67a
41961ed Merge branch 'main' into fix-PyLong_FromString/143050 skirpichev Mar 30, 2026 https://github.com/python/cpython/pull/145901/commits/41961ed4553d4827f18a6f0396ab4dcde7f9ad87
0b29e28 address review: add assert on _PY_IS_SMALL_INT skirpichev Mar 30, 2026 https://github.com/python/cpython/pull/145901/commits/0b29e28567f5afae1f39743268034e815232ea1a
45b3b04 Rename to _PyLong_IsSmallInt() vstinner Mar 31, 2026 https://github.com/python/cpython/pull/145901/commits/45b3b040da09b93a42a32e71f08de5670f8d79d6
Clear filters https://github.com/python/cpython/pull/145901/files
Please reload this pagehttps://github.com/python/cpython/pull/145901/files
Please reload this pagehttps://github.com/python/cpython/pull/145901/files
pycore_long.h https://github.com/python/cpython/pull/145901/files#diff-0817b8ffc6c3af36ea39ebabafe70c849d6ee7cb6621d3bda857f3ed25a37511
test_long.py https://github.com/python/cpython/pull/145901/files#diff-cc3c55fb42d8833c85cfb69e864008af59140bcf80ac0cdd411c98688dc534c4
immortal.c https://github.com/python/cpython/pull/145901/files#diff-4475403bbe82b492e8ef54bc096287b1e4774931d4bfe50a196ab396d086edcd
longobject.c https://github.com/python/cpython/pull/145901/files#diff-1a6e70e2beeecad88840c67284ac4d54a36998029244771fcc820e801390726a
Include/internal/pycore_long.hhttps://github.com/python/cpython/pull/145901/files#diff-0817b8ffc6c3af36ea39ebabafe70c849d6ee7cb6621d3bda857f3ed25a37511
View file https://github.com/skirpichev/cpython/blob/45b3b040da09b93a42a32e71f08de5670f8d79d6/Include/internal/pycore_long.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/145901/{{ revealButtonHref }}
https://github.com/python/cpython/pull/145901/files#diff-0817b8ffc6c3af36ea39ebabafe70c849d6ee7cb6621d3bda857f3ed25a37511
Please reload this pagehttps://github.com/python/cpython/pull/145901/files
https://github.com/python/cpython/pull/145901/files#diff-0817b8ffc6c3af36ea39ebabafe70c849d6ee7cb6621d3bda857f3ed25a37511
https://github.com/python/cpython/pull/145901/files#diff-0817b8ffc6c3af36ea39ebabafe70c849d6ee7cb6621d3bda857f3ed25a37511
https://github.com/python/cpython/pull/145901/files#diff-0817b8ffc6c3af36ea39ebabafe70c849d6ee7cb6621d3bda857f3ed25a37511
Lib/test/test_capi/test_long.pyhttps://github.com/python/cpython/pull/145901/files#diff-cc3c55fb42d8833c85cfb69e864008af59140bcf80ac0cdd411c98688dc534c4
View file https://github.com/skirpichev/cpython/blob/45b3b040da09b93a42a32e71f08de5670f8d79d6/Lib/test/test_capi/test_long.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/145901/{{ revealButtonHref }}
https://github.com/python/cpython/pull/145901/files#diff-cc3c55fb42d8833c85cfb69e864008af59140bcf80ac0cdd411c98688dc534c4
Please reload this pagehttps://github.com/python/cpython/pull/145901/files
Please reload this pagehttps://github.com/python/cpython/pull/145901/files
skirpichevhttps://github.com/skirpichev
Mar 13, 2026https://github.com/python/cpython/pull/145901/files#r2930299248
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@corona10https://github.com/corona10
#103962https://github.com/python/cpython/pull/103962
Please reload this pagehttps://github.com/python/cpython/pull/145901/files
colesburyhttps://github.com/colesbury
Mar 17, 2026https://github.com/python/cpython/pull/145901/files#r2949272105
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/145901/files
vstinnerhttps://github.com/vstinner
Mar 31, 2026https://github.com/python/cpython/pull/145901/files#r3015523598
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/145901/files
vstinnerhttps://github.com/vstinner
Mar 31, 2026https://github.com/python/cpython/pull/145901/files#r3015577333
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/145901/files
Modules/_testcapi/immortal.chttps://github.com/python/cpython/pull/145901/files#diff-4475403bbe82b492e8ef54bc096287b1e4774931d4bfe50a196ab396d086edcd
View file https://github.com/skirpichev/cpython/blob/45b3b040da09b93a42a32e71f08de5670f8d79d6/Modules/_testcapi/immortal.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/145901/{{ revealButtonHref }}
https://github.com/python/cpython/pull/145901/files#diff-4475403bbe82b492e8ef54bc096287b1e4774931d4bfe50a196ab396d086edcd
https://github.com/python/cpython/pull/145901/files#diff-4475403bbe82b492e8ef54bc096287b1e4774931d4bfe50a196ab396d086edcd
Objects/longobject.chttps://github.com/python/cpython/pull/145901/files#diff-1a6e70e2beeecad88840c67284ac4d54a36998029244771fcc820e801390726a
View file https://github.com/skirpichev/cpython/blob/45b3b040da09b93a42a32e71f08de5670f8d79d6/Objects/longobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/145901/{{ revealButtonHref }}
https://github.com/python/cpython/pull/145901/files#diff-1a6e70e2beeecad88840c67284ac4d54a36998029244771fcc820e801390726a
Please reload this pagehttps://github.com/python/cpython/pull/145901/files
https://github.com/python/cpython/pull/145901/files#diff-1a6e70e2beeecad88840c67284ac4d54a36998029244771fcc820e801390726a
https://github.com/python/cpython/pull/145901/files#diff-1a6e70e2beeecad88840c67284ac4d54a36998029244771fcc820e801390726a
https://github.com/python/cpython/pull/145901/files#diff-1a6e70e2beeecad88840c67284ac4d54a36998029244771fcc820e801390726a
https://github.com/python/cpython/pull/145901/files#diff-1a6e70e2beeecad88840c67284ac4d54a36998029244771fcc820e801390726a
Please reload this pagehttps://github.com/python/cpython/pull/145901/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.