| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:86e063a4-5532-fb1a-6460-74b39ca38310 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 96B6:729AC:3D3FF8:53C895:6AECCD99 |
| html-safe-nonce | cfde92b386dc8d5b3ea61408d8e8892cdb65ec485931241759af21bf840916af |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkI2OjcyOUFDOjNEM0ZGODo1M0M4OTU6NkFFQ0NEOTkiLCJ2aXNpdG9yX2lkIjoiMTk5NDg1ODQzNDk5MjU5MDIzNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1323802e86431f55b053c5204c434f5e838ac4f4a631d9463232a5578feba491 |
| hovercard-subject-tag | pull_request:3388710468 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/145851/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/62f2add2ddd422c2df11a981ed331627f352c57e85b5d7df7ba33a395bfd8466/python/cpython/pull/145851 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/62f2add2ddd422c2df11a981ed331627f352c57e85b5d7df7ba33a395bfd8466/python/cpython/pull/145851 |
| og:image:alt | calling it with non-ASCII string format will now raise a ValueError instead of UnicodeEncodeError
calling it with non-ASCII bytes format will now raise a ValueError instead of struct.error
getting ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | serhiy-storchaka |
| hostname | github.com |
| expected-hostname | github.com |
| None | dc0b519c5798dc1150b88dc4c06a8b9634d0069218dc04e469970e76aad74016 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | db139f0bf57b59bf9a8c4abb0849924d6c6ca559 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/cpython/pull/145851#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F145851 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F145851 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/145851 |
| Reload | https://github.com/python/cpython/pull/145851 |
| Reload | https://github.com/python/cpython/pull/145851 |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.3k (2.3k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/pulse |
| https://github.com/python/cpython |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| python:main | https://github.com/python/cpython/tree/main |
| serhiy-storchaka:struct-format | https://github.com/serhiy-storchaka/cpython/tree/struct-format |
| Conversation | https://github.com/python/cpython/pull/145851 |
| Commits6 (6) | https://github.com/python/cpython/pull/145851/commits |
| Checks | https://github.com/python/cpython/pull/145851/checks |
| Files changed | https://github.com/python/cpython/pull/145851/files |
| gh-145850: Change some implementation details in struct.Struct | https://github.com/python/cpython/pull/145851#top |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| python:main | https://github.com/python/cpython/tree/main |
| serhiy-storchaka:struct-format | https://github.com/serhiy-storchaka/cpython/tree/struct-format |
|
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Mar 12, 2026 | https://github.com/python/cpython/pull/145851#issue-4063626989 |
| Please reload this page | https://github.com/python/cpython/pull/145851 |
| Change some implementation details in struct.Struct #145850 | https://github.com/python/cpython/issues/145850 |
| Please reload this page | https://github.com/python/cpython/pull/145851 |
|
| https://github.com/serhiy-storchaka |
| pythongh-145850 | https://github.com/python/cpython/issues/145850 |
| : Change some implementation details in struct.Struct | https://github.com/python/cpython/pull/145851/commits/fde5c160cf0df584d060b360b53610b9b263dad0 |
| fde5c16 | https://github.com/python/cpython/pull/145851/commits/fde5c160cf0df584d060b360b53610b9b263dad0 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| vstinner | https://github.com/vstinner |
| March 12, 2026 10:20 | https://github.com/python/cpython/pull/145851#event-23501853111 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
Mar 12, 2026
| https://github.com/python/cpython/pull/145851#ref-issue-4063536194 |
|
Change some implementation details in struct.Struct
#145850
| https://github.com/python/cpython/issues/145850 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Mar 12, 2026 | https://github.com/python/cpython/pull/145851#event-23501857369 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Mar 12, 2026
| https://github.com/python/cpython/pull/145851#pullrequestreview-3935642348 |
|
View reviewed changes
| https://github.com/python/cpython/pull/145851/files/fde5c160cf0df584d060b360b53610b9b263dad0 |
| vstinner | https://github.com/vstinner |
| https://github.com/python/cpython/pull/145851#pullrequestreview-3935642348 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/145851 |
| Modules/_struct.c | https://github.com/python/cpython/pull/145851/files/fde5c160cf0df584d060b360b53610b9b263dad0#diff-13025e64470dd9f01cdfcf972b3aa2712511d83f8db49d587d85b43b2946e87b |
| Please reload this page | https://github.com/python/cpython/pull/145851 |
| Modules/_struct.c | https://github.com/python/cpython/pull/145851/files/fde5c160cf0df584d060b360b53610b9b263dad0#diff-13025e64470dd9f01cdfcf972b3aa2712511d83f8db49d587d85b43b2946e87b |
| Please reload this page | https://github.com/python/cpython/pull/145851 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| March 12, 2026 14:16 | https://github.com/python/cpython/pull/145851#commits-pushed-f22d34d |
|
| https://github.com/serhiy-storchaka |
| Use PyUnicode_FromObject() instead of _PyUnicode_Copy(). | https://github.com/python/cpython/pull/145851/commits/f22d34d6ad3e1f9839fe4f1fff247f13004441b4 |
| f22d34d | https://github.com/python/cpython/pull/145851/commits/f22d34d6ad3e1f9839fe4f1fff247f13004441b4 |
|
| https://github.com/serhiy-storchaka |
| Raise ValueError instead of UnicodeDecodeError. | https://github.com/python/cpython/pull/145851/commits/330181b674994ae674bfdbbf16e2a71eb59da8d0 |
| 330181b | https://github.com/python/cpython/pull/145851/commits/330181b674994ae674bfdbbf16e2a71eb59da8d0 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
|
Mar 12, 2026
| https://github.com/python/cpython/pull/145851#pullrequestreview-3936171361 |
|
View reviewed changes
| https://github.com/python/cpython/pull/145851/files/fde5c160cf0df584d060b360b53610b9b263dad0 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| https://github.com/python/cpython/pull/145851#pullrequestreview-3936171361 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @vstinner | https://github.com/vstinner |
| Please reload this page | https://github.com/python/cpython/pull/145851 |
| Modules/_struct.c | https://github.com/python/cpython/pull/145851/files/fde5c160cf0df584d060b360b53610b9b263dad0#diff-13025e64470dd9f01cdfcf972b3aa2712511d83f8db49d587d85b43b2946e87b |
| Please reload this page | https://github.com/python/cpython/pull/145851 |
| Modules/_struct.c | https://github.com/python/cpython/pull/145851/files/fde5c160cf0df584d060b360b53610b9b263dad0#diff-13025e64470dd9f01cdfcf972b3aa2712511d83f8db49d587d85b43b2946e87b |
| Please reload this page | https://github.com/python/cpython/pull/145851 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Mar 12, 2026
| https://github.com/python/cpython/pull/145851#pullrequestreview-3936310031 |
|
View reviewed changes
| https://github.com/python/cpython/pull/145851/files/7e8632d58d6cbdf1e48d07f02b9a03c4f7fa2cfe |
| vstinner | https://github.com/vstinner |
| https://github.com/python/cpython/pull/145851#pullrequestreview-3936310031 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/145851 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Mar 12, 2026 | https://github.com/python/cpython/pull/145851#event-23506538324 |
| https://github.com/jukarivalladares-boop |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F145851 |
| Please reload this page | https://github.com/python/cpython/pull/145851 |
|
| https://github.com/serhiy-storchaka |
| Merge branch 'main' into struct-format | https://github.com/python/cpython/pull/145851/commits/7e8632d58d6cbdf1e48d07f02b9a03c4f7fa2cfe |
| 7e8632d | https://github.com/python/cpython/pull/145851/commits/7e8632d58d6cbdf1e48d07f02b9a03c4f7fa2cfe |
| https://github.com/StanFromIreland |
| StanFromIreland | https://github.com/StanFromIreland |
| Mar 12, 2026 | https://github.com/python/cpython/pull/145851#issuecomment-4047837953 |
| https://github.com/python/cpython/actions/runs/23007198595/artifacts/5892860339 | https://github.com/python/cpython/actions/runs/23007198595/artifacts/5892860339 |
| Please reload this page | https://github.com/python/cpython/pull/145851 |
| https://github.com/StanFromIreland |
| StanFromIreland | https://github.com/StanFromIreland |
| Mar 12, 2026 | https://github.com/python/cpython/pull/145851#issuecomment-4047890764 |
| cpython/Modules/_xxtestfuzz/fuzzer.c | https://github.com/python/cpython/blob/d4cc553294a558d632a2f69523eb04fa8c51f1a7/Modules/_xxtestfuzz/fuzzer.c#L136 |
| d4cc553 | https://github.com/python/cpython/commit/d4cc553294a558d632a2f69523eb04fa8c51f1a7 |
| Please reload this page | https://github.com/python/cpython/pull/145851 |
|
| https://github.com/serhiy-storchaka |
| Fix the fuzzing tests. | https://github.com/python/cpython/pull/145851/commits/1cce527deb2e332d75611b32453fb66e65a8b1ab |
| 1cce527 | https://github.com/python/cpython/pull/145851/commits/1cce527deb2e332d75611b32453fb66e65a8b1ab |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Mar 12, 2026 | https://github.com/python/cpython/pull/145851#issuecomment-4048434089 |
| @StanFromIreland | https://github.com/StanFromIreland |
| Please reload this page | https://github.com/python/cpython/pull/145851 |
|
| https://github.com/serhiy-storchaka |
| Merge branch 'struct-format' of github.com:serhiy-storchaka/cpython i… | https://github.com/python/cpython/pull/145851/commits/9cedd03cda6fed25363460e067b549ceae3872fb |
| 9cedd03 | https://github.com/python/cpython/pull/145851/commits/9cedd03cda6fed25363460e067b549ceae3872fb |
| https://github.com/StanFromIreland |
| StanFromIreland | https://github.com/StanFromIreland |
|
Mar 13, 2026
| https://github.com/python/cpython/pull/145851#pullrequestreview-3942200423 |
|
View reviewed changes
| https://github.com/python/cpython/pull/145851/files/9cedd03cda6fed25363460e067b549ceae3872fb |
| StanFromIreland | https://github.com/StanFromIreland |
| https://github.com/python/cpython/pull/145851#pullrequestreview-3942200423 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/145851 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| Mar 13, 2026 | https://github.com/python/cpython/pull/145851#issuecomment-4053391362 |
| Please reload this page | https://github.com/python/cpython/pull/145851 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| 962fb87 | https://github.com/python/cpython/commit/962fb872ebd97ab6ab808a1b8e2034577e5501bf |
| Mar 13, 2026 | https://github.com/python/cpython/pull/145851#event-23541995500 |
| Please reload this page | https://github.com/python/cpython/pull/145851 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Mar 13, 2026 | https://github.com/python/cpython/pull/145851#event-23541996781 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| March 13, 2026 11:28 | https://github.com/python/cpython/pull/145851#event-23542647173 |
| ljfp | https://github.com/ljfp |
|
Apr 25, 2026
| https://github.com/python/cpython/pull/145851#ref-commit-3b2ad21 |
|
| https://github.com/serhiy-storchaka |
|
| https://github.com/ljfp |
| pythongh-145850 | https://github.com/python/cpython/issues/145850 |
| : Change some implementation details in struct.Struct ( | https://github.com/ljfp/cpython/commit/3b2ad21d38b6507773d55bf556c6288b2a948be8 |
| p… | https://github.com/python/cpython/pull/145851 |
| 3b2ad21 | https://github.com/ljfp/cpython/commit/3b2ad21d38b6507773d55bf556c6288b2a948be8 |
| …ythonGH-145851 | https://github.com/python/cpython/pull/145851 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F145851 |
|
| https://github.com/vstinner |
|
vstinner
| https://github.com/vstinner |
|
| https://github.com/python/cpython/pull/145851/files/7e8632d58d6cbdf1e48d07f02b9a03c4f7fa2cfe |
|
| https://github.com/StanFromIreland |
|
StanFromIreland
| https://github.com/StanFromIreland |
|
| https://github.com/python/cpython/pull/145851/files/9cedd03cda6fed25363460e067b549ceae3872fb |
|
| https://github.com/jukarivalladares-boop |
|
jukarivalladares-boop
| https://github.com/jukarivalladares-boop |
|
| https://github.com/python/cpython/pull/145851/files/330181b674994ae674bfdbbf16e2a71eb59da8d0 |
| Please reload this page | https://github.com/python/cpython/pull/145851 |
| Please reload this page | https://github.com/python/cpython/pull/145851 |
|
| https://github.com/serhiy-storchaka |
|
| https://github.com/StanFromIreland |
|
| https://github.com/vstinner |
|
| https://github.com/jukarivalladares-boop |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |