René's URL Explorer Experiment


Title: gh-145743: Fix inconsistency after calling Struct.__init__() with invalid format by serhiy-storchaka · Pull Request #145744 · python/cpython · GitHub

Open Graph Title: gh-145743: Fix inconsistency after calling Struct.__init__() with invalid format by serhiy-storchaka · Pull Request #145744 · python/cpython

X Title: gh-145743: Fix inconsistency after calling Struct.__init__() with invalid format by serhiy-storchaka · Pull Request #145744 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Only set the format attribute after successful (re-)initialization. Issue: Struct.__init__() can leave the Struct object in inconsistent state #145743

X Description: Only set the format attribute after successful (re-)initialization. Issue: Struct.__init__() can leave the Struct object in inconsistent state #145743

Opengraph URL: https://github.com/python/cpython/pull/145744

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ef21514a-a300-d868-b35d-16b14d1ebf1a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAAFA:94B88:51DEEF:6E7977:6AECCF75
html-safe-noncecec51730d0c55240f40a2c7125fd780c5b689f101314f36f25056aee782253e1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQUZBOjk0Qjg4OjUxREVFRjo2RTc5Nzc6NkFFQ0NGNzUiLCJ2aXNpdG9yX2lkIjoiMjg1OTMzODgyMjI4NzQxMzEwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6005cb4446eba232ea8d028903a7cee68cc6681bf4724f139b2627e092ded3da
hovercard-subject-tagpull_request:3378421500
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/145744/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/df802fe0b1f399ce15a4c55f90df18aae064a97cbf9492f5c5327c357304ae00/python/cpython/pull/145744
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/df802fe0b1f399ce15a4c55f90df18aae064a97cbf9492f5c5327c357304ae00/python/cpython/pull/145744
og:image:altOnly set the format attribute after successful (re-)initialization. Issue: Struct.__init__() can leave the Struct object in inconsistent state #145743
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameserhiy-storchaka
hostnamegithub.com
expected-hostnamegithub.com
None0d8e13d765457347e0bc9664aa9103874b0a754f8a1ffe4e190178ab258dd8cc
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee2ab5c9355284de552dd38ea36155a4fa132df68
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/145744#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F145744
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F145744
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/145744
Reloadhttps://github.com/python/cpython/pull/145744
Reloadhttps://github.com/python/cpython/pull/145744
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.3k (2.3k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/pulse
https://github.com/python/cpython
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
serhiy-storchaka:struct-reinitialization-consistencyhttps://github.com/serhiy-storchaka/cpython/tree/struct-reinitialization-consistency
Conversationhttps://github.com/python/cpython/pull/145744
Commits2 (2)https://github.com/python/cpython/pull/145744/commits
Checkshttps://github.com/python/cpython/pull/145744/checks
Files changedhttps://github.com/python/cpython/pull/145744/files
gh-145743: Fix inconsistency after calling Struct.__init__() with invalid formathttps://github.com/python/cpython/pull/145744#top
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
serhiy-storchaka:struct-reinitialization-consistencyhttps://github.com/serhiy-storchaka/cpython/tree/struct-reinitialization-consistency
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Mar 10, 2026https://github.com/python/cpython/pull/145744#issue-4051476432
Please reload this pagehttps://github.com/python/cpython/pull/145744
Struct.__init__() can leave the Struct object in inconsistent state #145743https://github.com/python/cpython/issues/145743
Please reload this pagehttps://github.com/python/cpython/pull/145744
https://github.com/serhiy-storchaka
pythongh-145743https://github.com/python/cpython/issues/145743
: Fix inconsistancy after calling Struct.__init__() wi…https://github.com/python/cpython/pull/145744/commits/7336aaad1a7458630089c4aecc8806b15ec64b23
7336aaahttps://github.com/python/cpython/pull/145744/commits/7336aaad1a7458630089c4aecc8806b15ec64b23
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Mar 10, 2026https://github.com/python/cpython/pull/145744#event-23430488206
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Mar 10, 2026 https://github.com/python/cpython/pull/145744#ref-issue-4051449589
Struct.__init__() can leave the Struct object in inconsistent state #145743 https://github.com/python/cpython/issues/145743
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Mar 10, 2026https://github.com/python/cpython/pull/145744#event-23430492118
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Mar 10, 2026 https://github.com/python/cpython/pull/145744#ref-pullrequest-4033066403
gh-143715: Deprecate incomplete initialization of struct.Struct() #145580 https://github.com/python/cpython/pull/145580
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Mar 10, 2026 https://github.com/python/cpython/pull/145744#pullrequestreview-3922099870
View reviewed changes https://github.com/python/cpython/pull/145744/files/7336aaad1a7458630089c4aecc8806b15ec64b23
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/145744#pullrequestreview-3922099870
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/145744
Modules/_struct.chttps://github.com/python/cpython/pull/145744/files/7336aaad1a7458630089c4aecc8806b15ec64b23#diff-13025e64470dd9f01cdfcf972b3aa2712511d83f8db49d587d85b43b2946e87b
Please reload this pagehttps://github.com/python/cpython/pull/145744
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Mar 10, 2026https://github.com/python/cpython/pull/145744#event-23430854206
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Mar 10, 2026https://github.com/python/cpython/pull/145744#event-23430866063
https://github.com/serhiy-storchaka
https://github.com/vstinner
Update Modules/_struct.chttps://github.com/python/cpython/pull/145744/commits/a23f9bb13d3b70d4db72f4a64d6de2cc7b7c5b3f
a23f9bbhttps://github.com/python/cpython/pull/145744/commits/a23f9bb13d3b70d4db72f4a64d6de2cc7b7c5b3f
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
3f33bf8https://github.com/python/cpython/commit/3f33bf83e8496737b86333bc9ec55dc3ccb3faca
Mar 10, 2026https://github.com/python/cpython/pull/145744#event-23439062960
Please reload this pagehttps://github.com/python/cpython/pull/145744
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Mar 10, 2026https://github.com/python/cpython/pull/145744#event-23439065760
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Mar 10, 2026https://github.com/python/cpython/pull/145744#issuecomment-4032796622
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/145744
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
March 10, 2026 16:29https://github.com/python/cpython/pull/145744#event-23439066302
miss-islingtonhttps://github.com/miss-islington
Mar 10, 2026 https://github.com/python/cpython/pull/145744#ref-commit-6ab0473
https://github.com/serhiy-storchaka
https://github.com/miss-islington
pythongh-145743https://github.com/python/cpython/issues/145743
: Fix inconsistency after calling Struct.__init__() wi…https://github.com/miss-islington/cpython/commit/6ab04737ef9abf5f867b46070ae80c508d9d54d5
6ab0473https://github.com/miss-islington/cpython/commit/6ab04737ef9abf5f867b46070ae80c508d9d54d5
pythonGH-145744https://github.com/python/cpython/pull/145744
3f33bf8https://github.com/miss-islington/cpython/commit/3f33bf83e8496737b86333bc9ec55dc3ccb3faca
miss-islingtonhttps://github.com/miss-islington
Mar 10, 2026 https://github.com/python/cpython/pull/145744#ref-commit-c9ade5e
https://github.com/serhiy-storchaka
https://github.com/miss-islington
pythongh-145743https://github.com/python/cpython/issues/145743
: Fix inconsistency after calling Struct.__init__() wi…https://github.com/miss-islington/cpython/commit/c9ade5e6be7ffec47f10d6d59818998bf03125a8
c9ade5ehttps://github.com/miss-islington/cpython/commit/c9ade5e6be7ffec47f10d6d59818998bf03125a8
pythonGH-145744https://github.com/python/cpython/pull/145744
3f33bf8https://github.com/miss-islington/cpython/commit/3f33bf83e8496737b86333bc9ec55dc3ccb3faca
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Mar 10, 2026https://github.com/python/cpython/pull/145744#issuecomment-4032798022
GH-145763https://github.com/python/cpython/pull/145763
3.14 branchhttps://github.com/python/cpython/tree/3.14
Please reload this pagehttps://github.com/python/cpython/pull/145744
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
Mar 10, 2026https://github.com/python/cpython/pull/145744#event-23439074023
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Mar 10, 2026https://github.com/python/cpython/pull/145744#issuecomment-4032798507
GH-145764https://github.com/python/cpython/pull/145764
3.13 branchhttps://github.com/python/cpython/tree/3.13
Please reload this pagehttps://github.com/python/cpython/pull/145744
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Mar 10, 2026https://github.com/python/cpython/pull/145744#event-23439076443
serhiy-storchakahttps://github.com/serhiy-storchaka
Mar 10, 2026 https://github.com/python/cpython/pull/145744#ref-commit-b5082d8
https://github.com/miss-islington
https://github.com/serhiy-storchaka
[3.13]https://github.com/python/cpython/commit/b5082d89cc90986776323fcaaf89e14a96e8e04b
gh-145743https://github.com/python/cpython/issues/145743
: Fix inconsistency after calling Struct.__init__() w…https://github.com/python/cpython/commit/b5082d89cc90986776323fcaaf89e14a96e8e04b
b5082d8https://github.com/python/cpython/commit/b5082d89cc90986776323fcaaf89e14a96e8e04b
GH-145744https://github.com/python/cpython/pull/145744
GH-145764https://github.com/python/cpython/pull/145764
3f33bf8https://github.com/python/cpython/commit/3f33bf83e8496737b86333bc9ec55dc3ccb3faca
serhiy-storchakahttps://github.com/serhiy-storchaka
Mar 10, 2026 https://github.com/python/cpython/pull/145744#ref-commit-7e38926
https://github.com/miss-islington
https://github.com/serhiy-storchaka
[3.14]https://github.com/python/cpython/commit/7e389260aa3a1b56c1b986c1ed9ef180d645ede0
gh-145743https://github.com/python/cpython/issues/145743
: Fix inconsistency after calling Struct.__init__() w…https://github.com/python/cpython/commit/7e389260aa3a1b56c1b986c1ed9ef180d645ede0
7e38926https://github.com/python/cpython/commit/7e389260aa3a1b56c1b986c1ed9ef180d645ede0
GH-145744https://github.com/python/cpython/pull/145744
GH-145763https://github.com/python/cpython/pull/145763
3f33bf8https://github.com/python/cpython/commit/3f33bf83e8496737b86333bc9ec55dc3ccb3faca
ljfphttps://github.com/ljfp
Apr 25, 2026 https://github.com/python/cpython/pull/145744#ref-commit-1c1c04c
https://github.com/serhiy-storchaka
https://github.com/ljfp
pythongh-145743https://github.com/python/cpython/issues/145743
: Fix inconsistency after calling Struct.__init__() wi…https://github.com/ljfp/cpython/commit/1c1c04c0fe637c9d51d332ac3cbe08a8ebfa6232
1c1c04chttps://github.com/ljfp/cpython/commit/1c1c04c0fe637c9d51d332ac3cbe08a8ebfa6232
pythonGH-145744https://github.com/python/cpython/pull/145744
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F145744
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/145744/files/7336aaad1a7458630089c4aecc8806b15ec64b23
Please reload this pagehttps://github.com/python/cpython/pull/145744
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/145744
https://github.com/serhiy-storchaka
https://github.com/vstinner
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.