René's URL Explorer Experiment


Title: bpo-19696: Move threaded import tests to dir test_importlib/ by aeros · Pull Request #14537 · python/cpython · GitHub

Open Graph Title: bpo-19696: Move threaded import tests to dir test_importlib/ by aeros · Pull Request #14537 · python/cpython

X Title: bpo-19696: Move threaded import tests to dir test_importlib/ by aeros · Pull Request #14537 · python/cpython

Description: This is the final component of issue 19696. This PR includes both test_threaded_import.py and threaded_import_hangers.py because the hangers are required for the threaded import test, so the two files are directly related. I'm not sure as to why the changes can't be automatically merged, the previous file move I had done had no issues with that. Is it due to more than one file being moved in a single PR? There's a minor typo in one of the commit messages ("theaded" instead of "threaded"), but there were no issues with the file moves. Is it possible to edit the commit messages? If this typo is an issue and there's no way of editing the commit messages, I can create a new branch, redo the changes, and submit another PR. Since this is just a file move, a "skip news" label would likely be appropriate. https://bugs.python.org/issue19696

Open Graph Description: This is the final component of issue 19696. This PR includes both test_threaded_import.py and threaded_import_hangers.py because the hangers are required for the threaded import test, so the two fi...

X Description: This is the final component of issue 19696. This PR includes both test_threaded_import.py and threaded_import_hangers.py because the hangers are required for the threaded import test, so the two fi...

Opengraph URL: https://github.com/python/cpython/pull/14537

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:cc94ef24-7311-74eb-af41-661b0c212237
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD70:2D523B:1B57F5F:254E563:6A5371DE
html-safe-noncee0749909c90a9eef41caad7da28d3f0374fd6f86165bd3a9f11aeafcb8bb006f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDcwOjJENTIzQjoxQjU3RjVGOjI1NEU1NjM6NkE1MzcxREUiLCJ2aXNpdG9yX2lkIjoiNjEyNjExMjIzMzQ3Mjg4MTExOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc6964e771717cb6c72c38d617473808621cc4dcaabe95ee172c4b146f2b1b32e
hovercard-subject-tagpull_request:293531091
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/14537/files
twitter:imagehttps://avatars.githubusercontent.com/u/44193521?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/44193521?s=400&v=4
og:image:altThis is the final component of issue 19696. This PR includes both test_threaded_import.py and threaded_import_hangers.py because the hangers are required for the threaded import test, so the two fi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/14537/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F14537%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F14537%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/14537/files
Reloadhttps://github.com/python/cpython/pull/14537/files
Reloadhttps://github.com/python/cpython/pull/14537/files
Please reload this pagehttps://github.com/python/cpython/pull/14537/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/14537/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
aeroshttps://github.com/aeros
python:masterhttps://github.com/python/cpython/tree/master
aeros:move-threaded_importhttps://github.com/aeros/cpython/tree/move-threaded_import
Conversation 4 https://github.com/python/cpython/pull/14537
Commits 7 https://github.com/python/cpython/pull/14537/commits
Checks 0 https://github.com/python/cpython/pull/14537/checks
Files changed https://github.com/python/cpython/pull/14537/files
Please reload this pagehttps://github.com/python/cpython/pull/14537/files
bpo-19696: Move threaded import tests to dir test_importlib/ https://github.com/python/cpython/pull/14537/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/14537/files
10d1b9b Move test_threaded_import.py to dir test_importlib/ aeros Jul 1, 2019 https://github.com/python/cpython/pull/14537/commits/10d1b9bda5c67273a8dcc79fc85373af54fded44
c9c738c Move theaded_import_hangers.py to dir test_importlib/ aeros Jul 1, 2019 https://github.com/python/cpython/pull/14537/commits/c9c738c9767af3086f74c3139f82480df0de0105
bba2151 Updated threaded_import_hangers import aeros Jul 2, 2019 https://github.com/python/cpython/pull/14537/commits/bba2151d3c9027191b7fda526c89360ee424ebf0
eafbd37 Update other references to "threaded_import_hangers" aeros Jul 2, 2019 https://github.com/python/cpython/pull/14537/commits/eafbd37bcacee31e0c96154fd40637673973bcb5
37f459e Update reference to threaded_import_hangers.py aeros Jul 2, 2019 https://github.com/python/cpython/pull/14537/commits/37f459e23f43629bf24415ad75b1ad7d9f816903
6ace114 Update reference to test_threaded_import.py aeros Jul 2, 2019 https://github.com/python/cpython/pull/14537/commits/6ace1140ff317b13ea112cc52ea4b8d2dd8f8353
cf5e677 Updated reference to test_pkgimport.py aeros Jul 2, 2019 https://github.com/python/cpython/pull/14537/commits/cf5e6777c44c7fefd24bdb69d4fc8724e13ed9c8
Clear filters https://github.com/python/cpython/pull/14537/files
Please reload this pagehttps://github.com/python/cpython/pull/14537/files
Please reload this pagehttps://github.com/python/cpython/pull/14537/files
test_threaded_import.py https://github.com/python/cpython/pull/14537/files#diff-a1e554f578aaaf3a7232078affdd527a19c86b178d8e3df84de287d335804ab1
threaded_import_hangers.py https://github.com/python/cpython/pull/14537/files#diff-2d1a0c5a7cce25b216643b78d288c62133aed9b8f3caf9464d4f6d7556420c0a
lib.pyproj https://github.com/python/cpython/pull/14537/files#diff-8b264d5a3d562fe10f3e28a59a223e1e74938149b065b666603bd05fddb1250b
Lib/test/test_threaded_import.py → ...st/test_importlib/test_threaded_import.pyhttps://github.com/python/cpython/pull/14537/files#diff-a1e554f578aaaf3a7232078affdd527a19c86b178d8e3df84de287d335804ab1
View file https://github.com/aeros/cpython/blob/cf5e6777c44c7fefd24bdb69d4fc8724e13ed9c8/Lib/test/test_importlib/test_threaded_import.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/14537/{{ revealButtonHref }}
https://github.com/python/cpython/pull/14537/files#diff-a1e554f578aaaf3a7232078affdd527a19c86b178d8e3df84de287d335804ab1
https://github.com/python/cpython/pull/14537/files#diff-a1e554f578aaaf3a7232078affdd527a19c86b178d8e3df84de287d335804ab1
Lib/test/threaded_import_hangers.py → ...test_importlib/threaded_import_hangers.pyhttps://github.com/python/cpython/pull/14537/files#diff-2d1a0c5a7cce25b216643b78d288c62133aed9b8f3caf9464d4f6d7556420c0a
View file https://github.com/aeros/cpython/blob/cf5e6777c44c7fefd24bdb69d4fc8724e13ed9c8/Lib/test/test_importlib/threaded_import_hangers.py
Open in desktop https://desktop.github.com
PCbuild/lib.pyprojhttps://github.com/python/cpython/pull/14537/files#diff-8b264d5a3d562fe10f3e28a59a223e1e74938149b065b666603bd05fddb1250b
View file https://github.com/aeros/cpython/blob/cf5e6777c44c7fefd24bdb69d4fc8724e13ed9c8/PCbuild/lib.pyproj
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/14537/{{ revealButtonHref }}
https://github.com/python/cpython/pull/14537/files#diff-8b264d5a3d562fe10f3e28a59a223e1e74938149b065b666603bd05fddb1250b
https://github.com/python/cpython/pull/14537/files#diff-8b264d5a3d562fe10f3e28a59a223e1e74938149b065b666603bd05fddb1250b
https://github.com/python/cpython/pull/14537/files#diff-8b264d5a3d562fe10f3e28a59a223e1e74938149b065b666603bd05fddb1250b
https://github.com/python/cpython/pull/14537/files#diff-8b264d5a3d562fe10f3e28a59a223e1e74938149b065b666603bd05fddb1250b
https://github.com/python/cpython/pull/14537/files#diff-8b264d5a3d562fe10f3e28a59a223e1e74938149b065b666603bd05fddb1250b
https://github.com/python/cpython/pull/14537/files#diff-8b264d5a3d562fe10f3e28a59a223e1e74938149b065b666603bd05fddb1250b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.