René's URL Explorer Experiment


Title: gh-144475: Fix a heap buffer overflow in partial_repr by brijkapadia · Pull Request #145362 · python/cpython · GitHub

Open Graph Title: gh-144475: Fix a heap buffer overflow in partial_repr by brijkapadia · Pull Request #145362 · python/cpython

X Title: gh-144475: Fix a heap buffer overflow in partial_repr by brijkapadia · Pull Request #145362 · python/cpython

Description: This is a cleaner version of PR #144571. I am not exactly sure what happened in #144571 so I would appreciate if anyone could tell me so I don't make the same mistake again. Here are the changes I made: I added an args and kw local pointer so that both live long enough during the call to repr to prevent a segfault I added an fn local pointer so that repr uses its original state when generating its final representation. I got rid of the error goto and merged it with the done goto as I needed to decrement the reference count of fn, args, and kw, and I found that decrementing them in the done goto was the easiest. I added a test based on @Qanux's original code. I extended it to also check for changes in the fn and kw arguments. Issue: gh-144475

Open Graph Description: This is a cleaner version of PR #144571. I am not exactly sure what happened in #144571 so I would appreciate if anyone could tell me so I don't make the same mistake again. Here are the change...

X Description: This is a cleaner version of PR #144571. I am not exactly sure what happened in #144571 so I would appreciate if anyone could tell me so I don't make the same mistake again. Here are the ch...

Opengraph URL: https://github.com/python/cpython/pull/145362

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:af6f70c9-3388-349e-dbc9-6f558a5573bf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD7A:47EDE:4D0E75E:6C9B1E1:6A500FAC
html-safe-nonceccc2c79f69a095ba6692d2c0d46a438655f12cf5b205403b86ad5650a407eeb0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDdBOjQ3RURFOjREMEU3NUU6NkM5QjFFMTo2QTUwMEZBQyIsInZpc2l0b3JfaWQiOiI2NDc2NjE0NjIzMTg5NTM2Njg0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac838f526dce22f903b8db3b15d74e8c8b495cb4ba1c7356b718e66ac5820c6cc0
hovercard-subject-tagpull_request:3338984462
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/145362/files
twitter:imagehttps://avatars.githubusercontent.com/u/97006829?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/97006829?s=400&v=4
og:image:altThis is a cleaner version of PR #144571. I am not exactly sure what happened in #144571 so I would appreciate if anyone could tell me so I don't make the same mistake again. Here are the change...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonefe4f38b24922a1ce81c1708c3793b47c185599b9144ab94f6ca846b00698058d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release42b6390c91978a16f9196c38c7a00e9bf21f37e7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/145362/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F145362%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F145362%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/145362/files
Reloadhttps://github.com/python/cpython/pull/145362/files
Reloadhttps://github.com/python/cpython/pull/145362/files
Please reload this pagehttps://github.com/python/cpython/pull/145362/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/145362/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
brijkapadia:partial-reprhttps://github.com/brijkapadia/cpython/tree/partial-repr
Conversation 14 https://github.com/python/cpython/pull/145362
Commits 5 https://github.com/python/cpython/pull/145362/commits
Checks 57 https://github.com/python/cpython/pull/145362/checks
Files changed https://github.com/python/cpython/pull/145362/files
Please reload this pagehttps://github.com/python/cpython/pull/145362/files
gh-144475: Fix a heap buffer overflow in partial_repr https://github.com/python/cpython/pull/145362/files#top
Show all changes 5 commits https://github.com/python/cpython/pull/145362/files
7a5456c gh-144475: Fix a heap buffer overflow in partial_repr (v2) brijkapadia Feb 28, 2026 https://github.com/python/cpython/pull/145362/commits/7a5456ca5e3e1fca138dfc7948e02055e3cd5308
7b4955f small changes brijkapadia Feb 28, 2026 https://github.com/python/cpython/pull/145362/commits/7b4955f495962b318dc3e603a495f88a864e0034
543d44c Update test_functools.py brijkapadia Feb 28, 2026 https://github.com/python/cpython/pull/145362/commits/543d44c9356b4315f14b11235336060cc55ee7f6
74b98ca move declaration brijkapadia Mar 3, 2026 https://github.com/python/cpython/pull/145362/commits/74b98caecaabc806ae8550775ea16d0dda254b94
ef0ffb3 Reword NEWS & move to Library encukou Mar 3, 2026 https://github.com/python/cpython/pull/145362/commits/ef0ffb3f42f704404028b3528142c1553b7ae249
Clear filters https://github.com/python/cpython/pull/145362/files
Please reload this pagehttps://github.com/python/cpython/pull/145362/files
Please reload this pagehttps://github.com/python/cpython/pull/145362/files
test_functools.py https://github.com/python/cpython/pull/145362/files#diff-d6d3bf2c98d5abf2efefac777e6edc9e571f4af579e71c1ce4d500c2045aa546
2026-02-07-16-37-42.gh-issue-144475.8tFEXw.rst https://github.com/python/cpython/pull/145362/files#diff-e14dd0cbd0f4a7fcf787939810612fa000231854e118f488c3801d1ee8029815
_functoolsmodule.c https://github.com/python/cpython/pull/145362/files#diff-d1deea0fb29260d389bac1b24c3ec3631e843d177e85c0e93d5cf50966dee630
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L476
Lib/test/test_functools.pyhttps://github.com/python/cpython/pull/145362/files#diff-d6d3bf2c98d5abf2efefac777e6edc9e571f4af579e71c1ce4d500c2045aa546
View file https://github.com/brijkapadia/cpython/blob/ef0ffb3f42f704404028b3528142c1553b7ae249/Lib/test/test_functools.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/145362/{{ revealButtonHref }}
https://github.com/python/cpython/pull/145362/files#diff-d6d3bf2c98d5abf2efefac777e6edc9e571f4af579e71c1ce4d500c2045aa546
https://github.com/python/cpython/pull/145362/files#diff-d6d3bf2c98d5abf2efefac777e6edc9e571f4af579e71c1ce4d500c2045aa546
Misc/NEWS.d/next/Library/2026-02-07-16-37-42.gh-issue-144475.8tFEXw.rsthttps://github.com/python/cpython/pull/145362/files#diff-e14dd0cbd0f4a7fcf787939810612fa000231854e118f488c3801d1ee8029815
View file https://github.com/brijkapadia/cpython/blob/ef0ffb3f42f704404028b3528142c1553b7ae249/Misc/NEWS.d/next/Library/2026-02-07-16-37-42.gh-issue-144475.8tFEXw.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/145362/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L477
Modules/_functoolsmodule.chttps://github.com/python/cpython/pull/145362/files#diff-d1deea0fb29260d389bac1b24c3ec3631e843d177e85c0e93d5cf50966dee630
View file https://github.com/brijkapadia/cpython/blob/ef0ffb3f42f704404028b3528142c1553b7ae249/Modules/_functoolsmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/145362/{{ revealButtonHref }}
https://github.com/python/cpython/pull/145362/files#diff-d1deea0fb29260d389bac1b24c3ec3631e843d177e85c0e93d5cf50966dee630
encukouhttps://github.com/encukou
Mar 2, 2026https://github.com/python/cpython/pull/145362/files#r2872869856
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
PyDict_Next docshttps://docs.python.org/3/c-api/dict.html#c.PyDict_Next
Please reload this pagehttps://github.com/python/cpython/pull/145362/files
brijkapadiahttps://github.com/brijkapadia
Mar 2, 2026https://github.com/python/cpython/pull/145362/files#r2875034635
Please reload this pagehttps://github.com/python/cpython/pull/145362/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/145362/files
encukouhttps://github.com/encukou
Mar 3, 2026https://github.com/python/cpython/pull/145362/files#r2878191257
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/145362/files
https://github.com/python/cpython/pull/145362/files#diff-d1deea0fb29260d389bac1b24c3ec3631e843d177e85c0e93d5cf50966dee630
Please reload this pagehttps://github.com/python/cpython/pull/145362/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.