René's URL Explorer Experiment


Title: gh-145301: Fix double-free in hashlib and hmac module initialization by krylosov-aa · Pull Request #145321 · python/cpython · GitHub

Open Graph Title: gh-145301: Fix double-free in hashlib and hmac module initialization by krylosov-aa · Pull Request #145321 · python/cpython

X Title: gh-145301: Fix double-free in hashlib and hmac module initialization by krylosov-aa · Pull Request #145321 · python/cpython

Description: Both hashlib and hmac modules have similar double-free bugs in their hashtable initialization code. Problem hashlib In py_hashentry_table_new(), when _Py_hashtable_set() fails while adding an entry by its py_alias key (after successfully adding it by py_name), the code calls PyMem_Free(entry) before goto error. The error handler then calls _Py_hashtable_destroy() which frees the same entry again via py_hashentry_t_destroy_value(). hmac In py_hmac_hinfo_ht_new(), the Py_HMAC_HINFO_LINK macro has the same issue. When py_hmac_hinfo_ht_add() fails for hashlib_name key (after successfully adding name), the code calls PyMem_Free(value) while the entry is already in the hashtable with refcnt=1. Solution hashlib Remove the manual PyMem_Free(entry) call since the entry is already tracked by the hashtable under the py_name key and will be properly freed by _Py_hashtable_destroy(). hmac Add a refcnt check before freeing: only call PyMem_Free(value) if value->refcnt == 0 (meaning it was never added to the table). If refcnt > 0, the entry is already in the table and will be freed by _Py_hashtable_destroy(). Tests No test added. I couldn't find a practical way to trigger this bug since it requires _Py_hashtable_set() to fail during module initialization. This type of bug is best caught by sanitizers rather than unit tests. The fix can be verified by running the reproducer provided by the issue author: Build with ASan: mkdir build-asan && cd build-asan ../configure --with-pydebug --with-address-sanitizer --without-pymalloc make -j$(nproc) Reproducer script (uaf_asan.py): import subprocess import sys code = ( "import sys, _testcapi\n" "if '_hashlib' in sys.modules:\n" " del sys.modules['_hashlib']\n" "_testcapi.set_nomemory(40, 41)\n" "try:\n" " import _hashlib\n" "except (MemoryError, ImportError):\n" " pass\n" "finally:\n" " _testcapi.remove_mem_hooks()\n" ) result = subprocess.run( [sys.executable, '-c', code], capture_output=True, text=True, timeout=10 ) if result.returncode != 0: print(f"[*] CRASH confirmed (rc={result.returncode})") print(f"[*] {result.stderr.strip().split(chr(10))[-1]}") else: print("[*] No crash (try different start values)") Before fix: $ ./build-asan/python uaf_asan.py [*] CRASH confirmed (rc=-6) [*] python: ../Include/internal/pycore_stackref.h:554: PyStackRef_FromPyObjectSteal: Assertion `obj != NULL' failed. After fix: No crash. Issue: gh-145301

Open Graph Description: Both hashlib and hmac modules have similar double-free bugs in their hashtable initialization code. Problem hashlib In py_hashentry_table_new(), when _Py_hashtable_set() fails while adding an entry...

X Description: Both hashlib and hmac modules have similar double-free bugs in their hashtable initialization code. Problem hashlib In py_hashentry_table_new(), when _Py_hashtable_set() fails while adding an entry...

Opengraph URL: https://github.com/python/cpython/pull/145321

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3a044c03-6d1a-2a5b-8bd3-2c23ada0921d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE39C:29FFA9:40C205E:51EB14E:6B0218DD
html-safe-nonce1fa6d116b99acfc444d4c2af332a20f5511b17136b25c974ca59e98115b4511f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzlDOjI5RkZBOTo0MEMyMDVFOjUxRUIxNEU6NkIwMjE4REQiLCJ2aXNpdG9yX2lkIjoiMTQ3MTUyMzU0MTkyNDA1OTM1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1aa03ffa03a0a79152c9eae60e05994753742fa5cddfe95d140bc9aaec8b50e0
hovercard-subject-tagpull_request:3336368625
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/145321/files
twitter:imagehttps://avatars.githubusercontent.com/u/242901957?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/242901957?s=400&v=4
og:image:altBoth hashlib and hmac modules have similar double-free bugs in their hashtable initialization code. Problem hashlib In py_hashentry_table_new(), when _Py_hashtable_set() fails while adding an entry...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/145321/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F145321%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F145321%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/145321/files
Reloadhttps://github.com/python/cpython/pull/145321/files
Reloadhttps://github.com/python/cpython/pull/145321/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gpsheadhttps://github.com/gpshead
python:mainhttps://github.com/python/cpython/tree/main
Conversation 47 https://github.com/python/cpython/pull/145321
Commits 1 https://github.com/python/cpython/pull/145321/commits
Checks 57 https://github.com/python/cpython/pull/145321/checks
Files changed 4 https://github.com/python/cpython/pull/145321/files
gh-145301: Fix double-free in hashlib and hmac module initialization https://github.com/python/cpython/pull/145321/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/145321/files
b19da21 gh-145301: Fix double-free in hashlib and hmac initialization krylosov-aa Mar 2, 2026 https://github.com/python/cpython/pull/145321/commits/b19da21c32a6472fc38e308cde73878bbced5631
Clear filters https://github.com/python/cpython/pull/145321/files
Please reload this pagehttps://github.com/python/cpython/pull/145321/files
Please reload this pagehttps://github.com/python/cpython/pull/145321/files
2026-02-27-19-00-26.gh-issue-145301.2Wih4b.rst https://github.com/python/cpython/pull/145321/files#diff-555e7403efd0d3f27aee81eeaf5ac897c6ac283bf11652375126ddacb636653f
2026-02-28-00-55-00.gh-issue-145301.Lk2bRl.rst https://github.com/python/cpython/pull/145321/files#diff-34375bba249e21a63b0bd40e435b61ca8b83d766d1ccf10d97b4773425fd6f78
_hashopenssl.c https://github.com/python/cpython/pull/145321/files#diff-b4fd2e5e447a6f18fb2508c350524c5cb1feed8ec92d70822eac54431ef71baf
hmacmodule.c https://github.com/python/cpython/pull/145321/files#diff-c1a0c4b200e7b9390d6af70efb2fd75fcce77c7bb63e26dd08946456fd6bf5f4
Misc/NEWS.d/next/Library/2026-02-27-19-00-26.gh-issue-145301.2Wih4b.rsthttps://github.com/python/cpython/pull/145321/files#diff-555e7403efd0d3f27aee81eeaf5ac897c6ac283bf11652375126ddacb636653f
View file https://github.com/python/cpython/blob/b19da21c32a6472fc38e308cde73878bbced5631/Misc/NEWS.d/next/Library/2026-02-27-19-00-26.gh-issue-145301.2Wih4b.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/145321/{{ revealButtonHref }}
Misc/NEWS.d/next/Library/2026-02-28-00-55-00.gh-issue-145301.Lk2bRl.rsthttps://github.com/python/cpython/pull/145321/files#diff-34375bba249e21a63b0bd40e435b61ca8b83d766d1ccf10d97b4773425fd6f78
View file https://github.com/python/cpython/blob/b19da21c32a6472fc38e308cde73878bbced5631/Misc/NEWS.d/next/Library/2026-02-28-00-55-00.gh-issue-145301.Lk2bRl.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/145321/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L394
Modules/_hashopenssl.chttps://github.com/python/cpython/pull/145321/files#diff-b4fd2e5e447a6f18fb2508c350524c5cb1feed8ec92d70822eac54431ef71baf
View file https://github.com/python/cpython/blob/b19da21c32a6472fc38e308cde73878bbced5631/Modules/_hashopenssl.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/145321/{{ revealButtonHref }}
https://github.com/python/cpython/pull/145321/files#diff-b4fd2e5e447a6f18fb2508c350524c5cb1feed8ec92d70822eac54431ef71baf
https://github.com/python/cpython/pull/145321/files#diff-b4fd2e5e447a6f18fb2508c350524c5cb1feed8ec92d70822eac54431ef71baf
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L393
Modules/hmacmodule.chttps://github.com/python/cpython/pull/145321/files#diff-c1a0c4b200e7b9390d6af70efb2fd75fcce77c7bb63e26dd08946456fd6bf5f4
View file https://github.com/python/cpython/blob/b19da21c32a6472fc38e308cde73878bbced5631/Modules/hmacmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/145321/{{ revealButtonHref }}
https://github.com/python/cpython/pull/145321/files#diff-c1a0c4b200e7b9390d6af70efb2fd75fcce77c7bb63e26dd08946456fd6bf5f4
https://github.com/python/cpython/pull/145321/files#diff-c1a0c4b200e7b9390d6af70efb2fd75fcce77c7bb63e26dd08946456fd6bf5f4
Please reload this pagehttps://github.com/python/cpython/pull/145321/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.