René's URL Explorer Experiment


Title: gh-145235: Make dict watcher API thread-safe for free-threaded builds by yoney · Pull Request #145233 · python/cpython · GitHub

Open Graph Title: gh-145235: Make dict watcher API thread-safe for free-threaded builds by yoney · Pull Request #145233 · python/cpython

X Title: gh-145235: Make dict watcher API thread-safe for free-threaded builds by yoney · Pull Request #145233 · python/cpython

Description: In free-threaded builds, concurrent calls to PyDict_AddWatcher, PyDict_ClearWatcher, PyDict_Watch, and PyDict_Unwatch can race on the shared callback array and the per-dict watcher tags. This change adds a mutex to serialize watcher registration and removal, atomic operations for tag updates, and atomic acquire/release synchronization for callback dispatch in _PyDict_SendEvent. Note: Before this change, running test.test_free_threading.test_dict_watcher emitted tsan warnings in the free-threaded tsan build. cc: @colesbury @mpage @DinoV Issue: gh-145235

Open Graph Description: In free-threaded builds, concurrent calls to PyDict_AddWatcher, PyDict_ClearWatcher, PyDict_Watch, and PyDict_Unwatch can race on the shared callback array and the per-dict watcher tags. This chang...

X Description: In free-threaded builds, concurrent calls to PyDict_AddWatcher, PyDict_ClearWatcher, PyDict_Watch, and PyDict_Unwatch can race on the shared callback array and the per-dict watcher tags. This chang...

Opengraph URL: https://github.com/python/cpython/pull/145233

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2236c33d-8b87-4506-75a3-44d3e68b29f8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA470:E9D16:2F7F274:3C4CF7A:6B01F86D
html-safe-nonce7c98d0b938ceefb6b636d436a5c2a6129274f9e002b5d917754dbe872a0e9c21
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDcwOkU5RDE2OjJGN0YyNzQ6M0M0Q0Y3QTo2QjAxRjg2RCIsInZpc2l0b3JfaWQiOiIxNjU3NTIzMzA2OTA1MDczNzczIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacca8acdab7a71b9ae89947da2efb89a742c94c32cea353b432dff8f34d0430902
hovercard-subject-tagpull_request:3327739774
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/145233/files
twitter:imagehttps://avatars.githubusercontent.com/u/2095011?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2095011?s=400&v=4
og:image:altIn free-threaded builds, concurrent calls to PyDict_AddWatcher, PyDict_ClearWatcher, PyDict_Watch, and PyDict_Unwatch can race on the shared callback array and the per-dict watcher tags. This chang...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/145233/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F145233%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F145233%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/145233/files
Reloadhttps://github.com/python/cpython/pull/145233/files
Reloadhttps://github.com/python/cpython/pull/145233/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
colesburyhttps://github.com/colesbury
python:mainhttps://github.com/python/cpython/tree/main
yoney:watcherhttps://github.com/yoney/cpython/tree/watcher
Conversation 17 https://github.com/python/cpython/pull/145233
Commits 6 https://github.com/python/cpython/pull/145233/commits
Checks 75 https://github.com/python/cpython/pull/145233/checks
Files changed https://github.com/python/cpython/pull/145233/files
Please reload this pagehttps://github.com/python/cpython/pull/145233/files
gh-145235: Make dict watcher API thread-safe for free-threaded builds https://github.com/python/cpython/pull/145233/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/145233/files
da3c401 Make dict watcher API thread-safe for free-threaded builds yoney Feb 24, 2026 https://github.com/python/cpython/pull/145233/commits/da3c401cea6eef8e5959a1ee0fb7a98457581df6
fd936f3 Add g_dict_watch_once to ignored yoney Feb 25, 2026 https://github.com/python/cpython/pull/145233/commits/fd936f39ea39b1a261b7f1023105d8b9ca07f47b
d3ad082 Address review comments: use _Py_LOCK_DONT_DETACH, atomic OR/AND, _Py… yoney Feb 26, 2026 https://github.com/python/cpython/pull/145233/commits/d3ad082dfe5ae6faf5a060676160e550f638c9a8
ddcebfe Merge remote-tracking branch 'origin/main' into watcher colesbury May 7, 2026 https://github.com/python/cpython/pull/145233/commits/ddcebfe1efbe29a521f33bec876001ea83b5e53c
d050e71 Clean-up post merge colesbury May 7, 2026 https://github.com/python/cpython/pull/145233/commits/d050e71f7d7e09c55b618ac28ed71019ab9ac321
250de26 Merge branch 'main' into watcher colesbury May 11, 2026 https://github.com/python/cpython/pull/145233/commits/250de269910ddada48c6c80604593d2e201ae0af
Clear filters https://github.com/python/cpython/pull/145233/files
Please reload this pagehttps://github.com/python/cpython/pull/145233/files
Please reload this pagehttps://github.com/python/cpython/pull/145233/files
pycore_dict_state.h https://github.com/python/cpython/pull/145233/files#diff-3263c8b16705dc3ea3e56b42dbbc78ab240468ecf9c572eddc3a417dc986a4c7
pycore_pyatomic_ft_wrappers.h https://github.com/python/cpython/pull/145233/files#diff-ce601684210b2d7f8f955bb70eb6836e92f54d7d0ec6cd87e6d9da2b974ab7f7
test_dict_watcher.py https://github.com/python/cpython/pull/145233/files#diff-92f2acae1b01564a2caa4d5fece4d0904cd6dc8fb3d163c5dc9d416d6771c1ae
2026-02-25-13-37-10.gh-issue-145235.-1ySNR.rst https://github.com/python/cpython/pull/145233/files#diff-9ca8195791f673ad74a61c6fca9b95074b1ab94f8579acb4a57944ed0868b487
watchers.c https://github.com/python/cpython/pull/145233/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
dictobject.c https://github.com/python/cpython/pull/145233/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
optimizer_analysis.c https://github.com/python/cpython/pull/145233/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
pystate.c https://github.com/python/cpython/pull/145233/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
ignored.tsv https://github.com/python/cpython/pull/145233/files#diff-fa2373a9a002e491408e623369773045f4b7de90114b9f5ba6933bfbf2d8c45c
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L321
Include/internal/pycore_dict_state.hhttps://github.com/python/cpython/pull/145233/files#diff-3263c8b16705dc3ea3e56b42dbbc78ab240468ecf9c572eddc3a417dc986a4c7
View file https://github.com/yoney/cpython/blob/250de269910ddada48c6c80604593d2e201ae0af/Include/internal/pycore_dict_state.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/145233/{{ revealButtonHref }}
https://github.com/python/cpython/pull/145233/files#diff-3263c8b16705dc3ea3e56b42dbbc78ab240468ecf9c572eddc3a417dc986a4c7
https://github.com/python/cpython/pull/145233/files#diff-3263c8b16705dc3ea3e56b42dbbc78ab240468ecf9c572eddc3a417dc986a4c7
Include/internal/pycore_pyatomic_ft_wrappers.hhttps://github.com/python/cpython/pull/145233/files#diff-ce601684210b2d7f8f955bb70eb6836e92f54d7d0ec6cd87e6d9da2b974ab7f7
View file https://github.com/yoney/cpython/blob/250de269910ddada48c6c80604593d2e201ae0af/Include/internal/pycore_pyatomic_ft_wrappers.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/145233/{{ revealButtonHref }}
https://github.com/python/cpython/pull/145233/files#diff-ce601684210b2d7f8f955bb70eb6836e92f54d7d0ec6cd87e6d9da2b974ab7f7
https://github.com/python/cpython/pull/145233/files#diff-ce601684210b2d7f8f955bb70eb6836e92f54d7d0ec6cd87e6d9da2b974ab7f7
https://github.com/python/cpython/pull/145233/files#diff-ce601684210b2d7f8f955bb70eb6836e92f54d7d0ec6cd87e6d9da2b974ab7f7
https://github.com/python/cpython/pull/145233/files#diff-ce601684210b2d7f8f955bb70eb6836e92f54d7d0ec6cd87e6d9da2b974ab7f7
Lib/test/test_free_threading/test_dict_watcher.pyhttps://github.com/python/cpython/pull/145233/files#diff-92f2acae1b01564a2caa4d5fece4d0904cd6dc8fb3d163c5dc9d416d6771c1ae
View file https://github.com/yoney/cpython/blob/250de269910ddada48c6c80604593d2e201ae0af/Lib/test/test_free_threading/test_dict_watcher.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/145233/{{ revealButtonHref }}
Misc/NEWS.d/next/C_API/2026-02-25-13-37-10.gh-issue-145235.-1ySNR.rsthttps://github.com/python/cpython/pull/145233/files#diff-9ca8195791f673ad74a61c6fca9b95074b1ab94f8579acb4a57944ed0868b487
View file https://github.com/yoney/cpython/blob/250de269910ddada48c6c80604593d2e201ae0af/Misc/NEWS.d/next/C_API/2026-02-25-13-37-10.gh-issue-145235.-1ySNR.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/145233/{{ revealButtonHref }}
Modules/_testcapi/watchers.chttps://github.com/python/cpython/pull/145233/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
View file https://github.com/yoney/cpython/blob/250de269910ddada48c6c80604593d2e201ae0af/Modules/_testcapi/watchers.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/145233/{{ revealButtonHref }}
https://github.com/python/cpython/pull/145233/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
https://github.com/python/cpython/pull/145233/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
https://github.com/python/cpython/pull/145233/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
https://github.com/python/cpython/pull/145233/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
https://github.com/python/cpython/pull/145233/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
https://github.com/python/cpython/pull/145233/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
https://github.com/python/cpython/pull/145233/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
https://github.com/python/cpython/pull/145233/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L212
Objects/dictobject.chttps://github.com/python/cpython/pull/145233/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
View file https://github.com/yoney/cpython/blob/250de269910ddada48c6c80604593d2e201ae0af/Objects/dictobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/145233/{{ revealButtonHref }}
https://github.com/python/cpython/pull/145233/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
Please reload this pagehttps://github.com/python/cpython/pull/145233/files
https://github.com/python/cpython/pull/145233/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/145233/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/145233/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/145233/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L303
Python/optimizer_analysis.chttps://github.com/python/cpython/pull/145233/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
View file https://github.com/yoney/cpython/blob/250de269910ddada48c6c80604593d2e201ae0af/Python/optimizer_analysis.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/145233/{{ revealButtonHref }}
https://github.com/python/cpython/pull/145233/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
https://github.com/python/cpython/pull/145233/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
https://github.com/python/cpython/pull/145233/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
https://github.com/python/cpython/pull/145233/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
https://github.com/python/cpython/pull/145233/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
https://github.com/python/cpython/pull/145233/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
https://github.com/python/cpython/pull/145233/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
https://github.com/python/cpython/pull/145233/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L319
Python/pystate.chttps://github.com/python/cpython/pull/145233/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
View file https://github.com/yoney/cpython/blob/250de269910ddada48c6c80604593d2e201ae0af/Python/pystate.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/145233/{{ revealButtonHref }}
https://github.com/python/cpython/pull/145233/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/145233/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L129
Tools/c-analyzer/cpython/ignored.tsvhttps://github.com/python/cpython/pull/145233/files#diff-fa2373a9a002e491408e623369773045f4b7de90114b9f5ba6933bfbf2d8c45c
View file https://github.com/yoney/cpython/blob/250de269910ddada48c6c80604593d2e201ae0af/Tools/c-analyzer/cpython/ignored.tsv
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/145233/{{ revealButtonHref }}
https://github.com/python/cpython/pull/145233/files#diff-fa2373a9a002e491408e623369773045f4b7de90114b9f5ba6933bfbf2d8c45c
https://github.com/python/cpython/pull/145233/files#diff-fa2373a9a002e491408e623369773045f4b7de90114b9f5ba6933bfbf2d8c45c
Please reload this pagehttps://github.com/python/cpython/pull/145233/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.