René's URL Explorer Experiment


Title: gh-144975: Fix wave.Wave_write.setframerate() validation order by mbeijen · Pull Request #144976 · python/cpython · GitHub

Open Graph Title: gh-144975: Fix wave.Wave_write.setframerate() validation order by mbeijen · Pull Request #144976 · python/cpython

X Title: gh-144975: Fix wave.Wave_write.setframerate() validation order by mbeijen · Pull Request #144976 · python/cpython

Description: Validate the frame rate after rounding to an integer, not before. This prevents values like 0.5 from passing validation (0.5 > 0) but then rounding to 0, which would cause a confusing delayed error "sampling rate not specified" when writing frames. With this fix, setframerate(0.5) immediately raises "bad frame rate", providing clear feedback at the point of the error. See #144975 Issue: gh-144975

Open Graph Description: Validate the frame rate after rounding to an integer, not before. This prevents values like 0.5 from passing validation (0.5 > 0) but then rounding to 0, which would cause a confusing delayed er...

X Description: Validate the frame rate after rounding to an integer, not before. This prevents values like 0.5 from passing validation (0.5 > 0) but then rounding to 0, which would cause a confusing delaye...

Opengraph URL: https://github.com/python/cpython/pull/144976

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:31a530cc-7458-5913-43dd-bb0801410a06
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id96B8:766B3:3C0490:50548B:6AECCAE1
html-safe-nonceb88abf263b4a82578d0300b90b85654c88b581bc7a78c5d406e039ef8f38611c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkI4Ojc2NkIzOjNDMDQ5MDo1MDU0OEI6NkFFQ0NBRTEiLCJ2aXNpdG9yX2lkIjoiNzQ5MTU4ODMzNjY3NDE5NjE5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac87cecbcefc5c83cf111b7fd8e98dc8b2eeba0f9ec6cf8c486dba4864f32e9937
hovercard-subject-tagpull_request:3300324260
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/144976/files
twitter:imagehttps://avatars.githubusercontent.com/u/659504?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/659504?s=400&v=4
og:image:altValidate the frame rate after rounding to an integer, not before. This prevents values like 0.5 from passing validation (0.5 > 0) but then rounding to 0, which would cause a confusing delayed er...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonedc0b519c5798dc1150b88dc4c06a8b9634d0069218dc04e469970e76aad74016
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedb139f0bf57b59bf9a8c4abb0849924d6c6ca559
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/144976/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F144976%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F144976%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/144976/files
Reloadhttps://github.com/python/cpython/pull/144976/files
Reloadhttps://github.com/python/cpython/pull/144976/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.3k (2.3k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
mbeijen:wave-setframeratehttps://github.com/mbeijen/cpython/tree/wave-setframerate
Conversation 2 https://github.com/python/cpython/pull/144976
Commits 3 https://github.com/python/cpython/pull/144976/commits
Checks 49 https://github.com/python/cpython/pull/144976/checks
Files changed https://github.com/python/cpython/pull/144976/files
Please reload this pagehttps://github.com/python/cpython/pull/144976/files
gh-144975: Fix wave.Wave_write.setframerate() validation order https://github.com/python/cpython/pull/144976/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/144976/files
0273641 gh-144975: Fix wave.Wave_write.setframerate() validation order mbeijen Feb 18, 2026 https://github.com/python/cpython/pull/144976/commits/027364153a751a8d3b907ccbea627a9be896c902
40a8fea Merge branch 'main' into wave-setframerate mbeijen Feb 18, 2026 https://github.com/python/cpython/pull/144976/commits/40a8fea3fe685e586198cdf47e375d4a8f2f8e40
925a175 Use subTests for the tests encukou Mar 17, 2026 https://github.com/python/cpython/pull/144976/commits/925a17552d8343dcb9cdb149a88e548e5a28f657
Clear filters https://github.com/python/cpython/pull/144976/files
Please reload this pagehttps://github.com/python/cpython/pull/144976/files
Please reload this pagehttps://github.com/python/cpython/pull/144976/files
test_wave.py https://github.com/python/cpython/pull/144976/files#diff-a199f1748809afe147b8e298adaef9a1af3bcf7c519b64823b573a47c4e55bbe
wave.py https://github.com/python/cpython/pull/144976/files#diff-8e67a696f050c6abebc661b71a215e2c2bb8d0bb2f27ee2ba25adecc8b1b094c
2026-02-18-21-45-00.gh-issue-144975.Ab3XyZ.rst https://github.com/python/cpython/pull/144976/files#diff-9124883086143673da9a4d83944f1cd19c4247648bccfa7cba984b7e175126a0
Lib/test/test_wave.pyhttps://github.com/python/cpython/pull/144976/files#diff-a199f1748809afe147b8e298adaef9a1af3bcf7c519b64823b573a47c4e55bbe
View file https://github.com/mbeijen/cpython/blob/925a17552d8343dcb9cdb149a88e548e5a28f657/Lib/test/test_wave.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/144976/{{ revealButtonHref }}
https://github.com/python/cpython/pull/144976/files#diff-a199f1748809afe147b8e298adaef9a1af3bcf7c519b64823b573a47c4e55bbe
https://github.com/python/cpython/pull/144976/files#diff-a199f1748809afe147b8e298adaef9a1af3bcf7c519b64823b573a47c4e55bbe
Lib/wave.pyhttps://github.com/python/cpython/pull/144976/files#diff-8e67a696f050c6abebc661b71a215e2c2bb8d0bb2f27ee2ba25adecc8b1b094c
View file https://github.com/mbeijen/cpython/blob/925a17552d8343dcb9cdb149a88e548e5a28f657/Lib/wave.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/144976/{{ revealButtonHref }}
https://github.com/python/cpython/pull/144976/files#diff-8e67a696f050c6abebc661b71a215e2c2bb8d0bb2f27ee2ba25adecc8b1b094c
https://github.com/python/cpython/pull/144976/files#diff-8e67a696f050c6abebc661b71a215e2c2bb8d0bb2f27ee2ba25adecc8b1b094c
Misc/NEWS.d/next/Library/2026-02-18-21-45-00.gh-issue-144975.Ab3XyZ.rsthttps://github.com/python/cpython/pull/144976/files#diff-9124883086143673da9a4d83944f1cd19c4247648bccfa7cba984b7e175126a0
View file https://github.com/mbeijen/cpython/blob/925a17552d8343dcb9cdb149a88e548e5a28f657/Misc/NEWS.d/next/Library/2026-02-18-21-45-00.gh-issue-144975.Ab3XyZ.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/144976/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/144976/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.