René's URL Explorer Experiment


Title: gh-144975: Fix wave.Wave_write.setframerate() validation order by mbeijen · Pull Request #144976 · python/cpython · GitHub

Open Graph Title: gh-144975: Fix wave.Wave_write.setframerate() validation order by mbeijen · Pull Request #144976 · python/cpython

X Title: gh-144975: Fix wave.Wave_write.setframerate() validation order by mbeijen · Pull Request #144976 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Validate the frame rate after rounding to an integer, not before. This prevents values like 0.5 from passing validation (0.5 > 0) but then rounding to 0, which would cause a confusing delayed er...

X Description: Validate the frame rate after rounding to an integer, not before. This prevents values like 0.5 from passing validation (0.5 > 0) but then rounding to 0, which would cause a confusing delaye...

Opengraph URL: https://github.com/python/cpython/pull/144976

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/checks(.:format)
route-controllerpull_requests
route-actionchecks
fetch-noncev2:4d7ee467-f6ed-f495-3044-d54fc6bd9734
current-catalog-service-hash87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a
request-id9E62:1ADD09:3E7197:53A0E4:6AECCB05
html-safe-nonce27f9da1c545471accce49b1d9b8f3d84ffe2c700b4885af87e4cf8414e10b057
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTYyOjFBREQwOTozRTcxOTc6NTNBMEU0OjZBRUNDQjA1IiwidmlzaXRvcl9pZCI6IjYxNjQ4MTQ1MTQ0OTk2Njg3NDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3b78c719529d2f35e6b1e68ee5f95038a55cf88daf6c07d7b66dfdcbd370a6e0
hovercard-subject-tagpull_request:3300324260
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/checks
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/144976/checks
twitter:imagehttps://opengraph.githubassets.com/6871f1b11f7ee476611adf7aa50bcecf83182f851c66e156599028894a1f15b3/python/cpython/pull/144976
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6871f1b11f7ee476611adf7aa50bcecf83182f851c66e156599028894a1f15b3/python/cpython/pull/144976
og:image:altValidate the frame rate after rounding to an integer, not before. This prevents values like 0.5 from passing validation (0.5 > 0) but then rounding to 0, which would cause a confusing delayed er...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamembeijen
hostnamegithub.com
expected-hostnamegithub.com
Nonedc0b519c5798dc1150b88dc4c06a8b9634d0069218dc04e469970e76aad74016
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedb139f0bf57b59bf9a8c4abb0849924d6c6ca559
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/144976/checks#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F144976%2Fchecks
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F144976%2Fchecks
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/144976/checks
Reloadhttps://github.com/python/cpython/pull/144976/checks
Reloadhttps://github.com/python/cpython/pull/144976/checks
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.3k (2.3k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/pulse
https://github.com/python/cpython
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
mbeijen:wave-setframeratehttps://github.com/mbeijen/cpython/tree/wave-setframerate
Conversationhttps://github.com/python/cpython/pull/144976
Commits3 (3)https://github.com/python/cpython/pull/144976/commits
Checkshttps://github.com/python/cpython/pull/144976/checks
Files changedhttps://github.com/python/cpython/pull/144976/files
gh-144975: Fix wave.Wave_write.setframerate() validation orderhttps://github.com/python/cpython/pull/144976/checks#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
mbeijen:wave-setframeratehttps://github.com/mbeijen/cpython/tree/wave-setframerate
Please reload this pagehttps://github.com/python/cpython/pull/144976/checks
Sign in for the full log viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F144976%2Fchecks
Check labels on: pull_request https://github.com/python/cpython/actions/runs/23204212844
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/23204212844/job/67434854356?pr=144976
Unresolved review https://github.com/python/cpython/actions/runs/23204212844/job/67434854380?pr=144976
Tests on: pull_request https://github.com/python/cpython/actions/runs/23204212864
Change detection / Create context from changed files https://github.com/python/cpython/actions/runs/23204212864/job/67434854915?pr=144976
Docs / Docs https://github.com/python/cpython/actions/runs/23204212864/job/67434901116?pr=144976
Docs / Doctest https://github.com/python/cpython/actions/runs/23204212864/job/67434901017?pr=144976
Docs / Check EPUB https://github.com/python/cpython/actions/runs/23204212864/job/67434900971?pr=144976
Check if Autoconf files are up to date https://github.com/python/cpython/actions/runs/23204212864/job/67434899980?pr=144976
Check if generated files are up to date https://github.com/python/cpython/actions/runs/23204212864/job/67434900102?pr=144976
C API Docs / Check if all C APIs are documented https://github.com/python/cpython/actions/runs/23204212864/job/67434900340?pr=144976
Windows / Build and test (x64) https://github.com/python/cpython/actions/runs/23204212864/job/67434900808?pr=144976
Windows (free-threading) / Build and test (x64) https://github.com/python/cpython/actions/runs/23204212864/job/67434900667?pr=144976
Windows / Build and test (Win32) https://github.com/python/cpython/actions/runs/23204212864/job/67434900539?pr=144976
Windows / Build and test (arm64) https://github.com/python/cpython/actions/runs/23204212864/job/67434900715?pr=144976
Windows (free-threading) / Build and test (arm64) https://github.com/python/cpython/actions/runs/23204212864/job/67434900511?pr=144976
Windows MSI${{ '' }} https://github.com/python/cpython/actions/runs/23204212864/job/67434900805?pr=144976
macOS / build and test (macos-14) https://github.com/python/cpython/actions/runs/23204212864/job/67434900853?pr=144976
macOS (free-threading) / build and test (macos-14) https://github.com/python/cpython/actions/runs/23204212864/job/67434901079?pr=144976
macOS / build and test (macos-15-intel) https://github.com/python/cpython/actions/runs/23204212864/job/67434901170?pr=144976
Ubuntu / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/23204212864/job/67434900905?pr=144976
Ubuntu / build and test (ubuntu-24.04-arm) https://github.com/python/cpython/actions/runs/23204212864/job/67434900911?pr=144976
Ubuntu (free-threading) / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/23204212864/job/67434900809?pr=144976
Ubuntu (free-threading) / build and test (ubuntu-24.04-arm) https://github.com/python/cpython/actions/runs/23204212864/job/67434900842?pr=144976
Ubuntu (bolt) / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/23204212864/job/67434900883?pr=144976
Ubuntu SSL tests (ubuntu-24.04, openssl, 1.1.1w) https://github.com/python/cpython/actions/runs/23204212864/job/67434900188?pr=144976
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.0.19) https://github.com/python/cpython/actions/runs/23204212864/job/67434900397?pr=144976
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.3.6) https://github.com/python/cpython/actions/runs/23204212864/job/67434900069?pr=144976
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.4.4) https://github.com/python/cpython/actions/runs/23204212864/job/67434900108?pr=144976
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.5.5) https://github.com/python/cpython/actions/runs/23204212864/job/67434900063?pr=144976
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.6.1) https://github.com/python/cpython/actions/runs/23204212864/job/67434900117?pr=144976
Ubuntu SSL tests (ubuntu-24.04, aws-lc, 1.68.0) https://github.com/python/cpython/actions/runs/23204212864/job/67434900159?pr=144976
Android (aarch64) https://github.com/python/cpython/actions/runs/23204212864/job/67434900097?pr=144976
Android (x86_64) https://github.com/python/cpython/actions/runs/23204212864/job/67434900031?pr=144976
iOS https://github.com/python/cpython/actions/runs/23204212864/job/67434900046?pr=144976
WASI / build and test https://github.com/python/cpython/actions/runs/23204212864/job/67434900504?pr=144976
Hypothesis tests on Ubuntu https://github.com/python/cpython/actions/runs/23204212864/job/67434900160?pr=144976
Address sanitizer (ubuntu-24.04) https://github.com/python/cpython/actions/runs/23204212864/job/67434900129?pr=144976
Sanitizers / TSan https://github.com/python/cpython/actions/runs/23204212864/job/67434900941?pr=144976
Sanitizers / TSan (free-threading) https://github.com/python/cpython/actions/runs/23204212864/job/67434900913?pr=144976
Sanitizers / UBSan https://github.com/python/cpython/actions/runs/23204212864/job/67434900903?pr=144976
Cross build Linux https://github.com/python/cpython/actions/runs/23204212864/job/67434900167?pr=144976
CIFuzz${{ '' }} https://github.com/python/cpython/actions/runs/23204212864/job/67434901313?pr=144976
All required checks pass https://github.com/python/cpython/actions/runs/23204212864/job/67439339706?pr=144976
Lint on: pull_request https://github.com/python/cpython/actions/runs/23204212872
lint https://github.com/python/cpython/actions/runs/23204212872/job/67434854786?pr=144976
Check labels on: pull_request https://github.com/python/cpython/actions/runs/23204341845
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/23204341845/job/67435338617?pr=144976
Unresolved review https://github.com/python/cpython/actions/runs/23204341845/job/67435338607?pr=144976
Check labels on: pull_request https://github.com/python/cpython/actions/runs/23204341971
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/23204341971/job/67435338463?pr=144976
Unresolved review https://github.com/python/cpython/actions/runs/23204341971/job/67435338454?pr=144976
Check labels on: pull_request https://github.com/python/cpython/actions/runs/23207192992
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/23207192992/job/67445786449?pr=144976
Unresolved review https://github.com/python/cpython/actions/runs/23207192992/job/67445786516?pr=144976
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.