René's URL Explorer Experiment


Title: gh-144975: Fix wave.Wave_write.setframerate() validation order by mbeijen · Pull Request #144976 · python/cpython · GitHub

Open Graph Title: gh-144975: Fix wave.Wave_write.setframerate() validation order by mbeijen · Pull Request #144976 · python/cpython

X Title: gh-144975: Fix wave.Wave_write.setframerate() validation order by mbeijen · Pull Request #144976 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Validate the frame rate after rounding to an integer, not before. This prevents values like 0.5 from passing validation (0.5 > 0) but then rounding to 0, which would cause a confusing delayed er...

X Description: Validate the frame rate after rounding to an integer, not before. This prevents values like 0.5 from passing validation (0.5 > 0) but then rounding to 0, which would cause a confusing delaye...

Opengraph URL: https://github.com/python/cpython/pull/144976

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:92edd6d8-0f0e-5877-8598-4b777e73423e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE3BC:61DB4:2467EF:3223E1:6AECC69B
html-safe-nonce346ba888803afb999d5d2d111ec7ab609b41f3abb57368a96382394f5c1240e1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0JDOjYxREI0OjI0NjdFRjozMjIzRTE6NkFFQ0M2OUIiLCJ2aXNpdG9yX2lkIjoiNTM1NDkyMTcxODQyNzk5Mzc1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8df7edc0041570719950b00c3e4c6363469a305abfb4b4367d98fdc7269911fa
hovercard-subject-tagpull_request:3300324260
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/144976/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6871f1b11f7ee476611adf7aa50bcecf83182f851c66e156599028894a1f15b3/python/cpython/pull/144976
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6871f1b11f7ee476611adf7aa50bcecf83182f851c66e156599028894a1f15b3/python/cpython/pull/144976
og:image:altValidate the frame rate after rounding to an integer, not before. This prevents values like 0.5 from passing validation (0.5 > 0) but then rounding to 0, which would cause a confusing delayed er...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamembeijen
hostnamegithub.com
expected-hostnamegithub.com
Nonedc0b519c5798dc1150b88dc4c06a8b9634d0069218dc04e469970e76aad74016
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedb139f0bf57b59bf9a8c4abb0849924d6c6ca559
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/144976#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F144976
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F144976
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/144976
Reloadhttps://github.com/python/cpython/pull/144976
Reloadhttps://github.com/python/cpython/pull/144976
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.3k (2.3k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/pulse
https://github.com/python/cpython
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
mbeijen:wave-setframeratehttps://github.com/mbeijen/cpython/tree/wave-setframerate
Conversationhttps://github.com/python/cpython/pull/144976
Commits3 (3)https://github.com/python/cpython/pull/144976/commits
Checkshttps://github.com/python/cpython/pull/144976/checks
Files changedhttps://github.com/python/cpython/pull/144976/files
gh-144975: Fix wave.Wave_write.setframerate() validation orderhttps://github.com/python/cpython/pull/144976#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
mbeijen:wave-setframeratehttps://github.com/mbeijen/cpython/tree/wave-setframerate
https://github.com/mbeijen
mbeijenhttps://github.com/mbeijen
Feb 18, 2026https://github.com/python/cpython/pull/144976#issue-3959709255
Please reload this pagehttps://github.com/python/cpython/pull/144976
#144975https://github.com/python/cpython/issues/144975
wave: setframerate() accepts invalid frame rate values that round to zero #144975https://github.com/python/cpython/issues/144975
Please reload this pagehttps://github.com/python/cpython/pull/144976
https://github.com/mbeijen
pythongh-144975https://github.com/python/cpython/issues/144975
: Fix wave.Wave_write.setframerate() validation orderhttps://github.com/python/cpython/pull/144976/commits/027364153a751a8d3b907ccbea627a9be896c902
0273641https://github.com/python/cpython/pull/144976/commits/027364153a751a8d3b907ccbea627a9be896c902
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Feb 18, 2026https://github.com/python/cpython/pull/144976#event-22895965991
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Feb 18, 2026 https://github.com/python/cpython/pull/144976#ref-issue-3959647412
wave: setframerate() accepts invalid frame rate values that round to zero #144975 https://github.com/python/cpython/issues/144975
https://github.com/mbeijen
Merge branch 'main' into wave-setframeratehttps://github.com/python/cpython/pull/144976/commits/40a8fea3fe685e586198cdf47e375d4a8f2f8e40
40a8feahttps://github.com/python/cpython/pull/144976/commits/40a8fea3fe685e586198cdf47e375d4a8f2f8e40
https://github.com/mbeijen
mbeijenhttps://github.com/mbeijen
Mar 13, 2026 https://github.com/python/cpython/pull/144976#ref-pullrequest-4006696525
GH-60729: Add IEEE format wave audio support #145384 https://github.com/python/cpython/pull/145384
https://github.com/encukou
Use subTests for the testshttps://github.com/python/cpython/pull/144976/commits/925a17552d8343dcb9cdb149a88e548e5a28f657
925a175https://github.com/python/cpython/pull/144976/commits/925a17552d8343dcb9cdb149a88e548e5a28f657
https://github.com/encukou
encukouhttps://github.com/encukou
Mar 17, 2026 https://github.com/python/cpython/pull/144976#pullrequestreview-3962052383
View reviewed changes https://github.com/python/cpython/pull/144976/files/925a17552d8343dcb9cdb149a88e548e5a28f657
encukouhttps://github.com/encukou
https://github.com/python/cpython/pull/144976#pullrequestreview-3962052383
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/144976
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Mar 17, 2026https://github.com/python/cpython/pull/144976#event-23650426482
https://github.com/mbeijen
mbeijenhttps://github.com/mbeijen
Mar 17, 2026https://github.com/python/cpython/pull/144976#issuecomment-4076483713
Please reload this pagehttps://github.com/python/cpython/pull/144976
https://github.com/encukou
encukouhttps://github.com/encukou
ff287a7https://github.com/python/cpython/commit/ff287a72de43e7fc6517aba9049cb23470e000b2
Mar 17, 2026https://github.com/python/cpython/pull/144976#event-23652063403
Please reload this pagehttps://github.com/python/cpython/pull/144976
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Mar 17, 2026https://github.com/python/cpython/pull/144976#event-23652699714
ljfphttps://github.com/ljfp
Apr 25, 2026 https://github.com/python/cpython/pull/144976#ref-commit-e6ba52c
https://github.com/mbeijen
https://github.com/ljfp
pythongh-144975https://github.com/python/cpython/issues/144975
: Fix wave.Wave_write.setframerate() validation order (https://github.com/ljfp/cpython/commit/e6ba52c6f3dc7d1c331949518f650cab16223781
p…https://github.com/python/cpython/pull/144976
e6ba52chttps://github.com/ljfp/cpython/commit/e6ba52c6f3dc7d1c331949518f650cab16223781
…ythonGH-144976https://github.com/python/cpython/pull/144976
https://github.com/htjworld
htjworldhttps://github.com/htjworld
May 3, 2026 https://github.com/python/cpython/pull/144976#ref-pullrequest-4370624105
gh-149306: Improve error messages in wave module to include the offending value #149307 https://github.com/python/cpython/pull/149307
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F144976
https://github.com/encukou
encukou https://github.com/encukou
https://github.com/python/cpython/pull/144976/files/925a17552d8343dcb9cdb149a88e548e5a28f657
Please reload this pagehttps://github.com/python/cpython/pull/144976
Please reload this pagehttps://github.com/python/cpython/pull/144976
https://github.com/mbeijen
https://github.com/encukou
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.