René's URL Explorer Experiment


Title: bpo-37424: Avoid a hang in subprocess.run timeout output capture by gpshead · Pull Request #14490 · python/cpython · GitHub

Open Graph Title: bpo-37424: Avoid a hang in subprocess.run timeout output capture by gpshead · Pull Request #14490 · python/cpython

X Title: bpo-37424: Avoid a hang in subprocess.run timeout output capture by gpshead · Pull Request #14490 · python/cpython

Description: Fixes a possible hang when using a timeout on subprocess.run() while capturing output. If the child process spawned its own children or otherwise connected its stdout or stderr handles with another process, we could hang after the timeout was reached and our child was killed when attempting to read final output from the pipes. https://bugs.python.org/issue37424

Open Graph Description: Fixes a possible hang when using a timeout on subprocess.run() while capturing output. If the child process spawned its own children or otherwise connected its stdout or stderr handles with anothe...

X Description: Fixes a possible hang when using a timeout on subprocess.run() while capturing output. If the child process spawned its own children or otherwise connected its stdout or stderr handles with anothe...

Opengraph URL: https://github.com/python/cpython/pull/14490

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:afba9972-56ac-f5c9-1fa5-e9b4d5128d2b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCF30:2D9C09:1B57D6F:2555C9D:6A53FB5D
html-safe-nonce8156fc9871d66492fe0c17e2f9ebd91fad5907482474cc14830fc8f17d04ed18
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjMwOjJEOUMwOToxQjU3RDZGOjI1NTVDOUQ6NkE1M0ZCNUQiLCJ2aXNpdG9yX2lkIjoiNzQ5NTg1MzU2OTkwMTU5MTM4OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac88f2133db48cf316d3e38098ac618c8cc5f7751d6dc915cf704048bef030b0b4
hovercard-subject-tagpull_request:293142507
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/14490/files
twitter:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
og:image:altFixes a possible hang when using a timeout on subprocess.run() while capturing output. If the child process spawned its own children or otherwise connected its stdout or stderr handles with anothe...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/14490/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F14490%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F14490%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/14490/files
Reloadhttps://github.com/python/cpython/pull/14490/files
Reloadhttps://github.com/python/cpython/pull/14490/files
Please reload this pagehttps://github.com/python/cpython/pull/14490/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/14490/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Yhg1shttps://github.com/Yhg1s
python:masterhttps://github.com/python/cpython/tree/master
gpshead:subprocess_timeout_shell_issue37424https://github.com/gpshead/cpython/tree/subprocess_timeout_shell_issue37424
Conversation 12 https://github.com/python/cpython/pull/14490
Commits 7 https://github.com/python/cpython/pull/14490/commits
Checks 0 https://github.com/python/cpython/pull/14490/checks
Files changed https://github.com/python/cpython/pull/14490/files
Please reload this pagehttps://github.com/python/cpython/pull/14490/files
bpo-37424: Avoid a hang in subprocess.run timeout output capture https://github.com/python/cpython/pull/14490/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/14490/files
00b93c4 bpo-37424: Have subprocess use killpg for some timeout kills. gpshead Jun 30, 2019 https://github.com/python/cpython/pull/14490/commits/00b93c411bf3c6cbfc3d4a40e6dfa5df6889591b
be807f6 Adds a test for the no session scenario (common). gpshead Jun 30, 2019 https://github.com/python/cpython/pull/14490/commits/be807f6781547cbfcaec45cb580993391ad47484
ef8406a Simplify this a lot, do not use magic process groups. gpshead Jul 4, 2019 https://github.com/python/cpython/pull/14490/commits/ef8406a16f3a260841dc160a773dfd141262325f
8710652 Remove the magic shell pgrp detection killpg logic. gpshead Jul 4, 2019 https://github.com/python/cpython/pull/14490/commits/871065226fb42c19ae7166a688a02510bbff32d9
f897d0b Remove session pgrp logic related test. gpshead Jul 4, 2019 https://github.com/python/cpython/pull/14490/commits/f897d0bca60d8940944e13748210752e60bbd633
814d81e blurb gpshead Jul 4, 2019 https://github.com/python/cpython/pull/14490/commits/814d81e859726d205517724d4d68dfe7c4e2f1e9
38df334 Typo in comment, add a test comment. gpshead Sep 10, 2019 https://github.com/python/cpython/pull/14490/commits/38df3341567767e2a8111349a1852382058ef0c0
Clear filters https://github.com/python/cpython/pull/14490/files
Please reload this pagehttps://github.com/python/cpython/pull/14490/files
Please reload this pagehttps://github.com/python/cpython/pull/14490/files
subprocess.py https://github.com/python/cpython/pull/14490/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
test_subprocess.py https://github.com/python/cpython/pull/14490/files#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
2019-07-04-13-00-20.bpo-37424.0i1MR-.rst https://github.com/python/cpython/pull/14490/files#diff-87a658e8908e988fa758659e84584153ad39f675e10454b7e8203f655dc3cc72
Lib/subprocess.pyhttps://github.com/python/cpython/pull/14490/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
View file https://github.com/gpshead/cpython/blob/38df3341567767e2a8111349a1852382058ef0c0/Lib/subprocess.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/14490/{{ revealButtonHref }}
https://github.com/python/cpython/pull/14490/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
Please reload this pagehttps://github.com/python/cpython/pull/14490/files
https://github.com/python/cpython/pull/14490/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/14490/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/14490/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/14490/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/14490/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
Lib/test/test_subprocess.pyhttps://github.com/python/cpython/pull/14490/files#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
View file https://github.com/gpshead/cpython/blob/38df3341567767e2a8111349a1852382058ef0c0/Lib/test/test_subprocess.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/14490/{{ revealButtonHref }}
https://github.com/python/cpython/pull/14490/files#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
https://github.com/python/cpython/pull/14490/files#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
https://github.com/python/cpython/pull/14490/files#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
Please reload this pagehttps://github.com/python/cpython/pull/14490/files
https://github.com/python/cpython/pull/14490/files#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
Misc/NEWS.d/next/Library/2019-07-04-13-00-20.bpo-37424.0i1MR-.rsthttps://github.com/python/cpython/pull/14490/files#diff-87a658e8908e988fa758659e84584153ad39f675e10454b7e8203f655dc3cc72
View file https://github.com/gpshead/cpython/blob/38df3341567767e2a8111349a1852382058ef0c0/Misc/NEWS.d/next/Library/2019-07-04-13-00-20.bpo-37424.0i1MR-.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/14490/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.