René's URL Explorer Experiment


Title: gh-144681: Fix JIT trace builder assertion failure when conditional branch jump target coincides with fallthrough target by cocolato · Pull Request #144742 · python/cpython · GitHub

Open Graph Title: gh-144681: Fix JIT trace builder assertion failure when conditional branch jump target coincides with fallthrough target by cocolato · Pull Request #144742 · python/cpython

X Title: gh-144681: Fix JIT trace builder assertion failure when conditional branch jump target coincides with fallthrough target by cocolato · Pull Request #144742 · python/cpython

Description: When the JIT trace builder translates POP_JUMP_IF_TRUE instructions, it determines the branch direction by comparing next_instr (where execution actually went) against computed_jump_instr (the jump target address). However, when oparg equals 1 and the instruction is followed by NOT_TAKEN, the computed jump target and the computed fallthrough target are the same address: computed_next_instr = target + 2 + 1 (skip NOT_TAKEN) = target + 3 computed_jump_instr = target + 2 + 1 (oparg) In this minimal reproduction case: def trigger(): _ = [x for x in range(200) if [].append(x) or True] for i in range(300): trigger() print("we finished") which produces: ... POP_JUMP_IF_TRUE 1 (to L4) L3: NOT_TAKEN L4: LOAD_FAST_BORROW 0 (x) LIST_APPEND 3 JUMP_BACKWARD 30 (to L2) ... the address comparison computed_jump_instr == next_instr is always true regardless of which branch was actually taken, causing the assertion jump_happened == (target_instr[1].cache & 1) failed when the branch was not taken. So we should fall back to the RECORD_BRANCH_TAKEN cache bit (target_instr[1].cache & 1) to determine the branch direction, since address comparison is ambiguous. Issue: gh-144681

Open Graph Description: When the JIT trace builder translates POP_JUMP_IF_TRUE instructions, it determines the branch direction by comparing next_instr (where execution actually went) against computed_jump_instr (the jump...

X Description: When the JIT trace builder translates POP_JUMP_IF_TRUE instructions, it determines the branch direction by comparing next_instr (where execution actually went) against computed_jump_instr (the jump...

Opengraph URL: https://github.com/python/cpython/pull/144742

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6644dfa3-6835-cbe1-743d-597d398533e1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB6B0:16AB79:408C1E2:51F73EE:6B021F8C
html-safe-nonce3f187b2538e6f2f7f3fb0d8f55937152a5e12994009ed152192018da30219200
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNkIwOjE2QUI3OTo0MDhDMUUyOjUxRjczRUU6NkIwMjFGOEMiLCJ2aXNpdG9yX2lkIjoiNjQwMjcxNTY0MjUxNzMzOTAwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac219657cfb1ed693346e61ed516aeb7a11920eeee8de469e74cd37bf620c986c6
hovercard-subject-tagpull_request:3276056682
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/144742/files
twitter:imagehttps://avatars.githubusercontent.com/u/35182391?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/35182391?s=400&v=4
og:image:altWhen the JIT trace builder translates POP_JUMP_IF_TRUE instructions, it determines the branch direction by comparing next_instr (where execution actually went) against computed_jump_instr (the jump...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/144742/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F144742%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F144742%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/144742/files
Reloadhttps://github.com/python/cpython/pull/144742/files
Reloadhttps://github.com/python/cpython/pull/144742/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Fidget-Spinnerhttps://github.com/Fidget-Spinner
python:mainhttps://github.com/python/cpython/tree/main
cocolato:fix-gh-144681https://github.com/cocolato/cpython/tree/fix-gh-144681
Conversation 12 https://github.com/python/cpython/pull/144742
Commits 7 https://github.com/python/cpython/pull/144742/commits
Checks 66 https://github.com/python/cpython/pull/144742/checks
Files changed https://github.com/python/cpython/pull/144742/files
Please reload this pagehttps://github.com/python/cpython/pull/144742/files
gh-144681: Fix JIT trace builder assertion failure when conditional branch jump target coincides with fallthrough target https://github.com/python/cpython/pull/144742/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/144742/files
1373bd1 fix bug cocolato Feb 12, 2026 https://github.com/python/cpython/pull/144742/commits/1373bd15f43f17d85f803fe000f3898b37443e46
4b107f5 📜🤖 Added by blurb_it. blurb-it[bot] Feb 12, 2026 https://github.com/python/cpython/pull/144742/commits/4b107f5211a600b99997ee6822af4359170469a5
efdba4f address code review cocolato Mar 9, 2026 https://github.com/python/cpython/pull/144742/commits/efdba4f043020b61e391b2ddd4535ee4ea2df611
1870e2f Merge branch 'main' into fix-gh-144681 cocolato Mar 9, 2026 https://github.com/python/cpython/pull/144742/commits/1870e2f777f7c1d89e1670817e22b3ff4703f94f
c36251c Merge branch 'main' into fix-gh-144681 cocolato Mar 9, 2026 https://github.com/python/cpython/pull/144742/commits/c36251c2fc34b44a7439b9e18c25ccbe900b7678
aa8ef2e Merge branch 'main' into fix-gh-144681 markshannon Mar 9, 2026 https://github.com/python/cpython/pull/144742/commits/aa8ef2ecd96a080fc7997df305424055c309135f
d84ef06 Merge branch 'main' into fix-gh-144681 cocolato Mar 10, 2026 https://github.com/python/cpython/pull/144742/commits/d84ef062aafba6033107a3afbaec91cd52bbecba
Clear filters https://github.com/python/cpython/pull/144742/files
Please reload this pagehttps://github.com/python/cpython/pull/144742/files
Please reload this pagehttps://github.com/python/cpython/pull/144742/files
test_opt.py https://github.com/python/cpython/pull/144742/files#diff-67b5bd915e37f77df79907865982648172c27d3b96fbb072b30a73c6a2735439
2026-02-12-12-39-50.gh-issue-144681.Ns2OT2.rst https://github.com/python/cpython/pull/144742/files#diff-f55243e8e1e920a2f68603b4192fb94c6930cb15e6048108490064f95f34783e
optimizer.c https://github.com/python/cpython/pull/144742/files#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
Lib/test/test_capi/test_opt.pyhttps://github.com/python/cpython/pull/144742/files#diff-67b5bd915e37f77df79907865982648172c27d3b96fbb072b30a73c6a2735439
View file https://github.com/cocolato/cpython/blob/d84ef062aafba6033107a3afbaec91cd52bbecba/Lib/test/test_capi/test_opt.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/144742/{{ revealButtonHref }}
https://github.com/python/cpython/pull/144742/files#diff-67b5bd915e37f77df79907865982648172c27d3b96fbb072b30a73c6a2735439
https://github.com/python/cpython/pull/144742/files#diff-67b5bd915e37f77df79907865982648172c27d3b96fbb072b30a73c6a2735439
Misc/NEWS.d/next/Core_and_Builtins/2026-02-12-12-39-50.gh-issue-144681.Ns2OT2.rsthttps://github.com/python/cpython/pull/144742/files#diff-f55243e8e1e920a2f68603b4192fb94c6930cb15e6048108490064f95f34783e
View file https://github.com/cocolato/cpython/blob/d84ef062aafba6033107a3afbaec91cd52bbecba/Misc/NEWS.d/next/Core_and_Builtins/2026-02-12-12-39-50.gh-issue-144681.Ns2OT2.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/144742/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L302
Python/optimizer.chttps://github.com/python/cpython/pull/144742/files#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
View file https://github.com/cocolato/cpython/blob/d84ef062aafba6033107a3afbaec91cd52bbecba/Python/optimizer.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/144742/{{ revealButtonHref }}
https://github.com/python/cpython/pull/144742/files#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
https://github.com/python/cpython/pull/144742/files#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
Please reload this pagehttps://github.com/python/cpython/pull/144742/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.