René's URL Explorer Experiment


Title: [3.12] gh-143935: Email preserve parens when folding comments (GH-143936) by miss-islington · Pull Request #144036 · python/cpython · GitHub

Open Graph Title: [3.12] gh-143935: Email preserve parens when folding comments (GH-143936) by miss-islington · Pull Request #144036 · python/cpython

X Title: [3.12] gh-143935: Email preserve parens when folding comments (GH-143936) by miss-islington · Pull Request #144036 · python/cpython

Description: Fix a bug in the folding of comments when flattening an email message using a modern email policy. Comments consisting of a very long sequence of non-foldable characters could trigger a forced line wrap that omitted the required leading space on the continuation line, causing the remainder of the comment to be interpreted as a new header field. This enabled header injection with carefully crafted inputs. (cherry picked from commit 17d1490) Co-authored-by: Seth Michael Larson seth@python.org Co-authored-by: Denis Ledoux dle@odoo.com Issue: gh-143935

Open Graph Description: Fix a bug in the folding of comments when flattening an email message using a modern email policy. Comments consisting of a very long sequence of non-foldable characters could trigger a forced line...

X Description: Fix a bug in the folding of comments when flattening an email message using a modern email policy. Comments consisting of a very long sequence of non-foldable characters could trigger a forced line...

Opengraph URL: https://github.com/python/cpython/pull/144036

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b99bdcd3-1b7a-113c-654f-cf6dcf0e68fb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAEC0:1CF8E4:32E8C5:4719E5:6B006C6C
html-safe-nonce4abb2b203d2ce2228d01acb0e45cf052d5d4aff5f2276b69b4f284dd047127c1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUMwOjFDRjhFNDozMkU4QzU6NDcxOUU1OjZCMDA2QzZDIiwidmlzaXRvcl9pZCI6IjE1MjQ1NzAwMDg2ODY5ODAyMDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf27859231818d87adc7994371a408933fe28e24657b3c0267ab439c186b2ca7f
hovercard-subject-tagpull_request:3187661925
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/144036/files
twitter:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
og:image:altFix a bug in the folding of comments when flattening an email message using a modern email policy. Comments consisting of a very long sequence of non-foldable characters could trigger a forced line...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None6527e91c60c0b29d16606ff32ac5df8ecdc37a2a62205ea057a14d7762c870fa
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release46f1cd2ae3cd8ae1a81019b5d619742e76f13bbd
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/144036/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F144036%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F144036%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/144036/files
Reloadhttps://github.com/python/cpython/pull/144036/files
Reloadhttps://github.com/python/cpython/pull/144036/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pablogsalhttps://github.com/pablogsal
python:3.12https://github.com/python/cpython/tree/3.12
miss-islington:backport-17d1490-3.12https://github.com/miss-islington/cpython/tree/backport-17d1490-3.12
Conversation 0 https://github.com/python/cpython/pull/144036
Commits 2 https://github.com/python/cpython/pull/144036/commits
Checks 24 https://github.com/python/cpython/pull/144036/checks
Files changed https://github.com/python/cpython/pull/144036/files
Please reload this pagehttps://github.com/python/cpython/pull/144036/files
[3.12] gh-143935: Email preserve parens when folding comments (GH-143936) https://github.com/python/cpython/pull/144036/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/144036/files
3900a2c gh-143935: Email preserve parens when folding comments (GH-143936) sethmlarson Jan 19, 2026 https://github.com/python/cpython/pull/144036/commits/3900a2cb7d8321629717b8483179263a968bf552
b7ab26f Merge branch '3.12' into backport-17d1490-3.12 pablogsal Jan 25, 2026 https://github.com/python/cpython/pull/144036/commits/b7ab26fae6dcc3c2898ae65e91e4c0550aabd7bf
Clear filters https://github.com/python/cpython/pull/144036/files
Please reload this pagehttps://github.com/python/cpython/pull/144036/files
Please reload this pagehttps://github.com/python/cpython/pull/144036/files
_header_value_parser.py https://github.com/python/cpython/pull/144036/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
test__header_value_parser.py https://github.com/python/cpython/pull/144036/files#diff-903868bb695b972a6c6c6fec7fdf1aedd13ef65e7e076aef8b0964a9ff004839
2026-01-16-14-40-31.gh-issue-143935.U2YtKl.rst https://github.com/python/cpython/pull/144036/files#diff-b83bc0eacac4f7a5c0ac64cf2de6334e2853c771e72ccea47b2f4f822f201223
https://github.com/python/cpython/blob/3.12/.github/CODEOWNERS#L86
Lib/email/_header_value_parser.pyhttps://github.com/python/cpython/pull/144036/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
View file https://github.com/miss-islington/cpython/blob/b7ab26fae6dcc3c2898ae65e91e4c0550aabd7bf/Lib/email/_header_value_parser.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/144036/{{ revealButtonHref }}
https://github.com/python/cpython/pull/144036/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/pull/144036/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/pull/144036/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/pull/144036/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/pull/144036/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/pull/144036/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/blob/3.12/.github/CODEOWNERS#L86
Lib/test/test_email/test__header_value_parser.pyhttps://github.com/python/cpython/pull/144036/files#diff-903868bb695b972a6c6c6fec7fdf1aedd13ef65e7e076aef8b0964a9ff004839
View file https://github.com/miss-islington/cpython/blob/b7ab26fae6dcc3c2898ae65e91e4c0550aabd7bf/Lib/test/test_email/test__header_value_parser.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/144036/{{ revealButtonHref }}
https://github.com/python/cpython/pull/144036/files#diff-903868bb695b972a6c6c6fec7fdf1aedd13ef65e7e076aef8b0964a9ff004839
https://github.com/python/cpython/pull/144036/files#diff-903868bb695b972a6c6c6fec7fdf1aedd13ef65e7e076aef8b0964a9ff004839
Misc/NEWS.d/next/Security/2026-01-16-14-40-31.gh-issue-143935.U2YtKl.rsthttps://github.com/python/cpython/pull/144036/files#diff-b83bc0eacac4f7a5c0ac64cf2de6334e2853c771e72ccea47b2f4f822f201223
View file https://github.com/miss-islington/cpython/blob/b7ab26fae6dcc3c2898ae65e91e4c0550aabd7bf/Misc/NEWS.d/next/Security/2026-01-16-14-40-31.gh-issue-143935.U2YtKl.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/144036/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.