| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d99f2100-bf72-c1ee-2e56-ae33da10fa46 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BB0A:2CE7C1:9A1F2CF:CCA1718:696E194D |
| html-safe-nonce | 880aff1fad3da2bc93e0cb145c0c74c8f347d914b1a8a09ea74dd8a008395bf8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjBBOjJDRTdDMTo5QTFGMkNGOkNDQTE3MTg6Njk2RTE5NEQiLCJ2aXNpdG9yX2lkIjoiNjUxOTU2NzMxMTIwMTc2OTgwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 035e1987da9b905342b6bf6acc0c76a3b4f165f278915c3f4cb4edb32928b300 |
| hovercard-subject-tag | pull_request:3183202641 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/143950/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/823970089faf108dfd4334497689a9d9fc0ea8ade4dfca357ebca47e106beffa/python/cpython/pull/143950 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/823970089faf108dfd4334497689a9d9fc0ea8ade4dfca357ebca47e106beffa/python/cpython/pull/143950 |
| og:image:alt | gh-143948: Explain graphlib's cycle-finding code
Long overdue comments explaining what's going on, and why. No code changes, just comments. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tim-one |
| hostname | github.com |
| expected-hostname | github.com |
| None | 113cc336e7105fbb9f2ee8beb67c6cc584d65fa66a8a1a5dd236ba66db174af7 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d23f8b0bc31294c6a73ba2f3adfdd8c7052ca1e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/143950#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F143950 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F143950 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/143950 |
| Reload | https://github.com/python/cpython/pull/143950 |
| Reload | https://github.com/python/cpython/pull/143950 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/143950 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/143950 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/143950#issue-comment-box |
| tim-one | https://github.com/tim-one |
| python:main | https://github.com/python/cpython/tree/main |
| tim-one:cycle | https://github.com/tim-one/cpython/tree/cycle |
|
GH-143948: Explain graphlib's cycle-finding code
| https://github.com/python/cpython/pull/143950#top |
| tim-one | https://github.com/tim-one |
| python:main | https://github.com/python/cpython/tree/main |
| tim-one:cycle | https://github.com/tim-one/cpython/tree/cycle |
|
Conversation
5
| https://github.com/python/cpython/pull/143950 |
|
Commits
6
| https://github.com/python/cpython/pull/143950/commits |
|
Checks
41
| https://github.com/python/cpython/pull/143950/checks |
|
Files changed
1
| https://github.com/python/cpython/pull/143950/files |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/tim-one |
| tim-one | https://github.com/tim-one |
| Jan 17, 2026 | https://github.com/python/cpython/pull/143950#issue-3824223031 |
| gh-143948 | https://github.com/python/cpython/issues/143948 |
| Please reload this page | https://github.com/python/cpython/pull/143950 |
|
| https://github.com/tim-one |
| Explain topsort's cycle-finding algorithm, and why it's written that … | https://github.com/python/cpython/pull/143950/commits/5d2bdb4c542105137d8968289d18c33ee82b1a70 |
| 5d2bdb4 | https://github.com/python/cpython/pull/143950/commits/5d2bdb4c542105137d8968289d18c33ee82b1a70 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Jan 17, 2026 | https://github.com/python/cpython/pull/143950#event-22108900348 |
| https://github.com/tim-one |
| tim-one | https://github.com/tim-one |
| Jan 17, 2026 | https://github.com/python/cpython/pull/143950#event-22108905870 |
| https://github.com/tim-one |
| tim-one | https://github.com/tim-one |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
|
stdlib
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astdlib |
| Jan 17, 2026 | https://github.com/python/cpython/pull/143950#event-22108912362 |
| https://github.com/tim-one |
| tim-one | https://github.com/tim-one |
| Jan 17, 2026 | https://github.com/python/cpython/pull/143950#event-22108915687 |
|
Explain graphlib's cycle-finding code
#143948
| https://github.com/python/cpython/issues/143948 |
|
| https://github.com/tim-one |
| Merge branch 'main' into cycle | https://github.com/python/cpython/pull/143950/commits/103b6403b68f406a26d819f47c9185224ff0ba5e |
| 103b640 | https://github.com/python/cpython/pull/143950/commits/103b6403b68f406a26d819f47c9185224ff0ba5e |
| https://github.com/tim-one |
| tim-one | https://github.com/tim-one |
| Jan 17, 2026 | https://github.com/python/cpython/pull/143950#event-22108923830 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
Jan 17, 2026
| https://github.com/python/cpython/pull/143950#ref-issue-3824154135 |
|
Explain graphlib's cycle-finding code
#143948
| https://github.com/python/cpython/issues/143948 |
| tim-one | https://github.com/tim-one |
| January 16, 2026 20:05 | https://github.com/python/cpython/pull/143950#commits-pushed-2e2c3cc |
|
| https://github.com/tim-one |
| typo | https://github.com/python/cpython/pull/143950/commits/2e2c3cc2769e23cc35f7f68ac666e3dbda9d2ca4 |
| 2e2c3cc | https://github.com/python/cpython/pull/143950/commits/2e2c3cc2769e23cc35f7f68ac666e3dbda9d2ca4 |
|
| https://github.com/tim-one |
| Merge remote-tracking branch 'upstream/main' into cycle | https://github.com/python/cpython/pull/143950/commits/8d11ebfd1cdef6768aed2de374a084027d9c78d7 |
| 8d11ebf | https://github.com/python/cpython/pull/143950/commits/8d11ebfd1cdef6768aed2de374a084027d9c78d7 |
|
| https://github.com/tim-one |
| Merge branch 'cycle' of | https://github.com/python/cpython/pull/143950/commits/7dd5e1604fb144fff8570895d6b72fcddab9998c |
| https://github.com/tim-one/cpython | https://github.com/tim-one/cpython |
| into cycle | https://github.com/python/cpython/pull/143950/commits/7dd5e1604fb144fff8570895d6b72fcddab9998c |
| 7dd5e16 | https://github.com/python/cpython/pull/143950/commits/7dd5e1604fb144fff8570895d6b72fcddab9998c |
|
| https://github.com/tim-one |
| Typo. | https://github.com/python/cpython/pull/143950/commits/437593a834d8911c2dc239dde09f888d11a80af5 |
| 437593a | https://github.com/python/cpython/pull/143950/commits/437593a834d8911c2dc239dde09f888d11a80af5 |
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
|
Jan 18, 2026
| https://github.com/python/cpython/pull/143950#pullrequestreview-3675825659 |
|
View reviewed changes
| https://github.com/python/cpython/pull/143950/files/437593a834d8911c2dc239dde09f888d11a80af5 |
| Lib/graphlib.py | https://github.com/python/cpython/pull/143950/files/437593a834d8911c2dc239dde09f888d11a80af5#diff-194691095e8943761551bf8e2c2cad2085c62434f9216b720218d5061448119f |
| picnixz | https://github.com/picnixz |
| Jan 18, 2026 | https://github.com/python/cpython/pull/143950#discussion_r2702800780 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/143950 |
| Lib/graphlib.py | https://github.com/python/cpython/pull/143950/files/437593a834d8911c2dc239dde09f888d11a80af5#diff-194691095e8943761551bf8e2c2cad2085c62434f9216b720218d5061448119f |
| picnixz | https://github.com/picnixz |
| Jan 18, 2026 | https://github.com/python/cpython/pull/143950#discussion_r2702801210 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/143950 |
| Lib/graphlib.py | https://github.com/python/cpython/pull/143950/files/437593a834d8911c2dc239dde09f888d11a80af5#diff-194691095e8943761551bf8e2c2cad2085c62434f9216b720218d5061448119f |
| picnixz | https://github.com/picnixz |
| Jan 18, 2026 | https://github.com/python/cpython/pull/143950#discussion_r2702801522 |
| Please reload this page | https://github.com/python/cpython/pull/143950 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/143950 |
| Lib/graphlib.py | https://github.com/python/cpython/pull/143950/files/437593a834d8911c2dc239dde09f888d11a80af5#diff-194691095e8943761551bf8e2c2cad2085c62434f9216b720218d5061448119f |
| picnixz | https://github.com/picnixz |
| Jan 18, 2026 | https://github.com/python/cpython/pull/143950#discussion_r2702801855 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/143950 |
| Lib/graphlib.py | https://github.com/python/cpython/pull/143950/files/437593a834d8911c2dc239dde09f888d11a80af5#diff-194691095e8943761551bf8e2c2cad2085c62434f9216b720218d5061448119f |
| picnixz | https://github.com/picnixz |
| Jan 18, 2026 | https://github.com/python/cpython/pull/143950#discussion_r2702812780 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/143950 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F143950 |
|
| https://github.com/picnixz |
|
picnixz
| https://github.com/picnixz |
|
| https://github.com/python/cpython/pull/143950/files/437593a834d8911c2dc239dde09f888d11a80af5 |
|
| https://github.com/tim-one |
|
tim-one
| https://github.com/tim-one |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
|
stdlib
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astdlib |
|
Explain graphlib's cycle-finding code
| https://github.com/python/cpython/issues/143948 |
| Please reload this page | https://github.com/python/cpython/pull/143950 |
|
| https://github.com/tim-one |
|
| https://github.com/picnixz |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |