René's URL Explorer Experiment


Title: gh-143543: Fix re-entrant use-after-free in itertools.groupby by VanshAgarwal24036 · Pull Request #143738 · python/cpython · GitHub

Open Graph Title: gh-143543: Fix re-entrant use-after-free in itertools.groupby by VanshAgarwal24036 · Pull Request #143738 · python/cpython

X Title: gh-143543: Fix re-entrant use-after-free in itertools.groupby by VanshAgarwal24036 · Pull Request #143738 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Fix a use-after-free in itertools.groupby when a user-defined eq re-enters next(groupby) during key comparison. groupby_next() compared borrowed references to currkey and tgtkey using PyObject_Rich...

X Description: Fix a use-after-free in itertools.groupby when a user-defined eq re-enters next(groupby) during key comparison. groupby_next() compared borrowed references to currkey and tgtkey using PyObject_Rich...

Opengraph URL: https://github.com/python/cpython/pull/143738

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:7e1075db-5590-60f2-6003-e8feb9ab1210
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A44:198E4:60644BB:87BC3A4:6A57402E
html-safe-nonced57d6c766a4240a44b425ad2e8f283c07dc3222f3d7f0d7244170e3d1ccfc5b9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTQ0OjE5OEU0OjYwNjQ0QkI6ODdCQzNBNDo2QTU3NDAyRSIsInZpc2l0b3JfaWQiOiI0MzE4NTcxMTM2NjY3ODI4MjcwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf142da7d827a1364755ca8e24460f03f0dcee52d7b65af8052d5d7d1fc002de1
hovercard-subject-tagpull_request:3166591033
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/143738/commits
twitter:imagehttps://opengraph.githubassets.com/9e40da099ca98ed62bd706e8af61a538ba01ac1e5700237c935dad5d53314b60/python/cpython/pull/143738
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9e40da099ca98ed62bd706e8af61a538ba01ac1e5700237c935dad5d53314b60/python/cpython/pull/143738
og:image:altFix a use-after-free in itertools.groupby when a user-defined eq re-enters next(groupby) during key comparison. groupby_next() compared borrowed references to currkey and tgtkey using PyObject_Rich...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameVanshAgarwal24036
hostnamegithub.com
expected-hostnamegithub.com
None4e7a7296a3830877cf21a6ad2a972c9e618a48915e03966cf0c53eb08e5aad98
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2576d1f0198cf1588faf2edf27f1ed120903be10
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/143738/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F143738%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F143738%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/143738/commits
Reloadhttps://github.com/python/cpython/pull/143738/commits
Reloadhttps://github.com/python/cpython/pull/143738/commits
Please reload this pagehttps://github.com/python/cpython/pull/143738/commits
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/143738/commits
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
VanshAgarwal24036:gh-143543-groupby-uafhttps://github.com/VanshAgarwal24036/cpython/tree/gh-143543-groupby-uaf
Conversationhttps://github.com/python/cpython/pull/143738
Commits22 (22)https://github.com/python/cpython/pull/143738/commits
Checkshttps://github.com/python/cpython/pull/143738/checks
Files changedhttps://github.com/python/cpython/pull/143738/files
gh-143543: Fix re-entrant use-after-free in itertools.groupbyhttps://github.com/python/cpython/pull/143738/commits#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
VanshAgarwal24036:gh-143543-groupby-uafhttps://github.com/VanshAgarwal24036/cpython/tree/gh-143543-groupby-uaf
gh-143543: Fix re-entrant use-after-free in itertools.groupbyhttps://github.com/python/cpython/pull/143738/commits/e898626432a811fb000251efc12927cbd7c57836
https://github.com/VanshAgarwal24036
VanshAgarwal24036https://github.com/python/cpython/commits?author=VanshAgarwal24036
e898626https://github.com/python/cpython/pull/143738/commits/e898626432a811fb000251efc12927cbd7c57836
https://github.com/python/cpython/tree/e898626432a811fb000251efc12927cbd7c57836
Fix whitespace per prekhttps://github.com/python/cpython/pull/143738/commits/ba974bca279ae55feadbd099733cb61f82027d1e
https://github.com/VanshAgarwal24036
VanshAgarwal24036https://github.com/python/cpython/commits?author=VanshAgarwal24036
ba974bchttps://github.com/python/cpython/pull/143738/commits/ba974bca279ae55feadbd099733cb61f82027d1e
https://github.com/python/cpython/tree/ba974bca279ae55feadbd099733cb61f82027d1e
Add NEWS entry for itertools.groupby crash fixhttps://github.com/python/cpython/pull/143738/commits/0debc2a0bd1fd2e3a7f7036e9215289733a37e34
https://github.com/VanshAgarwal24036
VanshAgarwal24036https://github.com/python/cpython/commits?author=VanshAgarwal24036
0debc2ahttps://github.com/python/cpython/pull/143738/commits/0debc2a0bd1fd2e3a7f7036e9215289733a37e34
https://github.com/python/cpython/tree/0debc2a0bd1fd2e3a7f7036e9215289733a37e34
Fix NEWS filename for gh-143543https://github.com/python/cpython/pull/143738/commits/8d831767d3ee54448b3c8d0e038a0fc0258a8ff6
https://github.com/VanshAgarwal24036
VanshAgarwal24036https://github.com/python/cpython/commits?author=VanshAgarwal24036
8d83176https://github.com/python/cpython/pull/143738/commits/8d831767d3ee54448b3c8d0e038a0fc0258a8ff6
https://github.com/python/cpython/tree/8d831767d3ee54448b3c8d0e038a0fc0258a8ff6
Fix NEWS entry type for gh-143543https://github.com/python/cpython/pull/143738/commits/ca932bf3433216f30b038fc47ced40082129d50a
https://github.com/VanshAgarwal24036
VanshAgarwal24036https://github.com/python/cpython/commits?author=VanshAgarwal24036
ca932bfhttps://github.com/python/cpython/pull/143738/commits/ca932bf3433216f30b038fc47ced40082129d50a
https://github.com/python/cpython/tree/ca932bf3433216f30b038fc47ced40082129d50a
Remove incorrect NEWS files for gh-143543https://github.com/python/cpython/pull/143738/commits/0e86303246ba709a7ecfbd871214899171ef8642
https://github.com/VanshAgarwal24036
VanshAgarwal24036https://github.com/python/cpython/commits?author=VanshAgarwal24036
0e86303https://github.com/python/cpython/pull/143738/commits/0e86303246ba709a7ecfbd871214899171ef8642
https://github.com/python/cpython/tree/0e86303246ba709a7ecfbd871214899171ef8642
Avoid borrowed references during groupby key comparisonhttps://github.com/python/cpython/pull/143738/commits/740218ccfe96ab468263a0f5c09a8c54628e7e44
https://github.com/VanshAgarwal24036
VanshAgarwal24036https://github.com/python/cpython/commits?author=VanshAgarwal24036
740218chttps://github.com/python/cpython/pull/143738/commits/740218ccfe96ab468263a0f5c09a8c54628e7e44
https://github.com/python/cpython/tree/740218ccfe96ab468263a0f5c09a8c54628e7e44
Clarify NEWS entry wordinghttps://github.com/python/cpython/pull/143738/commits/e3a54be56f0739c46983285a7825c35e80a1367c
https://github.com/VanshAgarwal24036
VanshAgarwal24036https://github.com/python/cpython/commits?author=VanshAgarwal24036
e3a54behttps://github.com/python/cpython/pull/143738/commits/e3a54be56f0739c46983285a7825c35e80a1367c
https://github.com/python/cpython/tree/e3a54be56f0739c46983285a7825c35e80a1367c
Fix refcounting during groupby key comparisonhttps://github.com/python/cpython/pull/143738/commits/998334526afc8d636572e30a831697aaf6c2e70b
https://github.com/VanshAgarwal24036
VanshAgarwal24036https://github.com/python/cpython/commits?author=VanshAgarwal24036
9983345https://github.com/python/cpython/pull/143738/commits/998334526afc8d636572e30a831697aaf6c2e70b
https://github.com/python/cpython/tree/998334526afc8d636572e30a831697aaf6c2e70b
Add NEWS entry via blurb for itertools.groupby crashhttps://github.com/python/cpython/pull/143738/commits/1ea51c06d7afcdbded3acf9d50e4a90736c615a9
https://github.com/VanshAgarwal24036
VanshAgarwal24036https://github.com/python/cpython/commits?author=VanshAgarwal24036
1ea51c0https://github.com/python/cpython/pull/143738/commits/1ea51c06d7afcdbded3acf9d50e4a90736c615a9
https://github.com/python/cpython/tree/1ea51c06d7afcdbded3acf9d50e4a90736c615a9
Fix duplicate variable declarations in groupby_nexthttps://github.com/python/cpython/pull/143738/commits/336c36748ab272ce0f980b19121084338d72772a
https://github.com/VanshAgarwal24036
VanshAgarwal24036https://github.com/python/cpython/commits?author=VanshAgarwal24036
336c367https://github.com/python/cpython/pull/143738/commits/336c36748ab272ce0f980b19121084338d72772a
https://github.com/python/cpython/tree/336c36748ab272ce0f980b19121084338d72772a
itertools: hold strong references during groupby key comparisonhttps://github.com/python/cpython/pull/143738/commits/9cbe1a6c3651ddde58eb9b388ff861a39205a058
https://github.com/VanshAgarwal24036
VanshAgarwal24036https://github.com/python/cpython/commits?author=VanshAgarwal24036
9cbe1a6https://github.com/python/cpython/pull/143738/commits/9cbe1a6c3651ddde58eb9b388ff861a39205a058
https://github.com/python/cpython/tree/9cbe1a6c3651ddde58eb9b388ff861a39205a058
Clarify re-entrant groupby key comparison commenthttps://github.com/python/cpython/pull/143738/commits/8c61450233d9cea60df098e63e9de4aead7d224c
https://github.com/VanshAgarwal24036
VanshAgarwal24036https://github.com/python/cpython/commits?author=VanshAgarwal24036
8c61450https://github.com/python/cpython/pull/143738/commits/8c61450233d9cea60df098e63e9de4aead7d224c
https://github.com/python/cpython/tree/8c61450233d9cea60df098e63e9de4aead7d224c
Update Modules/itertoolsmodule.chttps://github.com/python/cpython/pull/143738/commits/90e995b1b817ca47ee17dc90d7e68bfa888811c2
VanshAgarwal24036https://github.com/python/cpython/commits?author=VanshAgarwal24036
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
90e995bhttps://github.com/python/cpython/pull/143738/commits/90e995b1b817ca47ee17dc90d7e68bfa888811c2
https://github.com/python/cpython/tree/90e995b1b817ca47ee17dc90d7e68bfa888811c2
Update Lib/test/test_itertools.pyhttps://github.com/python/cpython/pull/143738/commits/4f2338f1c50fc29ffeed0da2d8491ad6f500a569
VanshAgarwal24036https://github.com/python/cpython/commits?author=VanshAgarwal24036
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
4f2338fhttps://github.com/python/cpython/pull/143738/commits/4f2338f1c50fc29ffeed0da2d8491ad6f500a569
https://github.com/python/cpython/tree/4f2338f1c50fc29ffeed0da2d8491ad6f500a569
Simplify groupby re-entrancy testhttps://github.com/python/cpython/pull/143738/commits/2cac26be898e86976f2211387fd82e2a1cfa7236
https://github.com/VanshAgarwal24036
VanshAgarwal24036https://github.com/python/cpython/commits?author=VanshAgarwal24036
2cac26bhttps://github.com/python/cpython/pull/143738/commits/2cac26be898e86976f2211387fd82e2a1cfa7236
https://github.com/python/cpython/tree/2cac26be898e86976f2211387fd82e2a1cfa7236
Move rcmp declaration and clarify re-entrancy commenthttps://github.com/python/cpython/pull/143738/commits/fed7db70b1fccd0e9d67fa3631c21ec0de3556c7
https://github.com/VanshAgarwal24036
VanshAgarwal24036https://github.com/python/cpython/commits?author=VanshAgarwal24036
fed7db7https://github.com/python/cpython/pull/143738/commits/fed7db70b1fccd0e9d67fa3631c21ec0de3556c7
https://github.com/python/cpython/tree/fed7db70b1fccd0e9d67fa3631c21ec0de3556c7
Move comment before declarations and inline rcmphttps://github.com/python/cpython/pull/143738/commits/4939083e12339646ff3dea681760e282b4fb0c74
https://github.com/VanshAgarwal24036
VanshAgarwal24036https://github.com/python/cpython/commits?author=VanshAgarwal24036
4939083https://github.com/python/cpython/pull/143738/commits/4939083e12339646ff3dea681760e282b4fb0c74
https://github.com/python/cpython/tree/4939083e12339646ff3dea681760e282b4fb0c74
Remove Extra lineshttps://github.com/python/cpython/pull/143738/commits/e42b9b419c30f47177b62188fbc9c6d287f4f801
https://github.com/VanshAgarwal24036
VanshAgarwal24036https://github.com/python/cpython/commits?author=VanshAgarwal24036
e42b9b4https://github.com/python/cpython/pull/143738/commits/e42b9b419c30f47177b62188fbc9c6d287f4f801
https://github.com/python/cpython/tree/e42b9b419c30f47177b62188fbc9c6d287f4f801
Remove extra Lineshttps://github.com/python/cpython/pull/143738/commits/e29c8184917ff9936d8ff58f3858e9de73f9ecea
https://github.com/VanshAgarwal24036
VanshAgarwal24036https://github.com/python/cpython/commits?author=VanshAgarwal24036
e29c818https://github.com/python/cpython/pull/143738/commits/e29c8184917ff9936d8ff58f3858e9de73f9ecea
https://github.com/python/cpython/tree/e29c8184917ff9936d8ff58f3858e9de73f9ecea
Update Lib/test/test_itertools.pyhttps://github.com/python/cpython/pull/143738/commits/4be9d4f3962a95354ce2d247cafd92bd8a5ae4af
VanshAgarwal24036https://github.com/python/cpython/commits?author=VanshAgarwal24036
encukouhttps://github.com/python/cpython/commits?author=encukou
4be9d4fhttps://github.com/python/cpython/pull/143738/commits/4be9d4f3962a95354ce2d247cafd92bd8a5ae4af
https://github.com/python/cpython/tree/4be9d4f3962a95354ce2d247cafd92bd8a5ae4af
Merge branch 'main' into gh-143543-groupby-uafhttps://github.com/python/cpython/pull/143738/commits/b48d388d3e00a96505f828134734c52d2fadc848
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
b48d388https://github.com/python/cpython/pull/143738/commits/b48d388d3e00a96505f828134734c52d2fadc848
https://github.com/python/cpython/tree/b48d388d3e00a96505f828134734c52d2fadc848
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.