René's URL Explorer Experiment


Title: gh-143375: Fix a crash in `BufferedWriter.seek` when passing an object with a specially crafted `__index__` by tomasr8 · Pull Request #143577 · python/cpython · GitHub

Open Graph Title: gh-143375: Fix a crash in `BufferedWriter.seek` when passing an object with a specially crafted `__index__` by tomasr8 · Pull Request #143577 · python/cpython

X Title: gh-143375: Fix a crash in `BufferedWriter.seek` when passing an object with a specially crafted `__index__` by tomasr8 · Pull Request #143577 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Adds a check after the call to PyNumber_AsOff_t which could have closed the file as a side-effect. Issue: Null pointer dereference in BufferedWriter.seek during re-entrant close #143375

X Description: Adds a check after the call to PyNumber_AsOff_t which could have closed the file as a side-effect. Issue: Null pointer dereference in BufferedWriter.seek during re-entrant close #143375

Opengraph URL: https://github.com/python/cpython/pull/143577

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:93791514-28d3-0a91-fd6f-9a47994162f6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA4F4:36A3E:30D41F0:41230F3:6B01EECB
html-safe-nonce673f01334985fdc5fe3b4f3af96a6fa168544ff517cf211c7a8728762bd595e8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNEY0OjM2QTNFOjMwRDQxRjA6NDEyMzBGMzo2QjAxRUVDQiIsInZpc2l0b3JfaWQiOiIyMjE5NDg4MzI1NTQxMTYyNjk5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac42585c92e1eac24a3bce065c4c305627a95ee3c413d3d5883d0ab952da71193f
hovercard-subject-tagpull_request:3157163756
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/143577/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6bdb3e4779b4ec32c807780e77f0f84a281450738b18617ea6997a3b0d7b7d16/python/cpython/pull/143577
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6bdb3e4779b4ec32c807780e77f0f84a281450738b18617ea6997a3b0d7b7d16/python/cpython/pull/143577
og:image:altAdds a check after the call to PyNumber_AsOff_t which could have closed the file as a side-effect. Issue: Null pointer dereference in BufferedWriter.seek during re-entrant close #143375
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametomasr8
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/143577#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F143577
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F143577
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/143577
Reloadhttps://github.com/python/cpython/pull/143577
Reloadhttps://github.com/python/cpython/pull/143577
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
tomasr8https://github.com/tomasr8
python:mainhttps://github.com/python/cpython/tree/main
tomasr8:buffer-seekhttps://github.com/tomasr8/cpython/tree/buffer-seek
Conversationhttps://github.com/python/cpython/pull/143577
Commits15 (15)https://github.com/python/cpython/pull/143577/commits
Checkshttps://github.com/python/cpython/pull/143577/checks
Files changedhttps://github.com/python/cpython/pull/143577/files
gh-143375: Fix a crash in BufferedWriter.seek when passing an object with a specially crafted __index__https://github.com/python/cpython/pull/143577#top
tomasr8https://github.com/tomasr8
python:mainhttps://github.com/python/cpython/tree/main
tomasr8:buffer-seekhttps://github.com/tomasr8/cpython/tree/buffer-seek
https://github.com/tomasr8
tomasr8https://github.com/tomasr8
Jan 8, 2026https://github.com/python/cpython/pull/143577#issue-3794048599
Please reload this pagehttps://github.com/python/cpython/pull/143577
Null pointer dereference in BufferedWriter.seek during re-entrant close #143375https://github.com/python/cpython/issues/143375
Please reload this pagehttps://github.com/python/cpython/pull/143577
tomasr8https://github.com/tomasr8
January 7, 2026 23:58https://github.com/python/cpython/pull/143577#commits-pushed-f9afb39
https://github.com/tomasr8
Fix crash when seeking a closed BufferedWriterhttps://github.com/python/cpython/pull/143577/commits/f9afb39a7cc07490aae204824d1459030f456612
f9afb39https://github.com/python/cpython/pull/143577/commits/f9afb39a7cc07490aae204824d1459030f456612
https://github.com/tomasr8
Add news entryhttps://github.com/python/cpython/pull/143577/commits/039bf4151ed411c2520ff63eede8c6b102ef10c3
039bf41https://github.com/python/cpython/pull/143577/commits/039bf4151ed411c2520ff63eede8c6b102ef10c3
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jan 8, 2026 https://github.com/python/cpython/pull/143577#ref-issue-3777649483
Null pointer dereference in BufferedWriter.seek during re-entrant close #143375 https://github.com/python/cpython/issues/143375
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jan 8, 2026https://github.com/python/cpython/pull/143577#event-21930553569
https://github.com/StanFromIreland
StanFromIrelandhttps://github.com/StanFromIreland
Jan 8, 2026 https://github.com/python/cpython/pull/143577#pullrequestreview-3641263902
View reviewed changes https://github.com/python/cpython/pull/143577/files/039bf4151ed411c2520ff63eede8c6b102ef10c3
Misc/NEWS.d/next/Core_and_Builtins/2026-01-08-19-56-40.gh-issue-143375.QCzA_8.rsthttps://github.com/python/cpython/pull/143577/files/039bf4151ed411c2520ff63eede8c6b102ef10c3#diff-39ba15840ffe5457eea62ef09f3a799b3bd397c1ea1059ced871cd94258106a7
Please reload this pagehttps://github.com/python/cpython/pull/143577
tomasr8https://github.com/tomasr8
January 8, 2026 21:59https://github.com/python/cpython/pull/143577#commits-pushed-2ae393b
https://github.com/tomasr8
Try with a :func:https://github.com/python/cpython/pull/143577/commits/2ae393b05a681132bc72e5117f530eda8537c4f7
2ae393bhttps://github.com/python/cpython/pull/143577/commits/2ae393b05a681132bc72e5117f530eda8537c4f7
https://github.com/tomasr8
Move news entry to Libraryhttps://github.com/python/cpython/pull/143577/commits/d0c7ff5e6c62eb767bf3aa03b6ed5aaa1d896658
d0c7ff5https://github.com/python/cpython/pull/143577/commits/d0c7ff5e6c62eb767bf3aa03b6ed5aaa1d896658
https://github.com/tomasr8
Fix news entryhttps://github.com/python/cpython/pull/143577/commits/f72095014be6984bc9ea25ae1be1b585f02d0b1c
f720950https://github.com/python/cpython/pull/143577/commits/f72095014be6984bc9ea25ae1be1b585f02d0b1c
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jan 9, 2026 https://github.com/python/cpython/pull/143577#pullrequestreview-3643719583
View reviewed changes https://github.com/python/cpython/pull/143577/files/f72095014be6984bc9ea25ae1be1b585f02d0b1c
Misc/NEWS.d/next/Library/2026-01-08-19-56-40.gh-issue-143375.QCzA_8.rsthttps://github.com/python/cpython/pull/143577/files/f72095014be6984bc9ea25ae1be1b585f02d0b1c#diff-fab03717555a736d9eb9978a117a58281b14a496b85eb226408c17308aebc31b
serhiy-storchakahttps://github.com/serhiy-storchaka
Jan 9, 2026https://github.com/python/cpython/pull/143577#discussion_r2676012451
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/143577
tomasr8https://github.com/tomasr8
Apr 5, 2026https://github.com/python/cpython/pull/143577#discussion_r3036946190
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/143577
Modules/_io/bufferedio.chttps://github.com/python/cpython/pull/143577/files/f72095014be6984bc9ea25ae1be1b585f02d0b1c#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
serhiy-storchakahttps://github.com/serhiy-storchaka
Jan 9, 2026https://github.com/python/cpython/pull/143577#discussion_r2676029401
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/143577
serhiy-storchakahttps://github.com/serhiy-storchaka
Jan 9, 2026https://github.com/python/cpython/pull/143577#discussion_r2676042720
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/143577
tomasr8https://github.com/tomasr8
Apr 5, 2026https://github.com/python/cpython/pull/143577#discussion_r3036947485
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/143577
Misc/NEWS.d/next/Library/2026-01-08-19-56-40.gh-issue-143375.QCzA_8.rsthttps://github.com/python/cpython/pull/143577/files/f72095014be6984bc9ea25ae1be1b585f02d0b1c#diff-fab03717555a736d9eb9978a117a58281b14a496b85eb226408c17308aebc31b
serhiy-storchakahttps://github.com/serhiy-storchaka
Jan 9, 2026https://github.com/python/cpython/pull/143577#discussion_r2676055718
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/143577
tomasr8https://github.com/tomasr8
Apr 5, 2026https://github.com/python/cpython/pull/143577#discussion_r3036951327
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/143577
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jan 9, 2026https://github.com/python/cpython/pull/143577#issuecomment-3729881431
#143007https://github.com/python/cpython/issues/143007
Please reload this pagehttps://github.com/python/cpython/pull/143577
tomasr8https://github.com/tomasr8
April 5, 2026 15:29https://github.com/python/cpython/pull/143577#commits-pushed-d69c91b
https://github.com/tomasr8
Merge remote-tracking branch 'upstream/main' into buffer-seekhttps://github.com/python/cpython/pull/143577/commits/d69c91bd87487a87a2fdf4849fc3dc8f42b66835
d69c91bhttps://github.com/python/cpython/pull/143577/commits/d69c91bd87487a87a2fdf4849fc3dc8f42b66835
https://github.com/tomasr8
Remove commenthttps://github.com/python/cpython/pull/143577/commits/ad20cdab484a171e2bc307e54a4fff05ab70b72b
ad20cdahttps://github.com/python/cpython/pull/143577/commits/ad20cdab484a171e2bc307e54a4fff05ab70b72b
https://github.com/tomasr8
Remove redundant CHECK_CLOSED callhttps://github.com/python/cpython/pull/143577/commits/a21ef456d4c1aa86b78760864f345177d1bc27cc
a21ef45https://github.com/python/cpython/pull/143577/commits/a21ef456d4c1aa86b78760864f345177d1bc27cc
https://github.com/tomasr8
Move PyNumber_AsOff_t after whence checkhttps://github.com/python/cpython/pull/143577/commits/92e3fdebe85167bcf47ee8a379ae16186262c6d1
92e3fdehttps://github.com/python/cpython/pull/143577/commits/92e3fdebe85167bcf47ee8a379ae16186262c6d1
https://github.com/tomasr8
Add tests for BufferedReader and BufferedRandomhttps://github.com/python/cpython/pull/143577/commits/5dbe999c83342bab7734ca43e835466521b97592
5dbe999https://github.com/python/cpython/pull/143577/commits/5dbe999c83342bab7734ca43e835466521b97592
https://github.com/tomasr8
Add tests for concurrent detachhttps://github.com/python/cpython/pull/143577/commits/05e9afd1da89962b0271d03bf237dfdfa2728044
05e9afdhttps://github.com/python/cpython/pull/143577/commits/05e9afd1da89962b0271d03bf237dfdfa2728044
https://github.com/tomasr8
Improve news entryhttps://github.com/python/cpython/pull/143577/commits/e43c25f6d3dc5bd8d397ae829df947e6e1194bb6
e43c25fhttps://github.com/python/cpython/pull/143577/commits/e43c25f6d3dc5bd8d397ae829df947e6e1194bb6
https://github.com/tomasr8
Add a newlinehttps://github.com/python/cpython/pull/143577/commits/0917ab19bb755fd72a466c8d41aa01317deb21f8
0917ab1https://github.com/python/cpython/pull/143577/commits/0917ab19bb755fd72a466c8d41aa01317deb21f8
https://github.com/tomasr8
Update news entryhttps://github.com/python/cpython/pull/143577/commits/276a2fbd29a506ceb746c13684c23d2c7dee903d
276a2fbhttps://github.com/python/cpython/pull/143577/commits/276a2fbd29a506ceb746c13684c23d2c7dee903d
https://github.com/tomasr8
tomasr8https://github.com/tomasr8
serhiy-storchakahttps://github.com/serhiy-storchaka
April 5, 2026 14:50https://github.com/python/cpython/pull/143577#event-24207143644
https://github.com/tomasr8
tomasr8https://github.com/tomasr8
Apr 5, 2026 https://github.com/python/cpython/pull/143577#pullrequestreview-4059754381
View reviewed changes https://github.com/python/cpython/pull/143577/files/276a2fbd29a506ceb746c13684c23d2c7dee903d
Lib/test/test_io/test_bufferedio.pyhttps://github.com/python/cpython/pull/143577/files/276a2fbd29a506ceb746c13684c23d2c7dee903d#diff-476088eb5a1c740688919c90c1c29143f7ec860a9087c72e87db405836826e0f
tomasr8https://github.com/tomasr8
Apr 5, 2026https://github.com/python/cpython/pull/143577#discussion_r3037238451
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/143577
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
May 17, 2026https://github.com/python/cpython/pull/143577#issuecomment-4468645193
Please reload this pagehttps://github.com/python/cpython/pull/143577
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
May 17, 2026https://github.com/python/cpython/pull/143577#event-25617555112
https://github.com/tomasr8
Merge branch 'main' into buffer-seekhttps://github.com/python/cpython/pull/143577/commits/cdc807462d2b74beffc566e71742998889051910
cdc8074https://github.com/python/cpython/pull/143577/commits/cdc807462d2b74beffc566e71742998889051910
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
Jul 24, 2026https://github.com/python/cpython/pull/143577#event-28421788309
https://github.com/BHUVANSH855
BHUVANSH855https://github.com/BHUVANSH855
Jul 31, 2026 https://github.com/python/cpython/pull/143577#ref-issue-5030780914
NULL pointer dereference in BufferedIO methods after re-entrant detach() #154997 https://github.com/python/cpython/issues/154997
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 27, 2026https://github.com/python/cpython/pull/143577#issuecomment-6430451281
Please reload this pagehttps://github.com/python/cpython/pull/143577
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
Oct 27, 2026https://github.com/python/cpython/pull/143577#event-34317599105
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F143577
https://github.com/StanFromIreland
StanFromIreland https://github.com/StanFromIreland
https://github.com/python/cpython/pull/143577/files/039bf4151ed411c2520ff63eede8c6b102ef10c3
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/143577
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
Please reload this pagehttps://github.com/python/cpython/pull/143577
https://github.com/tomasr8
https://github.com/serhiy-storchaka
https://github.com/StanFromIreland
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.