| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:57764ccf-da14-346c-f80c-69580532b0bb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 96B4:A6D52:1DF476B:29270C3:6A4F2B79 |
| html-safe-nonce | 0bf0cea25f897d1913d3ad77ddb2d3d2d8d077f856c85bac35030f32400a51eb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkI0OkE2RDUyOjFERjQ3NkI6MjkyNzBDMzo2QTRGMkI3OSIsInZpc2l0b3JfaWQiOiI4Mzk5NTg2NzY3MTIwODM3NDk4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 365df69b9057ddafeff4193975587c53673e1b2ce0892dfc5457cae45b0c6fd7 |
| hovercard-subject-tag | pull_request:291186692 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/14344/files |
| twitter:image | https://avatars.githubusercontent.com/u/356399?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/356399?s=400&v=4 |
| og:image:alt | The resurrection of #13630
Now without dangling threads in tests :)
https://bugs.python.org/issue35621 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b8f23afb982271f1b22258a94aede67a6b77760 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/14344/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F14344%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F14344%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/14344/files |
| Reload | https://github.com/python/cpython/pull/14344/files |
| Reload | https://github.com/python/cpython/pull/14344/files |
| Please reload this page | https://github.com/python/cpython/pull/14344/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/14344/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.6k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| asvetlov | https://github.com/asvetlov |
| python:master | https://github.com/python/cpython/tree/master |
| asvetlov:threaded-waiter | https://github.com/asvetlov/cpython/tree/threaded-waiter |
|
Conversation
15
| https://github.com/python/cpython/pull/14344 |
|
Commits
17
| https://github.com/python/cpython/pull/14344/commits |
|
Checks
0
| https://github.com/python/cpython/pull/14344/checks |
|
Files changed
| https://github.com/python/cpython/pull/14344/files |
| Please reload this page | https://github.com/python/cpython/pull/14344/files |
|
bpo-35621: Support running subprocesses in asyncio when loop is executed in non-main thread
| https://github.com/python/cpython/pull/14344/files#top |
|
Show all changes
17 commits
| https://github.com/python/cpython/pull/14344/files |
|
3695efd
Close pid waiters on watcher.close()
asvetlov Jun 3, 2019
| https://github.com/python/cpython/pull/14344/commits/3695efd8520c6b212a7b177c32b22d72b59d8f43 |
|
3559581
Revert "Revert "bpo-35621: Support running subprocesses in asyncio wh…
asvetlov Jun 4, 2019
| https://github.com/python/cpython/pull/14344/commits/3559581ad6ea84a9b5a00f0102999b629add3b95 |
|
b18e6b9
Merge branch 'dangling-threads-in-watcher' into threaded-waiter
asvetlov Jun 4, 2019
| https://github.com/python/cpython/pull/14344/commits/b18e6b9d7d858ebca55a3557f336c76d4024dfc0 |
|
1bc1d8e
Merge remote-tracking branch 'upstream/master' into threaded-waiter
asvetlov Jun 4, 2019
| https://github.com/python/cpython/pull/14344/commits/1bc1d8e17fa37dd9dcb4d672cabdbebed1643525 |
|
ef1e21c
Work on
asvetlov Jun 4, 2019
| https://github.com/python/cpython/pull/14344/commits/ef1e21cfb1e7b737abf9be61b51d9dd2eaee560a |
|
c982e4a
Merge branch 'master' into threaded-waiter
asvetlov Jun 24, 2019
| https://github.com/python/cpython/pull/14344/commits/c982e4af5cb2ec851d937bdd04ed8840a0e626e7 |
|
6912ec7
Fix dangling thread warnings in tests
asvetlov Jun 24, 2019
| https://github.com/python/cpython/pull/14344/commits/6912ec769b6abee0c974fab6e2dcfe803e7088e1 |
|
efb19c0
Update documentation
asvetlov Jun 24, 2019
| https://github.com/python/cpython/pull/14344/commits/efb19c08449ee2ab29c68e63f73c3d05f4b3ebf1 |
|
eb07403
Add docstrings
asvetlov Jun 25, 2019
| https://github.com/python/cpython/pull/14344/commits/eb07403115ebb8143b331faf91430652a5593399 |
|
6aa3357
Update Doc/library/asyncio-policy.rst
asvetlov Jun 30, 2019
| https://github.com/python/cpython/pull/14344/commits/6aa3357bef32dc96f1dece5dc9f55f260e095470 |
|
25d9ac2
Fix doc text
asvetlov Jun 30, 2019
| https://github.com/python/cpython/pull/14344/commits/25d9ac243f9ad05038c747fb0a4fdab6b566e489 |
|
ae3a706
Update Doc/library/asyncio-policy.rst
asvetlov Jun 30, 2019
| https://github.com/python/cpython/pull/14344/commits/ae3a7068d0a1e29f48305c9610a249eebe1be24a |
|
8baf48c
Update Doc/library/asyncio-policy.rst
asvetlov Jun 30, 2019
| https://github.com/python/cpython/pull/14344/commits/8baf48c5e537e4397515a28aaa96ded93e9c9f2a |
|
6e6a783
Update Doc/library/asyncio-policy.rst
asvetlov Jun 30, 2019
| https://github.com/python/cpython/pull/14344/commits/6e6a783fdcb3360ddb127378bddde3204be07fa2 |
|
1e1281a
Update Lib/asyncio/unix_events.py
asvetlov Jun 30, 2019
| https://github.com/python/cpython/pull/14344/commits/1e1281a4e283bf9741d356cb930d7c43593495a6 |
|
936aeb0
Update Lib/asyncio/unix_events.py
asvetlov Jun 30, 2019
| https://github.com/python/cpython/pull/14344/commits/936aeb0d3f55a72f163e9b979a7307e16345b7c8 |
|
cc5a752
Update docs
asvetlov Jun 30, 2019
| https://github.com/python/cpython/pull/14344/commits/cc5a7522791045ff9432333b8e98c4d44ff349fb |
|
Clear filters
| https://github.com/python/cpython/pull/14344/files |
| Please reload this page | https://github.com/python/cpython/pull/14344/files |
| Please reload this page | https://github.com/python/cpython/pull/14344/files |
|
asyncio-policy.rst
| https://github.com/python/cpython/pull/14344/files#diff-e62878ae42b3d224bef59a2ea83554f798a9de95b531375637aa4d2461ece8f6 |
|
asyncio-subprocess.rst
| https://github.com/python/cpython/pull/14344/files#diff-be4456db2975127c0a4620210c12c141855249ce3e599f56f589b8cd38101906 |
|
unix_events.py
| https://github.com/python/cpython/pull/14344/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
|
test_subprocess.py
| https://github.com/python/cpython/pull/14344/files#diff-3a12ea0e8988b2edcb96962049a9cca2db1ee02db133cd99493ccc87a81d08e2 |
|
test_unix_events.py
| https://github.com/python/cpython/pull/14344/files#diff-78695ed3f8e6b470fdf3701f14dd71a2ef5c039e21f398f043cd78c7dda6135c |
|
utils.py
| https://github.com/python/cpython/pull/14344/files#diff-73a82d560b5e6a3b3abd58b460de2b09eaf53e3d1598a263a7b3a61d41068d34 |
|
2019-05-28-19-03-46.bpo-35621.Abc1lf.rst
| https://github.com/python/cpython/pull/14344/files#diff-05d96389a4d2ced8368a5ebfdab9e64a27d2dbf2c6af476d94b133e03fb6ab6a |
| Doc/library/asyncio-policy.rst | https://github.com/python/cpython/pull/14344/files#diff-e62878ae42b3d224bef59a2ea83554f798a9de95b531375637aa4d2461ece8f6 |
|
View file
| https://github.com/asvetlov/cpython/blob/cc5a7522791045ff9432333b8e98c4d44ff349fb/Doc/library/asyncio-policy.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/14344/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/14344/files#diff-e62878ae42b3d224bef59a2ea83554f798a9de95b531375637aa4d2461ece8f6 |
|
| https://github.com/python/cpython/pull/14344/files#diff-e62878ae42b3d224bef59a2ea83554f798a9de95b531375637aa4d2461ece8f6 |
|
| https://github.com/python/cpython/pull/14344/files#diff-e62878ae42b3d224bef59a2ea83554f798a9de95b531375637aa4d2461ece8f6 |
|
| https://github.com/python/cpython/pull/14344/files#diff-e62878ae42b3d224bef59a2ea83554f798a9de95b531375637aa4d2461ece8f6 |
|
| https://github.com/python/cpython/pull/14344/files#diff-e62878ae42b3d224bef59a2ea83554f798a9de95b531375637aa4d2461ece8f6 |
|
| https://github.com/python/cpython/pull/14344/files#diff-e62878ae42b3d224bef59a2ea83554f798a9de95b531375637aa4d2461ece8f6 |
| Doc/library/asyncio-subprocess.rst | https://github.com/python/cpython/pull/14344/files#diff-be4456db2975127c0a4620210c12c141855249ce3e599f56f589b8cd38101906 |
|
View file
| https://github.com/asvetlov/cpython/blob/cc5a7522791045ff9432333b8e98c4d44ff349fb/Doc/library/asyncio-subprocess.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/14344/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/14344/files#diff-be4456db2975127c0a4620210c12c141855249ce3e599f56f589b8cd38101906 |
| Please reload this page | https://github.com/python/cpython/pull/14344/files |
|
| https://github.com/python/cpython/pull/14344/files#diff-be4456db2975127c0a4620210c12c141855249ce3e599f56f589b8cd38101906 |
| Please reload this page | https://github.com/python/cpython/pull/14344/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |