René's URL Explorer Experiment


Title: GH-43374: Fix urlretrieve reporthook to report actual bytes read by savannahostrowski · Pull Request #142653 · python/cpython · GitHub

Open Graph Title: GH-43374: Fix urlretrieve reporthook to report actual bytes read by savannahostrowski · Pull Request #142653 · python/cpython

X Title: GH-43374: Fix urlretrieve reporthook to report actual bytes read by savannahostrowski · Pull Request #142653 · python/cpython

Description: Spelunking through bugs marked with EOL version labels... The docs aren't explicit about what the second argument should represent. The current behavior (always reporting block size 8192) makes progress tracking unreliable since the last block could be smaller. This change makes reporthook report actual bytes read, which is more useful. Issue: gh-43374

Open Graph Description: Spelunking through bugs marked with EOL version labels... The docs aren't explicit about what the second argument should represent. The current behavior (always reporting block size 8192) makes...

X Description: Spelunking through bugs marked with EOL version labels... The docs aren't explicit about what the second argument should represent. The current behavior (always reporting block size 8192) m...

Opengraph URL: https://github.com/python/cpython/pull/142653

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:78d9a2a0-7c37-b31c-57e0-c209c62ac1d0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD2F0:50FD4:2EB5FDB:4017534:6A4F154E
html-safe-nonce7f3594bc1fda00f1191d5bc80c0ccc22cada0ad85a26a89addfb2a81a1eaa66b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkYwOjUwRkQ0OjJFQjVGREI6NDAxNzUzNDo2QTRGMTU0RSIsInZpc2l0b3JfaWQiOiI4OTUyODEzMDM0ODQzMDg0MTEwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac971dcdbb413bca038f5c2587ccc1b0130a48819675b43b1b20fee3be1cb7fe1e
hovercard-subject-tagpull_request:3098024392
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/142653/files
twitter:imagehttps://avatars.githubusercontent.com/u/8949415?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8949415?s=400&v=4
og:image:altSpelunking through bugs marked with EOL version labels... The docs aren't explicit about what the second argument should represent. The current behavior (always reporting block size 8192) makes...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/142653/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F142653%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F142653%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/142653/files
Reloadhttps://github.com/python/cpython/pull/142653/files
Reloadhttps://github.com/python/cpython/pull/142653/files
Please reload this pagehttps://github.com/python/cpython/pull/142653/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/142653/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
savannahostrowskihttps://github.com/savannahostrowski
python:mainhttps://github.com/python/cpython/tree/main
savannahostrowski:urllib-reporthookhttps://github.com/savannahostrowski/cpython/tree/urllib-reporthook
Conversation 10 https://github.com/python/cpython/pull/142653
Commits 5 https://github.com/python/cpython/pull/142653/commits
Checks 48 https://github.com/python/cpython/pull/142653/checks
Files changed https://github.com/python/cpython/pull/142653/files
Please reload this pagehttps://github.com/python/cpython/pull/142653/files
GH-43374: Fix urlretrieve reporthook to report actual bytes read https://github.com/python/cpython/pull/142653/files#top
Show all changes 5 commits https://github.com/python/cpython/pull/142653/files
3e93acc Fix urlretrieve reporthook to report actual bytes read savannahostrowski Dec 12, 2025 https://github.com/python/cpython/pull/142653/commits/3e93accd18b5dff5e7918132ed61b128fe5a3c24
295fcbc 📜🤖 Added by blurb_it. blurb-it[bot] Dec 12, 2025 https://github.com/python/cpython/pull/142653/commits/295fcbc97023bab1c818c1a121fbd8af623eaecd
5c66bd1 Fix test savannahostrowski Dec 12, 2025 https://github.com/python/cpython/pull/142653/commits/5c66bd1a27f5c5e6ca70f1b965ee924faf24dddd
d595029 Merge branch 'urllib-reporthook' of https://github.com/savannahostrow… savannahostrowski Dec 12, 2025 https://github.com/python/cpython/pull/142653/commits/d595029d8b7ac1fbfa7e81cedf94f40921ec4d0c
4d8a462 Merge branch 'main' into urllib-reporthook savannahostrowski Jan 9, 2026 https://github.com/python/cpython/pull/142653/commits/4d8a462d50296765c1a8126e98d4a502b4edb1b3
Clear filters https://github.com/python/cpython/pull/142653/files
Please reload this pagehttps://github.com/python/cpython/pull/142653/files
Please reload this pagehttps://github.com/python/cpython/pull/142653/files
test_urllib.py https://github.com/python/cpython/pull/142653/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
test_urllibnet.py https://github.com/python/cpython/pull/142653/files#diff-81da82c4ff085832e2464892c7ef9dfa2c560bbd2d01196cf7fbe940a8bd9562
request.py https://github.com/python/cpython/pull/142653/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
2025-12-12-23-17-10.gh-issue-43374.M6jGC5.rst https://github.com/python/cpython/pull/142653/files#diff-fbe260ac5d3d0d39ea14fe7823b8f19a7ab3d32f2cc259843f42410ae87a1b20
Lib/test/test_urllib.pyhttps://github.com/python/cpython/pull/142653/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
View file https://github.com/savannahostrowski/cpython/blob/4d8a462d50296765c1a8126e98d4a502b4edb1b3/Lib/test/test_urllib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/142653/{{ revealButtonHref }}
https://github.com/python/cpython/pull/142653/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
https://github.com/python/cpython/pull/142653/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
Lib/test/test_urllibnet.pyhttps://github.com/python/cpython/pull/142653/files#diff-81da82c4ff085832e2464892c7ef9dfa2c560bbd2d01196cf7fbe940a8bd9562
View file https://github.com/savannahostrowski/cpython/blob/4d8a462d50296765c1a8126e98d4a502b4edb1b3/Lib/test/test_urllibnet.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/142653/{{ revealButtonHref }}
https://github.com/python/cpython/pull/142653/files#diff-81da82c4ff085832e2464892c7ef9dfa2c560bbd2d01196cf7fbe940a8bd9562
https://github.com/python/cpython/pull/142653/files#diff-81da82c4ff085832e2464892c7ef9dfa2c560bbd2d01196cf7fbe940a8bd9562
Lib/urllib/request.pyhttps://github.com/python/cpython/pull/142653/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
View file https://github.com/savannahostrowski/cpython/blob/4d8a462d50296765c1a8126e98d4a502b4edb1b3/Lib/urllib/request.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/142653/{{ revealButtonHref }}
https://github.com/python/cpython/pull/142653/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
https://github.com/python/cpython/pull/142653/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
Misc/NEWS.d/next/Library/2025-12-12-23-17-10.gh-issue-43374.M6jGC5.rsthttps://github.com/python/cpython/pull/142653/files#diff-fbe260ac5d3d0d39ea14fe7823b8f19a7ab3d32f2cc259843f42410ae87a1b20
View file https://github.com/savannahostrowski/cpython/blob/4d8a462d50296765c1a8126e98d4a502b4edb1b3/Misc/NEWS.d/next/Library/2025-12-12-23-17-10.gh-issue-43374.M6jGC5.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/142653/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/142653/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.