René's URL Explorer Experiment


Title: gh-142418: Fix inspect.iscoroutinefunction for marked functools.partial and partialmethod objects by Joshua-Ward1 · Pull Request #142503 · python/cpython · GitHub

Open Graph Title: gh-142418: Fix inspect.iscoroutinefunction for marked functools.partial and partialmethod objects by Joshua-Ward1 · Pull Request #142503 · python/cpython

X Title: gh-142418: Fix inspect.iscoroutinefunction for marked functools.partial and partialmethod objects by Joshua-Ward1 · Pull Request #142503 · python/cpython

Description: Fixes gh-142418. This PR updates inspect.iscoroutinefunction() so that coroutine markers applied via inspect.markcoroutinefunction() are correctly detected on wrapped callables, including functools.partial and functools.partialmethod objects. Previously, iscoroutinefunction() only checked the marker after unwrapping the callable, which caused false negatives for marked partial and partialmethod objects. The new logic checks for the marker at each unwrap stage, with cycle protection, ensuring that any explicitly marked wrapper is recognized as a coroutine function. This change also adds regression tests verifying correct behavior for marked and unmarked functools.partial and functools.partialmethod objects, and includes a NEWS entry documenting the fix. 📚 Documentation preview 📚: https://cpython-previews--142503.org.readthedocs.build/

Open Graph Description: Fixes gh-142418. This PR updates inspect.iscoroutinefunction() so that coroutine markers applied via inspect.markcoroutinefunction() are correctly detected on wrapped callables, including functools...

X Description: Fixes gh-142418. This PR updates inspect.iscoroutinefunction() so that coroutine markers applied via inspect.markcoroutinefunction() are correctly detected on wrapped callables, including functools...

Opengraph URL: https://github.com/python/cpython/pull/142503

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:bb1e2e5e-f611-6147-0c02-16aa9f6901f9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC48C:3A5CC1:1418F4:1BC558:6996BC35
html-safe-nonce47b3cbbd2207157c5fbdf7f198b8cd1e0374c5da1d5439c17e6ce6f8f873a796
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDhDOjNBNUNDMToxNDE4RjQ6MUJDNTU4OjY5OTZCQzM1IiwidmlzaXRvcl9pZCI6IjUzMjMyNjMwNTkyMDAyMjg0MDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9e432cdb098107afe260143a1cffdf59d368964d026120fbab57700d174d33ec
hovercard-subject-tagpull_request:3088252660
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5
twitter:imagehttps://avatars.githubusercontent.com/u/32703550?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/32703550?s=400&v=4
og:image:altFixes gh-142418. This PR updates inspect.iscoroutinefunction() so that coroutine markers applied via inspect.markcoroutinefunction() are correctly detected on wrapped callables, including functools...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5513290f8d09a9ed78de519ab8316ed23b2b0ddd5e91d2420df56691d00827e8
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee258e32a8c50a12656030b21f3279030a774ec82
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F142503%2Fcommits%2F99611791e4a7b06db344fef20405c12c82211ed5
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F142503%2Fcommits%2F99611791e4a7b06db344fef20405c12c82211ed5
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5
Reloadhttps://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5
Reloadhttps://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Joshua-Ward1https://github.com/Joshua-Ward1
python:mainhttps://github.com/python/cpython/tree/main
Joshua-Ward1:fix-142418-iscoroutinefunction-partialhttps://github.com/Joshua-Ward1/cpython/tree/fix-142418-iscoroutinefunction-partial
Conversation 19 https://github.com/python/cpython/pull/142503
Commits 9 https://github.com/python/cpython/pull/142503/commits
Checks 46 https://github.com/python/cpython/pull/142503/checks
Files changed 4 https://github.com/python/cpython/pull/142503/files
gh-142418: Fix inspect.iscoroutinefunction for marked functools.partial and partialmethod objects https://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5#top
Show all changes 9 commits https://github.com/python/cpython/pull/142503/files
a51db30 Doc: clarify -i interaction with PYTHONSTARTUP Joshua-Ward1 Dec 10, 2025 https://github.com/python/cpython/pull/142503/commits/a51db306de4a95967275d105d2acfca1d66e36d5
1c4e6b9 gh-142418: Fix inspect.iscoroutinefunction for marked functools.parti… Joshua-Ward1 Dec 10, 2025 https://github.com/python/cpython/pull/142503/commits/1c4e6b9a6070443867759f57b955bfc086457fb1
245a701 Fix NEWS entry formatting for gh-142418 Joshua-Ward1 Dec 10, 2025 https://github.com/python/cpython/pull/142503/commits/245a701948b878597f0bf165bf57789a54395813
6084378 Rename NEWS entry to follow format Joshua-Ward1 Dec 10, 2025 https://github.com/python/cpython/pull/142503/commits/608437893025169df2bd62c2efa9ef4d5fa5b235
6117107 Fixed Filename Joshua-Ward1 Dec 10, 2025 https://github.com/python/cpython/pull/142503/commits/61171074410180ce1d0563debc17393b062391da
dba7cb9 gh-142418: Remove unnecessary cycle detection from _has_coroutine_mark Joshua-Ward1 Dec 10, 2025 https://github.com/python/cpython/pull/142503/commits/dba7cb905ecc28a214294d7921315f3e358ee0eb
9961179 gh-142418: Simplify _has_coroutine_mark by removing unnecessary cycle… Joshua-Ward1 Dec 10, 2025 https://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5
1f05728 gh-142418: Restore __partialmethod__ handling in _has_coroutine_mark Joshua-Ward1 Dec 10, 2025 https://github.com/python/cpython/pull/142503/commits/1f0572836d1167c28e29ad0833c398f7afed6775
5d5c324 Reorder coroutine marker check after method unwrapping Joshua-Ward1 Dec 10, 2025 https://github.com/python/cpython/pull/142503/commits/5d5c3240aa9dd02365d1855dcf3e08dd088e5663
Clear filters https://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5
Please reload this pagehttps://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5
Please reload this pagehttps://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5
Prev https://github.com/python/cpython/pull/142503/commits/dba7cb905ecc28a214294d7921315f3e358ee0eb
Next https://github.com/python/cpython/pull/142503/commits/1f0572836d1167c28e29ad0833c398f7afed6775
gh-142418https://github.com/python/cpython/issues/142418
Please reload this pagehttps://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5
https://github.com/Joshua-Ward1
Joshua-Ward1https://github.com/python/cpython/commits?author=Joshua-Ward1
Lib/inspect.pyhttps://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5#diff-b89cd06e4637abacb73f2500301ff979a67ad7ecbfa7cf151c7243715898d7ea
View file https://github.com/python/cpython/blob/99611791e4a7b06db344fef20405c12c82211ed5/Lib/inspect.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/142503/commits/{{ revealButtonHref }}
https://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5#diff-b89cd06e4637abacb73f2500301ff979a67ad7ecbfa7cf151c7243715898d7ea
picnixzhttps://github.com/picnixz
Dec 14, 2025https://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5#r2617376361
Please reload this pagehttps://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5
Please reload this pagehttps://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5
x42005e1fhttps://github.com/x42005e1f
Dec 10, 2025https://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5#r2605698696
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5
picnixzhttps://github.com/picnixz
Dec 14, 2025https://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5#r2617380078
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5
x42005e1fhttps://github.com/x42005e1f
Dec 14, 2025https://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5#r2617391383
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#142505https://github.com/python/cpython/pull/142505
Please reload this pagehttps://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5
x42005e1fhttps://github.com/x42005e1f
Dec 10, 2025https://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5#r2605952145
Please reload this pagehttps://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5
Please reload this pagehttps://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5
https://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5#diff-b89cd06e4637abacb73f2500301ff979a67ad7ecbfa7cf151c7243715898d7ea
Please reload this pagehttps://github.com/python/cpython/pull/142503/commits/99611791e4a7b06db344fef20405c12c82211ed5
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.