René's URL Explorer Experiment


Title: gh-142352: Fix start_tls() to transfer buffered data from StreamReader by kasimov-maxim · Pull Request #142354 · python/cpython · GitHub

Open Graph Title: gh-142352: Fix start_tls() to transfer buffered data from StreamReader by kasimov-maxim · Pull Request #142354 · python/cpython

X Title: gh-142352: Fix start_tls() to transfer buffered data from StreamReader by kasimov-maxim · Pull Request #142354 · python/cpython

Description: Fixes #142352 Summary When using StreamWriter.start_tls() to upgrade a connection to TLS mid-stream, any data already buffered in the StreamReader was lost. This commonly occurs when implementing s...

Open Graph Description: Fixes #142352 Summary When using StreamWriter.start_tls() to upgrade a connection to TLS mid-stream, any data already buffered in the StreamReader was lost. This commonly occurs when implementing s...

X Description: Fixes #142352 Summary When using StreamWriter.start_tls() to upgrade a connection to TLS mid-stream, any data already buffered in the StreamReader was lost. This commonly occurs when implementing s...

Opengraph URL: https://github.com/python/cpython/pull/142354

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5427d838-bae9-65d7-a2c1-4cec1caa6568
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCED6:FA8DE:40336C8:55A0A41:6964C2DE
html-safe-noncefd1c1de9e7ddafd1056a26b93af7cae3606aa84ae929f747b6d929b60cd7b610
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUQ2OkZBOERFOjQwMzM2Qzg6NTVBMEE0MTo2OTY0QzJERSIsInZpc2l0b3JfaWQiOiI0NTA4ODAzOTkxMzM1MTI1NzI2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac501ee6dba83835f761e0ba04aca6ade8aad07c2ddff6dc4649015678bbd6e395
hovercard-subject-tagpull_request:3077842781
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/142354/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/27b7a3097c50329d13781175d7fdc6840e3b824d4859c4c19ea24d9c61d94c10/python/cpython/pull/142354
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/27b7a3097c50329d13781175d7fdc6840e3b824d4859c4c19ea24d9c61d94c10/python/cpython/pull/142354
og:image:altFixes #142352 Summary When using StreamWriter.start_tls() to upgrade a connection to TLS mid-stream, any data already buffered in the StreamReader was lost. This commonly occurs when implementing s...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekasimov-maxim
hostnamegithub.com
expected-hostnamegithub.com
None21df671ce2c9f1a16940ccbd3af6cb4f3f12a856929ca7eb1b4aea8e384ea442
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5707c685ac172d50a0bdd7533dde4f8aabcf8eef
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/142354#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F142354
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F142354
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/142354
Reloadhttps://github.com/python/cpython/pull/142354
Reloadhttps://github.com/python/cpython/pull/142354
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/142354
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/142354
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/142354#issue-comment-box
kasimov-maximhttps://github.com/kasimov-maxim
python:mainhttps://github.com/python/cpython/tree/main
kasimov-maxim:gh-142352-start-tls-buffered-datahttps://github.com/kasimov-maxim/cpython/tree/gh-142352-start-tls-buffered-data
gh-142352: Fix start_tls() to transfer buffered data from StreamReader https://github.com/python/cpython/pull/142354#top
kasimov-maximhttps://github.com/kasimov-maxim
python:mainhttps://github.com/python/cpython/tree/main
kasimov-maxim:gh-142352-start-tls-buffered-datahttps://github.com/kasimov-maxim/cpython/tree/gh-142352-start-tls-buffered-data
Conversation 13 https://github.com/python/cpython/pull/142354
Commits 1 https://github.com/python/cpython/pull/142354/commits
Checks 48 https://github.com/python/cpython/pull/142354/checks
Files changed https://github.com/python/cpython/pull/142354/files
Please reload this pagehttps://github.com/python/cpython/pull/142354
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/kasimov-maxim
kasimov-maximhttps://github.com/kasimov-maxim
Dec 6, 2025https://github.com/python/cpython/pull/142354#issue-3702017094
Please reload this pagehttps://github.com/python/cpython/pull/142354
#142352https://github.com/python/cpython/issues/142352
asyncio: start_tls() loses buffered data from StreamReader #142352https://github.com/python/cpython/issues/142352
Please reload this pagehttps://github.com/python/cpython/pull/142354
https://github.com/kasimov-maxim
asyncio.streams: transfer buffered data to SSL layer in start_tls()https://github.com/python/cpython/pull/142354/commits/b2ed3c3c26ad8163bc1f56824f4b1db4fc75af75
b2ed3c3https://github.com/python/cpython/pull/142354/commits/b2ed3c3c26ad8163bc1f56824f4b1db4fc75af75
https://github.com/kasimov-maxim
kasimov-maximhttps://github.com/kasimov-maxim
1st1https://github.com/1st1
asvetlovhttps://github.com/asvetlov
kumaraditya303https://github.com/kumaraditya303
willingchttps://github.com/willingc
code ownershttps://github.com/python/cpython/blob/5be3405e4e94e494f3f2c4507d8c32c2c04bb2ee/.github/CODEOWNERS#L366
December 6, 2025 16:31https://github.com/python/cpython/pull/142354#event-21402255330
https://github.com/apps/python-cla-bot
python-cla-bothttps://github.com/apps/python-cla-bot
Dec 6, 2025https://github.com/python/cpython/pull/142354#issuecomment-3620661259
Please reload this pagehttps://github.com/python/cpython/pull/142354
https://cla.python.org/
Please reload this pagehttps://github.com/python/cpython/pull/142354
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Dec 6, 2025 https://github.com/python/cpython/pull/142354#ref-issue-3701986069
asyncio: start_tls() loses buffered data from StreamReader #142352 https://github.com/python/cpython/issues/142352
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Dec 6, 2025https://github.com/python/cpython/pull/142354#event-21402255822
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Dec 17, 2025 https://github.com/python/cpython/pull/142354#pullrequestreview-3588502202
View reviewed changes https://github.com/python/cpython/pull/142354/files/b2ed3c3c26ad8163bc1f56824f4b1db4fc75af75
Lib/asyncio/base_events.pyhttps://github.com/python/cpython/pull/142354/files/b2ed3c3c26ad8163bc1f56824f4b1db4fc75af75#diff-7962e1627bc1bfbce13bef0be78d5ef7fc962f99bbc524a199ef489852ca1344
kumaraditya303https://github.com/kumaraditya303
Dec 17, 2025https://github.com/python/cpython/pull/142354#discussion_r2627691348
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/142354
kasimov-maximhttps://github.com/kasimov-maxim
Jan 6, 2026https://github.com/python/cpython/pull/142354#discussion_r2664656048
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/142354
picnixzhttps://github.com/picnixz
Jan 6, 2026https://github.com/python/cpython/pull/142354#discussion_r2664846360
Please reload this pagehttps://github.com/python/cpython/pull/142354
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/142354
kasimov-maximhttps://github.com/kasimov-maxim
Jan 6, 2026https://github.com/python/cpython/pull/142354#discussion_r2665270552
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/142354
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Dec 17, 2025https://github.com/python/cpython/pull/142354#issuecomment-3666113613
@ambvhttps://github.com/ambv
#91453https://github.com/python/cpython/pull/91453
Please reload this pagehttps://github.com/python/cpython/pull/142354
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
ambvhttps://github.com/ambv
December 17, 2025 16:19https://github.com/python/cpython/pull/142354#event-21621506594
start_tls() loses buffered data and doesn't work when upgrading a stream MagicStack/uvloop#707 https://github.com/MagicStack/uvloop/issues/707
Fix start_tls() loses buffer data and hangs when upgrading the connection MagicStack/uvloop#708 https://github.com/MagicStack/uvloop/pull/708
start_tls() loses buffered data and doesn't work when upgrading a stream Vizonex/Winloop#102 https://github.com/Vizonex/Winloop/issues/102
Fix start_tls() loses StreamReader buffer data Vizonex/Winloop#103 https://github.com/Vizonex/Winloop/pull/103
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Jan 6, 2026 https://github.com/python/cpython/pull/142354#pullrequestreview-3630792566
View reviewed changes https://github.com/python/cpython/pull/142354/files/b2ed3c3c26ad8163bc1f56824f4b1db4fc75af75
picnixzhttps://github.com/picnixz
https://github.com/python/cpython/pull/142354#pullrequestreview-3630792566
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://devguide.python.org/getting-started/generative-ai/https://devguide.python.org/getting-started/generative-ai/
Please reload this pagehttps://github.com/python/cpython/pull/142354
Lib/test/test_asyncio/test_streams.pyhttps://github.com/python/cpython/pull/142354/files/b2ed3c3c26ad8163bc1f56824f4b1db4fc75af75#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
picnixzhttps://github.com/picnixz
Jan 6, 2026https://github.com/python/cpython/pull/142354#discussion_r2664833235
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/142354
kasimov-maximhttps://github.com/kasimov-maxim
Jan 6, 2026https://github.com/python/cpython/pull/142354#discussion_r2665351756
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/142354
Lib/test/test_asyncio/test_streams.pyhttps://github.com/python/cpython/pull/142354/files/b2ed3c3c26ad8163bc1f56824f4b1db4fc75af75#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
picnixzhttps://github.com/picnixz
Jan 6, 2026https://github.com/python/cpython/pull/142354#discussion_r2664833958
Please reload this pagehttps://github.com/python/cpython/pull/142354
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/142354
Lib/asyncio/base_events.pyhttps://github.com/python/cpython/pull/142354/files/b2ed3c3c26ad8163bc1f56824f4b1db4fc75af75#diff-7962e1627bc1bfbce13bef0be78d5ef7fc962f99bbc524a199ef489852ca1344
picnixzhttps://github.com/picnixz
Jan 6, 2026https://github.com/python/cpython/pull/142354#discussion_r2664846360
Please reload this pagehttps://github.com/python/cpython/pull/142354
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/142354
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jan 6, 2026https://github.com/python/cpython/pull/142354#event-21876162864
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jan 6, 2026https://github.com/python/cpython/pull/142354#issuecomment-3714615722
Please reload this pagehttps://github.com/python/cpython/pull/142354
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Jan 6, 2026https://github.com/python/cpython/pull/142354#issuecomment-3714634056
Please reload this pagehttps://github.com/python/cpython/pull/142354
https://datatracker.ietf.org/doc/html/rfc2817https://datatracker.ietf.org/doc/html/rfc2817
Please reload this pagehttps://github.com/python/cpython/pull/142354
https://github.com/kasimov-maxim
kasimov-maximhttps://github.com/kasimov-maxim
Jan 6, 2026https://github.com/python/cpython/pull/142354#issuecomment-3715167521
Please reload this pagehttps://github.com/python/cpython/pull/142354
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F142354
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
https://github.com/python/cpython/pull/142354/files/b2ed3c3c26ad8163bc1f56824f4b1db4fc75af75
https://github.com/picnixz
picnixz https://github.com/picnixz
https://github.com/python/cpython/pull/142354/files/b2ed3c3c26ad8163bc1f56824f4b1db4fc75af75
https://github.com/1st1
1st1 https://github.com/1st1
https://github.com/asvetlov
asvetlov https://github.com/asvetlov
https://github.com/willingc
willingc https://github.com/willingc
https://github.com/ambv
ambv https://github.com/ambv
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
asyncio: start_tls() loses buffered data from StreamReader https://github.com/python/cpython/issues/142352
Please reload this pagehttps://github.com/python/cpython/pull/142354
https://github.com/kasimov-maxim
https://github.com/kumaraditya303
https://github.com/picnixz
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.