René's URL Explorer Experiment


Title: gh-123241: Don't modify ref count during visitation by DinoV · Pull Request #142232 · python/cpython · GitHub

Open Graph Title: gh-123241: Don't modify ref count during visitation by DinoV · Pull Request #142232 · python/cpython

X Title: gh-123241: Don't modify ref count during visitation by DinoV · Pull Request #142232 · python/cpython

Description: traverse functions shouldn't modify the ref count during visitation otherwise they'll cause issues in the free threaded GC. CType_Type_traverse uses _PyStgInfo_FromType_NoState to get back to the s...

Open Graph Description: traverse functions shouldn't modify the ref count during visitation otherwise they'll cause issues in the free threaded GC. CType_Type_traverse uses _PyStgInfo_FromType_NoState to get back ...

X Description: traverse functions shouldn't modify the ref count during visitation otherwise they'll cause issues in the free threaded GC. CType_Type_traverse uses _PyStgInfo_FromType_NoState to g...

Opengraph URL: https://github.com/python/cpython/pull/142232

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6873770d-2e91-d5a0-9566-f216189d974b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8B06:18334E:4D76A80:6889CF2:696E063F
html-safe-nonce9a2e505038a6f136e9bbffa011e5cec364784476cabdbc193df62d884f56a713
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QjA2OjE4MzM0RTo0RDc2QTgwOjY4ODlDRjI6Njk2RTA2M0YiLCJ2aXNpdG9yX2lkIjoiMTY0ODQ0Mzk5OTQxNzkyNzIzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9dedb42104c6099f8ff4954af4936d2d171d1f1892249eb4926b994c2dcc0fa1
hovercard-subject-tagpull_request:3068458179
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/142232/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/40f364ae440fbcb616ec74dc257ab400ffae44f41a93cd643fefa9eab347c1fe/python/cpython/pull/142232
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/40f364ae440fbcb616ec74dc257ab400ffae44f41a93cd643fefa9eab347c1fe/python/cpython/pull/142232
og:image:alttraverse functions shouldn't modify the ref count during visitation otherwise they'll cause issues in the free threaded GC. CType_Type_traverse uses _PyStgInfo_FromType_NoState to get back ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDinoV
hostnamegithub.com
expected-hostnamegithub.com
None9b5131b207ddd175abf059a848d5f4302ec0606b02211b989013be49cf08593e
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef8590a63bfc8093b241930ca57d536c9a50f9680
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/142232#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F142232
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F142232
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/142232
Reloadhttps://github.com/python/cpython/pull/142232
Reloadhttps://github.com/python/cpython/pull/142232
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/142232
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/142232
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/142232#issue-comment-box
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
DinoV:dont_modify_refcounthttps://github.com/DinoV/cpython/tree/dont_modify_refcount
gh-123241: Don't modify ref count during visitation https://github.com/python/cpython/pull/142232#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
DinoV:dont_modify_refcounthttps://github.com/DinoV/cpython/tree/dont_modify_refcount
Conversation 10 https://github.com/python/cpython/pull/142232
Commits 7 https://github.com/python/cpython/pull/142232/commits
Checks 46 https://github.com/python/cpython/pull/142232/checks
Files changed 4 https://github.com/python/cpython/pull/142232/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/DinoV
DinoVhttps://github.com/DinoV
Dec 3, 2025https://github.com/python/cpython/pull/142232#issue-3691376871
Please reload this pagehttps://github.com/python/cpython/pull/142232
GC in free-threaded build has problems with Py_INCREF()/Py_DECREF() in tp_traverse handlers #123241https://github.com/python/cpython/issues/123241
Please reload this pagehttps://github.com/python/cpython/pull/142232
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Dec 3, 2025 https://github.com/python/cpython/pull/142232#ref-issue-2481556211
GC in free-threaded build has problems with Py_INCREF()/Py_DECREF() in tp_traverse handlers #123241 https://github.com/python/cpython/issues/123241
https://github.com/DinoV
DinoVhttps://github.com/DinoV
encukouhttps://github.com/encukou
mpagehttps://github.com/mpage
December 3, 2025 18:19https://github.com/python/cpython/pull/142232#event-21339706481
https://github.com/DinoV
DinoVhttps://github.com/DinoV
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Dec 3, 2025https://github.com/python/cpython/pull/142232#event-21339749597
https://github.com/DinoV
DinoVhttps://github.com/DinoV
December 3, 2025 18:46https://github.com/python/cpython/pull/142232#event-21340211334
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Dec 3, 2025https://github.com/python/cpython/pull/142232#event-21340212353
https://github.com/DinoV
DinoVhttps://github.com/DinoV
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
Dec 3, 2025https://github.com/python/cpython/pull/142232#event-21340383775
https://github.com/encukou
encukouhttps://github.com/encukou
Dec 4, 2025https://github.com/python/cpython/pull/142232#issuecomment-3611459025
Please reload this pagehttps://github.com/python/cpython/pull/142232
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Dec 4, 2025 https://github.com/python/cpython/pull/142232#pullrequestreview-3540920740
View reviewed changes https://github.com/python/cpython/pull/142232/files
colesburyhttps://github.com/colesbury
https://github.com/python/cpython/pull/142232#pullrequestreview-3540920740
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/142232
Modules/_ctypes/ctypes.hhttps://github.com/python/cpython/pull/142232/files#diff-53f61eb1ad6b25b3aff25b54b4df5004a1f1137ca1d2aae4c7e31fc00ec6e9f8
colesburyhttps://github.com/colesbury
Dec 4, 2025https://github.com/python/cpython/pull/142232#discussion_r2589780990
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/142232
https://github.com/mpage
mpagehttps://github.com/mpage
Dec 4, 2025https://github.com/python/cpython/pull/142232#issuecomment-3613608336
Please reload this pagehttps://github.com/python/cpython/pull/142232
DinoVhttps://github.com/DinoV
December 5, 2025 11:18https://github.com/python/cpython/pull/142232#commits-pushed-aa4924d
https://github.com/DinoV
Don't modify ref count during visitationhttps://github.com/python/cpython/pull/142232/commits/aa4924d4a01d1e7fe9420398d8baf5d5112755d1
aa4924dhttps://github.com/python/cpython/pull/142232/commits/aa4924d4a01d1e7fe9420398d8baf5d5112755d1
https://github.com/DinoV
Add _PyType_GetBaseByToken_Borrow, don't raise exception and let the …https://github.com/python/cpython/pull/142232/commits/f86011862212b454b4144f6e7482a3e494c86e07
f860118https://github.com/python/cpython/pull/142232/commits/f86011862212b454b4144f6e7482a3e494c86e07
https://github.com/DinoV
DinoVhttps://github.com/DinoV
force-pushedhttps://github.com/python/cpython/compare/346043e5f37457a7fab519ed7e7a4dfd60a1e70b..f86011862212b454b4144f6e7482a3e494c86e07
346043ehttps://github.com/python/cpython/commit/346043e5f37457a7fab519ed7e7a4dfd60a1e70b
f860118https://github.com/python/cpython/commit/f86011862212b454b4144f6e7482a3e494c86e07
Compare https://github.com/python/cpython/compare/346043e5f37457a7fab519ed7e7a4dfd60a1e70b..f86011862212b454b4144f6e7482a3e494c86e07
December 5, 2025 19:18https://github.com/python/cpython/pull/142232#event-21391504491
https://github.com/DinoV
DinoVhttps://github.com/DinoV
markshannonhttps://github.com/markshannon
code ownerhttps://github.com/python/cpython/blob/59f247e43bc93c607a5793c220bcaafb712cf542/.github/CODEOWNERS#L213
December 5, 2025 19:18https://github.com/python/cpython/pull/142232#event-21391504524
https://github.com/DinoV
DinoVhttps://github.com/DinoV
Dec 5, 2025https://github.com/python/cpython/pull/142232#issuecomment-3618268234
Please reload this pagehttps://github.com/python/cpython/pull/142232
encukouhttps://github.com/encukou
December 10, 2025 11:17https://github.com/python/cpython/pull/142232#commits-pushed-4dfa8ec
https://github.com/encukou
_PyType_GetBaseByToken_Borrow can't failhttps://github.com/python/cpython/pull/142232/commits/4dfa8eccbf3b272bcd9c8bdcbcf2fba7d324c547
4dfa8echttps://github.com/python/cpython/pull/142232/commits/4dfa8eccbf3b272bcd9c8bdcbcf2fba7d324c547
https://github.com/encukou
Add blurbhttps://github.com/python/cpython/pull/142232/commits/37f8fbfea8a21a5d3a77a31d2fe1e33ecb45d612
37f8fbfhttps://github.com/python/cpython/pull/142232/commits/37f8fbfea8a21a5d3a77a31d2fe1e33ecb45d612
https://github.com/encukou
encukouhttps://github.com/encukou
Dec 10, 2025https://github.com/python/cpython/pull/142232#issuecomment-3636374218
DinoV#2https://github.com/DinoV/cpython/pull/2
Please reload this pagehttps://github.com/python/cpython/pull/142232
DinoVhttps://github.com/DinoV
December 10, 2025 14:45https://github.com/python/cpython/pull/142232#commits-pushed-f8648ab
https://github.com/DinoV
Merge pull requesthttps://github.com/python/cpython/pull/142232/commits/f8648abc49a741e191582af9e2519822a0d8ce9d
#2https://github.com/DinoV/cpython/pull/2
from encukou/dont_modify_refcounthttps://github.com/python/cpython/pull/142232/commits/f8648abc49a741e191582af9e2519822a0d8ce9d
f8648abhttps://github.com/python/cpython/pull/142232/commits/f8648abc49a741e191582af9e2519822a0d8ce9d
https://github.com/DinoV
Always initialize resulthttps://github.com/python/cpython/pull/142232/commits/9861a58b8190a6bf32e1f70ea74f3d29834c9be3
9861a58https://github.com/python/cpython/pull/142232/commits/9861a58b8190a6bf32e1f70ea74f3d29834c9be3
https://github.com/DinoV
Merge branch 'main' into dont_modify_refcounthttps://github.com/python/cpython/pull/142232/commits/147c76dfe41e2df761ecb956d42073338374ca95
147c76dhttps://github.com/python/cpython/pull/142232/commits/147c76dfe41e2df761ecb956d42073338374ca95
https://github.com/encukou
encukouhttps://github.com/encukou
da8199fhttps://github.com/python/cpython/commit/da8199f8842c2830fa4015138725849863523de4
Dec 11, 2025https://github.com/python/cpython/pull/142232#event-21498670400
Please reload this pagehttps://github.com/python/cpython/pull/142232
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Dec 11, 2025https://github.com/python/cpython/pull/142232#issuecomment-3640898655
@DinoVhttps://github.com/DinoV
@encukouhttps://github.com/encukou
Please reload this pagehttps://github.com/python/cpython/pull/142232
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Dec 11, 2025https://github.com/python/cpython/pull/142232#event-21498671493
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Dec 11, 2025https://github.com/python/cpython/pull/142232#issuecomment-3640898844
@DinoVhttps://github.com/DinoV
@encukouhttps://github.com/encukou
cherry_pickerhttps://pypi.org/project/cherry-picker/
Please reload this pagehttps://github.com/python/cpython/pull/142232
https://github.com/encukou
encukouhttps://github.com/encukou
Dec 11, 2025https://github.com/python/cpython/pull/142232#issuecomment-3640898866
Please reload this pagehttps://github.com/python/cpython/pull/142232
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
encukouhttps://github.com/encukou
Dec 11, 2025https://github.com/python/cpython/pull/142232#event-21498672890
encukouhttps://github.com/encukou
Dec 11, 2025 https://github.com/python/cpython/pull/142232#ref-commit-232ff23
https://github.com/DinoV
https://github.com/encukou
[3.14]https://github.com/encukou/cpython/commit/232ff23b900252e95fad73f225f827aa485eb6d4
pythongh-123241https://github.com/python/cpython/issues/123241
: Don't modify ref count during visitation (https://github.com/encukou/cpython/commit/232ff23b900252e95fad73f225f827aa485eb6d4
pyt…https://github.com/python/cpython/pull/142232
232ff23https://github.com/encukou/cpython/commit/232ff23b900252e95fad73f225f827aa485eb6d4
…honGH-142232https://github.com/python/cpython/pull/142232
da8199fhttps://github.com/encukou/cpython/commit/da8199f8842c2830fa4015138725849863523de4
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Dec 11, 2025https://github.com/python/cpython/pull/142232#issuecomment-3641337703
GH-142567https://github.com/python/cpython/pull/142567
3.14 branchhttps://github.com/python/cpython/tree/3.14
Please reload this pagehttps://github.com/python/cpython/pull/142232
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
Dec 11, 2025https://github.com/python/cpython/pull/142232#event-21501115603
DinoVhttps://github.com/DinoV
Dec 11, 2025 https://github.com/python/cpython/pull/142232#ref-commit-e09c4de
https://github.com/encukou
https://github.com/DinoV
[3.14]https://github.com/python/cpython/commit/e09c4deb254a85ef2be7a0a636c2845688c915ad
gh-123241https://github.com/python/cpython/issues/123241
: Don't modify ref count during visitation (https://github.com/python/cpython/commit/e09c4deb254a85ef2be7a0a636c2845688c915ad
GH-142232https://github.com/python/cpython/pull/142232
) (https://github.com/python/cpython/commit/e09c4deb254a85ef2be7a0a636c2845688c915ad
e09c4dehttps://github.com/python/cpython/commit/e09c4deb254a85ef2be7a0a636c2845688c915ad
#142567https://github.com/python/cpython/pull/142567
da8199fhttps://github.com/python/cpython/commit/da8199f8842c2830fa4015138725849863523de4
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F142232
https://github.com/colesbury
colesbury https://github.com/colesbury
https://github.com/python/cpython/pull/142232/files/346043e5f37457a7fab519ed7e7a4dfd60a1e70b
https://github.com/mpage
mpage https://github.com/mpage
https://github.com/encukou
encukou https://github.com/encukou
https://github.com/markshannon
markshannon https://github.com/markshannon
https://github.com/encukou
encukou https://github.com/encukou
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/142232
https://github.com/DinoV
https://github.com/encukou
https://github.com/mpage
https://github.com/colesbury
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.