René's URL Explorer Experiment


Title: gh-141780: Make PyModule_FromSlotsAndSpec enable GIL if needed by encukou · Pull Request #141785 · python/cpython · GitHub

Open Graph Title: gh-141780: Make PyModule_FromSlotsAndSpec enable GIL if needed by encukou · Pull Request #141785 · python/cpython

X Title: gh-141780: Make PyModule_FromSlotsAndSpec enable GIL if needed by encukou · Pull Request #141785 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: We don't need to enable GIL for the PyModExport_ function, which is supposed to do as little as possible before returning a static array. Py_MOD_GIL_USED can be handled at module creation time,...

X Description: We don't need to enable GIL for the PyModExport_ function, which is supposed to do as little as possible before returning a static array. Py_MOD_GIL_USED can be handled at module creation t...

Opengraph URL: https://github.com/python/cpython/pull/141785

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:7a53e12a-35e3-9722-4c1e-aac4a5cfbebd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9A22:1AC37C:B97AAE:F7B3FC:6B004CFC
html-safe-nonce553d1ec0ef69250d7b40bf802e274255fdeace35c409ce73242a5494ceadc34a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTIyOjFBQzM3QzpCOTdBQUU6RjdCM0ZDOjZCMDA0Q0ZDIiwidmlzaXRvcl9pZCI6IjEzMjQ3NDAxMTcyNzcxMTQ4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac62add0637d596fd284af474b4573da1af6e985f3fe943dc30cf2538a383a05f2
hovercard-subject-tagpull_request:3029732959
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/141785/commits
twitter:imagehttps://opengraph.githubassets.com/45922b09a6326949d5d1e1161d61e1f1f9ebabc47f1c37b4ea540bc68d0c80c5/python/cpython/pull/141785
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/45922b09a6326949d5d1e1161d61e1f1f9ebabc47f1c37b4ea540bc68d0c80c5/python/cpython/pull/141785
og:image:altWe don't need to enable GIL for the PyModExport_ function, which is supposed to do as little as possible before returning a static array. Py_MOD_GIL_USED can be handled at module creation time,...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameencukou
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/141785/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F141785%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F141785%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/141785/commits
Reloadhttps://github.com/python/cpython/pull/141785/commits
Reloadhttps://github.com/python/cpython/pull/141785/commits
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:modexport-gilhttps://github.com/encukou/cpython/tree/modexport-gil
Conversationhttps://github.com/python/cpython/pull/141785
Commits10 (10)https://github.com/python/cpython/pull/141785/commits
Checkshttps://github.com/python/cpython/pull/141785/checks
Files changedhttps://github.com/python/cpython/pull/141785/files
gh-141780: Make PyModule_FromSlotsAndSpec enable GIL if needed https://github.com/python/cpython/pull/141785/commits#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:modexport-gilhttps://github.com/encukou/cpython/tree/modexport-gil
gh-141780: Make PyModule_FromSlotsAndSpec enable GIL if neededhttps://github.com/python/cpython/pull/141785/commits/13faf0f3d9391bfb2aa3898420d101883740f0c1
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
13faf0fhttps://github.com/python/cpython/pull/141785/commits/13faf0f3d9391bfb2aa3898420d101883740f0c1
https://github.com/python/cpython/tree/13faf0f3d9391bfb2aa3898420d101883740f0c1
Make test.test_importlib and _testmultiphase importable in subinterpretershttps://github.com/python/cpython/pull/141785/commits/60a669cc03b4e37418e29cfc73cefc58a1239dcf
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
60a669chttps://github.com/python/cpython/pull/141785/commits/60a669cc03b4e37418e29cfc73cefc58a1239dcf
https://github.com/python/cpython/tree/60a669cc03b4e37418e29cfc73cefc58a1239dcf
Test that Py_MOD_GIL_USED re-enables the GILhttps://github.com/python/cpython/pull/141785/commits/8a8a3449d08f47e053aecff6c318ee9d083e57a3
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
8a8a344https://github.com/python/cpython/pull/141785/commits/8a8a3449d08f47e053aecff6c318ee9d083e57a3
https://github.com/python/cpython/tree/8a8a3449d08f47e053aecff6c318ee9d083e57a3
blurbhttps://github.com/python/cpython/pull/141785/commits/e2c9c7e407efd012380ddbddcfe3d2740623baae
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
e2c9c7ehttps://github.com/python/cpython/pull/141785/commits/e2c9c7e407efd012380ddbddcfe3d2740623baae
https://github.com/python/cpython/tree/e2c9c7e407efd012380ddbddcfe3d2740623baae
Pass with -Werrorhttps://github.com/python/cpython/pull/141785/commits/b18c679b4a0334571d506a0a6dcc1f3567461f8e
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
b18c679https://github.com/python/cpython/pull/141785/commits/b18c679b4a0334571d506a0a6dcc1f3567461f8e
https://github.com/python/cpython/tree/b18c679b4a0334571d506a0a6dcc1f3567461f8e
Skip test_from_modexport_empty_slots on GIL-ful buildshttps://github.com/python/cpython/pull/141785/commits/103f427fdb38595e57e4d329424203ea24c16446
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
103f427https://github.com/python/cpython/pull/141785/commits/103f427fdb38595e57e4d329424203ea24c16446
https://github.com/python/cpython/tree/103f427fdb38595e57e4d329424203ea24c16446
Use @requires_subinterpretershttps://github.com/python/cpython/pull/141785/commits/91d59e9b3985f984506a5f4b49be4f26f60479fe
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
91d59e9https://github.com/python/cpython/pull/141785/commits/91d59e9b3985f984506a5f4b49be4f26f60479fe
https://github.com/python/cpython/tree/91d59e9b3985f984506a5f4b49be4f26f60479fe
Add more gil & interpreters slotshttps://github.com/python/cpython/pull/141785/commits/3e82c25f104154140de0ed03be617acb2391f729
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
3e82c25https://github.com/python/cpython/pull/141785/commits/3e82c25f104154140de0ed03be617acb2391f729
https://github.com/python/cpython/tree/3e82c25f104154140de0ed03be617acb2391f729
Fix assertion logichttps://github.com/python/cpython/pull/141785/commits/5b8b87c3140edd19a79490d1f66eac20a77f2a7f
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
5b8b87chttps://github.com/python/cpython/pull/141785/commits/5b8b87c3140edd19a79490d1f66eac20a77f2a7f
https://github.com/python/cpython/tree/5b8b87c3140edd19a79490d1f66eac20a77f2a7f
Python/import.c: PEP7https://github.com/python/cpython/pull/141785/commits/cde6c25858833988023682a024199bb6ddc5fe0a
encukouhttps://github.com/python/cpython/commits?author=encukou
colesburyhttps://github.com/python/cpython/commits?author=colesbury
cde6c25https://github.com/python/cpython/pull/141785/commits/cde6c25858833988023682a024199bb6ddc5fe0a
https://github.com/python/cpython/tree/cde6c25858833988023682a024199bb6ddc5fe0a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.