René's URL Explorer Experiment


Title: gh-141780: Make PyModule_FromSlotsAndSpec enable GIL if needed by encukou · Pull Request #141785 · python/cpython · GitHub

Open Graph Title: gh-141780: Make PyModule_FromSlotsAndSpec enable GIL if needed by encukou · Pull Request #141785 · python/cpython

X Title: gh-141780: Make PyModule_FromSlotsAndSpec enable GIL if needed by encukou · Pull Request #141785 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: We don't need to enable GIL for the PyModExport_ function, which is supposed to do as little as possible before returning a static array. Py_MOD_GIL_USED can be handled at module creation time,...

X Description: We don't need to enable GIL for the PyModExport_ function, which is supposed to do as little as possible before returning a static array. Py_MOD_GIL_USED can be handled at module creation t...

Opengraph URL: https://github.com/python/cpython/pull/141785

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/*id(.:format)
route-controllerpull_requests
route-actionshow
fetch-noncev2:77fc9cca-6567-69eb-1d56-b3ad1811cebe
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8C24:24D752:6A0B13:8E2CB4:6B0036EB
html-safe-noncea63d9bb3008ea57ad6574b4b7138462b2ea0c4dffe384e44cf70c92567ae86c9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzI0OjI0RDc1Mjo2QTBCMTM6OEUyQ0I0OjZCMDAzNkVCIiwidmlzaXRvcl9pZCI6IjgyNDA0NDQ5NDQ0ODE3OTM3NzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac11b2ae19ebc87af23b501b42b167eef3cc849249101703676352b8d9d970b4d5
hovercard-subject-tagpull_request:3029732959
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/141785
twitter:imagehttps://opengraph.githubassets.com/45922b09a6326949d5d1e1161d61e1f1f9ebabc47f1c37b4ea540bc68d0c80c5/python/cpython/pull/141785
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/45922b09a6326949d5d1e1161d61e1f1f9ebabc47f1c37b4ea540bc68d0c80c5/python/cpython/pull/141785
og:image:altWe don't need to enable GIL for the PyModExport_ function, which is supposed to do as little as possible before returning a static array. Py_MOD_GIL_USED can be handled at module creation time,...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameencukou
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/141785#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F141785
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F141785
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/141785
Reloadhttps://github.com/python/cpython/pull/141785
Reloadhttps://github.com/python/cpython/pull/141785
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:modexport-gilhttps://github.com/encukou/cpython/tree/modexport-gil
Conversationhttps://github.com/python/cpython/pull/141785
Commits10 (10)https://github.com/python/cpython/pull/141785/commits
Checkshttps://github.com/python/cpython/pull/141785/checks
Files changedhttps://github.com/python/cpython/pull/141785/files
gh-141780: Make PyModule_FromSlotsAndSpec enable GIL if needed https://github.com/python/cpython/pull/141785#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:modexport-gilhttps://github.com/encukou/cpython/tree/modexport-gil
https://github.com/encukou
encukouhttps://github.com/encukou
Nov 20, 2025https://github.com/python/cpython/pull/141785#issue-3647107225
Please reload this pagehttps://github.com/python/cpython/pull/141785
@colesburyhttps://github.com/colesbury
Forcing enabling the GIL doesn't seem to work with PEP 793 initialization #141780https://github.com/python/cpython/issues/141780
Please reload this pagehttps://github.com/python/cpython/pull/141785
encukouhttps://github.com/encukou
November 20, 2025 11:23https://github.com/python/cpython/pull/141785#commits-pushed-13faf0f
https://github.com/encukou
pythongh-141780https://github.com/python/cpython/issues/141780
: Make PyModule_FromSlotsAndSpec enable GIL if neededhttps://github.com/python/cpython/pull/141785/commits/13faf0f3d9391bfb2aa3898420d101883740f0c1
13faf0fhttps://github.com/python/cpython/pull/141785/commits/13faf0f3d9391bfb2aa3898420d101883740f0c1
https://github.com/encukou
Make test.test_importlib and _testmultiphase importable in subinterpr…https://github.com/python/cpython/pull/141785/commits/60a669cc03b4e37418e29cfc73cefc58a1239dcf
60a669chttps://github.com/python/cpython/pull/141785/commits/60a669cc03b4e37418e29cfc73cefc58a1239dcf
https://github.com/encukou
Test that Py_MOD_GIL_USED re-enables the GILhttps://github.com/python/cpython/pull/141785/commits/8a8a3449d08f47e053aecff6c318ee9d083e57a3
8a8a344https://github.com/python/cpython/pull/141785/commits/8a8a3449d08f47e053aecff6c318ee9d083e57a3
https://github.com/encukou
blurbhttps://github.com/python/cpython/pull/141785/commits/e2c9c7e407efd012380ddbddcfe3d2740623baae
e2c9c7ehttps://github.com/python/cpython/pull/141785/commits/e2c9c7e407efd012380ddbddcfe3d2740623baae
https://github.com/encukou
encukouhttps://github.com/encukou
brettcannonhttps://github.com/brettcannon
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
kumaraditya303https://github.com/kumaraditya303
ncoghlanhttps://github.com/ncoghlan
warsawhttps://github.com/warsaw
code ownershttps://github.com/python/cpython/blob/41b9ad5b38e913194a5cc88f0e7cfc096787b664/.github/CODEOWNERS#L254
November 20, 2025 12:38https://github.com/python/cpython/pull/141785#event-21069707117
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 20, 2025https://github.com/python/cpython/pull/141785#event-21069708248
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 20, 2025 https://github.com/python/cpython/pull/141785#ref-issue-3646006480
Forcing enabling the GIL doesn't seem to work with PEP 793 initialization #141780 https://github.com/python/cpython/issues/141780
https://github.com/encukou
encukouhttps://github.com/encukou
Nov 20, 2025 https://github.com/python/cpython/pull/141785#pullrequestreview-3487668088
View reviewed changes https://github.com/python/cpython/pull/141785/files/e2c9c7e407efd012380ddbddcfe3d2740623baae
Lib/test/test_importlib/util.pyhttps://github.com/python/cpython/pull/141785/files/e2c9c7e407efd012380ddbddcfe3d2740623baae#diff-cf049d6640b726c9ac283091e9c41e52434c770bcd2efb92eb64bdd6e2816d5a
encukouhttps://github.com/encukou
Nov 20, 2025https://github.com/python/cpython/pull/141785#discussion_r2545915126
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/141785
https://github.com/encukou
encukouhttps://github.com/encukou
November 20, 2025 13:20https://github.com/python/cpython/pull/141785#event-21070586287
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 20, 2025https://github.com/python/cpython/pull/141785#event-21070587253
encukouhttps://github.com/encukou
November 20, 2025 14:24https://github.com/python/cpython/pull/141785#commits-pushed-b18c679
https://github.com/encukou
Pass with -Werrorhttps://github.com/python/cpython/pull/141785/commits/b18c679b4a0334571d506a0a6dcc1f3567461f8e
b18c679https://github.com/python/cpython/pull/141785/commits/b18c679b4a0334571d506a0a6dcc1f3567461f8e
https://github.com/encukou
Skip test_from_modexport_empty_slots on GIL-ful buildshttps://github.com/python/cpython/pull/141785/commits/103f427fdb38595e57e4d329424203ea24c16446
103f427https://github.com/python/cpython/pull/141785/commits/103f427fdb38595e57e4d329424203ea24c16446
https://github.com/encukou
Use @requires_subinterpretershttps://github.com/python/cpython/pull/141785/commits/91d59e9b3985f984506a5f4b49be4f26f60479fe
91d59e9https://github.com/python/cpython/pull/141785/commits/91d59e9b3985f984506a5f4b49be4f26f60479fe
https://github.com/encukou
Add more gil & interpreters slotshttps://github.com/python/cpython/pull/141785/commits/3e82c25f104154140de0ed03be617acb2391f729
3e82c25https://github.com/python/cpython/pull/141785/commits/3e82c25f104154140de0ed03be617acb2391f729
https://github.com/encukou
Fix assertion logichttps://github.com/python/cpython/pull/141785/commits/5b8b87c3140edd19a79490d1f66eac20a77f2a7f
5b8b87chttps://github.com/python/cpython/pull/141785/commits/5b8b87c3140edd19a79490d1f66eac20a77f2a7f
https://github.com/encukou
encukouhttps://github.com/encukou
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Nov 20, 2025https://github.com/python/cpython/pull/141785#event-21073033023
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Nov 20, 2025https://github.com/python/cpython/pull/141785#issuecomment-3558518029
@encukouhttps://github.com/encukou
5b8b87chttps://github.com/python/cpython/commit/5b8b87c3140edd19a79490d1f66eac20a77f2a7f
https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F141785%2Fmergehttps://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F141785%2Fmerge
Please reload this pagehttps://github.com/python/cpython/pull/141785
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Nov 20, 2025https://github.com/python/cpython/pull/141785#event-21073034413
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Nov 20, 2025 https://github.com/python/cpython/pull/141785#pullrequestreview-3489517993
View reviewed changes https://github.com/python/cpython/pull/141785/files/5b8b87c3140edd19a79490d1f66eac20a77f2a7f
colesburyhttps://github.com/colesbury
https://github.com/python/cpython/pull/141785#pullrequestreview-3489517993
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/141785
Python/import.chttps://github.com/python/cpython/pull/141785/files/5b8b87c3140edd19a79490d1f66eac20a77f2a7f#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
Please reload this pagehttps://github.com/python/cpython/pull/141785
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Nov 20, 2025https://github.com/python/cpython/pull/141785#event-21079491199
https://github.com/brettcannon
brettcannonhttps://github.com/brettcannon
November 21, 2025 00:02https://github.com/python/cpython/pull/141785#event-21084729347
https://github.com/encukou
encukouhttps://github.com/encukou
November 21, 2025 15:08https://github.com/python/cpython/pull/141785#event-21099167833
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Nov 21, 2025https://github.com/python/cpython/pull/141785#event-21099168954
https://github.com/encukou
https://github.com/colesbury
Python/import.c: PEP7https://github.com/python/cpython/pull/141785/commits/cde6c25858833988023682a024199bb6ddc5fe0a
cde6c25https://github.com/python/cpython/pull/141785/commits/cde6c25858833988023682a024199bb6ddc5fe0a
https://github.com/encukou
encukouhttps://github.com/encukou
bf66bcehttps://github.com/python/cpython/commit/bf66bce4ee642e0d14d2e289490360e60980b14e
Nov 24, 2025https://github.com/python/cpython/pull/141785#event-21137290655
Please reload this pagehttps://github.com/python/cpython/pull/141785
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 24, 2025https://github.com/python/cpython/pull/141785#event-21137291801
https://github.com/encukou
encukouhttps://github.com/encukou
November 24, 2025 12:26https://github.com/python/cpython/pull/141785#event-21137292000
StanFromIrelandhttps://github.com/StanFromIreland
Dec 6, 2025 https://github.com/python/cpython/pull/141785#ref-commit-f614d18
https://github.com/encukou
https://github.com/StanFromIreland
pythongh-141780https://github.com/python/cpython/issues/141780
: Make PyModule_FromSlotsAndSpec enable GIL if needed (https://github.com/StanFromIreland/cpython/commit/f614d1867eb4ae768710675a7747f3b419156e4c
…https://github.com/python/cpython/pull/141785
f614d18https://github.com/StanFromIreland/cpython/commit/f614d1867eb4ae768710675a7747f3b419156e4c
…pythonGH-141785https://github.com/python/cpython/pull/141785
ashm-devhttps://github.com/ashm-dev
Dec 8, 2025 https://github.com/python/cpython/pull/141785#ref-commit-1fdf8af
https://github.com/encukou
https://github.com/ashm-dev
pythongh-141780https://github.com/python/cpython/issues/141780
: Make PyModule_FromSlotsAndSpec enable GIL if needed (https://github.com/ashm-dev/cpython/commit/1fdf8afe91014570f2bf0993a8c7002efb15f41e
…https://github.com/python/cpython/pull/141785
1fdf8afhttps://github.com/ashm-dev/cpython/commit/1fdf8afe91014570f2bf0993a8c7002efb15f41e
…pythonGH-141785https://github.com/python/cpython/pull/141785
[3.14] gh-144601: Avoid sharing exception objects raised in a PyInit function across multiple interpreters (GH-144602) #144633 https://github.com/python/cpython/pull/144633
[3.14] gh-144601: Use _testmultiphase instead of _testsinglephase in test_importlib #144769 https://github.com/python/cpython/pull/144769
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F141785
https://github.com/colesbury
colesbury https://github.com/colesbury
https://github.com/python/cpython/pull/141785/files/5b8b87c3140edd19a79490d1f66eac20a77f2a7f
https://github.com/ericsnowcurrently
ericsnowcurrently https://github.com/ericsnowcurrently
https://github.com/ncoghlan
ncoghlan https://github.com/ncoghlan
https://github.com/warsaw
warsaw https://github.com/warsaw
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
Please reload this pagehttps://github.com/python/cpython/pull/141785
Please reload this pagehttps://github.com/python/cpython/pull/141785
https://github.com/encukou
https://github.com/bedevere-bot
https://github.com/colesbury
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.