René's URL Explorer Experiment


Title: gh-141314: Fix TextIOWrapper.tell() assertion failure with standalone carriage return by mohsinm-dev · Pull Request #141331 · python/cpython · GitHub

Open Graph Title: gh-141314: Fix TextIOWrapper.tell() assertion failure with standalone carriage return by mohsinm-dev · Pull Request #141331 · python/cpython

X Title: gh-141314: Fix TextIOWrapper.tell() assertion failure with standalone carriage return by mohsinm-dev · Pull Request #141331 · python/cpython

Description: Summary Fix assertion failure in io.TextIOWrapper.tell() when reading files ending with standalone \r Add comprehensive test case to prevent regression Add NEWS entry documenting the fix Root Cause The tell() optimization algorithm assumed buffered data would always be available when calculating position, but files ending with standalone \r create empty snapshots, causing assert(skip_back <= PyBytes_GET_SIZE(next_input)) to fail. Fix Added check to skip optimization when next_input is empty, preventing the assertion failure while maintaining correct position calculation. Test Plan Added test case test_tell_after_readline_with_cr in test_textio.py Verified fix handles standalone carriage returns correctly Confirmed all existing io tests still pass Built CPython with debug assertions enabled Issue: gh-141314

Open Graph Description: Summary Fix assertion failure in io.TextIOWrapper.tell() when reading files ending with standalone \r Add comprehensive test case to prevent regression Add NEWS entry documenting the fix Root Cau...

X Description: Summary Fix assertion failure in io.TextIOWrapper.tell() when reading files ending with standalone \r Add comprehensive test case to prevent regression Add NEWS entry documenting the fix Root Cau...

Opengraph URL: https://github.com/python/cpython/pull/141331

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c6200cd0-47bb-3bcf-74b8-a64d3523a740
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB804:1EE5:387DD6F:4ED0086:6A50245A
html-safe-nonceb6466923783989026d4cc689128559a3a697b432fe5c4f32ac8b649450dd5857
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODA0OjFFRTU6Mzg3REQ2Rjo0RUQwMDg2OjZBNTAyNDVBIiwidmlzaXRvcl9pZCI6IjMzOTg2MTU2OTc2NDY5NTM1NjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6ec4fc7ab3006a414ee757d7409f83bbd5ec1b911f8d2af55801262f3c1df54b
hovercard-subject-tagpull_request:2993336620
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/141331/files
twitter:imagehttps://avatars.githubusercontent.com/u/55545648?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/55545648?s=400&v=4
og:image:altSummary Fix assertion failure in io.TextIOWrapper.tell() when reading files ending with standalone \r Add comprehensive test case to prevent regression Add NEWS entry documenting the fix Root Cau...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonea08040246389072795e3b4e7b33c6d9a0c564eee02e829a809326d67c418b069
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released1b91b18e7330fc458dfd824c61eaed7daa830d6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/141331/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F141331%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F141331%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/141331/files
Reloadhttps://github.com/python/cpython/pull/141331/files
Reloadhttps://github.com/python/cpython/pull/141331/files
Please reload this pagehttps://github.com/python/cpython/pull/141331/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/141331/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
mohsinm-dev:fix-textio-tell-assertion-gh-141314https://github.com/mohsinm-dev/cpython/tree/fix-textio-tell-assertion-gh-141314
Conversation 21 https://github.com/python/cpython/pull/141331
Commits 6 https://github.com/python/cpython/pull/141331/commits
Checks 56 https://github.com/python/cpython/pull/141331/checks
Files changed https://github.com/python/cpython/pull/141331/files
Please reload this pagehttps://github.com/python/cpython/pull/141331/files
gh-141314: Fix TextIOWrapper.tell() assertion failure with standalone carriage return https://github.com/python/cpython/pull/141331/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/141331/files
fe6dd19 gh-141314: Fix TextIOWrapper.tell() assertion failure with standalone… mohsinm-dev Nov 10, 2025 https://github.com/python/cpython/pull/141331/commits/fe6dd199f46dc23e29cb9e4d6e1261d2656cf13d
69960dc gh-141314: Fix TextIOWrapper.tell() assertion failure with standalone… mohsinm-dev Nov 10, 2025 https://github.com/python/cpython/pull/141331/commits/69960dc1755b44ee06904d58c648dd6d570b86cf
cdb9283 Fix linting issues mohsinm-dev Nov 10, 2025 https://github.com/python/cpython/pull/141331/commits/cdb92836e1bc53d871ff064822141a1d1c5ee579
b1e1885 Refactor code structure and add test for multiple CR cases mohsinm-dev Nov 10, 2025 https://github.com/python/cpython/pull/141331/commits/b1e18857a02226fc5291a6e45b25943b4dc3f014
1d9f77f Fix trailing whitespace in test file mohsinm-dev Nov 10, 2025 https://github.com/python/cpython/pull/141331/commits/1d9f77fdbe70659bc06d6e950c9c1b9b6955ffd6
e84d686 Fix TextIOWrapper assertion typo and simplify test mohsinm-dev Nov 10, 2025 https://github.com/python/cpython/pull/141331/commits/e84d686fd0b07eebd9a0b6e499095e4dcf0af2c8
Clear filters https://github.com/python/cpython/pull/141331/files
Please reload this pagehttps://github.com/python/cpython/pull/141331/files
Please reload this pagehttps://github.com/python/cpython/pull/141331/files
test_textio.py https://github.com/python/cpython/pull/141331/files#diff-871737268f0629fa5bc32f116d3c5f1a37accc05d5505883c9f0f21bf6ac7ee3
2025-11-10-01-47-18.gh-issue-141314.baaa28.rst https://github.com/python/cpython/pull/141331/files#diff-5e34c2f7bd9ac438eef712170ae7a75f808085fc51a30e9003decf559b846320
textio.c https://github.com/python/cpython/pull/141331/files#diff-f6d1380274f6859688c821fced58fb1c829d8acad44ae252ba988e220e1080b3
Lib/test/test_io/test_textio.pyhttps://github.com/python/cpython/pull/141331/files#diff-871737268f0629fa5bc32f116d3c5f1a37accc05d5505883c9f0f21bf6ac7ee3
View file https://github.com/mohsinm-dev/cpython/blob/e84d686fd0b07eebd9a0b6e499095e4dcf0af2c8/Lib/test/test_io/test_textio.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/141331/{{ revealButtonHref }}
https://github.com/python/cpython/pull/141331/files#diff-871737268f0629fa5bc32f116d3c5f1a37accc05d5505883c9f0f21bf6ac7ee3
Please reload this pagehttps://github.com/python/cpython/pull/141331/files
https://github.com/python/cpython/pull/141331/files#diff-871737268f0629fa5bc32f116d3c5f1a37accc05d5505883c9f0f21bf6ac7ee3
Misc/NEWS.d/next/Library/2025-11-10-01-47-18.gh-issue-141314.baaa28.rsthttps://github.com/python/cpython/pull/141331/files#diff-5e34c2f7bd9ac438eef712170ae7a75f808085fc51a30e9003decf559b846320
View file https://github.com/mohsinm-dev/cpython/blob/e84d686fd0b07eebd9a0b6e499095e4dcf0af2c8/Misc/NEWS.d/next/Library/2025-11-10-01-47-18.gh-issue-141314.baaa28.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/141331/{{ revealButtonHref }}
Modules/_io/textio.chttps://github.com/python/cpython/pull/141331/files#diff-f6d1380274f6859688c821fced58fb1c829d8acad44ae252ba988e220e1080b3
View file https://github.com/mohsinm-dev/cpython/blob/e84d686fd0b07eebd9a0b6e499095e4dcf0af2c8/Modules/_io/textio.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/141331/{{ revealButtonHref }}
https://github.com/python/cpython/pull/141331/files#diff-f6d1380274f6859688c821fced58fb1c829d8acad44ae252ba988e220e1080b3
https://github.com/python/cpython/pull/141331/files#diff-f6d1380274f6859688c821fced58fb1c829d8acad44ae252ba988e220e1080b3
Please reload this pagehttps://github.com/python/cpython/pull/141331/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.