René's URL Explorer Experiment


Title: gh-141174: Improve `annotationlib.get_annotations()` test coverage by dr-carlos · Pull Request #141286 · python/cpython · GitHub

Open Graph Title: gh-141174: Improve `annotationlib.get_annotations()` test coverage by dr-carlos · Pull Request #141286 · python/cpython

X Title: gh-141174: Improve `annotationlib.get_annotations()` test coverage by dr-carlos · Pull Request #141286 · python/cpython

Description: All lines in get_annotations(), _rewrite_star_unpack(), and _get_and_call_annotate() should now be covered by tests. Branch coverage for evaluating stringized annotations on classes with no module or a module which cannot be imported was intentionally not included, as I couldn't find a realistic case and it didn't seem like a behaviour that needed to be reproducible. Happy to add a new test for this. Also happy to remove the test which covers the branch of 'what if we unwrap a partial object but functools has never been imported', as this isn't a very realistic situation either. Issue: gh-141174

Open Graph Description: All lines in get_annotations(), _rewrite_star_unpack(), and _get_and_call_annotate() should now be covered by tests. Branch coverage for evaluating stringized annotations on classes with no module ...

X Description: All lines in get_annotations(), _rewrite_star_unpack(), and _get_and_call_annotate() should now be covered by tests. Branch coverage for evaluating stringized annotations on classes with no module ...

Opengraph URL: https://github.com/python/cpython/pull/141286

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:666e100d-f89d-05ac-19d1-946dd015f332
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB82E:34CAB:4405DDE:56D2378:6B024345
html-safe-nonce06fa504fc9244830cc0e7e0fc46287e38efcbe022336f9028ae5abb16f168a5c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODJFOjM0Q0FCOjQ0MDVEREU6NTZEMjM3ODo2QjAyNDM0NSIsInZpc2l0b3JfaWQiOiI3NDQ1NjgwNzExMTQ4OTEzNDc3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca3f24f88bc0e08f1b228af1cd00197b39fb51bde6077bcbc4487be1720b61ea1
hovercard-subject-tagpull_request:2992638250
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/141286/files
twitter:imagehttps://avatars.githubusercontent.com/u/77367421?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/77367421?s=400&v=4
og:image:altAll lines in get_annotations(), _rewrite_star_unpack(), and _get_and_call_annotate() should now be covered by tests. Branch coverage for evaluating stringized annotations on classes with no module ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/141286/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F141286%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F141286%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/141286/files
Reloadhttps://github.com/python/cpython/pull/141286/files
Reloadhttps://github.com/python/cpython/pull/141286/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
dr-carlos:get-annotations-testshttps://github.com/dr-carlos/cpython/tree/get-annotations-tests
Conversation 5 https://github.com/python/cpython/pull/141286
Commits 5 https://github.com/python/cpython/pull/141286/commits
Checks 0 https://github.com/python/cpython/pull/141286/checks
Files changed https://github.com/python/cpython/pull/141286/files
Please reload this pagehttps://github.com/python/cpython/pull/141286/files
gh-141174: Improve annotationlib.get_annotations() test coverage https://github.com/python/cpython/pull/141286/files#top
Show all changes 5 commits https://github.com/python/cpython/pull/141286/files
9793ccb Test `get_annotations(format=Format.VALUE)` for stringized annotation… dr-carlos Nov 8, 2025 https://github.com/python/cpython/pull/141286/commits/9793ccbb0484037fa3289cf5e0e247d2c5be80c7
cf73525 Test `get_annotations(format=Format.VALUE)` for stringized annotation… dr-carlos Nov 9, 2025 https://github.com/python/cpython/pull/141286/commits/cf735258dea1b3551e3045ac3d89d8481ea6397a
1c2ead8 Update test_stringized_annotations_with_star_unpack() to actually tes… dr-carlos Nov 9, 2025 https://github.com/python/cpython/pull/141286/commits/1c2ead86a1941a20afcd0baffdd7e67087f89995
b231e29 Test __annotate__ returning a non-dict dr-carlos Nov 9, 2025 https://github.com/python/cpython/pull/141286/commits/b231e29de766bf47281eabec8a6b8073a400e250
918e45a Test passing globals and locals to stringized `get_annotations()` dr-carlos Nov 9, 2025 https://github.com/python/cpython/pull/141286/commits/918e45a8a50b3302d5e6ea9d542fba317bd49d85
Clear filters https://github.com/python/cpython/pull/141286/files
Please reload this pagehttps://github.com/python/cpython/pull/141286/files
Please reload this pagehttps://github.com/python/cpython/pull/141286/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L366
Lib/test/test_annotationlib.pyhttps://github.com/python/cpython/pull/141286/files#diff-68e8ce66befd2f080ec5c1b5cc5536c8a62147a4be63211d0852468870fbeeaa
View file https://github.com/dr-carlos/cpython/blob/918e45a8a50b3302d5e6ea9d542fba317bd49d85/Lib/test/test_annotationlib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/141286/{{ revealButtonHref }}
https://github.com/python/cpython/pull/141286/files#diff-68e8ce66befd2f080ec5c1b5cc5536c8a62147a4be63211d0852468870fbeeaa
https://github.com/python/cpython/pull/141286/files#diff-68e8ce66befd2f080ec5c1b5cc5536c8a62147a4be63211d0852468870fbeeaa
https://github.com/python/cpython/pull/141286/files#diff-68e8ce66befd2f080ec5c1b5cc5536c8a62147a4be63211d0852468870fbeeaa
https://github.com/python/cpython/pull/141286/files#diff-68e8ce66befd2f080ec5c1b5cc5536c8a62147a4be63211d0852468870fbeeaa
https://github.com/python/cpython/pull/141286/files#diff-68e8ce66befd2f080ec5c1b5cc5536c8a62147a4be63211d0852468870fbeeaa
https://github.com/python/cpython/pull/141286/files#diff-68e8ce66befd2f080ec5c1b5cc5536c8a62147a4be63211d0852468870fbeeaa
https://github.com/python/cpython/pull/141286/files#diff-68e8ce66befd2f080ec5c1b5cc5536c8a62147a4be63211d0852468870fbeeaa
https://github.com/python/cpython/pull/141286/files#diff-68e8ce66befd2f080ec5c1b5cc5536c8a62147a4be63211d0852468870fbeeaa
https://github.com/python/cpython/pull/141286/files#diff-68e8ce66befd2f080ec5c1b5cc5536c8a62147a4be63211d0852468870fbeeaa
https://github.com/python/cpython/pull/141286/files#diff-68e8ce66befd2f080ec5c1b5cc5536c8a62147a4be63211d0852468870fbeeaa
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.